On Tue, 7 Mar 2023 17:27:56 GMT, Julian Waters <jwat...@openjdk.org> wrote:
> security.cpp contains a few invalid implicit conversions between pointer > types that will not fly when the permissive- compiler option is active. Given > that permissive- will become the Visual C++ compiler's default mode of > operation in the future, it is better to handle this now so future compiler > upgrades will not cause issues. Problems here are very easily solved with > explicit casts Thanks for taking care of this. The code change looks innocent. I'm just wondering if this problem only happens in this file or there are similar changes needed in other files. If yes, I hope the change is consistent. For example, instead of casting to `jchar*`, is it possible to declare the variable to be `jchar*` at the beginning? I understand there might be other casts needed. ------------- PR: https://git.openjdk.org/jdk/pull/12907
