On Tue, 12 Jul 2022 14:34:32 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> 1. I tried to keep as much of the original parenthesis as possible. I can do >> the minimum number if that is what you prefer. >> 2. I'll change MD4, MD5, and SHA-1 to use `rotateLeft` in keeping with how >> they are described in their respective RFCs. > >> * I tried to keep as much of the original parenthesis as possible. I can do >> the minimum number if that is what you prefer. > > Yes, it's always a good choice to keep the styles consistent. With you recent > code change from `rotateRight(a, (32 -b))` to `rotateLeft(a, b)`, I think it > already looks much better. > @wangweij , I agree it looks much better. Thanks for the `rotateLeft` > suggestion. > > @jatin-bhateja , I ran micro performance tests on my MacBook (macosx-aarch64) > and didn't see any change in performance. Can you suggest a test that might > show better performance? I'm assuming it would involve some platform other > than my laptop. Hi @mcpowers , Before pattern matching over graph snippet, rotate routines which are non-intrinsic will get in-lined, so your change should ideally not impact the generate JIT code. ------------- PR: https://git.openjdk.org/jdk/pull/9456
