On Mon, 11 Jul 2022 21:20:43 GMT, Mark Powers <d...@openjdk.org> wrote:

> https://bugs.openjdk.org/browse/JDK-4887998

Two comments:
1. There are many unnecessary parenthesis, like `(32 - s)` or `(Integer... + 
5)`.
2. Why choose `rotateRight` and not `rotateLeft`? 
https://en.wikipedia.org/wiki/SHA-1 uses "circular left shift operation" to 
describe the rotation.

-------------

PR: https://git.openjdk.org/jdk/pull/9456

Reply via email to