Re: [Xen-devel] [PATCH v2] xen: issue warning message when out of grant maptrack entries

2018-09-20 Thread Boris Ostrovsky
On 9/19/18 9:42 AM, Juergen Gross wrote: > When a driver domain (e.g. dom0) is running out of maptrack entries it > can't map any more foreign domain pages. Instead of silently stalling > the affected domUs issue a rate limited warning in this case in order > to make it easier to detect that situat

[Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-22 Thread Boris Ostrovsky
iggered in get_free_grant(). This can be observed even on an idle system, within 20-30 minutes. We should keep the grants in the buffer when purging, and only free the grant ref. Fixes: a46b53672b2c ("xen/blkfront: cleanup stale persistent grants") Signed-off-by: Boris Ostrovsky --- drivers/bloc

Re: [Xen-devel] clean up physical merging helpers

2018-09-24 Thread Boris Ostrovsky
On 9/20/18 10:39 AM, Jens Axboe wrote: > On 9/20/18 12:29 AM, Christoph Hellwig wrote: >> On Sat, Sep 15, 2018 at 08:47:13AM -0600, Jens Axboe wrote: > this series moves various helpers related to merging based on physical > addresses from the public headers into block/, moves the Xen speci

Re: [Xen-devel] [PATCH] xen: x86: make asm/xen/events.h include xen/xen.h

2018-09-24 Thread Boris Ostrovsky
On 9/23/18 1:38 PM, Nicolai Stange wrote: > arch/x86/include/asm/xen/events.h references xen_hvm_domain() from the > inlined xen_support_evtchn_rebind(). > > xen_hvm_domain() gets #defined in include/xen/xen.h and > arch/x86/include/asm/xen/events.h doesn't include that. > > On current Linus' tree,

Re: [Xen-devel] [PATCH 1/6] xenbus: prepare data structures and parameter for xenwatch multithreading

2018-09-25 Thread Boris Ostrovsky
On 9/25/18 1:14 AM, Dongli Zhang wrote: > > So far we have: (1) domain hash table, (2) domain list (where duplicate > entries > may exist) and (3) purge list. > > Can I assume you would like to discard the domain list and only keep domain > hash > table and purge list? Yes, that's what I was thi

Re: [Xen-devel] [PATCH v2] xen: Make XEN_BACKEND selectable by DomU

2018-09-25 Thread Boris Ostrovsky
t; could not select the option. With the new Kconfig, we default y for > Dom0 and n for DomU. Either can then toggle the selection. > > Signed-off-by: Jason Andryuk Reviewed-by: Boris Ostrovsky Applied to for-linus-19d ___ Xen-devel mailing lis

Re: [Xen-devel] [PATCH trivial] xen/balloon: Grammar s/Is it/It is/

2018-09-26 Thread Boris Ostrovsky
On 9/26/18 4:43 AM, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > drivers/xen/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index 90d387b50ab747f5..7f42d41f66ee98e3 100644 > --- a/drivers/xen/Kc

Re: [Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-27 Thread Boris Ostrovsky
On 9/27/18 2:56 PM, Jens Axboe wrote: > On 9/27/18 12:52 PM, Sander Eikelenboom wrote: >> On 27/09/18 16:26, Jens Axboe wrote: >>> On 9/27/18 1:12 AM, Juergen Gross wrote: >>>> On 22/09/18 21:55, Boris Ostrovsky wrote: >>>>> Commit a46b53672b2c (&

Re: [Xen-devel] [PATCH] xen/blkfront: When purging persistent grants, keep them in the buffer

2018-09-27 Thread Boris Ostrovsky
On 9/27/18 5:37 PM, Jens Axboe wrote: > On 9/27/18 2:33 PM, Sander Eikelenboom wrote: >> On 27/09/18 21:06, Boris Ostrovsky wrote: >>> On 9/27/18 2:56 PM, Jens Axboe wrote: >>>> On 9/27/18 12:52 PM, Sander Eikelenboom wrote: >>>>> On 27/09/18 16:26

Re: [Xen-devel] [PATCH] xen/blkfront: correct purging of persistent grants

2018-09-28 Thread Boris Ostrovsky
On 9/28/18 3:28 AM, Juergen Gross wrote: > Commit a46b53672b2c2e3770b38a4abf90d16364d2584b ("xen/blkfront: cleanup > stale persistent grants") introduced a regression as purged persistent > grants were not pu into the list of free grants again. Correct that. > > Signed-off-by: Juergen Gross > ---

Re: [Xen-devel] [PATCH] xen/blkfront: correct purging of persistent grants

2018-09-28 Thread Boris Ostrovsky
On 9/28/18 9:13 AM, Juergen Gross wrote: > On 28/09/2018 14:45, Boris Ostrovsky wrote: >> On 9/28/18 3:28 AM, Juergen Gross wrote: >>> Commit a46b53672b2c2e3770b38a4abf90d16364d2584b ("xen/blkfront: cleanup >>> stale persistent grants") introduced a regression

Re: [Xen-devel] [PATCH] xen/blkfront: correct purging of persistent grants

2018-09-28 Thread Boris Ostrovsky
On 9/28/18 9:52 AM, Juergen Gross wrote: > On 28/09/2018 15:33, Boris Ostrovsky wrote: >> On 9/28/18 9:13 AM, Juergen Gross wrote: >>> On 28/09/2018 14:45, Boris Ostrovsky wrote: >>>> On 9/28/18 3:28 AM, Juergen Gross wrote: >>>>> Commit a46b53672b

Re: [Xen-devel] [PATCH] mm/page_alloc: always scrub pages given to the allocator

2018-10-01 Thread Boris Ostrovsky
On 10/1/18 9:12 AM, Andrew Cooper wrote: > On 01/10/18 12:13, Jan Beulich wrote: > On 01.10.18 at 11:58, wrote: >>> Having the allocator return unscrubbed pages is a potential security >>> concern: some domain can be given pages with memory contents of another >>> domain. This may happen, for

Re: [Xen-devel] [PATCH] mm/page_alloc: always scrub pages given to the allocator

2018-10-01 Thread Boris Ostrovsky
On 10/1/18 9:50 AM, George Dunlap wrote: > On 10/01/2018 02:44 PM, Boris Ostrovsky wrote: >> On 10/1/18 9:12 AM, Andrew Cooper wrote: >>> On 01/10/18 12:13, Jan Beulich wrote: >>>>>>> On 01.10.18 at 11:58, wrote: >>>>> Having the all

Re: [Xen-devel] Ping: [PATCH v3 3/4] x86/HVM: implement memory read caching

2018-10-02 Thread Boris Ostrovsky
r nowadays than we did in the past, we're still >> not quite there to guarantee hardware like behavior in all cases >> anyway. Nothing is getting worse by the changes made here, afaict. >> >> Signed-off-by: Jan Beulich >> Acked-by: Tim Deegan >> Reviewed-by: Paul Durrant > SVM and VMX maintainers? Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] x86/HVM: move vendor independent CPU save/restore logic to shared code

2018-10-05 Thread Boris Ostrovsky
endor "save" hook, eliminating the need for the hook > functions to zero individual fields. > > Signed-off-by: Jan Beulich Reviewed-by: Boris Ostrovsky https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH] xen/balloon: Support xend-based toolstack

2018-10-07 Thread Boris Ostrovsky
Xend-based toolstacks don't have static-max entry in xenstore. The equivalent node for those toolstacks is memory_static_max. Fixes: 5266b8e4445c (xen: fix booting ballooned down hvm guest) Signed-off-by: Boris Ostrovsky Cc: # 4.13 --- drivers/xen/xen-balloon.c | 13 - 1

Re: [Xen-devel] [PATCH V3 2/2] Xen/PCIback: Implement PCI flr/slot/bus reset with 'reset' SysFS attribute

2018-10-08 Thread Boris Ostrovsky
On 10/3/18 11:51 AM, Pasi Kärkkäinen wrote: > On Wed, Sep 19, 2018 at 11:05:26AM +0200, Roger Pau Monné wrote: >> On Tue, Sep 18, 2018 at 02:09:53PM -0400, Boris Ostrovsky wrote: >>> On 9/18/18 5:32 AM, George Dunlap wrote: >>>>> On Sep 18, 2018, at 8:15 AM, Pasi

Re: [Xen-devel] [PATCH v4 3/3] x86/acpi: take rsdp address for boot params if available

2018-10-09 Thread Boris Ostrovsky
On 10/9/18 6:54 AM, Juergen Gross wrote: > + > +u64 x86_default_get_root_pointer(void) > +{ > + return boot_params.hdr.acpi_rsdp_addr; > +} Should we then update init_pvh_bootparams() with     pvh_bootparams.hdr.acpi_rsdp_addr = pvh_start_info.rsdp_paddr; (and drop x86_init.acpi.get_root_po

Re: [Xen-devel] [PATCH] KVM: Start populating /sys/hypervisor with KVM entries

2018-10-09 Thread Boris Ostrovsky
On 10/9/18 6:41 AM, Christian Borntraeger wrote: > > > On 10/09/2018 11:54 AM, Filippo Sironi wrote: >> Start populating /sys/hypervisor with KVM entries when we're running on >> KVM. This is to replicate functionality that's available when we're >> running on Xen. >> >> Let's start with /sys/hyp

Re: [Xen-devel] [PATCH] xen: drop writing error messages to xenstore

2018-10-10 Thread Boris Ostrovsky
On 10/10/18 11:53 AM, Juergen Gross wrote: > On 10/10/2018 17:09, Joao Martins wrote: >> On 10/09/2018 05:09 PM, Juergen Gross wrote: >>> xenbus_va_dev_error() will try to write error messages to Xenstore >>> under the error//error node (with something like >>> "device/vbd/51872"). This will fail

Re: [Xen-devel] [PATCH v2 5/5] x86: Reorganise and rename debug register fields in struct vcpu

2018-10-15 Thread Boris Ostrovsky
On 10/15/18 6:36 AM, Andrew Cooper wrote: > > @@ -567,7 +573,10 @@ struct arch_vcpu > void *fpu_ctxt; > unsigned long vgc_flags; > struct cpu_user_regs user_regs; > -unsigned long debugreg[8]; > + > +/* Debug registers. */ > +unsigned long dr[4],

Re: [Xen-devel] [PATCH v2 5/5] x86: Reorganise and rename debug register fields in struct vcpu

2018-10-15 Thread Boris Ostrovsky
On 10/15/18 9:32 AM, Andrew Cooper wrote: > On 15/10/18 14:28, Boris Ostrovsky wrote: >> On 10/15/18 6:36 AM, Andrew Cooper wrote: >>> >>> @@ -567,7 +573,10 @@ struct arch_vcpu >>> void *fpu_ctxt; >>> unsigned long vgc_f

Re: [Xen-devel] [PATCH] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM

2018-10-16 Thread Boris Ostrovsky
le")" so it can be > picked up for backporting. SoB would also be good to have ;-) Reviewed-by: Boris Ostrovsky > > Acked-by: Julien Grall > > Cheers, >> >> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h >> index fd18c97..939a962 10064

Re: [Xen-devel] Ping AMD maintainers? [PATCH] x86/svm: Fix svm_update_guest_efer() for domains using shadow paging

2018-10-17 Thread Boris Ostrovsky
gt;> In addition to describing this corner case in the SVM side, extend the >> comment >> for the same fix on the VT-x side. (I have a suspicion that I've just worked >> out why VT-x doesn't tolerate LMA != LME when Unrestricted Guest is clear.) >> >> Si

Re: [Xen-devel] [PATCH] x86/svm: Remove the pdpe fields from struct vmcb

2018-10-17 Thread Boris Ostrovsky
design. > Xen doesn't use the fields at all, except to copy them on virtual > vmentry/vmexit. > > Signed-off-by: Andrew Cooper Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] add myself as reviewer for Xen support in Linux

2018-10-17 Thread Boris Ostrovsky
On 10/17/18 9:44 AM, Stefano Stabellini wrote: > It would be good for me to keep an eye on the patches that touch Xen > support in Linux to try to spot changes that break Xen on ARM early on. > > Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky > > diff --g

Re: [Xen-devel] [PATCH] x86: Consolidate the storage of MSR_AMD64_DR{0-3}_ADDRESS_MASK

2018-10-19 Thread Boris Ostrovsky
On 10/19/18 11:14 AM, Andrew Cooper wrote: > diff --git a/xen/include/asm-x86/msr.h b/xen/include/asm-x86/msr.h > index 7a061b2..c1cb38f 100644 > --- a/xen/include/asm-x86/msr.h > +++ b/xen/include/asm-x86/msr.h > @@ -287,6 +287,12 @@ struct vcpu_msrs > bool cpuid_faulting:1; >

Re: [Xen-devel] [PATCH] xen-swiotlb: exchange memory with Xen only when pages are contiguous

2018-10-24 Thread Boris Ostrovsky
involve swapping if and else in the former. > > Does that sound correct? > >> Thank you Boris for pointing it out. >> > Fixes: 4855c92dbb7 ("xen-sw..") ? > >> Signed-off-by: Joe Jin >> Cc: Konrad Rzeszutek Wilk >> Cc: Boris Ostrovsky > Repo

Re: [Xen-devel] [PATCH] xen-swiotlb: exchange memory with Xen only when pages are contiguous

2018-10-25 Thread Boris Ostrovsky
On 10/24/18 10:43 AM, Joe Jin wrote: > On 10/24/18 6:57 AM, Boris Ostrovsky wrote: >> On 10/24/18 9:02 AM, Konrad Rzeszutek Wilk wrote: >>> On Tue, Oct 23, 2018 at 08:09:04PM -0700, Joe Jin wrote: >>>> Commit 4855c92dbb7 "xen-swiotlb: fix the check condition

Re: [Xen-devel] [PATCH] xen/pvh: don't try to unplug emulated devices

2018-10-25 Thread Boris Ostrovsky
he boot message: > > [0.00] Xen Platform PCI: unrecognised magic value > > Cc: # 4.11 > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen: drop writing error messages to xenstore

2018-10-25 Thread Boris Ostrovsky
On 10/25/18 8:36 AM, Juergen Gross wrote: > On 11/10/2018 13:03, Joao Martins wrote: >> On 10/11/2018 06:05 AM, Juergen Gross wrote: >>> On 10/10/2018 18:57, Boris Ostrovsky wrote: >>>> On 10/10/18 11:53 AM, Juergen Gross wrote: >>>>> On 10/10/2018 17

Re: [Xen-devel] [PATCH] xen-swiotlb: exchange memory with Xen only when pages are contiguous

2018-10-25 Thread Boris Ostrovsky
On 10/25/18 10:23 AM, Joe Jin wrote: > On 10/25/18 4:45 AM, Boris Ostrovsky wrote: >> On 10/24/18 10:43 AM, Joe Jin wrote: >>> On 10/24/18 6:57 AM, Boris Ostrovsky wrote: >>>> On 10/24/18 9:02 AM, Konrad Rzeszutek Wilk wrote: >>>>> On Tue, Oc

Re: [Xen-devel] [PATCH] xen: fix frontend driver disconnected from xenbus on removal

2018-02-01 Thread Boris Ostrovsky
On 02/01/2018 03:57 AM, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Current xenbus frontend driver removal flow first disconnects > the driver from xenbus and then calls driver's remove callback. > This makes it impossible for the driver to listen to backend's > state change

Re: [Xen-devel] [PATCH v2] x86/xen: init %gs very early to avoid page faults with stack protector

2018-02-01 Thread Boris Ostrovsky
dy. > > Cc: sta...@vger.kernel.org > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen: fix frontend driver disconnected from xenbus on removal

2018-02-01 Thread Boris Ostrovsky
On 02/01/2018 03:24 PM, Oleksandr Andrushchenko wrote: > > > On 02/01/2018 10:08 PM, Boris Ostrovsky wrote: >> On 02/01/2018 03:57 AM, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> Current xenbus frontend driver removal flow fi

Re: [Xen-devel] [PATCH] xen: hypercall: fix out-of-bounds memcpy

2018-02-02 Thread Boris Ostrovsky
On 02/02/2018 10:32 AM, Arnd Bergmann wrote: > The legacy hypercall handlers were originally added with > a comment explaining that "copying the argument structures in > HYPERVISOR_event_channel_op() and HYPERVISOR_physdev_op() into the local > variable is sufficiently safe" and only made sure to n

Re: [Xen-devel] [PATCH 1/3] x86/svm: update VGIF support

2018-02-03 Thread Boris Ostrovsky
Woods Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD

2018-02-03 Thread Boris Ostrovsky
On 01/31/2018 03:35 PM, Brian Woods wrote: Only enable virtual VMLOAD/SAVE and VGIF if the guest EFER.SVME is set. Reported-by: Andrew Cooper Signed-off-by: Brian Woods Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel

Re: [Xen-devel] [PATCH 3/3] x86/svm: correct EFER.SVME intercept checks

2018-02-03 Thread Boris Ostrovsky
On 01/31/2018 03:35 PM, Brian Woods wrote: Corrects some EFER.SVME checks in intercepts. See AMD APM vol2 section 15.4 for more details. VMMCALL isn't checked due to guests needing it to boot. Don't you need SVME be on for VMMCALL? -boris ___

Re: [Xen-devel] [PATCH] xen: hypercall: fix out-of-bounds memcpy

2018-02-03 Thread Boris Ostrovsky
On 02/03/2018 10:12 AM, Arnd Bergmann wrote: On Sat, Feb 3, 2018 at 12:33 AM, Boris Ostrovsky wrote: On 02/02/2018 10:32 AM, Arnd Bergmann wrote: The legacy hypercall handlers were originally added with a comment explaining that "copying the argument structur

Re: [Xen-devel] [PATCH 3/3] x86/svm: correct EFER.SVME intercept checks

2018-02-03 Thread Boris Ostrovsky
On 02/03/2018 12:10 PM, Andrew Cooper wrote: On 03/02/18 17:03, Boris Ostrovsky wrote: On 01/31/2018 03:35 PM, Brian Woods wrote: Corrects some EFER.SVME checks in intercepts.  See AMD APM vol2 section 15.4 for more details.  VMMCALL isn't checked due to guests needing it to boot.

Re: [Xen-devel] [PATCH] xen: hypercall: fix out-of-bounds memcpy

2018-02-04 Thread Boris Ostrovsky
On 02/04/2018 10:35 AM, Arnd Bergmann wrote: On Sat, Feb 3, 2018 at 6:08 PM, Boris Ostrovsky wrote: On 02/03/2018 10:12 AM, Arnd Bergmann wrote: On Sat, Feb 3, 2018 at 12:33 AM, Boris Ostrovsky wrote: On 02/02/2018 10:32 AM, Arnd Bergmann wrote: The legacy hypercall handlers were

Re: [Xen-devel] [PATCH] pvcalls-back: do not return error on inet_accept EAGAIN

2018-02-04 Thread Boris Ostrovsky
On 02/02/2018 08:34 PM, Stefano Stabellini wrote: When the client sends a regular blocking accept request, the backend is expected to return only when the accept is completed, simulating a blocking behavior, or return an error. Specifically, on EAGAIN from inet_accept, the backend shouldn't re

Re: [Xen-devel] [PATCH] pvcalls-back: do not return error on inet_accept EAGAIN

2018-02-05 Thread Boris Ostrovsky
On 02/05/2018 01:01 PM, Stefano Stabellini wrote: > On Sun, 4 Feb 2018, Boris Ostrovsky wrote: >> On 02/02/2018 08:34 PM, Stefano Stabellini wrote: >>> When the client sends a regular blocking accept request, the backend is >>> expected to return only when the accept

Re: [Xen-devel] [PATCH] x86/xen: Calculate __max_logical_packages on PV domains

2018-02-07 Thread Boris Ostrovsky
by: Prarit Bhargava Tested-and-reported-by: Simon Gaiser Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Dou Liyang Cc: Prarit Bhargava Cc: Kate Stewart Cc: Greg Kroah-Hartman Cc: Andy Lutomirski Cc: Andi Kleen

Re: [Xen-devel] [PATCH v2 2/4] hvm/svm: Enable Breakpoint events

2018-02-10 Thread Boris Ostrovsky
On 02/08/2018 10:25 AM, Alexandru Isaila wrote: + + rc = hvm_monitor_debug(regs->rip, + HVM_MONITOR_SOFTWARE_BREAKPOINT, + X86_EVENTTYPE_SW_EXCEPTION, + inst_len); + if ( rc <

Re: [Xen-devel] [PATCH 1/2] xen: xenbus_dev_frontend: Fix XS_TRANSACTION_END handling

2018-02-10 Thread Boris Ostrovsky
sidering a transaction closed if we have sent XS_TRANSACTION_END once regardless of the return code. Cc: # 4.11 Fixes: fd8aa9095a95 ("xen: optimize xenbus driver for multiple concurrent xenstore accesses") Signed-off-by: Simon Gaiser Reviewed-by: Boris Ostrovsky (although I'd pref

Re: [Xen-devel] [PATCH 2/2] xen: xenbus: WARN_ON XS_TRANSACTION_{START, END} misuse

2018-02-10 Thread Boris Ostrovsky
On 02/07/2018 05:22 PM, Simon Gaiser wrote: As the previous commit shows it's quite easy to confuse the transaction reference counting by ending a transaction twice. So at least try to detect and report it. Signed-off-by: Simon Gaiser --- drivers/xen/xenbus/xenbus_xs.c | 9 + 1 fil

Re: [Xen-devel] [PATCH v2 1/4] asm-x86/monitor: Enable svm monitor events

2018-02-10 Thread Boris Ostrovsky
(Resending) On 02/10/2018 11:30 AM, Boris Ostrovsky wrote: > > > On 02/08/2018 10:25 AM, Alexandru Isaila wrote: >> This commit separates the svm caps from the vmx caps. >> >> Signed-off-by: Alexandru Isaila >> >> --- >> Changes since V1: >>

Re: [Xen-devel] [PATCH v2 3/4] hvm/svm: Enable MSR events

2018-02-10 Thread Boris Ostrovsky
(Resending too. Something was wrong with my client) On 02/10/2018 11:33 AM, Boris Ostrovsky wrote: On 02/08/2018 10:25 AM, Alexandru Isaila wrote: This commit enables MSR events for svm. Signed-off-by: Alexandru Isaila Reviewed-by: Boris Ostrovsky

Re: [Xen-devel] [PATCH 2/2] xen: xenbus: WARN_ON XS_TRANSACTION_{START, END} misuse

2018-02-11 Thread Boris Ostrovsky
On 02/10/2018 08:27 PM, Simon Gaiser wrote: Boris Ostrovsky: On 02/07/2018 05:22 PM, Simon Gaiser wrote: +users_old = xs_state_users; xs_state_users--; if ((req->type == XS_TRANSACTION_START && req->msg.type == XS_ERROR) || req->type == X

Re: [Xen-devel] [PATCH v2 3/4] hvm/svm: Enable MSR events

2018-02-14 Thread Boris Ostrovsky
On 02/08/2018 10:25 AM, Alexandru Isaila wrote: This commit enables MSR events for svm. Signed-off-by: Alexandru Isaila Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org

Re: [Xen-devel] [PATCH v2 1/4] asm-x86/monitor: Enable svm monitor events

2018-02-14 Thread Boris Ostrovsky
On 02/08/2018 10:25 AM, Alexandru Isaila wrote: This commit separates the svm caps from the vmx caps. Signed-off-by: Alexandru Isaila --- Changes since V1: - Removed the if ( cpu_has_svm ) --- xen/include/asm-x86/monitor.h | 34 +++--- 1 file changed, 1

Re: [Xen-devel] [PATCH v4 0/4] hvm/svm: Enable vm events for SVM

2018-02-15 Thread Boris Ostrovsky
On 02/15/2018 05:22 AM, Alexandru Isaila wrote: > Hi all, > > This series provides a skeleton for enabling vm_events on SVM. For the > first step, the MSR, CR, Breakpoint and GuestRequest have been tested > and added to the capabilities list. > Reviewed-b

Re: [Xen-devel] [PATCH v2 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD

2018-02-20 Thread Boris Ostrovsky
On 02/20/2018 05:00 PM, Brian Woods wrote: > I've seen patch 1 and 3 are in but this one isn't. Any status on it? > That's possibly because you needed an SVM maintainer ACK. I think Jan was waiting for decision on how to present the ASSERT. From the 3 options I slightly more prefer ASSERT(neste

Re: [Xen-devel] [PATCH v4 2/3] x86/svm: add EFER SVME support for VGIF/VLOAD

2018-02-20 Thread Boris Ostrovsky
On 02/20/2018 05:27 PM, Brian Woods wrote: > Only enable virtual VMLOAD/SAVE and VGIF if the guest EFER.SVME is set. > > Reported-by: Andrew Cooper > Signed-off-by: Brian Woods Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing li

Re: [Xen-devel] [PATCH v3 1/2] x86/hvm: introduce cr{0, 4}_host_mask to store trapped bits of CR accesses

2018-02-20 Thread Boris Ostrovsky
On 02/20/2018 03:56 AM, Roger Pau Monne wrote: > At the moment this is currently set at VMC{S/B} creation and not changed, > but further patches are going to change the CR4 mask at runtime. > > Signed-off-by: Roger Pau Monné > --- > Cc: Boris Ostrovsky > Cc: Suravee Sut

Re: [Xen-devel] [PATCH v3 1/2] x86/hvm: introduce cr{0, 4}_host_mask to store trapped bits of CR accesses

2018-02-21 Thread Boris Ostrovsky
On 02/21/2018 03:27 AM, Roger Pau Monné wrote: > On Tue, Feb 20, 2018 at 07:23:44PM -0500, Boris Ostrovsky wrote: >> On 02/20/2018 03:56 AM, Roger Pau Monne wrote: >>> At the moment this is currently set at VMC{S/B} creation and not changed, >>> but further patches are g

Re: [Xen-devel] [PATCH v4 16/16] xen: Convert page_to_mfn and mfn_to_page to use typesafe MFN

2018-02-21 Thread Boris Ostrovsky
n that > most of the callers are now switched to _mfn(domain_page_to_mfn(...)). > > Signed-off-by: Julien Grall Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 0/2] x86/svm: add pause filtering threshold for SVM

2018-02-21 Thread Boris Ostrovsky
hvm/svm/svm.h | 5 - > xen/include/asm-x86/hvm/svm/vmcb.h | 3 ++- > 4 files changed, 10 insertions(+), 2 deletions(-) > IIRC previous count value (3000) was somewhat arbitrary so Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list X

Re: [Xen-devel] [PATCH] x86/HVM: don't give the wrong impression of WRMSR succeeding

2018-02-22 Thread Boris Ostrovsky
mit 013e34f5a6 ("x86: handle paged gfn in > wrmsr_hypervisor_regs") was probably okay, since prior to that the > return value wasn't checked at all. But that's not how we want things > to be handled nowadays. > > Si

Re: [Xen-devel] [PATCH v2] hvm/svm: Implement CPUID events

2018-02-22 Thread Boris Ostrovsky
On 02/21/2018 05:18 AM, Alexandru Isaila wrote: > At this moment the CPUID events for the AMD architecture are not > forwarded to the monitor layer. > > This patch adds the CPUID event to the common capabilities and then > forwards the event to the monitor layer. > > --- > Changes since V1: >

Re: [Xen-devel] [PATCH] x86/HVM: don't give the wrong impression of WRMSR succeeding

2018-02-22 Thread Boris Ostrovsky
On 02/22/2018 10:44 AM, Jan Beulich wrote: On 22.02.18 at 15:53, wrote: >> On 22/02/18 13:44, Jan Beulich wrote: >>> ... for unknown MSRs: wrmsr_hypervisor_regs()'s comment clearly says >>> that the function returns 0 for unrecognized MSRs, so >>> {svm,vmx}_msr_write_intercept() should not co

Re: [Xen-devel] [PATCH 1/9] drm/xen-front: Introduce Xen para-virtualized frontend driver

2018-02-22 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > +static struct xenbus_driver xen_driver = { > + .ids = xen_drv_ids, > + .probe = xen_drv_probe, > + .remove = xen_drv_remove, > + .otherend_changed = backend_on_changed, What does "_on_" stand for? -boris __

Re: [Xen-devel] [PATCH 3/9] drm/xen-front: Read driver configuration from Xen store

2018-02-22 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > + > +static int cfg_connector(struct xen_drm_front_info *front_info, > + struct xen_drm_front_cfg_connector *connector, > + const char *path, int index) > +{ > + char *connector_path; > + > + connector_path = d

Re: [Xen-devel] [PATCH 4/9] drm/xen-front: Implement Xen event channel handling

2018-02-22 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > + > +static irqreturn_t evtchnl_interrupt_ctrl(int irq, void *dev_id) > +{ > + struct xen_drm_front_evtchnl *evtchnl = dev_id; > + struct xen_drm_front_info *front_info = evtchnl->front_info; > + struct xendispl_resp *resp; > +

Re: [Xen-devel] [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

2018-02-22 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > > static int __init xen_drv_init(void) > { > + /* At the moment we only support case with XEN_PAGE_SIZE == PAGE_SIZE */ > + BUILD_BUG_ON(XEN_PAGE_SIZE != PAGE_SIZE); Why BUILD_BUG_ON? This should simply not load if page sizes ar

Re: [Xen-devel] [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

2018-02-23 Thread Boris Ostrovsky
On 02/23/2018 02:53 AM, Oleksandr Andrushchenko wrote: > On 02/23/2018 02:25 AM, Boris Ostrovsky wrote: >> On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: >>> static int __init xen_drv_init(void) >>> { >>> +/* At the moment we only support case

Re: [Xen-devel] [PATCH 1/9] drm/xen-front: Introduce Xen para-virtualized frontend driver

2018-02-23 Thread Boris Ostrovsky
On 02/23/2018 01:37 AM, Oleksandr Andrushchenko wrote: > On 02/23/2018 12:23 AM, Boris Ostrovsky wrote: >> On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: >>> +static struct xenbus_driver xen_driver = { >>> +.ids = xen_drv_ids, >>> +.pro

Re: [Xen-devel] [PATCH 4/9] drm/xen-front: Implement Xen event channel handling

2018-02-23 Thread Boris Ostrovsky
On 02/23/2018 02:00 AM, Oleksandr Andrushchenko wrote: > On 02/23/2018 01:50 AM, Boris Ostrovsky wrote: >> On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: >>> + >>> +static irqreturn_t evtchnl_interrupt_ctrl(int irq, void *dev_id) >>> +{ >>&g

Re: [Xen-devel] [PATCH v3] hvm/svm: Implement CPUID events

2018-02-23 Thread Boris Ostrovsky
gt; Changes since V2: > - Pass the inst_len to svm_vmexit_do_cpuid() > > Signed-off-by: Alexandru Isaila Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 6/9] drm/xen-front: Introduce DRM/KMS virtual display driver

2018-02-23 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > + > +struct drm_driver xen_drm_driver = { > + .driver_features = DRIVER_GEM | DRIVER_MODESET | > + DRIVER_PRIME | DRIVER_ATOMIC, > + .lastclose = lastclose, > + .gem_free

Re: [Xen-devel] [PATCH 8/9] drm/xen-front: Implement GEM operations

2018-02-23 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > +static struct xen_gem_object *gem_create(struct drm_device *dev, size_t size) > +{ > + struct xen_drm_front_drm_info *drm_info = dev->dev_private; > + struct xen_gem_object *xen_obj; > + int ret; > + > + size = round_up(size,

Re: [Xen-devel] [PATCH] xen: use hvc console for dom0

2018-02-26 Thread Boris Ostrovsky
On 02/26/2018 06:08 AM, Juergen Gross wrote: > Today the hvc console is added as a preferred console for pv domUs > only. As this requires a boot parameter for getting dom0 messages per > default add it for dom0, too. > > Signed-off-by: Juergen Gross > --- > arch/x86/xen/enlighten_pv.c | 4 +++- >

Re: [Xen-devel] [PATCH 2/6] x86/hvm: Handle viridian MSRs via the new guest_{rd, wr}msr() infrastructure

2018-02-26 Thread Boris Ostrovsky
very appropriate. > > Update them to take a vcpu pointer rather than presuming that they act on > current, which is safe for all implemented operations. Also update them to > use X86EMUL_* return values. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Jun

Re: [Xen-devel] [PATCH 3/6] x86: Handle the Xen MSRs via the new guest_{rd, wr}msr() infrastructure

2018-02-26 Thread Boris Ostrovsky
7;t very appropriate. > > Update them to take a vcpu pointer rather than presuming that they act on > current, and switch to using X86EMUL_* return values. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Jun Nakajima > CC: Paul Durrant > CC: Kevin Tian

Re: [Xen-devel] [RFC PATCH 0/5] x86: Multiple fixes to MSR_TSC_AUX and RDTSCP handling for guests

2018-02-26 Thread Boris Ostrovsky
On 02/26/2018 02:12 PM, Andrew Cooper wrote: > On 20/02/18 11:58, Andrew Cooper wrote: >> This rats nest was discovered when finding that MSR_TSC_AUX leaked into PV >> guests. It is RFC because I haven't done extensive testing on the result, >> and >> because there are some functional changes for

Re: [Xen-devel] [PATCH 2/5] x86/pv: Avoid leaking other guests' MSR_TSC_AUX values into PV context

2018-02-26 Thread Boris Ostrovsky
e common case. > > To amortise overhead cost, introduce wrmsr_tsc_aux() which performs a lazy > update of the MSR, and use this function consistently across the codebase. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Jun Nakajima > CC: Kevin Tian > CC:

Re: [Xen-devel] [PATCH 1/2] xen: fix out-of-bounds irq unbind for MSI message groups

2018-02-26 Thread Boris Ostrovsky
Reported-by: Hooman Mirhadi > CC: > CC: Roger Pau Monné > CC: David Vrabel > CC: Boris Ostrovsky > CC: Eduardo Valentin > CC: Juergen Gross > CC: Thomas Gleixner > CC: "K. Y. Srinivasan" > CC: Liu Shuo > CC: Anoob Soman > Signed-off-by: Amit Sha

Re: [Xen-devel] [PATCH 8/9] drm/xen-front: Implement GEM operations

2018-02-26 Thread Boris Ostrovsky
On 02/23/2018 10:35 AM, Oleksandr Andrushchenko wrote: > On 02/23/2018 05:26 PM, Boris Ostrovsky wrote: >> On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: >>> +static struct xen_gem_object *gem_create(struct drm_device *dev, >>> size_t size) >>> +{ &g

Re: [Xen-devel] [PATCH] x86/HVM: don't give the wrong impression of WRMSR succeeding

2018-02-27 Thread Boris Ostrovsky
On 02/27/2018 03:39 AM, Jan Beulich wrote: On 23.02.18 at 08:55, wrote: > On 22.02.18 at 23:16, wrote: >>> On 02/22/2018 10:44 AM, Jan Beulich wrote: >>> On 22.02.18 at 15:53, wrote: > On 22/02/18 13:44, Jan Beulich wrote: >> ... for unknown MSRs: wrmsr_hypervisor_regs()'s c

Re: [Xen-devel] [PATCH v2] x86/xen: add tty0 and hvc0 as preferred consoles for dom0

2018-02-27 Thread Boris Ostrovsky
On 02/27/2018 05:19 AM, Juergen Gross wrote: > Today the tty0 and hvc0 consoles are added as a preferred consoles for > pv domUs only. As this requires a boot parameter for getting dom0 > messages per default, add them for dom0, too. > > Signed-off-by: Juergen Gross Reviewed-by:

Re: [Xen-devel] [PATCH] pvcalls-front: 64-bit align flags

2018-02-27 Thread Boris Ostrovsky
On 02/27/2018 02:54 PM, Stefano Stabellini wrote: > We are using test_and_* operations on the status and flag fields of > struct sock_mapping. However, these functions require the operand to be > 64-bit aligned on arm64. Currently, only status is 64-bit aligned. > > Make flags 64-bit aligned by int

Re: [Xen-devel] [PATCH] pvcalls-front: 64-bit align flags

2018-02-27 Thread Boris Ostrovsky
On 02/27/2018 04:32 PM, Stefano Stabellini wrote: > On Tue, 27 Feb 2018, Boris Ostrovsky wrote: >> On 02/27/2018 02:54 PM, Stefano Stabellini wrote: >>> We are using test_and_* operations on the status and flag fields of >>> struct sock_mapping. However, these function

Re: [Xen-devel] [PATCH] xen/pirq: fix error path cleanup when binding MSIs

2018-02-28 Thread Boris Ostrovsky
gt; Fixes: 4892c9b4ada9f9 ("xen: add support for MSI message groups") >> Reported-by: Hooman Mirhadi >> Signed-off-by: Roger Pau Monné >> --- >> Cc: Boris Ostrovsky >> Cc: Juergen Gross >> Cc: Amit Shah >> CC: sta...@vger.kernel.org >

Re: [Xen-devel] [PATCH] xen-netfront: Fix hang on device removal

2018-02-28 Thread Boris Ostrovsky
) > > Signed-off-by: Jason Andryuk > Cc: Eduardo Otubo Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [ATTN SVM maintainers] Re: [PATCH V6] x86/hvm: fix domain crash when CR3 has the noflush bit set

2018-02-28 Thread Boris Ostrovsky
gt; >> Signed-off-by: Razvan Cojocaru >> Reported-by: Bitweasil >> Suggested-by: Andrew Cooper >> Acked-by: Tamas K Lengyel >> Reviewed-by: Jan Beulich >> Reviewed-by: Kevin Tian >> Acked-by: George Dunlap > Boris / Suvaree, any opinions on the S

Re: [Xen-devel] [PATCH 8/9] drm/xen-front: Implement GEM operations

2018-02-28 Thread Boris Ostrovsky
On 02/27/2018 01:52 AM, Oleksandr Andrushchenko wrote: > On 02/27/2018 01:47 AM, Boris Ostrovsky wrote: >> On 02/23/2018 10:35 AM, Oleksandr Andrushchenko wrote: >>> On 02/23/2018 05:26 PM, Boris Ostrovsky wrote: >>>> On 02/21/2018 03:03 AM, Oleksandr Andrushchenk

Re: [Xen-devel] [PATCH v2] pvcalls-front: 64-bit align flags

2018-02-28 Thread Boris Ostrovsky
-bit aligned. Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [RFC PATCH v4 1/7] xen/pvh: Split CONFIG_XEN_PVH into CONFIG_PVH and CONFIG_XEN_PVH

2018-03-01 Thread Boris Ostrovsky
On 02/28/2018 01:27 PM, Maran Wilson wrote: > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index eb7f43f23521..fa7cd0305125 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -791,6 +791,14 @@ config KVM_GUEST > underlying device model, the host provides the guest with >

Re: [Xen-devel] [RFC PATCH v4 4/7] xen/pvh: Move Xen specific PVH VM initialization out of common code

2018-03-01 Thread Boris Ostrovsky
On 02/28/2018 01:28 PM, Maran Wilson wrote: > We need to refactor PVH entry code so that support for other hypervisors > like Qemu/KVM can be added more easily. > > This patch moves the small block of code used for initializing Xen PVH > virtual machines into the Xen specific file. This initializat

Re: [Xen-devel] [RFC PATCH v4 2/7] xen/pvh: Move PVH entry code out of Xen specific tree

2018-03-01 Thread Boris Ostrovsky
On 03/01/2018 03:46 AM, Paolo Bonzini wrote: > On 01/03/2018 07:11, Juergen Gross wrote: >>> Probably a better place for these would be >>> arch/x86/platform/pvh/{enlighten.c,head.S}. (Just because there are no >>> .c or .S files in arch/x86). >> Right. >> >>> Maybe Xen ought to be moved under >>>

Re: [Xen-devel] [PATCH v3 7/7] amd/pvh: enable ACPI C1E disable quirk on PVH Dom0

2018-10-31 Thread Boris Ostrovsky
I is enabled. > > Reported-by: Jan Beulich > Signed-off-by: Roger Pau Monné > --- > Cc: Jan Beulich > Cc: Andrew Cooper > Cc: Wei Liu > Cc: Boris Ostrovsky > Cc: Suravee Suthikulpanit > Cc: Brian Woods Reviewed-by: Boris Ostrovsky ___

Re: [Xen-devel] [PATCH v2 2/8] x86/nestedhvm: introduce vvmcx_valid()

2018-11-06 Thread Boris Ostrovsky
On 11/6/18 7:07 AM, Sergey Dyasli wrote: > As a convenient helper function and refactor the code to use it. > > No functional change. > > Signed-off-by: Sergey Dyasli > --- > CC: Boris Ostrovsky > CC: Suravee Suthikulpanit > CC: Brian Woods > > v2: >

Re: [Xen-devel] x86 Community Call: Nov 14 - 15:00 - 16:00 UTC - Call for Agenda Items

2018-11-07 Thread Boris Ostrovsky
On 11/7/18 5:49 AM, Daniel Kiper wrote: > On Tue, Nov 06, 2018 at 09:54:54AM -0700, Jan Beulich wrote: > On 02.11.18 at 18:59, wrote: >>> It’s time again for the x86 community call: for the agenda see >>> https://docs.google.com/document/d/1RxW-iwcFFuKzNjjEqLEtiwFVHgAUlk35c0EtTkRE1 >>> k4/edit

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-07 Thread Boris Ostrovsky
On 11/7/18 4:30 AM, Sander Eikelenboom wrote: > Hi Juergen / Boris, > > Last week i tested Linux kernel 4.19.0 stable with the Xen "for-linus-4.20" > branch pulled on top. > Unfortunately i was seeing guests lockup after some time, see below for the > logging from one of the guest > which i was a

Re: [Xen-devel] Guest soft lockups with "xen: make xen_qlock_wait() nestable"

2018-11-07 Thread Boris Ostrovsky
On 11/7/18 5:45 PM, Sander Eikelenboom wrote: > On 07/11/18 23:34, Boris Ostrovsky wrote: >> On 11/7/18 4:30 AM, Sander Eikelenboom wrote: >>> Hi Juergen / Boris, >>> >>> Last week i tested Linux kernel 4.19.0 stable with the Xen "for-linus-4.20" >

Re: [Xen-devel] [PATCH] xen: remove size limit of privcmd-buf mapping interface

2018-11-09 Thread Boris Ostrovsky
On 11/9/18 2:03 AM, Juergen Gross wrote: > Ping? > > Jan's remark regarding de-privileged qemu is no issue as the hypercall > node is being closed by the de-privilege library function. Reviewed-by: Boris Ostrovsky ___ Xen-devel

Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()

2018-11-09 Thread Boris Ostrovsky
tatic DEFINE_PER_CPU(int, lock_kicker_irq) = -1; > static DEFINE_PER_CPU(char *, irq_name); > +static DEFINE_PER_CPU(atomic_t, xen_qlock_wait_nest); I'd move this to xen_qlock_wait(). Either way, Reviewed-by: Boris Ostrovsky > static bool xen_pvspin = true; > > s

<    1   2   3   4   5   6   7   8   9   10   >