wrote:
> From: Anthony PERARD
>
> When doing a live migration of a Xen guest with libxl, the images for
> block devices are locked by the original QEMU process, and this prevent
> the QEMU at the destination to take the lock and the migration fail.
>
> >From QEMU point of view
drew Cooper
> CC: Jan Beulich
> CC: Stefano Stabellini
> CC: Konrad Wilk
> CC: Tim Deegan
> CC: Roger Pau Monne
> CC: Anthony Perard
> CC: Paul Durrant
> ---
> SUPPORT.md | 105
> +
> 1 file cha
On Mon, Nov 27, 2017 at 04:30:36PM +, George Dunlap wrote:
> On 11/27/2017 03:12 PM, Anthony PERARD wrote:
> > On Wed, Nov 22, 2017 at 07:20:15PM +, George Dunlap wrote:
> >> x86-specific virtual hardware provided by the hypervisor, toolstack,
> >> or QEMU.
>
On Wed, Nov 29, 2017 at 12:28:39PM +, Julien Grall wrote:
> + Stefano
>
> On 11/27/2017 03:00 PM, Anthony PERARD wrote:
> > Hi Julien,
>
> Hi Anthony,
>
> >
> > Can I get a release-ack for this patch?
> >
> > This fix local live migration
Signed-off-by: Anthony PERARD
---
Osstest/TestSupport.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 65324fb..13e4360 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -530,6 +530,8 @@ sub package_install_cmd
AND job = $job
AND name = $name
} runvarinfo {
se..."
(procedure "jobdb::read-runvar" line 3)
invoked from within
"jobdb::read-runvar $flight $job all_host_os"
(procedure "run-job" line 13)
invoked from within
"run-job $
jobs can be created with:
OSSTEST_FLIGHT=standalone ./make-centos-flight centos xen-4.8-testing play
In an osstest instance, create a flight simply with:
./make-centos-flight centos xen-4.8-testing play
Anthony PERARD (16):
JobDB-Standalone.tcl: Fix read-runvar
Osstest/TestSupport: In
e.g. If the file to be edited is only accessible to the root user,
target_getfile() would not work.
Signed-off-by: Anthony PERARD
---
Osstest/TestSupport.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index c9dada3..65324fb
Signed-off-by: Anthony PERARD
---
Osstest/CentOS.pm | 215 ++
1 file changed, 215 insertions(+)
diff --git a/Osstest/CentOS.pm b/Osstest/CentOS.pm
index 33479b1..dbba354 100644
--- a/Osstest/CentOS.pm
+++ b/Osstest/CentOS.pm
@@ -28,13 +28,22
Signed-off-by: Anthony PERARD
---
ts-centos-host-install | 154 +
1 file changed, 154 insertions(+)
create mode 100755 ts-centos-host-install
diff --git a/ts-centos-host-install b/ts-centos-host-install
new file mode 100755
index 000..943002d
set as the new default.
Signed-off-by: Anthony PERARD
---
Osstest/CentOS.pm | 7 ++
.../systemd/system/osstest-confirm-booted.service | 28 ++
overlay-centos/etc/systemd/system/osstest.target | 19 +++
3 files changed, 54
The location for new certificates is different, and
update-ca-certificates is Debian specific.
Signed-off-by: Anthony PERARD
---
Osstest/TestSupport.pm | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index
Signed-off-by: Anthony PERARD
---
Osstest/TestSupport.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 13e4360..b0e21bf 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -2818,7 +2818,8 @@ sub
This function will be use later to install CentOS on a host.
Signed-off-by: Anthony PERARD
---
Osstest/CentOS.pm | 51 +++
1 file changed, 51 insertions(+)
create mode 100644 Osstest/CentOS.pm
diff --git a/Osstest/CentOS.pm b/Osstest/CentOS.pm
Install candidate packages that have been built by CBS, the CentOS
Community Build Service.
Signed-off-by: Anthony PERARD
---
ts-centos-xen-pkg-install | 79 +++
1 file changed, 79 insertions(+)
create mode 100755 ts-centos-xen-pkg-install
diff
Signed-off-by: Anthony PERARD
---
ts-centos-xen-pkg-install | 22 ++
1 file changed, 22 insertions(+)
diff --git a/ts-centos-xen-pkg-install b/ts-centos-xen-pkg-install
index 0327b72..9a4dcdd 100755
--- a/ts-centos-xen-pkg-install
+++ b/ts-centos-xen-pkg-install
@@ -82,8
This also select a different xen installation script.
Signed-off-by: Anthony PERARD
---
sg-run-job | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/sg-run-job b/sg-run-job
index f6e8340..b324101 100755
--- a/sg-run-job
+++ b/sg-run-job
@@ -25,8 +25,9
Ajust configuration of xenconsoled and libvirtd.
Signed-off-by: Anthony PERARD
---
ts-centos-xen-pkg-install | 10 ++
1 file changed, 10 insertions(+)
diff --git a/ts-centos-xen-pkg-install b/ts-centos-xen-pkg-install
index e10456d..0327b72 100755
--- a/ts-centos-xen-pkg-install
+++ b
Signed-off-by: Anthony PERARD
---
Osstest/TestSupport.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 40a5c5a..c82ba96 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -1949,8 +1949,8 @@ sub
is no build jobs as the Xen packages been tested
are built in the CentOS CBS.
Signed-off-by: Anthony PERARD
---
make-centos-flight | 524 +
1 file changed, 524 insertions(+)
create mode 100755 make-centos-flight
diff --git a/make-centos-flight
On host running with systemd as init, doing `ssh host reboot` will
result in ssh returning an error.
This patch works around by not waiting for the reboot command to return.
Signed-off-by: Anthony PERARD
---
Osstest/TestSupport.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
b: activate input handlers for raw pointer devices
The patch series looks good to me:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
nst older version of Xen, but I don't think an
older libxc (like from Xen 4.10) is going to correctly with this new
arguments.
> if (rc) {
> -XEN_PT_ERR(d, "Unbinding of MSI%s failed. (err: %d, pirq: %d,
> gvec: %#x)\n",
> - is_msix ? "-X" : "", errno, pirq, gvec);
> +XEN_PT_ERR(d, "Unbinding of MSI%s failed. (err: %d, pirq: %d, "
> + "addr: %"PRIx64", data: %#x)\n",
> + is_msix ? "-X" : "", errno, pirq, addr, data);
> return rc;
> }
> }
Thanks,
--
Anthony PERARD
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
> + * remappable msi.
> + */
> +#define MSI_ADDR_IF_MASK 0x0010
I don't think that is the right place for a define, they also exist
outside of the context of the function.
That define would be better at the top of this file, I think. (There is
probably a better place in the
nge
FYI, I think that is done by <20171103115631.15175-3-owen.sm...@citrix.com>.
([PATCH v5 2/4] xenfb: Use Input Handlers directly)
--
Anthony PERARD
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
ut-keymap.c
> +++ b/ui/input-keymap.c
> @@ -6,6 +6,7 @@
> #include "standard-headers/linux/input.h"
>
> #include "ui/input-keymap-linux-to-qcode.c"
> +#include "ui/input-keymap-qcode-to-linux.c"
> #include "ui/input-keymap-qcode-to-
s still occupied.
>
> Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
--
Anthony PERARD
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
; subsequent patch.
>
> Signed-off-by: Paul Durrant
Reviewed-by: Anthony PERARD
--
Anthony PERARD
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
* Re-write the state to cause a XenBus backend_watch notification,
> + * resulting in a call to xen_bus_cleanup().
> + */
> +xen_device_backend_printf(xendev, "state", "%u", state);
It kind of feels wrong to rely on xenstore to notify QEMU's xenbus
driver that a device needs cleanup. But that does the job.
With a note about the use of QLIST_NEXT and the few typo fixed, the
patch will be good to go.
Thanks,
--
Anthony PERARD
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
after
EBS is called.
In some places (like XenStoreVSPrint), instead of allocating a buffer, the
buffer (4k) is on the stack.
Thanks,
Anthony PERARD (11):
OvmfPkg/XenBusDxe: Fix missing \n in DEBUG messages
OvmfPkg/XenBusDxe: Have XenStoreFindWatch take a pointer
OvmfPkg/XenBusDxe: Re
In order to be able to use XenStoreVSPrint during the
ExitBootServices, we remove the allocation done by the function and
use the stack instead.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2190
Signed-off-by: Anthony PERARD
---
OvmfPkg/XenBusDxe/XenStore.c | 21 +
1
Fix missing \n in DEBUG messages in XenBusDxe and use DEBUG_*.
Signed-off-by: Anthony PERARD
---
OvmfPkg/XenBusDxe/EventChannel.c | 3 ++-
OvmfPkg/XenBusDxe/XenStore.c | 6 +++---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/OvmfPkg/XenBusDxe/EventChannel.c b/OvmfPkg
Rework XenStoreFindWatch() to be able to search for a registered watch
with a pointer instead of a string.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2190
Signed-off-by: Anthony PERARD
---
OvmfPkg/XenBusDxe/XenStore.c | 20 +++-
1 file changed, 11 insertions(+), 9
for every watch events.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2190
Signed-off-by: Anthony PERARD
---
OvmfPkg/XenBusDxe/XenStore.c | 125 ++-
1 file changed, 35 insertions(+), 90 deletions(-)
diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBu
been allocated at the initialisation of the driver.
A temporary memory allocation is made in XenStoreTalkv but that will
be removed in a further patch.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2190
Signed-off-by: Anthony PERARD
---
OvmfPkg/XenBusDxe/XenStore.c
https://bugzilla.tianocore.org/show_bug.cgi?id=2190
Signed-off-by: Anthony PERARD
---
OvmfPkg/Include/Protocol/XenBus.h | 32 --
OvmfPkg/XenBusDxe/XenStore.c | 44 +-
OvmfPkg/XenBusDxe/XenStore.h | 6 +++--
OvmfPkg/XenPvBlkDxe/BlockFront.c
=2190
Signed-off-by: Anthony PERARD
---
OvmfPkg/XenBusDxe/XenBus.c | 40 ++--
OvmfPkg/XenBusDxe/XenStore.c | 115 ---
OvmfPkg/XenBusDxe/XenStore.h | 17 +++---
3 files changed, 95 insertions(+), 77 deletions(-)
diff --git a/OvmfPkg/XenBusDxe/XenBu
are
going to be disconnected. Linux can deal with that. And that will be
fixed by the next patch with a change for XenPvBlkDxe.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2190
Signed-off-by: Anthony PERARD
---
OvmfPkg/Include/Protocol/XenBus.h | 35 +++
OvmfPkg
ied directly to the xenstore shared ring.
Also change WRITE_REQUEST.Len type, it only contain sizes and doesn't
need to be exactly 32bits.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2190
Signed-off-by: Anthony PERARD
---
OvmfPkg/XenBusDxe/XenStore.c | 78 +---
: Anthony PERARD
---
OvmfPkg/XenPvBlkDxe/BlockFront.c | 37 ---
OvmfPkg/XenPvBlkDxe/BlockFront.h | 12 +-
OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.c | 4 ++--
3 files changed, 47 insertions(+), 6 deletions(-)
diff --git a/OvmfPkg/XenPvBlkDxe/BlockFront.c b/OvmfPkg
ately and
let caller of XenStoreWaitForEvent do a busy loop.
Also cleanup error handling in XenStoreWaitForEvent, WaitForEvent
shouldn't return EFI_UNSUPPORTED anymore.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2190
Signed-off-by: Anthony PERARD
---
OvmfPkg/XenBusDxe/XenBus
ontext.
> - change xen_device_state_is_active() to
> xen_device_frontend_is_active() (and pass a XenDevice directly)
> since the state tests contained therein only apply to a frontend.
> - use 'state' rather then 'xendev->backend_state' in
bxl_passthrough = Enumeration("passthrough", [
> +(0, "disabled"),
> +(1, "sync_pt"),
> +(2, "share_pt"),
> +])
> +
> #
> # Complex libxl types
> #
So, with this changes, when libvirt is rebuilt against a newer libx
amp;buf, 0)) {
> +buf = (d_config->num_pcidevs || d_config->num_dtdevs)
> +? "enabled" : "disabled";
> +}
> +
> +if (!strncmp(buf, "enabled", strlen(buf))) {
Do you intend to have "passthrough=''"
On Tue, Sep 17, 2019 at 04:44:30PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH v2 3/9] libxl_internal: Introduce
> libxl__ev_lock for devices hotplug via QMP"):
> > The current lock `domain_userdata_lock' can't be used when modification
> > to
On Tue, Sep 17, 2019 at 05:44:03PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH 11/15] libxl_usb: Fix wrong usage of asserts"):
> > Signed-off-by: Anthony PERARD
>
> I'm not sure why you wouldn't just delete the breaks, rather than
> repl
On Tue, Sep 17, 2019 at 05:50:05PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH 01/35] libxl: Make libxl_domain_unpause
> async"):
> > libxl_domain_unpause needs to make QMP calls, which are asynchronous,
> > change the API to reflect tha
On Tue, Sep 17, 2019 at 06:02:18PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH 08/35] libxl: Replace
> libxl__qmp_initializations by ev_qmp calls"):
> > Setup a timeout of 10s for all the commands. It used to be about 5s
> > per commands.
>
>
On Tue, Sep 17, 2019 at 06:19:14PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH 28/35] libxl_pci: Use ev_qmp in do_pci_add"):
> > This patch also replaces the use of
> > libxl__wait_for_device_model_deprecated() by its equivalent
> > without the need
a default).
>
> Signed-off-by: Paul Durrant
> Reviewed-by: Jan Beulich
> Acked-by: Christian Lindig
> Acked-by: Julien Grall
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On Tue, Sep 17, 2019 at 06:02:18PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH 08/35] libxl: Replace
> libxl__qmp_initializations by ev_qmp calls"):
> > Setup a timeout of 10s for all the commands. It used to be about 5s
> > per commands.
>
>
On Wed, Sep 18, 2019 at 03:23:45PM +0100, Anthony PERARD wrote:
> On Tue, Sep 17, 2019 at 06:19:14PM +0100, Ian Jackson wrote:
> > Anthony PERARD writes ("[PATCH 28/35] libxl_pci: Use ev_qmp in do_pci_add"):
> > > This patch also replaces the use of
> > > li
Replace the assert(0) by abort() since the intention in libxl is that
asserts are always compiled in. This patch makes its clear and removes
the need to deal with asserts been compiled out.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- replace asserts by abort().
tools/libxl
That comment as been separated from the function it defines by
4197d3abbb3055d3798254eb7ba239bfb5824360, but then was not useful
anymore when the libxl__device_disk_add() prototype was removed by
22ea8ad02e465e32cd40887c750b55c3a997a288.
Signed-off-by: Anthony PERARD
Acked-by: Wei Liu
Acked-by
.. and rename them to libxl__qmp_param_*.
This is to allow other files than libxl_qmp.c to make QMP calls with
parameters.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_internal.h | 15
tools/libxl/libxl_qmp.c | 75
e xenstore (mostly because
it's updated as the same time as the userdata).
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
Notes:
v2:
- rewrite patch description
- rework use of the new lock
tools/libxl/libxl_disk.c | 196 +++
1 fi
release CTX_LOCK and try to grab both lock again
in the right order.
That optimisation is only enabled in releases (debug=n) so the more
complicated code with fork is actually exercised.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
Notes:
v2:
- new patch
tools/libxl/Makefile
This is in preparation of cutting libxl_cdrom_insert into several
functions to allow asynchronous callbacks.
No functional changes.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_disk.c | 58 ++--
1 file changed, 32 insertions
t-http/people/aperard/xen-unstable.git
br.libxl-slow-lock-v3
Anthony PERARD (9):
libxl_internal: Remove lost comment
libxl: Pointer on usage of libxl__domain_userdata_lock
libxl_internal: Introduce libxl__ev_devlock for devices hotplug via
QMP
libxl: Add optimisation to ev_lock
Make libxl_cdrom_insert asynchronous when QEMU is involved. And
have the cdrom opened by libxl, sending a file descriptor to QEMU.
The "opaque" parameter of the "add-fd" can help to figure out what a
fdset in QEMU is used for. It can be queried by "query-fdsets".
which can take over part
of the job of the json_lock.
This lock is outside CTX_LOCK in the lock hierarchy.
libxl__ev_devlock_lock will have CTX_UNLOCK before trying to grab the
ev_devlock. The callback is used to notify when the ev_devlock have
been acquired.
Signed-off-by: Anthony PERARD
---
After the patch "libxl_disk: Use ev_qmp in libxl_cdrom_insert"
there will not be any kind of timeout, add one back.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
Notes:
Ian, in this patch, the timeout is setup after we have aquired the lock.
Should we change that to
It is currently difficult to know how/when/why the userdata lock is
supposed to be used. Add some pointers to the hotplug comments.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_internal.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/libxl
On Tue, Sep 17, 2019 at 05:52:24PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH 06/35] libxl: Use ev_qmp for
> switch_qemu_xen_logdirty"):
> > Signed-off-by: Anthony PERARD
> ...
> > +rc = libxl__ev_time
On Thu, Sep 19, 2019 at 02:03:10PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("Re: [PATCH 06/35] libxl: Use ev_qmp for
> switch_qemu_xen_logdirty"):
> > On Tue, Sep 17, 2019 at 05:52:24PM +0100, Ian Jackson wrote:
> > I guess we could try to optimise the sim
On Tue, Sep 17, 2019 at 06:42:10PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH 33/35] libxl: Extract qmp_parse_query_cpus"):
> > The QMP command "query-cpus" is called from different places, extract
> > the algorithm that parse the answer into a
On Tue, Sep 17, 2019 at 06:07:31PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH 17/35] libxl: Add libxl__ev_qmp to
> libxl__ao_device"):
> > `aodev->qmp' is initialised in libxl__prepare_ao_device(), but since
> > there isn't a single exi
On Fri, Jun 14, 2019 at 12:24:29PM +0100, Anthony PERARD wrote:
> Hi,
>
> This series contains cleanup patches, ahead of a series that's going to make
> more changes to libxl.
v2 with patch 11 acked and the whole branch rebased pushed to:
https://xenbits.xen.org/git-http/p
- [PATCH 00/15] Some cleanup of libxl
(its v2)
Cheers,
Anthony PERARD (35):
libxl: Make libxl_domain_unpause async
libxl: Make libxl_send_trigger async
libxl: Make libxl_set_vcpuonline async
libxl: Make libxl_retrieve_domain_configuration async
libxl: Make libxl_qemu_monito
Signed-off-by: Anthony PERARD
---
tools/libxl/libxl_dom_save.c | 41
tools/libxl/libxl_internal.h | 3 +--
tools/libxl/libxl_qmp.c | 10 -
3 files changed, 38 insertions(+), 16 deletions(-)
diff --git a/tools/libxl/libxl_dom_save.c b/tools
#x27;change' command is replaced by 'change-vnc-password'
because 'change' is deprecated. The new command is available in all
QEMU versions that also have Xen support.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_dm.c | 211 +++
.. because it makes QMP calls which are going to be async.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl.h| 13 -
tools/libxl/libxl_domain.c | 12
tools/xl/xl_misc.c | 4 ++--
tools/xl/xl_vmcontrol.c| 4 ++--
4 files
libxl__domain_unpause which will make use of libxl__ev_qmp.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_colo_restore.c | 4 ++--
tools/libxl/libxl_colo_save.c| 4 ++--
tools/libxl/libxl_dm.c | 2 +-
tools/libxl/libxl_dom_suspend.c | 6 +++---
tools/libxl
.. because it makes QMP calls which are going to be async.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl.h | 14 +-
tools/libxl/libxl_qmp.c | 9 +
tools/xl/xl_misc.c | 2 +-
3 files changed, 19 insertions(+), 6 deletions(-)
diff --git
ng to libxl_dm and libxl__dm_spawn_state's
machinery.
We move the call ahead of a follow-up patch which going to "inline"
libxl__qmp_initializations.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_create.c | 10 --
tools/libxl/libxl_dm.c |
.. because it makes QMP calls which are going to be async.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl.h| 15 ++-
tools/libxl/libxl_domain.c | 12
tools/xl/xl_cpupool.c | 2 +-
tools/xl/xl_vcpu.c | 2 +-
4 files
.. because it makes QMP calls which are going to be async.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl.h| 13 -
tools/libxl/libxl_domain.c | 14 +++---
tools/xl/xl_info.c | 3 ++-
tools/xl/xl_saverestore.c | 3 ++-
tools/xl
libxl_domain_unpause needs to make QMP calls, which are asynchronous,
change the API to reflect that.
Do the same with libxl_domain_pause async, even if it will keep
completing synchronously.
Also fix some coding style issue in those functions.
Signed-off-by: Anthony PERARD
Acked-by: Ian
This was the last user of libxl__qmp_query_cpus which can now be
removed.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
Notes:
v3:
- following rename of ev_lock to ev_devlock, renamed field rdcs.ev_lock
to rdcs.devlock
tools/libxl/libxl_domain.c | 163
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_usb.c | 93 ++---
1 file changed, 77 insertions(+), 16 deletions(-)
diff --git a/tools/libxl/libxl_usb.c b/tools/libxl/libxl_usb.c
index de8122dc57e9..506dbdcf5ee4 100644
--- a/tools
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_domain.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/tools/libxl/libxl_domain.c b/tools/libxl/libxl_domain.c
index 52a8bd7895cb..f3c39fa86fc9 100644
--- a/tools/libxl
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_internal.h | 7 +-
tools/libxl/libxl_pci.c | 170 ++-
2 files changed, 150 insertions(+), 27 deletions(-)
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_qmp.c | 52 +++--
1 file changed, 50 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c
index 9639d491d991..9aabad74fabd 100644
--- a/tools
#x27;t be used.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_internal.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 43a431f53565..6c09b93f91f1 100644
--- a/tools/libxl/libx
er QEMU is running or not, no need to check ahead.
Moving the check to do it only with qemu-trad makes upcoming changes
simpler.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_pci.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_domain.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_domain.c b/tools/libxl/libxl_domain.c
index 80797c5ed21c..d78ffa6b6019 100644
--- a/tools/libxl
cpus.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- the patch "libxl: Extract qmp_parse_query_cpus" have been squashed
into this one.
tools/libxl/libxl_domain.c | 204 +++
tools/libxl/libxl_internal.h | 2 -
tools/libxl/libxl_qmp.c
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_usb.c | 97 +
1 file changed, 79 insertions(+), 18 deletions(-)
diff --git a/tools/libxl/libxl_usb.c b/tools/libxl/libxl_usb.c
index 506dbdcf5ee4..373b37d7159a 100644
--- a/tools
7;
in the error message of those calls.
There were an `out' label that was use it seems to skip setting up the
IRQ, the label has been renamed to `out_no_irq'.
No functional changes.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_pci.c | 79 +++
This patch also replaces the use of
libxl__wait_for_device_model_deprecated() by its equivalent
without the need for a thread.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_internal.h | 2 -
tools/libxl/libxl_pci.c | 222
libxl__domain_unpause is a reimplementation of
libxl__domain_unpause_deprecated with asynchronous operation.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_domain.c | 52
tools/libxl/libxl_internal.h | 5 +++-
2 files changed
This also mean libxl__initiate_device_usbctrl_remove, which uses
libxl__device_usbdev_remove synchronously, needs to be updated to use
it with multidev.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_usb.c | 79 +++--
1 file
Functions pci_add_qemu_trad_watch_state_cb and
pci_remove_qemu_trad_watch_state_cb are similar so the common part is
extracted in a different function.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- new patch which attempt to combine the "basically-identical" functions
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_usb.c | 99 +
1 file changed, 81 insertions(+), 18 deletions(-)
diff --git a/tools/libxl/libxl_usb.c b/tools/libxl/libxl_usb.c
index 373b37d7159a..b9a31f96ebe3 100644
--- a/tools
This is in preparation of using asynchronous operation to communicate
with QEMU via QMP (libxl__ev_qmp).
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_domain.c | 49 ++--
tools/libxl/libxl_internal.h | 6 +-
tools/libxl/libxl_pci.c | 221
libxl__domain_unpause and can be used
instead of libxl__domain_resume_device_model_deprecated.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_dom_suspend.c | 192
tools/libxl/libxl_internal.h| 27 +
2 files changed, 219 insertions
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools/libxl/libxl_usb.c | 78 +++--
1 file changed, 68 insertions(+), 10 deletions(-)
diff --git a/tools/libxl/libxl_usb.c b/tools/libxl/libxl_usb.c
index 3b432231ea85..1fc7ccf41f86 100644
--- a/tools
Having the function do_usbdev_add makes it harder to add asynchronous
calls into it. Move its body back into libxl__device_usbdev_add and
adjust the latter as there are no reason to have a separated function.
No functional changes.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
tools
`aodev->qmp' is initialised in libxl__prepare_ao_device(), but since
there isn't a single exit path for a `libxl__ao_device', users of this
new `qmp' field will have to disposed of it.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
---
Notes:
v2:
Having the function do_usbdev_remove makes it harder to add asynchronous
calls into it. Move its body back into libxl__device_usbdev_remove and
adjust the latter as there are no reason to have a separated function.
No functional changes.
Signed-off-by: Anthony PERARD
Acked-by: Ian Jackson
1 - 100 of 3207 matches
Mail list logo
