Re: [PATCH v2 0/2] net: Update MemReentrancyGuard for NIC

2023-06-01 Thread Philippe Mathieu-Daudé
On 1/6/23 05:18, Akihiko Odaki wrote: Recently MemReentrancyGuard was added to DeviceState to record that the device is engaging in I/O. The network device backend needs to update it when delivering a packet to a device. This implementation follows what bottom half does, but it does not add a tr

Re: [PATCH v3 30/34] sh: Convert pte_free_tlb() to use ptdescs

2023-06-01 Thread Geert Uytterhoeven
On Wed, May 31, 2023 at 11:33 PM Vishal Moola (Oracle) wrote: > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. Also cleans up some spacing issues. > > Signed-off-by: Vishal Moola (Oracle) LGTM, so Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH v3 30/34] sh: Convert pte_free_tlb() to use ptdescs

2023-06-01 Thread John Paul Adrian Glaubitz
Hi Geert! On Thu, 2023-06-01 at 09:20 +0200, Geert Uytterhoeven wrote: > On Wed, May 31, 2023 at 11:33 PM Vishal Moola (Oracle) > wrote: > > Part of the conversions to replace pgtable constructor/destructors with > > ptdesc equivalents. Also cleans up some spacing issues. > > > > Signed-off-by:

Re: [PATCH v3 25/34] m68k: Convert various functions to use ptdescs

2023-06-01 Thread Geert Uytterhoeven
Hi Vishal, On Wed, May 31, 2023 at 11:32 PM Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert

Re: [PATCH v2 0/2] net: Update MemReentrancyGuard for NIC

2023-06-01 Thread Akihiko Odaki
On 2023/06/01 16:16, Philippe Mathieu-Daudé wrote: On 1/6/23 05:18, Akihiko Odaki wrote: Recently MemReentrancyGuard was added to DeviceState to record that the device is engaging in I/O. The network device backend needs to update it when delivering a packet to a device. This implementation fol

Re: [PATCH v3 30/34] sh: Convert pte_free_tlb() to use ptdescs

2023-06-01 Thread Geert Uytterhoeven
Hi Adrian, On Thu, Jun 1, 2023 at 9:28 AM John Paul Adrian Glaubitz wrote: > On Thu, 2023-06-01 at 09:20 +0200, Geert Uytterhoeven wrote: > > On Wed, May 31, 2023 at 11:33 PM Vishal Moola (Oracle) > > wrote: > > > Part of the conversions to replace pgtable constructor/destructors with > > > ptde

Re: [PATCH v3 30/34] sh: Convert pte_free_tlb() to use ptdescs

2023-06-01 Thread John Paul Adrian Glaubitz
On Thu, 2023-06-01 at 09:42 +0200, Geert Uytterhoeven wrote: > Hi Adrian, > > On Thu, Jun 1, 2023 at 9:28 AM John Paul Adrian Glaubitz > wrote: > > On Thu, 2023-06-01 at 09:20 +0200, Geert Uytterhoeven wrote: > > > On Wed, May 31, 2023 at 11:33 PM Vishal Moola (Oracle) > > > wrote: > > > > Part

Re: [PATCH v6 5/6] xen/riscv: introduce an implementation of macros from

2023-06-01 Thread Jan Beulich
On 31.05.2023 22:06, Oleksii wrote: > On Tue, 2023-05-30 at 18:00 +0200, Jan Beulich wrote: >>> +static uint32_t read_instr(unsigned long pc) >>> +{ >>> +    uint16_t instr16 = *(uint16_t *)pc; >>> + >>> +    if ( GET_INSN_LENGTH(instr16) == 2 ) >>> +    return (uint32_t)instr16; >>> +    else

[PATCH v1] xentrace: adjust exit code for --help option

2023-06-01 Thread Olaf Hering
Invoking the --help option of any tool should not return with an error, if that tool does indeed have a documented and implemented help option. Adjust the usage() function to exit with either error or success. Handle the existing entry in the option table to call usage accordingly. Adjust the get

[PATCH v1] xenalyze: remove unused defines

2023-06-01 Thread Olaf Hering
These defines are not used by xenalyze. NR_CPUS will not match what was used for building Xen itself. Signed-off-by: Olaf Hering --- tools/xentrace/analyze.h | 13 - 1 file changed, 13 deletions(-) diff --git a/tools/xentrace/analyze.h b/tools/xentrace/analyze.h index 6fefa19639..89

Re: [PATCH v1] xentrace: adjust exit code for --help option

2023-06-01 Thread Jan Beulich
On 01.06.2023 10:08, Olaf Hering wrote: > Invoking the --help option of any tool should not return with an error, > if that tool does indeed have a documented and implemented help option. > > Adjust the usage() function to exit with either error or success. > Handle the existing entry in the optio

Re: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR

2023-06-01 Thread Juergen Gross
On 31.05.23 19:48, Borislav Petkov wrote: On Wed, May 31, 2023 at 04:20:08PM +0200, Juergen Gross wrote: One other note: why does mtrr_cleanup() think that using 8 instead of 6 variable MTRRs would be an "optimal setting"? Maybe the more extensive debug output below would help answer that...

Re: [PATCH v3 25/34] m68k: Convert various functions to use ptdescs

2023-06-01 Thread Vishal Moola
On Thu, Jun 1, 2023 at 12:40 AM Geert Uytterhoeven wrote: > > Hi Vishal, > > On Wed, May 31, 2023 at 11:32 PM Vishal Moola (Oracle) > wrote: > > As part of the conversions to replace pgtable constructor/destructors with > > ptdesc equivalents, convert various page table functions to use ptdescs.

Re: [PATCH v1] xentrace: adjust exit code for --help option

2023-06-01 Thread Olaf Hering
Thu, 1 Jun 2023 10:17:17 +0200 Jan Beulich : > Is this any different from the v1 sent on May 26th? Yeah, this one still has the bogus commit message. I forgot that this patch was already sent earlier. Please ignore this one. Olaf pgpLWnjH0JCfF.pgp Description: Digitale Signatur von OpenPGP

Re: [PATCH v3 30/34] sh: Convert pte_free_tlb() to use ptdescs

2023-06-01 Thread Vishal Moola
On Thu, Jun 1, 2023 at 12:28 AM John Paul Adrian Glaubitz wrote: > > Hi Geert! > > On Thu, 2023-06-01 at 09:20 +0200, Geert Uytterhoeven wrote: > > On Wed, May 31, 2023 at 11:33 PM Vishal Moola (Oracle) > > wrote: > > > Part of the conversions to replace pgtable constructor/destructors with > > >

Re: [PATCH] xen/cpu-policy: Add an IBRS -> AUTO_IBRS dependency

2023-06-01 Thread Jan Beulich
On 31.05.2023 17:30, Andrew Cooper wrote: > AUTO_IBRS is an extention over regular (AMD) IBRS, and needs hiding if IBRS is > levelled out for any reason. > > Fixes: defaf651631a ("x86/hvm: Expose Automatic IBRS to guests") > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

Re: [PATCH v3 0/6] block: add blk_io_plug_call() API

2023-06-01 Thread Kevin Wolf
Am 31.05.2023 um 21:50 hat Stefan Hajnoczi geschrieben: > Hi Kevin, > Do you want to review the thread-local blk_io_plug() patch series or > should I merge it? I haven't reviewed it in detail, but on the high level it looks good to me, and you already got reviews for the details. Acked-by: Kevin

[PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Michal Orzel
There are implementations of the PL011 that can only handle 32-bit accesses (i.e. no 16-bit or 8-bit), usually advertised by 'reg-io-width' dt property set to 4. On such UARTs, the current early printk code for arm64 does not work. To fix this issue, make all the accesses to be 32-bit by using ldr,

Re: [PATCH v2 0/2] net: Update MemReentrancyGuard for NIC

2023-06-01 Thread Philippe Mathieu-Daudé
On 1/6/23 09:41, Akihiko Odaki wrote: On 2023/06/01 16:16, Philippe Mathieu-Daudé wrote: On 1/6/23 05:18, Akihiko Odaki wrote: Recently MemReentrancyGuard was added to DeviceState to record that the device is engaging in I/O. The network device backend needs to update it when delivering a packe

RE: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Henry Wang
Hi Michal, > -Original Message- > Subject: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader > compatibility > > There are implementations of the PL011 that can only handle 32-bit > accesses (i.e. no 16-bit or 8-bit), usually advertised by 'reg-io-width' > dt property set to

Re: [PATCH 1/2] x86/vPIT: re-order functions

2023-06-01 Thread Roger Pau Monné
On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote: > To avoid the need for a forward declaration of pit_load_count() in a > subsequent change, move it earlier in the file (along with its helper > callback). > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Just a couple of

Re: [PATCH 1/2] x86/vPIT: re-order functions

2023-06-01 Thread Jan Beulich
On 01.06.2023 11:17, Roger Pau Monné wrote: > On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote: >> To avoid the need for a forward declaration of pit_load_count() in a >> subsequent change, move it earlier in the file (along with its helper >> callback). >> >> Signed-off-by: Jan Beulich

Re: [PATCH v8 05/12] arm/sve: save/restore SVE context switch

2023-06-01 Thread Bertrand Marquis
Hi Luca, > On 31 May 2023, at 09:24, Luca Fancellu wrote: > > Save/restore context switch for SVE, allocate memory to contain > the Z0-31 registers whose length is maximum 2048 bits each and > FFR who can be maximum 256 bits, the allocated memory depends on > how many bits is the vector length f

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Bertrand Marquis
Hi Michal, > On 1 Jun 2023, at 10:50, Michal Orzel wrote: > > There are implementations of the PL011 that can only handle 32-bit > accesses (i.e. no 16-bit or 8-bit), usually advertised by 'reg-io-width' > dt property set to 4. On such UARTs, the current early printk code for > arm64 does not wo

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Michal Orzel
Hi Bertrand, On 01/06/2023 12:19, Bertrand Marquis wrote: > > > Hi Michal, > >> On 1 Jun 2023, at 10:50, Michal Orzel wrote: >> >> There are implementations of the PL011 that can only handle 32-bit >> accesses (i.e. no 16-bit or 8-bit), usually advertised by 'reg-io-width' >> dt property set t

Re: [PATCH v2 3/3] x86: Add support for AMD's Automatic IBRS

2023-06-01 Thread Jan Beulich
On 30.05.2023 15:58, Alejandro Vallejo wrote: > @@ -1150,15 +1155,20 @@ void __init init_speculation_mitigations(void) > } > else > { > -/* > - * Evaluate the safest Branch Target Injection mitigations to use. > - * First, begin with compiler-aided mitigations

Re: [PATCH v2 3/3] x86: Add support for AMD's Automatic IBRS

2023-06-01 Thread Andrew Cooper
On 01/06/2023 11:35 am, Jan Beulich wrote: > On 30.05.2023 15:58, Alejandro Vallejo wrote: >> @@ -1150,15 +1155,20 @@ void __init init_speculation_mitigations(void) >> } >> else >> { >> -/* >> - * Evaluate the safest Branch Target Injection mitigations to use. >> -

[ovmf test] 181072: all pass - PUSHED

2023-06-01 Thread osstest service owner
flight 181072 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181072/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c1e853769046b322690ad336fdb98966757e7414 baseline version: ovmf 9f12d6b6ecf8ffe9cd4d9

Ping: [PATCH v2 2/2] build: use $(dot-target)

2023-06-01 Thread Jan Beulich
On 08.05.2023 14:58, Jan Beulich wrote: > While slightly longer, I agree with Andrew that using it helps > readability. Where touching them anyway, also wrap some overly long > lines. > > Suggested-by: Andrew Cooper > Signed-off-by: Jan Beulich I didn't expect this was controversial, so - any c

Re: [PATCH] x86/microcode: Prevent attempting updates known to fail

2023-06-01 Thread Andrew Cooper
On 31/05/2023 6:51 pm, Alejandro Vallejo wrote: > diff --git a/xen/arch/x86/cpu/microcode/core.c > b/xen/arch/x86/cpu/microcode/core.c > index cd456c476f..e507945932 100644 > --- a/xen/arch/x86/cpu/microcode/core.c > +++ b/xen/arch/x86/cpu/microcode/core.c > @@ -697,6 +697,17 @@ static long cf_che

Ping: [PATCH v2] x86emul: avoid triggering event related assertions

2023-06-01 Thread Jan Beulich
On 17.04.2023 14:23, Jan Beulich wrote: > The assertion at the end of x86_emulate_wrapper() as well as the ones > in x86_emul_{hw_exception,pagefault}() can trigger if we ignore > X86EMUL_EXCEPTION coming back from certain hook functions. Squash > exceptions when merely probing MSRs, plus on SWAPGS

Re: [PATCH] MAINTAINERS: remove xenstore related files from LIBS

2023-06-01 Thread Jan Beulich
On 22.05.2023 18:00, Juergen Gross wrote: > There is no need to have the Xenstore headers listed in the LIBS > section now that they have been added to the XENSTORE section. > > Suggested-by: Jan Beulich > Signed-off-by: Juergen Gross Anthony, Wei, since this is taking away things from an area

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Julien Grall
Hi, Sorry for the formatting. On Thu, 1 Jun 2023 at 12:31, Michal Orzel wrote: > Hi Bertrand, > > On 01/06/2023 12:19, Bertrand Marquis wrote: > > > > > > Hi Michal, > > > >> On 1 Jun 2023, at 10:50, Michal Orzel wrote: > >> > >> There are implementations of the PL011 that can only handle 32-b

Re: [PATCH v8 0/7] Add pci_dev_for_each_resource() helper and update users

2023-06-01 Thread Jonas Gorski
On Wed, 31 May 2023 at 23:30, Bjorn Helgaas wrote: > > On Wed, May 31, 2023 at 08:48:35PM +0200, Jonas Gorski wrote: > > ... > > > Looking at the code I understand where coverity is coming from: > > > > #define __pci_dev_for_each_res0(dev, res, ...) \ > >for (unsign

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Michal Orzel
Hi Julien, On 01/06/2023 13:12, Julien Grall wrote: > > > > Hi, > > Sorry for the formatting. > > On Thu, 1 Jun 2023 at 12:31, Michal Orzel > wrote: > > Hi Bertrand, > > On 01/06/2023 12:19, Bertrand Marquis wrote: > > > > > > Hi Micha

Re: [PATCH 2/2] x86/vPIT: account for "counter stopped" time

2023-06-01 Thread Roger Pau Monné
On Tue, May 30, 2023 at 05:30:40PM +0200, Jan Beulich wrote: > For an approach like that used in "x86: detect PIT aliasing on ports > other than 0x4[0-3]" [1] to work, channel 2 may not (appear to) continue > counting when "gate" is low. Record the time when "gate" goes low, and > adjust pit_get_{c

Re: [PATCH 1/2] x86/vPIT: re-order functions

2023-06-01 Thread Roger Pau Monné
On Thu, Jun 01, 2023 at 11:56:12AM +0200, Jan Beulich wrote: > On 01.06.2023 11:17, Roger Pau Monné wrote: > > On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote: > >> To avoid the need for a forward declaration of pit_load_count() in a > >> subsequent change, move it earlier in the file (

[xen-unstable test] 181061: regressions - FAIL

2023-06-01 Thread osstest service owner
flight 181061 xen-unstable real [real] flight 181071 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181061/ http://logs.test-lab.xenproject.org/osstest/logs/181071/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: Ping: [PATCH v2 2/2] build: use $(dot-target)

2023-06-01 Thread Bertrand Marquis
Hi Jan, > On 1 Jun 2023, at 12:52, Jan Beulich wrote: > > On 08.05.2023 14:58, Jan Beulich wrote: >> While slightly longer, I agree with Andrew that using it helps >> readability. Where touching them anyway, also wrap some overly long >> lines. >> >> Suggested-by: Andrew Cooper >> Signed-off-b

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Julien Grall
On Thu, 1 Jun 2023 at 13:48, Michal Orzel wrote: > Hi Julien, > > On 01/06/2023 13:12, Julien Grall wrote: > > > > > > > > Hi, > > > > Sorry for the formatting. > > > > On Thu, 1 Jun 2023 at 12:31, Michal Orzel michal.or...@amd.com>> wrote: > > > > Hi Bertrand, > > > > On 01/06/2023 12:1

[xen-unstable-smoke test] 181074: tolerable all pass - PUSHED

2023-06-01 Thread osstest service owner
flight 181074 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181074/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

2023-06-01 Thread Michal Orzel
On 01/06/2023 14:17, Julien Grall wrote: > > > > > > On Thu, 1 Jun 2023 at 13:48, Michal Orzel > wrote: > > Hi Julien, > > On 01/06/2023 13:12, Julien Grall wrote: > >        > > > > > > Hi, > > > > Sorry for the formattin

Re: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR

2023-06-01 Thread Borislav Petkov
On Thu, Jun 01, 2023 at 08:39:17AM +0200, Juergen Gross wrote: > Does this translate to: "we should remove that cleanup crap"? I'd be > positive to that. :-) Why, what's wrong with that thing? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR

2023-06-01 Thread Juergen Gross
On 01.06.23 14:48, Borislav Petkov wrote: On Thu, Jun 01, 2023 at 08:39:17AM +0200, Juergen Gross wrote: Does this translate to: "we should remove that cleanup crap"? I'd be positive to that. :-) Why, what's wrong with that thing? Why do you need it if you don't think adding MTRRs dynamical

Re: [PATCH v3 0/6] block: add blk_io_plug_call() API

2023-06-01 Thread Stefan Hajnoczi
On Tue, May 30, 2023 at 02:09:53PM -0400, Stefan Hajnoczi wrote: > v3 > - Patch 5: Mention why dev_max_batch condition was dropped [Stefano] > v2 > - Patch 1: "is not be freed" -> "is not freed" [Eric] > - Patch 2: Remove unused nvme_process_completion_queue_plugged trace event > [Stefano] > - Pa

[PATCH v3 0/3] x86/gfx: early boot improvements

2023-06-01 Thread Roger Pau Monne
Hello, The following series contains some fixes and improvements related to graphics usage when booting Xen. Proposed patches fix some shortcomings when using multiboot2, like the ignoring of the vga= parameter and forcefully switching the console to the maximum supported resolution. Thanks, Rog

[PATCH v3 1/3] multiboot2: parse vga= option when setting GOP mode

2023-06-01 Thread Roger Pau Monne
Introduce support for passing the command line to the efi_multiboot2() helper, and parse the vga= option if present. Add support for the 'gfx' and 'current' vga options, ignore the 'keep' option, and print a warning message about other options not being currently implemented. Signed-off-by: Roger

[PATCH v3 2/3] multiboot2: do not set StdOut mode unconditionally

2023-06-01 Thread Roger Pau Monne
Only initialize StdOut if the current StdOut mode is unusable. This avoids forcefully switching StdOut to the maximum supported resolution, and thus very likely changing the GOP mode without having first parsed the command line options. Signed-off-by: Roger Pau Monné --- The code is very similar

[PATCH v3 3/3] cmdline: parse multiple instances of the vga option

2023-06-01 Thread Roger Pau Monne
Parse all instances of the vga= option on the command line, in order to always enforce the last selection on the command line. Note that it's not safe to parse just the last occurrence of the vga= option, as then a command line with `vga=current vga=keep` would result in current being ignored. Ad

[ovmf test] 181076: all pass - PUSHED

2023-06-01 Thread osstest service owner
flight 181076 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181076/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1df6658bcbc4cade29a8763808a9804e5d449046 baseline version: ovmf c1e853769046b322690ad

Re: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR

2023-06-01 Thread Juergen Gross
On 31.05.23 19:48, Borislav Petkov wrote: On Wed, May 31, 2023 at 04:20:08PM +0200, Juergen Gross wrote: One other note: why does mtrr_cleanup() think that using 8 instead of 6 variable MTRRs would be an "optimal setting"? Maybe the more extensive debug output below would help answer that...

Re: [PATCH] MAINTAINERS: remove xenstore related files from LIBS

2023-06-01 Thread Anthony PERARD
On Thu, Jun 01, 2023 at 12:57:56PM +0200, Jan Beulich wrote: > On 22.05.2023 18:00, Juergen Gross wrote: > > There is no need to have the Xenstore headers listed in the LIBS > > section now that they have been added to the XENSTORE section. > > > > Suggested-by: Jan Beulich > > Signed-off-by: Jue

Re: [PATCH v3 03/34] s390: Use pt_frag_refcount for pagetables

2023-06-01 Thread Gerald Schaefer
On Wed, 31 May 2023 14:30:01 -0700 "Vishal Moola (Oracle)" wrote: > s390 currently uses _refcount to identify fragmented page tables. > The page table struct already has a member pt_frag_refcount used by > powerpc, so have s390 use that instead of the _refcount field as well. > This improves the

[linux-linus test] 181063: regressions - FAIL

2023-06-01 Thread osstest service owner
flight 181063 linux-linus real [real] flight 181077 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181063/ http://logs.test-lab.xenproject.org/osstest/logs/181077/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

Re: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR

2023-06-01 Thread Borislav Petkov
On Thu, Jun 01, 2023 at 10:19:01AM +0200, Juergen Gross wrote: > Patch 2 wants this diff on top: Obviously. :-) That fixes it, thx. Now lemme restart testing. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH 1/2] x86/vPIT: re-order functions

2023-06-01 Thread Jan Beulich
On 01.06.2023 13:50, Roger Pau Monné wrote: > On Thu, Jun 01, 2023 at 11:56:12AM +0200, Jan Beulich wrote: >> On 01.06.2023 11:17, Roger Pau Monné wrote: >>> On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote: To avoid the need for a forward declaration of pit_load_count() in a s

Re: [PATCH 2/2] x86/vPIT: account for "counter stopped" time

2023-06-01 Thread Jan Beulich
On 01.06.2023 13:48, Roger Pau Monné wrote: > On Tue, May 30, 2023 at 05:30:40PM +0200, Jan Beulich wrote: >> TBD: "gate" can only ever be low for chan2 (with "x86/vPIT: check/bound >> values loaded from state save record" [2] in place), so in >> principle we could get away without a new

Re: [PATCH v3 25/34] m68k: Convert various functions to use ptdescs

2023-06-01 Thread kernel test robot
E_OP-folio-functions/20230601-053454 base: next-20230531 patch link: https://lore.kernel.org/r/20230531213032.25338-26-vishal.moola%40gmail.com patch subject: [PATCH v3 25/34] m68k: Convert various functions to use ptdescs config: m68k-randconfig-r002-20230531 (https://download.01.org/0day-

[libvirt test] 181066: tolerable all pass - PUSHED

2023-06-01 Thread osstest service owner
flight 181066 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/181066/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 181023 test-armhf-armhf-libvirt 16 saveresto

[PATCH v1 0/7] xentrace changes

2023-06-01 Thread Olaf Hering
Olaf Hering (7): xentrace: remove unimplemented option from man page xentrace: use correct output format for pit and rtc xenalyze: sync with vmx.h, use EXIT_REASON_PENDING_VIRT_INTR xenalyze: sync with vmx.h, use EXIT_REASON_VMXOFF xenalyze: sync with vmx.h, use EXIT_REASON_VMXON xenaly

[PATCH v1 2/7] xentrace: use correct output format for pit and rtc

2023-06-01 Thread Olaf Hering
The input values were always 32bit. Fixes 55ee5dea32 ("xentrace: add TRC_HVM_EMUL") Signed-off-by: Olaf Hering --- tools/xentrace/formats | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/xentrace/formats b/tools/xentrace/formats index 0fcc327a40..afb5ee0112 100644 -

[PATCH v1 4/7] xenalyze: sync with vmx.h, use EXIT_REASON_VMXOFF

2023-06-01 Thread Olaf Hering
Signed-off-by: Olaf Hering --- tools/xentrace/xenalyze.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index 1cae055ef4..d2e6c77590 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -466,7 +466

[PATCH v1 3/7] xenalyze: sync with vmx.h, use EXIT_REASON_PENDING_VIRT_INTR

2023-06-01 Thread Olaf Hering
Signed-off-by: Olaf Hering --- tools/xentrace/xenalyze.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index a50538e9a8..1cae055ef4 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -447,7 +4

[PATCH v1 1/7] xentrace: remove unimplemented option from man page

2023-06-01 Thread Olaf Hering
The documented option --usage worked because every unknown option showed the help. Signed-off-by: Olaf Hering --- docs/man/xentrace.8.pod | 4 1 file changed, 4 deletions(-) diff --git a/docs/man/xentrace.8.pod b/docs/man/xentrace.8.pod index 69aef05f65..4c174a84c0 100644 --- a/docs/man/xe

[PATCH v1 7/7] xenalyze: handle more potential exit reason values from vmx.h

2023-06-01 Thread Olaf Hering
Copy and use more constants from vmx.h, to turn numbers into strings. Adjust the REASON_MAX value accordingly. Remove the size constraint from string array, the compiler will grow it as needed. Signed-off-by: Olaf Hering --- tools/xentrace/xenalyze.c | 28 1 file cha

[PATCH v1 6/7] xenalyze: sync with vmx.h, use EXIT_REASON_MCE_DURING_VMENTRY

2023-06-01 Thread Olaf Hering
Signed-off-by: Olaf Hering --- tools/xentrace/xenalyze.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index 88c3d5f873..9635ff453a 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -479,7 +479

[PATCH v1 5/7] xenalyze: sync with vmx.h, use EXIT_REASON_VMXON

2023-06-01 Thread Olaf Hering
Signed-off-by: Olaf Hering --- tools/xentrace/xenalyze.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index d2e6c77590..88c3d5f873 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -467,7 +467

Re: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR

2023-06-01 Thread Borislav Petkov
On Thu, Jun 01, 2023 at 03:22:33PM +0200, Borislav Petkov wrote: > Now lemme restart testing. This is from another box, with the latest changes incorporated: https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=rc1-mtrr --- proc-mtrr.before2011-03-04 01:03:35.243994733 +0100 +++

Re: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR

2023-06-01 Thread Juergen Gross
On 01.06.23 16:33, Borislav Petkov wrote: On Thu, Jun 01, 2023 at 03:22:33PM +0200, Borislav Petkov wrote: Now lemme restart testing. This is from another box, with the latest changes incorporated: https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=rc1-mtrr --- proc-mtrr.before

[PATCH] x86/ucode: Exit early from early_update_cache() if loading not available

2023-06-01 Thread Andrew Cooper
If for any reason early_microcode_init() concludes that no microcode loading is available, early_update_cache() will fall over a NULL function pointer: (XEN) Xen call trace: (XEN)[] R show_code+0x91/0x18f (XEN)[] F show_execution_state+0x2d/0x1fc (XEN)[] F fatal_trap+0x87/0x19a

[PATCH v2 0/3] x86: RSBA and RRSBA handling

2023-06-01 Thread Andrew Cooper
This series deals with the hanlding of the RSBA and RRSBA bits across all parts and all mistakes encountered in various microcode versions. There are substantial changes from v1, following a clarification from Intel. Importantly, CPUs are not expected to enumerate both RSBA and RRSBA, therefore we

[PATCH v2 1/3] x86/spec-ctrl: Rename retpoline_safe() to retpoline_calculations()

2023-06-01 Thread Andrew Cooper
This is prep work, split out to simply the diff on the following change. * Rename to retpoline_calculations(), and call unconditionally. It is shortly going to synthesise missing enumerations required for guest safety. * For the model check switch statement, store the result in a variable an

[PATCH v2 2/3] x86/spec-ctrl: Fix up the RSBA/RRSBA bits as appropriate

2023-06-01 Thread Andrew Cooper
In order to level a VM safely for migration, the toolstack needs to know the RSBA/RRSBA properties of the CPU, whether or not they happen to be enumerated. See the code comment for details. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v2: * Rewrite almost

[PATCH v2 3/3] x86/cpu-policy: Derive RSBA/RRSBA for guest policies

2023-06-01 Thread Andrew Cooper
The RSBA bit, "RSB Alternative", means that the RSB may use alternative predictors when empty. From a practical point of view, this mean "Retpoline not safe". Enhanced IBRS (officially IBRS_ALL in Intel's docs, previously IBRS_ATT) is a statement that IBRS is implemented in hardware (as opposed t

Re: [PATCH] x86/ucode: Exit early from early_update_cache() if loading not available

2023-06-01 Thread Jan Beulich
On 01.06.2023 16:38, Andrew Cooper wrote: > If for any reason early_microcode_init() concludes that no microcode loading > is available, early_update_cache() will fall over a NULL function pointer: > > (XEN) Xen call trace: > (XEN)[] R show_code+0x91/0x18f > (XEN)[] F show_execution_

[PULL 0/8] Block patches

2023-06-01 Thread Stefan Hajnoczi
The following changes since commit c6a5fc2ac76c5ab709896ee1b0edd33685a67ed1: decodetree: Add --output-null for meson testing (2023-05-31 19:56:42 -0700) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 98b126

[PULL 4/8] block/io_uring: convert to blk_io_plug_call() API

2023-06-01 Thread Stefan Hajnoczi
Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Reviewed-by: Stefano Garzarella Acked-by: Kevin Wolf Message-id: 20230530180959.1

[PULL 3/8] block/blkio: convert to blk_io_plug_call() API

2023-06-01 Thread Stefan Hajnoczi
Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Reviewed-by: Stefano Garzarella Acked-by: Kevin Wolf Message-id: 20230530180959.1

[PULL 7/8] block/blkio: use qemu_open() to support fd passing for virtio-blk

2023-06-01 Thread Stefan Hajnoczi
From: Stefano Garzarella Some virtio-blk drivers (e.g. virtio-blk-vhost-vdpa) supports the fd passing. Let's expose this to the user, so the management layer can pass the file descriptor of an already opened path. If the libblkio virtio-blk driver supports fd passing, let's always use qemu_open(

[PULL 2/8] block/nvme: convert to blk_io_plug_call() API

2023-06-01 Thread Stefan Hajnoczi
Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Reviewed-by: Stefano Garzarella Acked-by: Kevin Wolf Message-id: 20230530180959.1

[PULL 6/8] block: remove bdrv_co_io_plug() API

2023-06-01 Thread Stefan Hajnoczi
No block driver implements .bdrv_co_io_plug() anymore. Get rid of the function pointers. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Reviewed-by: Stefano Garzarella Acked-by: Kevin Wolf Message-id: 20230530180959.1108766-7-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- inc

[PULL 5/8] block/linux-aio: convert to blk_io_plug_call() API

2023-06-01 Thread Stefan Hajnoczi
Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Note that a dev_max_batch check is dropped in laio_io_unplug() because the semantics of unplug_fn() are different from .bdrv_co_unplug(): 1.

[PULL 8/8] qapi: add '@fdset' feature for BlockdevOptionsVirtioBlkVhostVdpa

2023-06-01 Thread Stefan Hajnoczi
From: Stefano Garzarella The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the fd passing through the new 'fd' property. Since now we are using qemu_open() on '@path' if the virtio-blk driver supports the fd passing, let's announce it. In this way, the management layer can pass the fil

[PULL 1/8] block: add blk_io_plug_call() API

2023-06-01 Thread Stefan Hajnoczi
Introduce a new API for thread-local blk_io_plug() that does not traverse the block graph. The goal is to make blk_io_plug() multi-queue friendly. Instead of having block drivers track whether or not we're in a plugged section, provide an API that allows them to defer a function call until we're u

Re: [linux-linus test] 181063: regressions - FAIL

2023-06-01 Thread Roger Pau Monné
On Thu, Jun 01, 2023 at 01:20:26PM +, osstest service owner wrote: > flight 181063 linux-linus real [real] > flight 181077 linux-linus real-retest [real] > http://logs.test-lab.xenproject.org/osstest/logs/181063/ > http://logs.test-lab.xenproject.org/osstest/logs/181077/ > > Regressions :-( >

Re: [PATCH v8 0/7] Add pci_dev_for_each_resource() helper and update users

2023-06-01 Thread Andy Shevchenko
On Wed, May 31, 2023 at 08:48:35PM +0200, Jonas Gorski wrote: > On Tue, 30 May 2023 at 23:34, Bjorn Helgaas wrote: > > On Fri, May 12, 2023 at 02:48:51PM -0500, Bjorn Helgaas wrote: > > > On Fri, May 12, 2023 at 01:56:29PM +0300, Andy Shevchenko wrote: > > > > On Tue, May 09, 2023 at 01:21:22PM -0

Re: [PATCH v8 0/7] Add pci_dev_for_each_resource() helper and update users

2023-06-01 Thread Andy Shevchenko
On Thu, Jun 01, 2023 at 07:25:46PM +0300, Andy Shevchenko wrote: > On Wed, May 31, 2023 at 08:48:35PM +0200, Jonas Gorski wrote: > > On Tue, 30 May 2023 at 23:34, Bjorn Helgaas wrote: > > > On Fri, May 12, 2023 at 02:48:51PM -0500, Bjorn Helgaas wrote: ... > > > Where are we at? Are we going to

Re: [PATCH] x86/ucode: Exit early from early_update_cache() if loading not available

2023-06-01 Thread Alejandro Vallejo
On Thu, Jun 01, 2023 at 03:38:13PM +0100, Andrew Cooper wrote: > If for any reason early_microcode_init() concludes that no microcode loading > is available, early_update_cache() will fall over a NULL function pointer: > > (XEN) Xen call trace: > (XEN)[] R show_code+0x91/0x18f > (XEN)

[ovmf test] 181081: all pass - PUSHED

2023-06-01 Thread osstest service owner
flight 181081 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181081/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 15f83fa36442eaa272300b31699b3b82ce7e07a9 baseline version: ovmf 1df6658bcbc4cade29a87

Re: [PATCH v2] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

2023-06-01 Thread Dave Hansen
On 5/30/23 08:01, Ross Lagerwall wrote: > Since firmware doesn't indicate the iBFT in the E820, add a reserved > region so that it gets identity mapped when running as Dom 0 so that it > is possible to search for it. Move the call to reserve_ibft_region() > later so that it is called after the Xen

Re: [PATCH v2] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

2023-06-01 Thread Dave Hansen
On 6/1/23 09:57, Dave Hansen wrote: > On 5/30/23 08:01, Ross Lagerwall wrote: >> Since firmware doesn't indicate the iBFT in the E820, add a reserved >> region so that it gets identity mapped when running as Dom 0 so that it >> is possible to search for it. Move the call to reserve_ibft_region() >>

[PATCH] x86: Add Kconfig option to require NX bit support

2023-06-01 Thread Alejandro Vallejo
This allows replacing many instances of runtime checks with folded constants. The patch asserts support for the NX bit in PTEs at boot time and if so short-circuits cpu_has_nx to 1. This has several knock-on effects that improve codegen: * _PAGE_NX matches _PAGE_NX_BIT, optimising the macro to a

Re: [PATCH v2] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

2023-06-01 Thread Andrew Cooper
On 01/06/2023 6:08 pm, Dave Hansen wrote: > On 6/1/23 09:57, Dave Hansen wrote: >> On 5/30/23 08:01, Ross Lagerwall wrote: >>> Since firmware doesn't indicate the iBFT in the E820, add a reserved >>> region so that it gets identity mapped when running as Dom 0 so that it >>> is possible to search f

[qemu-mainline test] 181068: regressions - FAIL

2023-06-01 Thread osstest service owner
flight 181068 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181068/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 180691 test-amd64-amd64-

[ovmf test] 181087: all pass - PUSHED

2023-06-01 Thread osstest service owner
flight 181087 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181087/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ded1d5414b5a0161de8fcf234b7fb200fb59fb2c baseline version: ovmf 15f83fa36442eaa272300

Re: [PATCH v6 5/6] xen/riscv: introduce an implementation of macros from

2023-06-01 Thread Oleksii
On Thu, 2023-06-01 at 09:59 +0200, Jan Beulich wrote: > On 31.05.2023 22:06, Oleksii wrote: > > On Tue, 2023-05-30 at 18:00 +0200, Jan Beulich wrote: > > > > +static uint32_t read_instr(unsigned long pc) > > > > +{ > > > > +    uint16_t instr16 = *(uint16_t *)pc; > > > > + > > > > +    if ( GET_INS

Re: [PATCH v3 03/34] s390: Use pt_frag_refcount for pagetables

2023-06-01 Thread Vishal Moola
On Thu, Jun 1, 2023 at 6:19 AM Gerald Schaefer wrote: > > On Wed, 31 May 2023 14:30:01 -0700 > "Vishal Moola (Oracle)" wrote: > > > s390 currently uses _refcount to identify fragmented page tables. > > The page table struct already has a member pt_frag_refcount used by > > powerpc, so have s390

[PATCH 0/2] xen/blkback: support delete-on-close block devices

2023-06-01 Thread Demi Marie Obenour
These two patches allow userspace to provide an expected diskseq of a block device and discover when blkback has opened the device. Together, these features allow using blkback with delete-on-close block devices, such as loop devices with autoclear set. Demi Marie Obenour (2): xen-blkback: Impl

[xen-unstable test] 181079: tolerable FAIL - PUSHED

2023-06-01 Thread osstest service owner
flight 181079 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/181079/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail in 181061 pass in 181079 test-amd64-amd64-pair

[PATCH 1/2] xen-blkback: Implement diskseq checks

2023-06-01 Thread Demi Marie Obenour
This allows specifying a disk sequence number in XenStore. If it does not match the disk sequence number of the underlying device, the device will not be exported and a warning will be logged. Userspace can use this to eliminate race conditions due to major/minor number reuse. Old kernels do not

  1   2   >