On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote:
> To avoid the need for a forward declaration of pit_load_count() in a
> subsequent change, move it earlier in the file (along with its helper
> callback).
>
> Signed-off-by: Jan Beulich <jbeul...@suse.com>
Reviewed-by: Roger Pau Monné <roger....@citrix.com>
Just a couple of nits, which you might also noticed but decided to not
fix given this is just code movement.
>
> --- a/xen/arch/x86/emul-i8254.c
> +++ b/xen/arch/x86/emul-i8254.c
> @@ -87,6 +87,57 @@ static int pit_get_count(PITState *pit,
> return counter;
> }
>
> +static void cf_check pit_time_fired(struct vcpu *v, void *priv)
Seems like v could be constified?
> +{
> + uint64_t *count_load_time = priv;
> + TRACE_0D(TRC_HVM_EMUL_PIT_TIMER_CB);
> + *count_load_time = get_guest_time(v);
> +}
> +
> +static void pit_load_count(PITState *pit, int channel, int val)
> +{
> + u32 period;
uint32_t
Thanks, Roger.
