On 01/06/2023 6:08 pm, Dave Hansen wrote: > On 6/1/23 09:57, Dave Hansen wrote: >> On 5/30/23 08:01, Ross Lagerwall wrote: >>> Since firmware doesn't indicate the iBFT in the E820, add a reserved >>> region so that it gets identity mapped when running as Dom 0 so that it >>> is possible to search for it. Move the call to reserve_ibft_region() >>> later so that it is called after the Xen identity mapping adjustments >>> are applied. > Oh, and one more thing: > > What is the end user visible effect of this problem and of your solution? > > Do Xen Dom 0 systems fail to find their boot iSCSI volume and refuse to > boot? I take it after this patch that they can boot again. >
Yeah, this isn't as clear as it could be. In short... The iBFT suffers from the same problem as legacy ACPI RDSP. You've got to search lowmem for a magic marker to find it. Xen dom0 is just a VM with root-like perms. Anything it wants an identity map of, it has to ask for. And because dom0 is commonly sharing ownership of hardware, it requests identity mappings for everything reserved in the E820 table. The consequence of not having this patch is that if you try iSCSI boot under Xen, dom0 can't find it's filesystem, because it can't get at the iSCSI initiator. ~Andrew
