Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU

2023-01-03 Thread Ayan Kumar Halder
Hi Michal, On 02/01/2023 14:49, Michal Orzel wrote: Printing domain's memory size in hex without even prepending it with 0x is not very useful and can be misleading. Switch to decimal notation. Signed-off-by: Michal Orzel --- xen/arch/arm/domain_build.c | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU

2023-01-03 Thread Michal Orzel
Hi Ayan, On 03/01/2023 10:21, Ayan Kumar Halder wrote: > > > Hi Michal, > > On 02/01/2023 14:49, Michal Orzel wrote: >> Printing domain's memory size in hex without even prepending it >> with 0x is not very useful and can be misleading. Switch to decimal >> notation. >> >> Signed-off-by: Michal

Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU

2023-01-03 Thread Julien Grall
Hi Ayan, On 03/01/2023 09:21, Ayan Kumar Halder wrote: On 02/01/2023 14:49, Michal Orzel wrote: Printing domain's memory size in hex without even prepending it with 0x is not very useful and can be misleading. Switch to decimal notation. Signed-off-by: Michal Orzel ---   xen/arch/arm/domain_b

Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU

2023-01-03 Thread Julien Grall
Hi Michal, On 03/01/2023 09:39, Michal Orzel wrote: On 03/01/2023 10:21, Ayan Kumar Halder wrote: Hi Michal, On 02/01/2023 14:49, Michal Orzel wrote: Printing domain's memory size in hex without even prepending it with 0x is not very useful and can be misleading. Switch to decimal notation.

Re: [PATCH] xen/arm: Print memory size in decimal in construct_domU

2023-01-03 Thread Michal Orzel
Hi Julien, On 03/01/2023 10:56, Julien Grall wrote: > > > Hi Michal, > > On 03/01/2023 09:39, Michal Orzel wrote: >> On 03/01/2023 10:21, Ayan Kumar Halder wrote: >>> >>> >>> Hi Michal, >>> >>> On 02/01/2023 14:49, Michal Orzel wrote: Printing domain's memory size in hex without even prepe

[PATCH v2] xen/arm: Add 0x prefix when printing memory size in construct_domU

2023-01-03 Thread Michal Orzel
Printing memory size in hex without 0x prefix can be misleading, so add it. Also, take the opportunity to adhere to 80 chars line length limit by moving the printk arguments to the next line. Signed-off-by: Michal Orzel --- Changes in v2: - was: "Print memory size in decimal in construct_domU"

[xen-unstable test] 175554: FAIL

2023-01-03 Thread osstest service owner
flight 175554 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/175554/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair broken in 175548 Tests whi

[ovmf test] 175558: all pass - PUSHED

2023-01-03 Thread osstest service owner
flight 175558 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175558/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b670700ddf5eb1dd958d60eb4f2a51e0636206f9 baseline version: ovmf bbd30066e137c036db140

Re: [PATCH 1/2] x86/cpuid: Infrastructure for leaves 7:1{ecx,edx}

2023-01-03 Thread Andrew Cooper
On 01/01/2023 3:00 pm, Marek Marczykowski-Górecki wrote: > On Sat, Dec 31, 2022 at 12:30:06AM +, Andrew Cooper wrote: >> diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c >> index d5833e9ce879..0091a11a67bc 100644 >> --- a/tools/misc/xen-cpuid.c >> +++ b/tools/misc/xen-cpuid.c >> @@

Re: [PATCH 2/2] x86/shskt: Disable CET-SS on parts succeptable to fractured updates

2023-01-03 Thread Andrew Cooper
On 01/01/2023 3:10 pm, Marek Marczykowski-Górecki wrote: > On Sat, Dec 31, 2022 at 12:30:07AM +, Andrew Cooper wrote: >> diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c >> index b3fcf4680f3a..d962f384a995 100644 >> --- a/xen/arch/x86/cpu/common.c >> +++ b/xen/arch/x86/cpu/com

[libvirt test] 175555: tolerable all pass - PUSHED

2023-01-03 Thread osstest service owner
flight 17 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/17/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 175482 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [PATCH v2] xen/arm: Add 0x prefix when printing memory size in construct_domU

2023-01-03 Thread Ayan Kumar Halder
On 03/01/2023 10:25, Michal Orzel wrote: Printing memory size in hex without 0x prefix can be misleading, so add it. Also, take the opportunity to adhere to 80 chars line length limit by moving the printk arguments to the next line. Signed-off-by: Michal Orzel Reviewed-by: Ayan Kumar Halder

Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2023-01-03 Thread Bertrand Marquis
Hi, Sorry for the delay but I have very limited access to my mails right now. On 9 Dec 2022, at 23:11, Stefano Stabellini mailto:sstabell...@kernel.org>> wrote: On Fri, 9 Dec 2022, Julien Grall wrote: Hi Henry, On 08/12/2022 03:06, Henry Wang wrote: I am trying to work on the follow-up improve

[PATCH v3] drivers/xen/hypervisor: Expose Xen SIF flags to userspace

2023-01-03 Thread Per Bilse
/proc/xen is a legacy pseudo filesystem which predates Xen support getting merged into Linux. It has largely been replaced with more normal locations for data (/sys/hypervisor/ for info, /dev/xen/ for user devices). We want to compile xenfs support out of the dom0 kernel. There is one item which

Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE

2023-01-03 Thread Philippe Mathieu-Daudé
Hi Chuck, On 3/1/23 04:15, Chuck Zmudzinski wrote: On 1/2/23 4:34 PM, Bernhard Beschow wrote: This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finally removes it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make Xen in the PC machine agnostic to the precise southbridge

Re: [PATCH 5/6] hw/isa/piix: Resolve redundant k->config_write assignments

2023-01-03 Thread Philippe Mathieu-Daudé
On 2/1/23 22:35, Bernhard Beschow wrote: The previous patch unified handling of piix_write_config() accross all PIIX device models which allows for assigning k->config_write once in the base class. Signed-off-by: Bernhard Beschow --- hw/isa/piix.c | 4 +--- 1 file changed, 1 insertion(+), 3

Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE

2023-01-03 Thread Bernhard Beschow
On Tue, Jan 3, 2023 at 2:17 PM Philippe Mathieu-Daudé wrote: > Hi Chuck, > > On 3/1/23 04:15, Chuck Zmudzinski wrote: > > On 1/2/23 4:34 PM, Bernhard Beschow wrote: > >> This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finally > removes > >> it. The motivation is to 1/ decouple PIIX

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-03 Thread Alex Williamson
On Mon, 2 Jan 2023 18:10:24 -0500 Chuck Zmudzinski wrote: > On 1/2/23 12:46 PM, Michael S. Tsirkin wrote: > > On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > > as noted in docs/igd-assign.txt in th

Re: [RFC PATCH 21/21] xen/arm: vIOMMU: Modify the partial device tree for dom0less

2023-01-03 Thread Stewart Hildebrand
On 12/1/22 11:02, Rahul Singh wrote: > To configure IOMMU in guest for passthrough devices, user will need to > copy the unmodified "iommus" property from host device tree to partial > device tree. To enable the dom0 linux kernel to confiure the IOMMU > correctly replace the phandle in partial devi

Re: [RFC PATCH 11/21] xen/arm: vsmmuv3: Attach Stage-1 configuration to SMMUv3 hardware

2023-01-03 Thread Stewart Hildebrand
On 12/1/22 11:02, Rahul Singh wrote: > Attach the Stage-1 configuration to device STE to support nested > translation for the guests. > > Signed-off-by: Rahul Singh > --- > xen/drivers/passthrough/arm/smmu-v3.c | 79 ++ > xen/drivers/passthrough/arm/smmu-v3.h | 1 + >

[linux-linus test] 175556: regressions - FAIL

2023-01-03 Thread osstest service owner
flight 175556 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175556/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-li

[linux-5.4 test] 175557: FAIL

2023-01-03 Thread osstest service owner
flight 175557 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/175557/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 broken in 175547 Tests which

Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE

2023-01-03 Thread Chuck Zmudzinski
On 1/3/2023 8:38 AM, Bernhard Beschow wrote: > > > On Tue, Jan 3, 2023 at 2:17 PM Philippe Mathieu-Daudé > wrote: > > Hi Chuck, > > On 3/1/23 04:15, Chuck Zmudzinski wrote: > > On 1/2/23 4:34 PM, Bernhard Beschow wrote: > >> This series first renders TYPE_PIIX3_XEN_DEVICE redundan

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-03 Thread Chuck Zmudzinski
On 1/2/2023 12:46 PM, Michael S. Tsirkin wrote: > On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > as noted in docs/igd-assign.txt in the Qemu source code. > > > > Currently, when the xl toolstack is use

[PATCH 3/4] xen/version: Drop bogus return values for XENVER_platform_parameters

2023-01-03 Thread Andrew Cooper
A split in virtual address space is only applicable for x86 PV guests. Furthermore, the information returned for x86 64bit PV guests is wrong. Explain the problem in version.h, stating the other information that PV guests need to know. For 64bit PV guests, and all non-x86-PV guests, return 0, whi

[PATCH 2/4] xen/version: Drop compat/kernel.c

2023-01-03 Thread Andrew Cooper
kernel.c is mostly in an #ifndef COMPAT guard, because compat/kernel.c reincludes kernel.c to recompile xen_version() in a compat form. However, the xen_version hypercall is almost guest-ABI-agnostic; only XENVER_platform_parameters has a compat split. Handle this locally, and do away with the re

[PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops

2023-01-03 Thread Andrew Cooper
Recently in XenServer, we have encountered problems caused by both XENVER_extraversion and XENVER_commandline having fixed bounds. More than just the invariant size, the APIs/ABIs also broken by typedef-ing an array, and using an unqualified 'char' which has implementation-specific signed-ness. P

[PATCH 1/4] public/version: Change xen_feature_info to have a fixed size

2023-01-03 Thread Andrew Cooper
This is technically an ABI change, but Xen doesn't operate in any environment where "unsigned int" is differnet to uint32_t, so switch to the explicit form. This avoids the need to derive (identical) compat logic for handling the subop. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan

[PATCH 0/4] Fix truncation of various XENVER_* subops

2023-01-03 Thread Andrew Cooper
See patch 4 for details of the problem. Other patches fix other errors found while investigating. This is only the hypervisor side of the change for now, because I want agreement before starting to untangle the mess which is libxc's helpers for this. Also a disaster is Linux's sysfs handling for

Re: [PATCH v2 0/2] x86: Check return values for early memory/IO remap calls

2023-01-03 Thread Ross Philipson
On 11/10/22 10:45, Ross Philipson wrote: While sending an earlier patch set it was discovered that there are a number of places in early x86 code were the functions early_memremap() and early_ioremap() are called but the returned pointer is not checked for NULL. Since NULL can be returned for a c

Re: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops

2023-01-03 Thread Julien Grall
Hi Andrew, On 03/01/2023 20:09, Andrew Cooper wrote: diff --git a/xen/include/public/version.h b/xen/include/public/version.h index c8325219f648..cf2d2ef38b54 100644 --- a/xen/include/public/version.h +++ b/xen/include/public/version.h @@ -19,12 +19,20 @@ /* arg == NULL; returns major:minor (1

Re: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops

2023-01-03 Thread Andrew Cooper
On 03/01/2023 8:47 pm, Julien Grall wrote: > Hi Andrew, > > On 03/01/2023 20:09, Andrew Cooper wrote: >> diff --git a/xen/include/public/version.h b/xen/include/public/version.h >> index c8325219f648..cf2d2ef38b54 100644 >> --- a/xen/include/public/version.h >> +++ b/xen/include/public/version.h >>

Re: [PATCH 4/4] xen/version: Introduce non-truncating XENVER_* subops

2023-01-03 Thread Julien Grall
On 03/01/2023 21:22, Andrew Cooper wrote: On 03/01/2023 8:47 pm, Julien Grall wrote: On 03/01/2023 20:09, Andrew Cooper wrote: diff --git a/xen/include/public/version.h b/xen/include/public/version.h index c8325219f648..cf2d2ef38b54 100644 --- a/xen/include/public/version.h +++ b/xen/include

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-03 Thread Chuck Zmudzinski
On 1/3/2023 10:14 AM, Alex Williamson wrote: > On Mon, 2 Jan 2023 18:10:24 -0500 > Chuck Zmudzinski wrote: > > > On 1/2/23 12:46 PM, Michael S. Tsirkin wrote: > > > On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > > > > Intel specifies that the Intel IGD must occupy slot 2 on

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-03 Thread Chuck Zmudzinski
On 1/3/2023 4:50 PM, Chuck Zmudzinski wrote: > On 1/3/2023 10:14 AM, Alex Williamson wrote: > > On Mon, 2 Jan 2023 18:10:24 -0500 > > Chuck Zmudzinski wrote: > > > > > On 1/2/23 12:46 PM, Michael S. Tsirkin wrote: > > > > On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > > > >

Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE

2023-01-03 Thread Bernhard Beschow
Am 3. Januar 2023 17:25:35 UTC schrieb Chuck Zmudzinski : >On 1/3/2023 8:38 AM, Bernhard Beschow wrote: >> >> >> On Tue, Jan 3, 2023 at 2:17 PM Philippe Mathieu-Daudé >> wrote: >> >> Hi Chuck, >> >> On 3/1/23 04:15, Chuck Zmudzinski wrote: >> > On 1/2/23 4:34 PM, Bernhard Beschow w

[linux-linus test] 175559: regressions - FAIL

2023-01-03 Thread osstest service owner
flight 175559 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175559/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-li

Re: [PATCH 1/6] CI: Drop automation/configs/

2023-01-03 Thread Stefano Stabellini
On Fri, 30 Dec 2022, Andrew Cooper wrote: > Having 3 extra hypervisor builds on the end of a full build is deeply > confusing to debug if one of them fails, because the .config file presented in > the artefacts is not the one which caused a build failure. Also, the log > tends to be truncated in t

Re: [PATCH 2/6] CI: Remove guesswork about which artefacts to preserve

2023-01-03 Thread Stefano Stabellini
On Fri, 30 Dec 2022, Andrew Cooper wrote: > Preserve the artefacts based on the `make` rune we actually ran, rather than > guesswork about which rune we would have run based on other settings. > > Note that the ARM qemu smoke tests depend on finding binaries/xen even from > full builds. Also that

Re: [PATCH 3/6] CI: Only calculate ./configure args if needed

2023-01-03 Thread Stefano Stabellini
On Fri, 30 Dec 2022, Andrew Cooper wrote: > This is purely code motion of the cfgargs construction, into the case where it > is used. > > No practical change. > > Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini > --- > CC: Doug Goldstein > CC: Stefano Stabellini > CC: Anthony

Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml

2023-01-03 Thread Stefano Stabellini
On Fri, 30 Dec 2022, Andrew Cooper wrote: > Whether to build only Xen, or everything, is a property of container, > toolchain and/or testcase. It is not a property of XEN_TARGET_ARCH. > > Capitalise HYPERVISOR_ONLY and have it set by the debian-unstable-gcc-arm32-* > testcases at the point tha

[linux-5.4 test] 175560: tolerable FAIL - PUSHED

2023-01-03 Thread osstest service owner
flight 175560 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/175560/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 175557 pass in 175560 test-amd64-amd64

Re: [PATCH 2/6] CI: Remove guesswork about which artefacts to preserve

2023-01-03 Thread Andrew Cooper
On 04/01/2023 1:10 am, Stefano Stabellini wrote: > On Fri, 30 Dec 2022, Andrew Cooper wrote: >> Preserve the artefacts based on the `make` rune we actually ran, rather than >> guesswork about which rune we would have run based on other settings. >> >> Note that the ARM qemu smoke tests depend on fi

Re: [PATCH 5/6] CI: Fix build script when CROSS_COMPILE is in use

2023-01-03 Thread Stefano Stabellini
On Fri, 30 Dec 2022, Andrew Cooper wrote: > Some testcases use a cross compiler. Presently it's only arm32 and due to > previous cleanup the only thing which is now wrong is printing the compiler > version at the start of day. > > Construct $cc to match what `make` will eventually choose given CR

Re: [PATCH 6/6] CI: Simplify the MUSL check

2023-01-03 Thread Stefano Stabellini
On Fri, 30 Dec 2022, Andrew Cooper wrote: > There's no need to do ad-hoc string parsing. Use grep -q instead. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini > --- > CC: Doug Goldstein > CC: Stefano Stabellini > CC: Anthony PERARD > CC: Michal O

Re: [PATCH 2/6] CI: Remove guesswork about which artefacts to preserve

2023-01-03 Thread Stefano Stabellini
On Wed, 4 Jan 2023, Andrew Cooper wrote: > On 04/01/2023 1:10 am, Stefano Stabellini wrote: > > On Fri, 30 Dec 2022, Andrew Cooper wrote: > >> Preserve the artefacts based on the `make` rune we actually ran, rather > >> than > >> guesswork about which rune we would have run based on other settings

Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml

2023-01-03 Thread Andrew Cooper
On 04/01/2023 1:15 am, Stefano Stabellini wrote: > On Fri, 30 Dec 2022, Andrew Cooper wrote: > >> Whether to build only Xen, or everything, is a property of container, >> toolchain and/or testcase. It is not a property of XEN_TARGET_ARCH. >> >> Capitalise HYPERVISOR_ONLY and have it set by the deb

Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml

2023-01-03 Thread Stefano Stabellini
On Wed, 4 Jan 2023, Andrew Cooper wrote: > On 04/01/2023 1:15 am, Stefano Stabellini wrote: > > On Fri, 30 Dec 2022, Andrew Cooper wrote: > > > >> Whether to build only Xen, or everything, is a property of container, > >> toolchain and/or testcase. It is not a property of XEN_TARGET_ARCH. > >> > >

Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml

2023-01-03 Thread Andrew Cooper
On 04/01/2023 1:36 am, Stefano Stabellini wrote: > On Wed, 4 Jan 2023, Andrew Cooper wrote: >> On 04/01/2023 1:15 am, Stefano Stabellini wrote: >>> On Fri, 30 Dec 2022, Andrew Cooper wrote: >>> Whether to build only Xen, or everything, is a property of container, toolchain and/or testcase

Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml

2023-01-03 Thread Stefano Stabellini
On Wed, 4 Jan 2023, Andrew Cooper wrote: > On 04/01/2023 1:36 am, Stefano Stabellini wrote: > > On Wed, 4 Jan 2023, Andrew Cooper wrote: > >> On 04/01/2023 1:15 am, Stefano Stabellini wrote: > >>> On Fri, 30 Dec 2022, Andrew Cooper wrote: > >>> > Whether to build only Xen, or everything, is a

Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml

2023-01-03 Thread Andrew Cooper
On 04/01/2023 1:48 am, Stefano Stabellini wrote: > On Wed, 4 Jan 2023, Andrew Cooper wrote: >> On 04/01/2023 1:36 am, Stefano Stabellini wrote: >>> On Wed, 4 Jan 2023, Andrew Cooper wrote: On 04/01/2023 1:15 am, Stefano Stabellini wrote: > On Fri, 30 Dec 2022, Andrew Cooper wrote: > >>

Re: [PATCH 4/6] CI: Express HYPERVISOR_ONLY in build.yml

2023-01-03 Thread Stefano Stabellini
On Wed, 4 Jan 2023, Andrew Cooper wrote: > On 04/01/2023 1:48 am, Stefano Stabellini wrote: > > On Wed, 4 Jan 2023, Andrew Cooper wrote: > >> On 04/01/2023 1:36 am, Stefano Stabellini wrote: > >>> On Wed, 4 Jan 2023, Andrew Cooper wrote: > On 04/01/2023 1:15 am, Stefano Stabellini wrote: > >>>

[ovmf test] 175563: all pass - PUSHED

2023-01-03 Thread osstest service owner
flight 175563 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175563/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 89c5d90003d9c54d03d3e85bd305718e9c29a213 baseline version: ovmf b670700ddf5eb1dd958d6