On 01/01/2023 3:10 pm, Marek Marczykowski-Górecki wrote:
> On Sat, Dec 31, 2022 at 12:30:07AM +0000, Andrew Cooper wrote:
>> diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
>> index b3fcf4680f3a..d962f384a995 100644
>> --- a/xen/arch/x86/cpu/common.c
>> +++ b/xen/arch/x86/cpu/common.c
>> @@ -346,11 +346,18 @@ void __init early_cpu_init(void)
>>             x86_cpuid_vendor_to_str(c->x86_vendor), c->x86, c->x86,
>>             c->x86_model, c->x86_model, c->x86_mask, eax);
>>  
>> -    if (c->cpuid_level >= 7)
>> -            cpuid_count(7, 0, &eax, &ebx,
>> +    if (c->cpuid_level >= 7) {
>> +            uint32_t max_subleaf;
>> +
>> +            cpuid_count(7, 0, &max_subleaf, &ebx,
>>                          &c->x86_capability[FEATURESET_7c0],
>>                          &c->x86_capability[FEATURESET_7d0]);
>>  
>> +                if (max_subleaf >= 1)
> tabs vs spaces ...

Fixed.

>
> Is this file imported from Linux? It uses tabs for indentation, contrary
> to the rest of the Xen code base.

It is a file which originally inherits from Linux, but it probably has
~0% in common any more...

~Andrew

Reply via email to