On 04/01/2023 1:15 am, Stefano Stabellini wrote: > On Fri, 30 Dec 2022, Andrew Cooper wrote: > >> Whether to build only Xen, or everything, is a property of container, >> toolchain and/or testcase. It is not a property of XEN_TARGET_ARCH. >> >> Capitalise HYPERVISOR_ONLY and have it set by the debian-unstable-gcc-arm32-* >> testcases at the point that arm32 get matched with a container that can only >> build Xen. >> >> For simplicity, retain the RANDCONFIG -> HYPERVISOR_ONLY implication. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> >> --- >> CC: Doug Goldstein <car...@cardoe.com> >> CC: Stefano Stabellini <sstabell...@kernel.org> >> CC: Anthony PERARD <anthony.per...@citrix.com> >> CC: Michal Orzel <michal.or...@amd.com> >> CC: Oleksii Kurochko <oleksii.kuroc...@gmail.com> >> --- >> automation/gitlab-ci/build.yaml | 2 ++ >> automation/scripts/build | 11 ++++------- >> 2 files changed, 6 insertions(+), 7 deletions(-) >> >> diff --git a/automation/gitlab-ci/build.yaml >> b/automation/gitlab-ci/build.yaml >> index 93d9ff69a9f2..e6a9357de3ef 100644 >> --- a/automation/gitlab-ci/build.yaml >> +++ b/automation/gitlab-ci/build.yaml >> @@ -516,11 +516,13 @@ debian-unstable-gcc-arm32: >> extends: .gcc-arm32-cross-build >> variables: >> CONTAINER: debian:unstable-arm32-gcc >> + HYPERVISOR_ONLY: y >> >> debian-unstable-gcc-arm32-debug: >> extends: .gcc-arm32-cross-build-debug >> variables: >> CONTAINER: debian:unstable-arm32-gcc >> + HYPERVISOR_ONLY: y > can you move the setting of HYPERVISOR_ONLY to .arm32-cross-build-tmpl ?
Not really - that's the point I'm trying to make in the commit message. > I think that makes the most sense because .arm32-cross-build-tmpl is the > one setting XEN_TARGET_ARCH and also the x86_64 tag. It's not about x86_64; its about the container. Whether we can build just Xen, or everything, solely depends on the contents in debian:unstable-arm32-gcc If we wanted to, we could update unstable-arm32-gcc's dockerfile to install the arm32 cross user libs, and drop this HYPERVISOR_ONLY restriction. ~Andrew
