Re: [PATCH v2 1/2] live migration: do not use deffered bitmap when inappropriate

2022-09-07 Thread Jan Beulich
On 06.09.2022 11:54, Andrei Semenov wrote: > Use deffered bitmap only in PV guests context as it not used for HVM guests. > This allow to reduce memory pressure on domain0 while migrating very large > (memory wise) HVM guests. > > Signed-off-by: Andrei Semenov Did you see https://lists.xen.org/a

Re: [PATCH v2 2/2] live migration: use superpages for physmap population on restore when possible

2022-09-07 Thread Jan Beulich
On 06.09.2022 11:54, Andrei Semenov wrote: > Implement an heuristic for X86 HVM guests which tries to use superpages while > populating guest physmap on live migration. This should impove memory accesses > performances for these guests. > > Signed-off-by: Andrei Semenov Olaf - I recall you've do

Re: [PATCH v2 2/2] live migration: use superpages for physmap population on restore when possible

2022-09-07 Thread Olaf Hering
Wed, 7 Sep 2022 09:40:41 +0200 Jan Beulich : > Olaf - I recall you've done some similar work before. Do you have any > thoughts here, perhaps going as far as merging your and Andrei's work? I have no hope that any such work will be merged. My variant is in the archives, for reference. Thanks,

Re: [PATCH v4 00/10] xen/arm: smmuv3: Merge Linux fixes to Xen

2022-09-07 Thread Bertrand Marquis
Hi Julien > On 6 Sep 2022, at 17:49, Julien Grall wrote: > > Hi, > > On 06/09/2022 10:55, Rahul Singh wrote: >> This patch series merge the applicable Linux fixes to Xen. >> Bixuan Cui (1): >> xen/arm: smmuv3: Change *array into *const array >> Christophe JAILLET (1): >> xen/arm: smmuv3: Av

[qemu-mainline test] 173030: regressions - FAIL

2022-09-07 Thread osstest service owner
flight 173030 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/173030/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 172123 test-amd64-i386-f

Re: [PATCH v4 7/7] xen/arm: introduce xen-evtchn dom0less property

2022-09-07 Thread Rahul Singh
Hi Stefano, > On 6 Sep 2022, at 11:22 pm, Stefano Stabellini wrote: > > On Tue, 6 Sep 2022, Rahul Singh wrote: >> Introduce a new sub-node under /chosen node to establish static event >> channel communication between domains on dom0less systems. >> >> An event channel will be created beforehand

Re: [PATCH v4 6/7] xen/arm: introduce new xen,enhanced property value

2022-09-07 Thread Rahul Singh
Hi Stefano, > On 6 Sep 2022, at 11:12 pm, Stefano Stabellini wrote: > > On Tue, 6 Sep 2022, Rahul Singh wrote: >> Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to >> disable xenstore interface for dom0less guests. >> >> Signed-off-by: Rahul Singh >> --- >> Changes in v4:

Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-07 Thread Rahul Singh
Hi Julien, > On 6 Sep 2022, at 10:53 am, Julien Grall wrote: > > > > On 06/09/2022 10:39, Rahul Singh wrote: >> Hi Julien, >>> On 3 Sep 2022, at 8:18 am, Julien Grall wrote: >>> >>> Hi Rahul, >>> >>> On 01/09/2022 10:29, Rahul Singh wrote: is_memory_hole was implemented for x86 and not

Re: [PATCH] xen/arm: acpi: Include header file for version number

2022-09-07 Thread Julien Grall
Hi Leo, On 06/09/2022 12:31, Leo Yan wrote: On Arm64 Linux kernel prints log for Xen version number: [0.00] Xen XEN_VERSION.XEN_SUBVERSION support found Because the header file "xen/compile.h" is missed, XEN_VERSION and XEN_SUBVERSION are not defined, thus compiler directly uses the

Re: [PATCH] xen/arm: acpi: Include header file for version number

2022-09-07 Thread Bertrand Marquis
Hi Julien, > On 7 Sep 2022, at 09:26, Julien Grall wrote: > > Hi Leo, > > On 06/09/2022 12:31, Leo Yan wrote: >> On Arm64 Linux kernel prints log for Xen version number: >> [0.00] Xen XEN_VERSION.XEN_SUBVERSION support found >> Because the header file "xen/compile.h" is missed, XEN_VE

[PATCH v3 1/4] xen/arm: bootfdt: Make process_chosen_node() return int

2022-09-07 Thread Henry Wang
At the boot time, it is saner to stop booting early if an error occurs when parsing the device tree chosen node, rather than seeing random behavior afterwards. Therefore, this commit changes the return type of the process_chosen_node() from void to int, and return correct errno based on the error t

[PATCH v3 0/4] Introduce static heap

2022-09-07 Thread Henry Wang
The static heap, or statically configured heap, refers to parts of RAM reserved in the beginning for heap. Like the static memory allocation, such static heap regions are reserved by configuration in the device tree using physical address ranges. This feature is useful to run Xen on Arm MPU system

[PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Henry Wang
This commit introduces the static heap memory, which is parts of RAM reserved in the beginning of the boot time for heap. Firstly, since a new type of memory bank is needed for marking the memory bank solely as the heap, this commit defines `enum membank_type` and use this enum in function device_

[PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-07 Thread Henry Wang
With the static heap setup, keep using xenheap_* in the function setup_xenheap_mappings() will make the code confusing to read, because we always need to map the full RAM on Arm64. Therefore, renaming all "xenheap_*" variables to "directmap_*" to make clear the area is used to access the RAM easily

[PATCH v3 4/4] xen/arm: Handle static heap pages in boot and heap allocator

2022-09-07 Thread Henry Wang
This commit firstly adds a bool field `static_heap` to bootinfo. This newly introduced field is set at the device tree parsing time if the static heap ranges are defined in the device tree chosen node. For Arm32, In `setup_mm`, if the static heap is enabled, we use the static heap region for both

Re: [PATCH] xen/arm: acpi: Include header file for version number

2022-09-07 Thread Julien Grall
On 07/09/2022 09:30, Bertrand Marquis wrote: On 7 Sep 2022, at 09:26, Julien Grall wrote: Hi Leo, On 06/09/2022 12:31, Leo Yan wrote: On Arm64 Linux kernel prints log for Xen version number: [0.00] Xen XEN_VERSION.XEN_SUBVERSION support found Because the header file "xen/compile

Re: [PATCH v4 4/4] tools/xenstore: add migration stream extensions for new features

2022-09-07 Thread Julien Grall
Hi Juergen, On 07/09/2022 07:28, Juergen Gross wrote: On 06.09.22 19:27, Julien Grall wrote: Hi Juergen, On 05/09/2022 13:47, Juergen Gross wrote: Extend the definition of the Xenstore migration stream to cover new features: - per domain features - extended watches (watch depth) - per domain

Re: [PATCH] xen/arm: acpi: Include header file for version number

2022-09-07 Thread Bertrand Marquis
Hi Julien, > On 7 Sep 2022, at 09:37, Julien Grall wrote: > > > > On 07/09/2022 09:30, Bertrand Marquis wrote: >>> On 7 Sep 2022, at 09:26, Julien Grall wrote: >>> >>> Hi Leo, >>> >>> On 06/09/2022 12:31, Leo Yan wrote: On Arm64 Linux kernel prints log for Xen version number: [

Re: [PATCH] xen/arm: acpi: Include header file for version number

2022-09-07 Thread Julien Grall
On 07/09/2022 09:53, Bertrand Marquis wrote: Otherwise if we start adding those kinds of checks, we will have to add them in at least 3 places in xen code. The solution I proposed above is easy to implement right now. My gut feeling is tweaking __stringify (or else) will take a bit more ti

Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-07 Thread Julien Grall
Hi Jan & Stefano, On 06/09/2022 09:53, Jan Beulich wrote: On 03.09.2022 02:24, Stefano Stabellini wrote: On Thu, 1 Sep 2022, Rahul Singh wrote: @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(struct domain *d) return 0; } +static int is_bar_valid(const struct dt_device_node

Re: [PATCH] xen/arm: acpi: Include header file for version number

2022-09-07 Thread Bertrand Marquis
> On 7 Sep 2022, at 09:55, Julien Grall wrote: > > > > On 07/09/2022 09:53, Bertrand Marquis wrote: Otherwise if we start adding those kinds of checks, we will have to add them in at least 3 places in xen code. >>> >>> The solution I proposed above is easy to implement right now.

Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-07 Thread Jan Beulich
On 07.09.2022 10:58, Julien Grall wrote: > Hi Jan & Stefano, > > On 06/09/2022 09:53, Jan Beulich wrote: >> On 03.09.2022 02:24, Stefano Stabellini wrote: >>> On Thu, 1 Sep 2022, Rahul Singh wrote: @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(struct domain *d) return 0;

Re: [PATCH] xen/arm: acpi: Include header file for version number

2022-09-07 Thread Jan Beulich
On 07.09.2022 10:58, Bertrand Marquis wrote: >> On 7 Sep 2022, at 09:55, Julien Grall wrote: >> On 07/09/2022 09:53, Bertrand Marquis wrote: > Otherwise if we start adding those kinds of checks, we will have to add > them in at least 3 places in xen code. The solution I proposed

Re: [PATCH v3 1/4] xen/arm: bootfdt: Make process_chosen_node() return int

2022-09-07 Thread Michal Orzel
Hi Henry, On 07/09/2022 10:36, Henry Wang wrote: > > At the boot time, it is saner to stop booting early if an error occurs > when parsing the device tree chosen node, rather than seeing random > behavior afterwards. Therefore, this commit changes the return type of > the process_chosen_node() fr

[ovmf test] 173038: regressions - FAIL

2022-09-07 Thread osstest service owner
flight 173038 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173038/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

Re: [PATCH v4 4/4] tools/xenstore: add migration stream extensions for new features

2022-09-07 Thread Juergen Gross
On 07.09.22 10:44, Julien Grall wrote: Hi Juergen, On 07/09/2022 07:28, Juergen Gross wrote: On 06.09.22 19:27, Julien Grall wrote: Hi Juergen, On 05/09/2022 13:47, Juergen Gross wrote: Extend the definition of the Xenstore migration stream to cover new features: - per domain features - ext

Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-07 Thread Julien Grall
Hi Jan, On 07/09/2022 10:07, Jan Beulich wrote: On 07.09.2022 10:58, Julien Grall wrote: Hi Jan & Stefano, On 06/09/2022 09:53, Jan Beulich wrote: On 03.09.2022 02:24, Stefano Stabellini wrote: On Thu, 1 Sep 2022, Rahul Singh wrote: @@ -363,6 +373,39 @@ int __init pci_host_bridge_mappings(s

[PATCH] .gitignore: Add init-dom0less

2022-09-07 Thread Viresh Kumar
Add tools/helpers/init-dom0less to gitignore. Signed-off-by: Viresh Kumar --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 27881c976432..9f9f18c97d5f 100644 --- a/.gitignore +++ b/.gitignore @@ -170,6 +170,7 @@ tools/flask/utils/flask-setenforce t

Re: [PATCH v3 1/4] xen/arm: bootfdt: Make process_chosen_node() return int

2022-09-07 Thread Julien Grall
On 07/09/2022 10:19, Michal Orzel wrote: Hi Henry, On 07/09/2022 10:36, Henry Wang wrote: At the boot time, it is saner to stop booting early if an error occurs when parsing the device tree chosen node, rather than seeing random behavior afterwards. Therefore, this commit changes the return

[PATCH] .gitignore: Add *.patch

2022-09-07 Thread Viresh Kumar
Add *.patch entry to .gitignore file to stop showing git generated patches in commands like 'git status'. Signed-off-by: Viresh Kumar --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 9f9f18c97d5f..d9a4fd038145 100644 --- a/.gitignore +++ b/.gitigno

Re: [PATCH] xen/arm: acpi: Include header file for version number

2022-09-07 Thread Bertrand Marquis
Hi Jan, > On 7 Sep 2022, at 10:14, Jan Beulich wrote: > > On 07.09.2022 10:58, Bertrand Marquis wrote: >>> On 7 Sep 2022, at 09:55, Julien Grall wrote: >>> On 07/09/2022 09:53, Bertrand Marquis wrote: >> Otherwise if we start adding those kinds of checks, we will have to add >> them in

Re: [PATCH] .gitignore: Add *.patch

2022-09-07 Thread Juergen Gross
On 07.09.22 12:05, Viresh Kumar wrote: Add *.patch entry to .gitignore file to stop showing git generated patches in commands like 'git status'. Signed-off-by: Viresh Kumar --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 9f9f18c97d5f..d9a4fd03

Re: [PATCH] .gitignore: Add *.patch

2022-09-07 Thread Viresh Kumar
On 07-09-22, 12:09, Juergen Gross wrote: > On 07.09.22 12:05, Viresh Kumar wrote: > > Add *.patch entry to .gitignore file to stop showing git generated > > patches in commands like 'git status'. > > > > Signed-off-by: Viresh Kumar > > --- > > .gitignore | 1 + > > 1 file changed, 1 insertion(

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Julien Grall
Hi Henry, On 07/09/2022 09:36, Henry Wang wrote: static int __init early_scan_node(const void *fdt, diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index b76a84e8f5..0741645014 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1038,9 +1038,11

Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-07 Thread Julien Grall
Hi Henry, On 07/09/2022 09:36, Henry Wang wrote: diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7f5b317d3e..4a70ed2986 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -132,12 +132,12 @@ uint64_t init_ttbr; static paddr_t phys_offset; /* Limits of the Xen heap */ -mfn_

[xen-unstable test] 173031: tolerable FAIL - PUSHED

2022-09-07 Thread osstest service owner
flight 173031 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/173031/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 buil

Re: [PATCH v3 4/4] xen/arm: Handle static heap pages in boot and heap allocator

2022-09-07 Thread Julien Grall
Hi Henry, On 07/09/2022 09:36, Henry Wang wrote: This commit firstly adds a bool field `static_heap` to bootinfo. This newly introduced field is set at the device tree parsing time if the static heap ranges are defined in the device tree chosen node. For Arm32, In `setup_mm`, if the static heap

RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > > -/* find first memory range not bound to a Xen domain */ > > -for ( i = 0; i < mem->nr_banks && mem->bank[i].xen_domain; i++ ) > > +/* find first memory range not bound to a Xen domain nor heap */ > > This comment could

Re: Setting constant-time mode CPU flag

2022-09-07 Thread Bertrand Marquis
Hi Demi, > On 2 Sep 2022, at 03:05, Demi Marie Obenour > wrote: > > On Intel chips (Ice Lake and later) and ARM64, a bit needs to be set in This bit would not change anything on Arm currently so nothing is required for now (and nothing has been done in Linux for ARM64). Thanks a lot for noti

RE: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-07 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to > directmap_* > > Hi Henry, > > On 07/09/2022 09:36, Henry Wang wrote: > > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > > index 7f5b317d3e..4a70ed2986 100

[libvirt test] 173035: regressions - FAIL

2022-09-07 Thread osstest service owner
flight 173035 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/173035/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-armhf-libvirt

Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-07 Thread Julien Grall
On 07/09/2022 11:53, Henry Wang wrote: -Original Message- From: Julien Grall Subject: Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Hi Henry, On 07/09/2022 09:36, Henry Wang wrote: diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7f5b317d3e..4a70e

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-07 Thread Michal Hocko
On Tue 06-09-22 14:20:58, Kent Overstreet wrote: [...] > Otherwise, saying "code has to be maintained" is a little bit like saying > water > is wet, and we're all engineers here, I think we know that :) Hmm, it seems that further discussion doesn't really make much sense here. I know how to use m

Re: USB-C 250GB SSD Passthrough fails to DomU Ubuntu

2022-09-07 Thread A Sudheer
Hi All, Is anyone aware if this a general limitation of DomU Or is there a way to convince DomU to expose USB host controllers with streams support ? Thanks Sudheer On Tue, Aug 30, 2022 at 1:34 PM A Sudheer wrote: > Few more logs > > From Dom0, did passthrough of two USB drives (32GB stick and

Re: [PATCH] .gitignore: Add init-dom0less

2022-09-07 Thread Jan Beulich
On 07.09.2022 12:03, Viresh Kumar wrote: > Add tools/helpers/init-dom0less to gitignore. > > Signed-off-by: Viresh Kumar > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 27881c976432..9f9f18c97d5f 100644 > --- a/.gitignore > +++ b/.giti

Re: [PATCH] xen/arm: acpi: Include header file for version number

2022-09-07 Thread Leo Yan
On Wed, Sep 07, 2022 at 10:05:54AM +, Bertrand Marquis wrote: [...] > I think a define in compile.h using stringify is the easiest solution: > >>> > >>> Ah! I thought you were suggesting to tweak __stringify. This is ... > >> > >> Also possible but a bit more tricky > >> > #defin

[ImageBuilder v2 2/2] Add support for Xen boot-time cpupools

2022-09-07 Thread Michal Orzel
Introduce support for creating boot-time cpupools in the device tree and assigning them to dom0less domUs. Add the following options: - CPUPOOL[number]="cpu@1,...,cpu@N scheduler" to specify the list of cpus' node names and the scheduler to be used to create cpupool - NUM_CPUPOOLS to specify t

[ImageBuilder v2 1/2] scripts/common: Introduce phandle_next and get_next_phandle()

2022-09-07 Thread Michal Orzel
When dealing with device trees, we need to have a solution to add custom phandles to the nodes we create/modify. Add a global variable phandle_next to act as a countdown counter starting with the highest valid phandle value 0xfffe. Add a new function get_next_phandle to get a value of the next

[PATCH v4 0/2] xen/pci: implement is_memory_hole for ARM

2022-09-07 Thread Rahul Singh
This patch series is to implement something like is_memory_hole function for ARM. Rahul Singh (2): xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev xen/pci: replace call to is_memory_hole to pci_check_bar xen/arch/arm/include/asm/pci.h | 5 ++- xen/arch/arm/pci/pci-

RE: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-07 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > >>> @@ -609,7 +609,7 @@ void __init setup_xenheap_mappings(unsigned > >> long base_mfn, > >> > >> I think the function also want to be renamed to match the code below. > > > > Hmmm, renaming the name to "setup_directmap_mappings" woul

[PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-07 Thread Rahul Singh
is_memory_hole was implemented for x86 and not for ARM when introduced. Replace is_memory_hole call to pci_check_bar as function should check if device BAR is in defined memory range. Also, add an implementation for ARM which is required for PCI passthrough. On x86, pci_check_bar will call is_memo

Re: [PATCH] xen/arm: acpi: Include header file for version number

2022-09-07 Thread Bertrand Marquis
Hi Leo, > On 7 Sep 2022, at 12:08, Leo Yan wrote: > > On Wed, Sep 07, 2022 at 10:05:54AM +, Bertrand Marquis wrote: > > [...] > >> I think a define in compile.h using stringify is the easiest solution: > > Ah! I thought you were suggesting to tweak __stringify. This is ... >>>

Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-07 Thread Julien Grall
On 07/09/2022 12:09, Henry Wang wrote: Hi Julien, Hi Henry, -Original Message- From: Julien Grall @@ -609,7 +609,7 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, I think the function also want to be renamed to match the code below. Hmmm, renaming the name to "s

Re: [PATCH] xen/arm: acpi: Include header file for version number

2022-09-07 Thread Leo Yan
On Wed, Sep 07, 2022 at 11:12:24AM +, Bertrand Marquis wrote: [...] > > Just remind, We need to define XEN_VERSION_STRING in compile.h.in rather > > than in compile.h, something like: > > > > #define XEN_VERSION_STRING @@version@@.@@subversion@@ > > Very true but you will need the quotes h

RE: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-07 Thread Henry Wang
Hi Julien, > -Original Message- > > How about > > /* > > * For Arm32, set up the xenheap: up to 1GB of contiguous, > > * always-mapped memory. Base must be 32MB aligned and size > > * a multiple of 32MB. > > * For Arm64, set up the directmap area of memory. > > One remark. I would

[PATCH v4 1/2] xen/arm: pci: modify pci_find_host_bridge_node argument to const pdev

2022-09-07 Thread Rahul Singh
Modify pci_find_host_bridge_node argument to const pdev to avoid converting the dev to pdev in pci_find_host_bridge_node and also constify the return. Signed-off-by: Rahul Singh Reviewed-by: Oleksandr Tyshchenko Acked-by: Stefano Stabellini --- Changes in v4: - no changes Changes in v3: - no

Re: [PATCH v7 2/9] xen/arm: assign static shared memory to the default owner dom_io

2022-09-07 Thread Julien Grall
Hi Penny, On 06/09/2022 09:59, Penny Zheng wrote: +static int __init assign_shared_memory(struct domain *d, + uint32_t addr_cells, uint32_t size_cells, + paddr_t pbase, paddr_t psize) +{ +mfn_t smfn; + +dprintk(

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Julien Grall
Hi Henry, While reviewing the binding sent by Penny I noticed some inconsistency with the one you introduced. See below. On 07/09/2022 09:36, Henry Wang wrote: +- xen,static-heap + +Property under the top-level "chosen" node. It specifies the address +and size of Xen static heap memor

RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory > > Hi Henry, > > While reviewing the binding sent by Penny I noticed some inconsistency > with the one you introduced. See below. > > On 07/09/2022 09:36, Hen

Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-07 Thread Jan Beulich
On 07.09.2022 12:00, Julien Grall wrote: > On 07/09/2022 10:07, Jan Beulich wrote: >> On 07.09.2022 10:58, Julien Grall wrote: >>> On 06/09/2022 09:53, Jan Beulich wrote: On 03.09.2022 02:24, Stefano Stabellini wrote: > On Thu, 1 Sep 2022, Rahul Singh wrote: >> @@ -363,6 +373,39 @@ int

[PATCH] xen: Add macro for version number string

2022-09-07 Thread Leo Yan
On Arm64 Linux kernel prints log for Xen version number: Xen XEN_VERSION.XEN_SUBVERSION support found The header file "xen/compile.h" is missed so that XEN_VERSION and XEN_SUBVERSION are not defined, __stringify() wrongly converts them as strings and concatenate to string "XEN_VERSION.XEN_SUBVE

Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-07 Thread Jan Beulich
On 07.09.2022 13:09, Rahul Singh wrote: > is_memory_hole was implemented for x86 and not for ARM when introduced. > Replace is_memory_hole call to pci_check_bar as function should check > if device BAR is in defined memory range. Also, add an implementation > for ARM which is required for PCI passt

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Bertrand Marquis
Hi, > On 7 Sep 2022, at 12:48, Henry Wang wrote: > > Hi Julien, > >> -Original Message- >> From: Julien Grall >> Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory >> >> Hi Henry, >> >> While reviewing the binding sent by Penny I noticed some inconsistency >> wit

Re: [PATCH] xen: Add macro for version number string

2022-09-07 Thread Jan Beulich
On 07.09.2022 14:04, Leo Yan wrote: > On Arm64 Linux kernel prints log for Xen version number: > > Xen XEN_VERSION.XEN_SUBVERSION support found > > The header file "xen/compile.h" is missed so that XEN_VERSION and > XEN_SUBVERSION are not defined, __stringify() wrongly converts them as > string

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Michal Orzel
Hi Julien, On 07/09/2022 13:36, Julien Grall wrote: > > Hi Henry, > > While reviewing the binding sent by Penny I noticed some inconsistency > with the one you introduced. See below. > > On 07/09/2022 09:36, Henry Wang wrote: >> +- xen,static-heap >> + >> +Property under the top-level "chos

Re: [PATCH] xen: Add macro for version number string

2022-09-07 Thread Bertrand Marquis
Hi Leo, Thanks a lot for the quick handling here. > On 7 Sep 2022, at 13:04, Leo Yan wrote: > > On Arm64 Linux kernel prints log for Xen version number: > > Xen XEN_VERSION.XEN_SUBVERSION support found > > The header file "xen/compile.h" is missed so that XEN_VERSION and > XEN_SUBVERSION are

Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer

2022-09-07 Thread Dario Faggioli
On Tue, 2022-09-06 at 14:35 +0200, Marek Marczykowski-Górecki wrote: > On Tue, Sep 06, 2022 at 01:46:55PM +0200, Juergen Gross wrote: > > > > Could you test the attached patch, please? > > I did a test with only dom0 running, and it works now. It isn't a > comprehensive test, but just dom0 was en

Re: [PATCH] xen: Add macro for version number string

2022-09-07 Thread Leo Yan
Hi Jan, On Wed, Sep 07, 2022 at 02:12:25PM +0200, Jan Beulich wrote: > On 07.09.2022 14:04, Leo Yan wrote: > > On Arm64 Linux kernel prints log for Xen version number: > > > > Xen XEN_VERSION.XEN_SUBVERSION support found > > > > The header file "xen/compile.h" is missed so that XEN_VERSION and

Re: [PATCH] xen: Add macro for version number string

2022-09-07 Thread Jan Beulich
On 07.09.2022 14:28, Leo Yan wrote: > A question, since commit 5d797ee199b3 was merged in 4.11.0-rc6, for > fixing it, should I explictly add backport tag as below? > > Backport: 4.11+ That's up to you, I would say. We don't really use that tag all that much, the Fixes: tag is more relevant at

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Julien Grall
On 07/09/2022 13:12, Michal Orzel wrote: Hi Julien, Hi Michal, On 07/09/2022 13:36, Julien Grall wrote: Hi Henry, While reviewing the binding sent by Penny I noticed some inconsistency with the one you introduced. See below. On 07/09/2022 09:36, Henry Wang wrote: +- xen,static-heap +

Re: [PATCH V5 1/6] libxl: Add support for Virtio I2C device

2022-09-07 Thread Viresh Kumar
Hi Anthony, Thanks a lot for the in-depth review, it is really helpful. I don't have much knowledge of the Xen code and wanted this code for I2C and GPIO to be tested on Xen for the work we are doing around hypervisor agnostic backends [1]. I started looking for a simple device's implementation

Re: [PATCH] xen: Add macro for version number string

2022-09-07 Thread Leo Yan
On Wed, Sep 07, 2022 at 02:31:52PM +0200, Jan Beulich wrote: > On 07.09.2022 14:28, Leo Yan wrote: > > A question, since commit 5d797ee199b3 was merged in 4.11.0-rc6, for > > fixing it, should I explictly add backport tag as below? > > > > Backport: 4.11+ > > That's up to you, I would say. We d

Re: [PATCH] xen: Add macro for version number string

2022-09-07 Thread Jan Beulich
On 07.09.2022 14:20, Bertrand Marquis wrote: > Hi Leo, > > Thanks a lot for the quick handling here. > >> On 7 Sep 2022, at 13:04, Leo Yan wrote: >> >> On Arm64 Linux kernel prints log for Xen version number: >> >> Xen XEN_VERSION.XEN_SUBVERSION support found >> >> The header file "xen/compile.

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Julien Grall
On 07/09/2022 13:12, Bertrand Marquis wrote: Hi, Hi Bertrand, On 7 Sep 2022, at 12:48, Henry Wang wrote: Hi Julien, -Original Message- From: Julien Grall Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Hi Henry, While reviewing the binding sent by Pen

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Michal Orzel
On 07/09/2022 14:32, Julien Grall wrote: > [CAUTION: External Email] > > On 07/09/2022 13:12, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> On 07/09/2022 13:36, Julien Grall wrote: >>> >>> Hi Henry, >>> >>> While reviewing the binding sent by Penny I noticed some inconsistency >>> wit

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Julien Grall
On 07/09/2022 13:41, Michal Orzel wrote: On 07/09/2022 14:32, Julien Grall wrote: [CAUTION: External Email] On 07/09/2022 13:12, Michal Orzel wrote: Hi Julien, Hi Michal, On 07/09/2022 13:36, Julien Grall wrote: Hi Henry, While reviewing the binding sent by Penny I noticed some inc

Re: [PATCH v3 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-07 Thread Julien Grall
On 07/09/2022 13:01, Jan Beulich wrote: On 07.09.2022 12:00, Julien Grall wrote: On 07/09/2022 10:07, Jan Beulich wrote: On 07.09.2022 10:58, Julien Grall wrote: On 06/09/2022 09:53, Jan Beulich wrote: On 03.09.2022 02:24, Stefano Stabellini wrote: On Thu, 1 Sep 2022, Rahul Singh wrote:

Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-07 Thread Julien Grall
Hi Jan, On 07/09/2022 13:06, Jan Beulich wrote: On 07.09.2022 13:09, Rahul Singh wrote: is_memory_hole was implemented for x86 and not for ARM when introduced. Replace is_memory_hole call to pci_check_bar as function should check if device BAR is in defined memory range. Also, add an implementa

[PATCH v2] xen: Add macro for version number string

2022-09-07 Thread Leo Yan
On Arm64 Linux kernel prints log for Xen version number: Xen XEN_VERSION.XEN_SUBVERSION support found The header file "xen/compile.h" is missed so that XEN_VERSION and XEN_SUBVERSION are not defined, __stringify() wrongly converts them as strings and concatenate to string "XEN_VERSION.XEN_SUBVE

Re: [PATCH] xen: Add macro for version number string

2022-09-07 Thread Leo Yan
On Wed, Sep 07, 2022 at 02:34:25PM +0200, Jan Beulich wrote: > On 07.09.2022 14:20, Bertrand Marquis wrote: > > Hi Leo, > > > > Thanks a lot for the quick handling here. > > > >> On 7 Sep 2022, at 13:04, Leo Yan wrote: > >> > >> On Arm64 Linux kernel prints log for Xen version number: > >> > >>

[ovmf test] 173043: regressions - FAIL

2022-09-07 Thread osstest service owner
flight 173043 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/173043/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 172136 build-amd64-libvirt

[linux-linus test] 173034: regressions - FAIL

2022-09-07 Thread osstest service owner
flight 173034 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/173034/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 172133 build-i386-libvirt

Re: [PATCH v4 3/7] xen/evtchn: restrict the maximum number of evtchn supported for domUs

2022-09-07 Thread Julien Grall
On 06/09/2022 14:40, Rahul Singh wrote: Restrict the maximum number of evtchn supported for domUs to avoid allocating a large amount of memory in Xen. Set the default value of max_evtchn_port to 1023. The value of 1023 should be sufficient for domUs guests because on ARM we don't bind To me

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-07 Thread Kent Overstreet
On Wed, Sep 07, 2022 at 01:00:09PM +0200, Michal Hocko wrote: > Hmm, it seems that further discussion doesn't really make much sense > here. I know how to use my time better. Just a thought, but I generally find it more productive to propose ideas than to just be disparaging. Cheers, Kent

Re: [PATCH v4 6/7] xen/arm: introduce new xen,enhanced property value

2022-09-07 Thread Julien Grall
Hi Rahul On 06/09/2022 14:40, Rahul Singh wrote: Introduce a new "xen,enhanced" dom0less property value "no-xenstore" to disable xenstore interface for dom0less guests. Signed-off-by: Rahul Singh --- Changes in v4: - Implement defines for dom0less features Changes in v3: - new patch in thi

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Michal Orzel
On 07/09/2022 14:45, Julien Grall wrote: > > On 07/09/2022 13:41, Michal Orzel wrote: >> >> >> On 07/09/2022 14:32, Julien Grall wrote: >>> [CAUTION: External Email] >>> >>> On 07/09/2022 13:12, Michal Orzel wrote: Hi Julien, >>> >>> Hi Michal, >>> On 07/09/2022 13:36, Julien Grall wro

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Bertrand Marquis
Hi, > On 7 Sep 2022, at 13:45, Julien Grall wrote: > > > > On 07/09/2022 13:41, Michal Orzel wrote: >> On 07/09/2022 14:32, Julien Grall wrote: >>> [CAUTION: External Email] >>> >>> On 07/09/2022 13:12, Michal Orzel wrote: Hi Julien, >>> >>> Hi Michal, >>> On 07/09/2022 13:36, Jul

Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-07 Thread Bertrand Marquis
Hi Jan, > On 7 Sep 2022, at 13:06, Jan Beulich wrote: > > On 07.09.2022 13:09, Rahul Singh wrote: >> is_memory_hole was implemented for x86 and not for ARM when introduced. >> Replace is_memory_hole call to pci_check_bar as function should check >> if device BAR is in defined memory range. Also,

Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-07 Thread Jan Beulich
On 07.09.2022 15:13, Bertrand Marquis wrote: > Hi Jan, > >> On 7 Sep 2022, at 13:06, Jan Beulich wrote: >> >> On 07.09.2022 13:09, Rahul Singh wrote: >>> is_memory_hole was implemented for x86 and not for ARM when introduced. >>> Replace is_memory_hole call to pci_check_bar as function should che

Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-07 Thread Bertrand Marquis
Hi, > On 7 Sep 2022, at 13:48, Julien Grall wrote: > > Hi Jan, > > On 07/09/2022 13:06, Jan Beulich wrote: >> On 07.09.2022 13:09, Rahul Singh wrote: >>> is_memory_hole was implemented for x86 and not for ARM when introduced. >>> Replace is_memory_hole call to pci_check_bar as function should c

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Bertrand Marquis
Hi Michal, > On 7 Sep 2022, at 14:09, Michal Orzel wrote: > > > On 07/09/2022 14:45, Julien Grall wrote: >> >> On 07/09/2022 13:41, Michal Orzel wrote: >>> >>> >>> On 07/09/2022 14:32, Julien Grall wrote: [CAUTION: External Email] On 07/09/2022 13:12, Michal Orzel wrote:

Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar

2022-09-07 Thread Bertrand Marquis
Hi, > On 7 Sep 2022, at 14:21, Jan Beulich wrote: > > On 07.09.2022 15:13, Bertrand Marquis wrote: >> Hi Jan, >> >>> On 7 Sep 2022, at 13:06, Jan Beulich wrote: >>> >>> On 07.09.2022 13:09, Rahul Singh wrote: is_memory_hole was implemented for x86 and not for ARM when introduced. Re

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Michal Orzel
On 07/09/2022 15:28, Bertrand Marquis wrote: > > Hi Michal, > >> On 7 Sep 2022, at 14:09, Michal Orzel wrote: >> >> >> On 07/09/2022 14:45, Julien Grall wrote: >>> >>> On 07/09/2022 13:41, Michal Orzel wrote: On 07/09/2022 14:32, Julien Grall wrote: > [CAUTION: External Ema

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Bertrand Marquis
> On 7 Sep 2022, at 14:31, Michal Orzel wrote: > > > > On 07/09/2022 15:28, Bertrand Marquis wrote: >> >> Hi Michal, >> >>> On 7 Sep 2022, at 14:09, Michal Orzel wrote: >>> >>> >>> On 07/09/2022 14:45, Julien Grall wrote: On 07/09/2022 13:41, Michal Orzel wrote: > >

RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Henry Wang
Hi Michal, > -Original Message- > From: Michal Orzel > > I am not convinced by the arguments on not using #address-cells and will > > leave that one to Stefano > > > > But in any case we should only add one pair here for sure, as you say the > > only implication is to add a couple of 0 in

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Michal Orzel
On 07/09/2022 15:33, Bertrand Marquis wrote: > >> On 7 Sep 2022, at 14:31, Michal Orzel wrote: >> >> >> >> On 07/09/2022 15:28, Bertrand Marquis wrote: >>> >>> Hi Michal, >>> On 7 Sep 2022, at 14:09, Michal Orzel wrote: On 07/09/2022 14:45, Julien Grall wrote: > >

Re: [PATCH v7 7/9] xen/arm: create shared memory nodes in guest device tree

2022-09-07 Thread Julien Grall
Hi Penny, On 06/09/2022 09:59, Penny Zheng wrote: We expose the shared memory to the domU using the "xen,shared-memory-v1" reserved-memory binding. See Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt in Linux for the corresponding device tree binding. To save the cost of

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-07 Thread Steven Rostedt
On Wed, 7 Sep 2022 09:04:28 -0400 Kent Overstreet wrote: > On Wed, Sep 07, 2022 at 01:00:09PM +0200, Michal Hocko wrote: > > Hmm, it seems that further discussion doesn't really make much sense > > here. I know how to use my time better. > > Just a thought, but I generally find it more product

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Bertrand Marquis
Hi Henry, > On 7 Sep 2022, at 14:35, Henry Wang wrote: > > Hi Michal, > >> -Original Message- >> From: Michal Orzel >>> I am not convinced by the arguments on not using #address-cells and will >>> leave that one to Stefano >>> >>> But in any case we should only add one pair here for s

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Bertrand Marquis
Hi, > On 7 Sep 2022, at 14:37, Michal Orzel wrote: > > > > On 07/09/2022 15:33, Bertrand Marquis wrote: >> >>> On 7 Sep 2022, at 14:31, Michal Orzel wrote: >>> >>> >>> >>> On 07/09/2022 15:28, Bertrand Marquis wrote: Hi Michal, > On 7 Sep 2022, at 14:09, Michal Orzel

  1   2   >