Re: [PATCH v7 2/9] xen/arm: assign static shared memory to the default owner dom_io

[Julien Grall]

Hi Penny,

On 06/09/2022 09:59, Penny Zheng wrote:
+static int __init assign_shared_memory(struct domain *d,
+                                       uint32_t addr_cells, uint32_t 
size_cells,
+                                       paddr_t pbase, paddr_t psize)
+{
+    mfn_t smfn;
+
+    dprintk(XENLOG_INFO,
+            "%pd: allocate static shared memory BANK 
%#"PRIpaddr"-%#"PRIpaddr".\n",
+            d, pbase, pbase + psize);
+
+    smfn = acquire_shared_memory_bank(d, pbase, psize);
+    if ( mfn_eq(smfn, INVALID_MFN) )
+        return -EINVAL;
+
+    /*
+     * DOMID_IO is auto-translated (i.e. it seems RAM 1:1). So we do not need

Hmmm... I should have re-read my sentence before hitting sending. It 
should be "is not auto-translated" and s/seeems/sees/.

Other than that:

Reviewed-by: Julien Grall <jgr...@amazon.com>

Cheers,

--
Julien Grall