On 07.09.2022 14:20, Bertrand Marquis wrote:
> Hi Leo,
>
> Thanks a lot for the quick handling here.
>
>> On 7 Sep 2022, at 13:04, Leo Yan <leo....@linaro.org> wrote:
>>
>> On Arm64 Linux kernel prints log for Xen version number:
>>
>> Xen XEN_VERSION.XEN_SUBVERSION support found
>>
>> The header file "xen/compile.h" is missed so that XEN_VERSION and
>> XEN_SUBVERSION are not defined, __stringify() wrongly converts them as
>> strings and concatenate to string "XEN_VERSION.XEN_SUBVERSION".
>>
>> This patch introduces a string macro XEN_VERSION_STRING, we can directly
>> use it as version number string, as a result it drops to use of
>> __stringify() to make the code more readable.
>>
>> The change has been tested on Ampere AVA Arm64 platform.
>>
>> Fixes: 5d797ee199b3 ("xen/arm: split domain_build.c")
>> Suggested-by: Bertrand Marquis <bertrand.marq...@arm.com>
>> Signed-off-by: Leo Yan <leo....@linaro.org>
> Reviewed-by: Bertrand Marquis <bertrand.marq...@arm.com>
>
> Regarding the change suggested by Jan to add spaces, I think it is a
> good idea so if the commiter agrees to do on it on commit please do,
> otherwise we can keep this as is.
If I end up committing this, I'd be happy to add the blanks, and therefore
I'm inclined to say no need for a re-send.
Jan
