Hi Jan,
> -Original Message-
> From: Jan Beulich
> Sent: 2022年7月5日 14:35
> To: Wei Chen
> Cc: Stefano Stabellini ; Julien Grall
> ; Bertrand Marquis ; Volodymyr
> Babchuk ; xen-devel@lists.xenproject.org
> Subject: Re: [PATCH v2] Xen: fix EFI stub wchar_t size warning of arm32
> building
On 04.07.2022 18:31, G.R. wrote:
> On Tue, Jul 5, 2022 at 12:21 AM Roger Pau Monné wrote:
>>
>> On Mon, Jul 04, 2022 at 11:37:13PM +0800, G.R. wrote:
>>> On Mon, Jul 4, 2022 at 11:15 PM G.R.
>>> wrote:
On Mon, Jul 4, 2022 at 10:51 PM G.R.
wrote:
>
> On Mon, Jul 4, 2022 a
On 05.07.2022 09:18, Wei Chen wrote:
> Hi Jan,
>
>> -Original Message-
>> From: Jan Beulich
>> Sent: 2022年7月5日 14:35
>> To: Wei Chen
>> Cc: Stefano Stabellini ; Julien Grall
>> ; Bertrand Marquis ; Volodymyr
>> Babchuk ; xen-devel@lists.xenproject.org
>> Subject: Re: [PATCH v2] Xen: fix
Hi Wei,
On 05/07/2022 04:54, Wei Chen wrote:
Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32
is using stub.c of EFI common code for EFI stub functions. But
"-fshort-wchar" CFLAG will cause a warning when build stub.c
for Arm32:
"arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_i
On 04/07/2022 08:45, Penny Zheng wrote:
Hi Stefano and Julien
Hi Penny,
-Original Message-
From: Stefano Stabellini
+res = fdt_property_cell(fdt, "xen,id", shm_id);
Looking at the Linux binding, "xen,id" is meant to be a string. But
here you are writing it as an integer
On 28.06.2022 14:39, Roger Pau Monné wrote:
> On Thu, Jun 09, 2022 at 12:16:38PM +0200, Jan Beulich wrote:
>> For vendor specific code to support superpages we need to be able to
>> deal with a superpage mapping replacing an intermediate page table (or
>> hierarchy thereof). Consequently an iommu_a
On 02.06.2022 12:26, Jan Beulich wrote:
> From: Artem Bityutskiy
>
> On Sapphire Rapids Xeon (SPR) the C1 and C1E states are basically mutually
> exclusive - only one of them can be enabled. By default, 'intel_idle' driver
> enables C1 and disables C1E. However, some users prefer to use C1E inste
flight 171497 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/171497/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777
build-arm64-libvirt
On Mon, Jul 04, 2022 at 03:32:08PM +, Bertrand Marquis wrote:
> Hi Luca,
>
> > On 29 Jun 2022, at 13:49, Luca Fancellu wrote:
> >
> > Fix snprintf argument in init-dom0less.c because two instances of
> > the function are using libxl_dominfo struct members that are uint64_t
> > types, so chan
flight 171496 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/171496/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-arm64-pvops 6 kernel-build fail REGR. vs. 171491
Tests which did no
Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32
is using stub.c of EFI common code for EFI stub functions. But
"-fshort-wchar" CFLAG will cause a warning when build stub.c
for Arm32:
"arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses
2-byte wchar_t yet the output is to use
On 24.06.2022 20:17, Demi Marie Obenour wrote:
> The EFI System Resource Table (ESRT) is necessary for fwupd to identify
> firmware updates to install. According to the UEFI specification §23.4,
> the ESRT shall be stored in memory of type EfiBootServicesData. However,
> memory of type EfiBootSer
[CCing tglx, mingo, Boris and Juergen]
On 04.07.22 14:26, Jan Beulich wrote:
> On 04.07.2022 13:58, Thorsten Leemhuis wrote:
>> On 25.05.22 10:55, Jan Beulich wrote:
>>> On 28.04.2022 16:50, Jan Beulich wrote:
The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT
with p
On 05.07.2022 12:57, Thorsten Leemhuis wrote:
> [CCing tglx, mingo, Boris and Juergen]
>
> On 04.07.22 14:26, Jan Beulich wrote:
>> On 04.07.2022 13:58, Thorsten Leemhuis wrote:
>>> On 25.05.22 10:55, Jan Beulich wrote:
On 28.04.2022 16:50, Jan Beulich wrote:
> The latest with commit bdd8
On 22.06.22 08:38, Juergen Gross wrote:
Instead of an all or nothing approach add support for requiring
restricted memory access per device.
Changes in V3:
- new patches 1 + 2
- basically complete rework of patch 3
Juergen Gross (3):
virtio: replace restricted mem access flag with callback
On Tue, Jul 5, 2022 at 5:04 PM Jan Beulich wrote:
>
> On 04.07.2022 18:31, G.R. wrote:
> > On Tue, Jul 5, 2022 at 12:21 AM Roger Pau Monné
> > wrote:
> >>> I retried with the following:
> >>> pci=['05:00.0,permissive=1,msitranslate=1']
> >>> Those extra options suppressed some error logging, but
On 05.07.2022 13:31, G.R. wrote:
> On Tue, Jul 5, 2022 at 5:04 PM Jan Beulich wrote:
>>
>> On 04.07.2022 18:31, G.R. wrote:
>>> On Tue, Jul 5, 2022 at 12:21 AM Roger Pau Monné
>>> wrote:
> I retried with the following:
> pci=['05:00.0,permissive=1,msitranslate=1']
> Those extra optio
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Xen Security Advisory CVE-2022-33744 / XSA-406
version 3
Arm guests can cause Dom0 DoS via PV devices
UPDATES IN VERSION 3
Public release.
ISSUE DESCRIPTION
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Xen Security Advisory CVE-2022-33743 / XSA-405
version 3
network backend may cause Linux netfront to use freed SKBs
UPDATES IN VERSION 3
Public release.
ISSUE DESCRIPTION
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Xen Security Advisory
CVE-2022-26365,CVE-2022-33740,CVE-2022-33741,CVE-2022-33742 / XSA-403
version 3
Linux disk/nic frontends data leaks
UPDATES IN VERSION 3
Publi
Hi Julien,
> On 29 Jun 2022, at 11:52, Julien Grall wrote:
>
> Hi,
>
> On 29/06/2022 11:46, Michal Orzel wrote:
>> On 27.06.2022 15:15, Michal Orzel wrote:
>>> This is just for the style and consistency reasons as the former is
>>> being used more often than the latter.
>>>
>>> Signed-off-by:
Add the function prototype of show_stack() in header file
so that it is visible before its definition in traps.c.
Although show_stack() is referenced only in traps.c, it is declared with
external linkage because, during development, it is often called also by
other files for debugging purposes. D
Hi Xenia,
> On 5 Jul 2022, at 13:21, Xenia Ragiadakou wrote:
>
> Add the function prototype of show_stack() in header file
> so that it is visible before its definition in traps.c.
>
> Although show_stack() is referenced only in traps.c, it is declared with
> external linkage because, during d
For a long time we've been rather inefficient with IOMMU page table
management when not sharing page tables, i.e. in particular for PV (and
further specifically also for PV Dom0) and AMD (where nowadays we never
share page tables). While up to about 3.5 years ago AMD code had logic
to un-shatter pa
From: Roger Pau Monné
The loop in iommu_{,un}map() can be arbitrary large, and as such it
needs to handle preemption. Introduce a new flag that signals whether
the function should do preemption checks, returning the number of pages
that have been processed in case a need for preemption was actua
For large page mappings to be easily usable (i.e. in particular without
un-shattering of smaller page mappings) and for mapping operations to
then also be more efficient, pass batches of Dom0 memory to iommu_map().
In dom0_construct_pv() and its helpers (covering strict mode) this
additionally requ
For vendor specific code to support superpages we need to be able to
deal with a superpage mapping replacing an intermediate page table (or
hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is
needed to free individual page tables while a domain is still alive.
Since the freeing
Before actually enabling their use, provide a means to suppress it in
case of problems. Note that using the option can also affect the sharing
of page tables in the VT-d / EPT combination: If EPT would use large
page mappings but the option is in effect, page table sharing would be
suppressed (to p
No separate feature flags exist which would control availability of
these; the only restriction is HATS (establishing the maximum number of
page table levels in general), and even that has a lower bound of 4.
Thus we can unconditionally announce 2M and 1G mappings. (Via non-
default page sizes the
This is a re-usable helper (kind of a template) which gets introduced
without users so that the individual subsequent patches introducing such
users can get committed independently of one another.
See the comment at the top of the new file. To demonstrate the effect,
if a page table had just 16 en
Page tables are used for two purposes after allocation: They either
start out all empty, or they are filled to replace a superpage.
Subsequently, to replace all empty or fully contiguous page tables,
contiguous sub-regions will be recorded within individual page tables.
Install the initial set of m
When a page table ends up with no present entries left, it can be
replaced by a non-present entry at the next higher level. The page table
itself can then be scheduled for freeing.
Note that while its output isn't used there yet,
pt_update_contig_markers() right away needs to be called in all plac
... depending on feature availability (and absence of quirks).
Also make the page table dumping function aware of superpages.
Signed-off-by: Jan Beulich
Reviewed-by: Kevin Tian
Reviewed-by: Roger Pau Monné
---
v6: Re-base over addition of "iommu=no-superpages" command line option.
v5: In intel
When a page table ends up with no present entries left, it can be
replaced by a non-present entry at the next higher level. The page table
itself can then be scheduled for freeing.
Note that while its output isn't used there yet,
pt_update_contig_markers() right away needs to be called in all plac
When a page table ends up with all contiguous entries (including all
identical attributes), it can be replaced by a superpage entry at the
next higher level. The page table itself can then be scheduled for
freeing.
The adjustment to LEVEL_MASK is merely to avoid leaving a latent trap
for whenever
Signed-off-by: Jan Beulich
Reviewed-by: Kevin tian
Reviewed-by: Roger Pau Monné
---
v3: New.
--- a/xen/arch/x86/include/asm/perfc_defn.h
+++ b/xen/arch/x86/include/asm/perfc_defn.h
@@ -125,4 +125,7 @@ PERFCOUNTER(realmode_exits, "vmexit
PERFCOUNTER(pauseloop_exits, "vmexits from Pause-L
This way intel_iommu_unmap_page() ends up quite a bit more similar to
intel_iommu_map_page().
No functional change intended.
Signed-off-by: Jan Beulich
Reviewed-by: Kevin Tian
Reviewed-by: Roger Pau Monné
---
v5: Re-base of changes earlier in the series.
v4: New.
--- a/xen/drivers/passthrough
On 05/07/2022 13:07, Bertrand Marquis wrote:
Hi Julien,
Hi Bertrand,
On 29 Jun 2022, at 11:52, Julien Grall wrote:
Hi,
On 29/06/2022 11:46, Michal Orzel wrote:
On 27.06.2022 15:15, Michal Orzel wrote:
This is just for the style and consistency reasons as the former is
being used more oft
On 05.07.2022 14:41, Jan Beulich wrote:
> For a long time we've been rather inefficient with IOMMU page table
> management when not sharing page tables, i.e. in particular for PV (and
> further specifically also for PV Dom0) and AMD (where nowadays we never
> share page tables). While up to about 3
When a page table ends up with all contiguous entries (including all
identical attributes), it can be replaced by a superpage entry at the
next higher level. The page table itself can then be scheduled for
freeing.
Signed-off-by: Jan Beulich
Reviewed-by: Roger Pau Monné
---
Unlike the freeing of
On Wed, Jun 29, 2022 at 10:22 PM Daniel P. Smith
wrote:
>
> The function flask_domain_alloc_security() is where a default sid should be
> assigned to a domain under construction. For reasons unknown, the initial
> domain would be assigned unlabeled_t and then fixed up under
> flask_domain_create()
Hi Anthony,
> On 24 Jun 2022, at 17:04, Anthony PERARD wrote:
>
> Signed-off-by: Anthony PERARD
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
>
> Notes:
>v2:
>- move new .gitignore entries to the one in tools/libs/
>
> .gitignore| 26 --
>
Hi Anthony,
> On 24 Jun 2022, at 17:04, Anthony PERARD wrote:
>
> Remove -I. from CFLAGS, it isn't necessary.
>
> Removed $(AUTOSRCS), it isn't used.
>
> Signed-off-by: Anthony PERARD
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> tools/libs/util/Makefile | 3 +--
> 1 file changed,
HI Anthony,
> On 24 Jun 2022, at 17:04, Anthony PERARD wrote:
>
> Signed-off-by: Anthony PERARD
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> tools/libs/libs.mk | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
>
On 30.06.2022 10:54, Roger Pau Monne wrote:
> Allow setting the default x2APIC destination mode from Kconfig to
> Physical.
>
> Note the default destination mode is still Logical (Cluster) mode.
>
> Signed-off-by: Roger Pau Monné
Reviewed-by: Jan Beulich
Hi Anthony,
> On 24 Jun 2022, at 17:04, Anthony PERARD wrote:
>
> We can simply use $(PKG_CONFIG) to set the parameters, and add it to
> $(TARGETS) as necessary.
>
> Signed-off-by: Anthony PERARD
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> tools/libs/libs.mk | 11 +--
> 1
Hi Julien,
> On 28 Jun 2022, at 4:18 pm, Julien Grall wrote:
>
>
>
> On 28/06/2022 15:52, Bertrand Marquis wrote:
>> Hi Julien,
>>> On 28 Jun 2022, at 15:26, Julien Grall wrote:
>>>
>>>
>>>
>>> On 28/06/2022 14:53, Rahul Singh wrote:
Hi Julien
>>>
>>> Hi Rahul,
>>>
> On 23 Jun
Hi Anthony,
> On 24 Jun 2022, at 17:04, Anthony PERARD wrote:
>
> There is no need to call the "headers.chk" target when it isn't
> wanted, so it never need to be .PHONY.
>
> Also, there is no more reason to separate the prerequisites from the
> recipe.
>
> Signed-off-by: Anthony PERARD
Revi
On 30.06.2022 10:54, Roger Pau Monne wrote:
> Logic in ioapic_init() that sets the number of available vectors for
> external interrupts requires knowing the x2APIC Destination Mode. As
> such move the call after x2APIC BSP setup.
"requires" reads as if this was the case already, which I don't th
On 05.07.22 15:36, Borislav Petkov wrote:
On Tue, Jul 05, 2022 at 12:57:18PM +0200, Thorsten Leemhuis wrote:
Side note: Juergen Gross recently posted related patches in this code
area to fix some other problems (regressions?), but his efforts look
stalled, too:
https://lore.kernel.org/all/ddb0cc
flight 171498 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/171498/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277
test-amd64-amd64-li
On 05/07/2022 14:28, Rahul Singh wrote:
Hi Julien,
Hi Rahul,
On 28 Jun 2022, at 4:18 pm, Julien Grall wrote:
a new driver in linux kernel, etc where right now we just need to introduce an
extra IOCTL in linux to support this feature.
I don't understand why would need a new driver, etc
Hi all,
I’ve encountered an issue building Xen for x86_64, basically the script
check-endbr.sh was returning an error:
“Error: More valid-addrs than all-addrs”.
I have found a solution but I’m writing anyway to you to make you aware of the
issue.
In my setup I’m using a docker container with b
Hi Samuel
On Fri, Jul 01, 2022 at 03:00:49PM -0500, Samuel Holland wrote:
> The MIPS GIC irqchip driver may be selected in a uniprocessor
> configuration, but it unconditionally registers an IPI domain.
>
> Limit the part of the driver dealing with IPIs to only be compiled when
> GENERIC_IRQ_IPI
On 30.06.2022 10:54, Roger Pau Monne wrote:
> Current code to calculate nr_irqs assumes the APIC destination mode to
> be physical, so all vectors on each possible CPU is available for use
> by a different interrupt source. This is not true when using Logical
> (Cluster) destination mode, where CPU
On 05/07/2022 14:56, Luca Fancellu wrote:
> After spending a bit of time to understand what the script does, I’ve checked
> the awk version
> and seems that the script is failing in the Docker container because there is
> mawk there:
> # awk -W version
> mawk 1.3.4 20200120
> Copyright 2008-2019,
On 30.06.2022 10:54, Roger Pau Monne wrote:
> Using nr_irqs minus nr_irqs_gsi is misleading, as GSI interrupts are
> not allocated unless requested by the hardware domain, so a hardware
> domain could not use any GSI (or just one for the ACPI SCI), and hence
> (almost) all nr_irqs will be available
On 30.06.2022 10:54, Roger Pau Monne wrote:
> When using an APIC do not set nr_irqs based on a factor of nr_irqs_gsi
> (currently x8), and instead do so exclusively based on the amount of
> available vectors on the system.
>
> There's no point in setting nr_irqs to a value higher than the
> availa
On 21.04.2022 15:21, Roger Pau Monne wrote:
> @@ -366,8 +383,11 @@ void cf_check amd_iommu_ioapic_update_ire(
> fresh = true;
> }
>
> -/* mask the interrupt while we change the intremap table */
> -if ( !saved_mask )
> +/*
> + * Mask the interrupt while we change the
On 21.04.2022 15:21, Roger Pau Monne wrote:
> --- a/xen/arch/x86/io_apic.c
> +++ b/xen/arch/x86/io_apic.c
> @@ -267,12 +267,47 @@ void __ioapic_write_entry(
> unsigned int apic, unsigned int pin, bool raw,
> struct IO_APIC_route_entry e)
> {
> -union entry_union eu = { .entry = e };
On 22.06.2022 16:37, Rahul Singh wrote:
> Event channel support will be added for dom0less domains to allocate
> static event channel. It is necessary to have access to the
> evtchn_bind_interdomain function to do that, so make
> evtchn_bind_interdomain global and also make it __must_check.
>
> Si
On 22.06.2022 16:51, Julien Grall wrote:
> On 22/06/2022 15:37, Rahul Singh wrote:
>> evtchn_alloc_unbound() always allocates the next available port. Static
>> event channel support for dom0less domains requires allocating a
>> specified port.
>>
>> Modify the evtchn_alloc_unbound() to accept the
On 22.06.2022 16:38, Rahul Singh wrote:
> @@ -387,8 +392,19 @@ int evtchn_bind_interdomain(evtchn_bind_interdomain_t
> *bind)
> spin_lock(&ld->event_lock);
> }
>
> -if ( (lport = get_free_port(ld)) < 0 )
> -ERROR_EXIT(lport);
> +if ( lport != 0 )
> +{
> +
On 22.06.2022 16:38, Rahul Singh wrote:
> evtchn_bind_interdomain() finds the local domain from "current->domain"
> pointer.
>
> evtchn_bind_interdomain() will be called from the XEN to support static
> event channel during domain creation. "current" pointer is not valid at
> that time, therefore
On 22.06.2022 16:38, Rahul Singh wrote:
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -119,6 +119,7 @@ struct evtchn
> unsigned char priority;/* FIFO event channels only. */
> unsigned short notify_vcpu_id; /* VCPU for local delivery notification */
> u
Hi Jan,
On 05/07/2022 16:11, Jan Beulich wrote:
On 22.06.2022 16:38, Rahul Singh wrote:
@@ -387,8 +392,19 @@ int evtchn_bind_interdomain(evtchn_bind_interdomain_t
*bind)
spin_lock(&ld->event_lock);
}
-if ( (lport = get_free_port(ld)) < 0 )
-ERROR_EXIT(lport);
+
On 22.06.2022 16:38, Rahul Singh wrote:
> evtchn_bind_interdomain() sets the notification on the local port to
> handle the lost notification on remote unbound port.
>
> Static event-channel will be created during domain creation, there is no
> need to set the notification as remote domain is not
On 22.06.2022 16:38, Rahul Singh wrote:
> --- a/xen/include/xen/event.h
> +++ b/xen/include/xen/event.h
> @@ -73,12 +73,12 @@ int evtchn_allocate_port(struct domain *d, unsigned int
> port);
>
> /* Allocate a new event channel */
> int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *
On 05.07.2022 17:26, Jan Beulich wrote:
> On 22.06.2022 16:38, Rahul Singh wrote:
>> --- a/xen/include/xen/event.h
>> +++ b/xen/include/xen/event.h
>> @@ -73,12 +73,12 @@ int evtchn_allocate_port(struct domain *d, unsigned int
>> port);
>>
>> /* Allocate a new event channel */
>> int __must_ch
On 05.07.2022 17:22, Julien Grall wrote:
> Hi Jan,
>
> On 05/07/2022 16:11, Jan Beulich wrote:
>> On 22.06.2022 16:38, Rahul Singh wrote:
>>> @@ -387,8 +392,19 @@ int evtchn_bind_interdomain(evtchn_bind_interdomain_t
>>> *bind)
>>> spin_lock(&ld->event_lock);
>>> }
>>>
>>> -
On 05.07.2022 17:04, Borislav Petkov wrote:
> On Thu, Apr 28, 2022 at 04:50:29PM +0200, Jan Beulich wrote:
>> --- a/arch/x86/mm/pat/memtype.c
>> +++ b/arch/x86/mm/pat/memtype.c
>> @@ -62,6 +62,7 @@
>>
>> static bool __read_mostly pat_bp_initialized;
>> static bool __read_mostly pat_disabled = !
On 09.06.2022 17:52, Jan Beulich wrote:
> With debug info retained, xen.efi can be quite large. Unlike for xen.gz
> there's no intermediate step (mkelf32 there) involved which would strip
> debug info kind of as a side effect. While the installing of xen.efi on
> the EFI partition is an optional st
On 26.04.2022 12:44, Julien Grall wrote:
> On 26/04/2022 11:33, Jan Beulich wrote:
>> See the code comment. The higher the rate of vCPU-s migrating across
>> pCPU-s, the less useful this attempted optimization actually is. With
>> credit2 the migration rate looks to be unduly high even on mostly id
On Tue, Jul 05, 2022 at 05:56:36PM +0200, Jan Beulich wrote:
> Re-using pat_disabled like you do in your suggestion below won't
> work, because mtrr_bp_init() calls pat_disable() when MTRRs
> appear to be disabled (from the kernel's view). The goal is to
> honor "nopat" without honoring any other c
On 11.01.2022 11:08, Jan Beulich wrote:
> On 16.12.2021 14:33, Jan Beulich wrote:
>> On 16.12.2021 12:54, Andrew Cooper wrote:
>>> On 13/12/2021 15:12, Jan Beulich wrote:
show_hvm_stack() requires interrupts to be enabled to avoids triggering
the consistency check in check_lock() for the
flight 171501 xen-unstable-smoke real [real]
flight 171504 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/171501/
http://logs.test-lab.xenproject.org/osstest/logs/171504/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which co
On Mon, Jul 4, 2022 at 11:57 AM Roger Pau Monné wrote:
>
> On Mon, Jul 04, 2022 at 11:44:14PM +0800, G.R. wrote:
> > On Mon, Jul 4, 2022 at 11:33 PM Roger Pau Monné
> > wrote:
> > >
> > > Right, so hvmloader attempts to place a BAR from 05:00.0 and a BAR
> > > from 00:17.0 into the same page, wh
On 7/5/22 09:03, Jason Andryuk wrote:
> On Wed, Jun 29, 2022 at 10:22 PM Daniel P. Smith
> wrote:
>>
>> The function flask_domain_alloc_security() is where a default sid should be
>> assigned to a domain under construction. For reasons unknown, the initial
>> domain would be assigned unlabeled_t a
Add the function prototypes of the functions below in header
file so that they are visible before the function definitions in traps.c.
enter_hypervisor_from_guest_preirq()
enter_hypervisor_from_guest()
do_trap_hyp_sync()
do_trap_guest_sync()
do_trap_irq()
do_trap_fiq()
leave_hypervisor_to_guest()
Resolve MISRA C 2012 Rule 8.4 violation warnings.
Xenia Ragiadakou (4):
xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violations
xen/common: time: Fix MISRA C 2012 Rule 8.7 violation
xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation
xen/char: pv_console: Fix MISRA C 2012 Rule 8.4 violation
The function pv_console_evtchn() is defined in the header .
If the header happens to be included by multiple files, this can result in
linker errors due to multiple definitions,
So, it is more appropriate to resolve this MISRA C 2012 Rule 8.4 violation
warning by making pv_console_evtchn() inline w
The variable __mon_lengths is referenced only in time.c.
Change its linkage from external to internal by adding the storage-class
specifier static to its definitions.
Also, this patch resolves indirectly a MISRA C 2012 Rule 8.4 violation warning.
Signed-off-by: Xenia Ragiadakou
---
xen/common/t
The function idle_loop() is referenced only in domain.c.
Change its linkage from external to internal by adding the storage-class
specifier static to its definitions.
Since idle_loop() is referenced only in inline assembly, add the 'used'
attribute to suppress unused-function compiler warning.
Al
flight 171506 xen-unstable-smoke real [real]
flight 171508 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/171506/
http://logs.test-lab.xenproject.org/osstest/logs/171508/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which co
Hi Xenia,
On 05/07/2022 22:02, Xenia Ragiadakou wrote:
Add the function prototypes of the functions below in header
file so that they are visible before the function definitions in traps.c.
enter_hypervisor_from_guest_preirq()
enter_hypervisor_from_guest()
do_trap_hyp_sync()
do_trap_guest_sync(
Hi Xenia,
On 05/07/2022 22:02, Xenia Ragiadakou wrote:
The variable __mon_lengths is referenced only in time.c.
Change its linkage from external to internal by adding the storage-class
specifier static to its definitions.
Also, this patch resolves indirectly a MISRA C 2012 Rule 8.4 violation wa
Hi Xenia,
On 05/07/2022 22:02, Xenia Ragiadakou wrote:
The function idle_loop() is referenced only in domain.c.
Change its linkage from external to internal by adding the storage-class
specifier static to its definitions.
Since idle_loop() is referenced only in inline assembly, add the 'used'
a
flight 171502 qemu-mainline real [real]
flight 171509 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/171502/
http://logs.test-lab.xenproject.org/osstest/logs/171509/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-am
Hi Xenia,
On 05/07/2022 22:02, Xenia Ragiadakou wrote:
The function pv_console_evtchn() is defined in the header .
If the header happens to be included by multiple files, this can result in
linker errors due to multiple definitions,
So, it is more appropriate to resolve this MISRA C 2012 Rule 8.
Hi Jan,
On 05/07/2022 17:10, Jan Beulich wrote:
On 26.04.2022 12:44, Julien Grall wrote:
On 26/04/2022 11:33, Jan Beulich wrote:
See the code comment. The higher the rate of vCPU-s migrating across
pCPU-s, the less useful this attempted optimization actually is. With
credit2 the migration rate
Hi Julien,
On 7/6/22 00:28, Julien Grall wrote:
Hi Xenia,
On 05/07/2022 22:02, Xenia Ragiadakou wrote:
Add the function prototypes of the functions below in
header
file so that they are visible before the function definitions in traps.c.
enter_hypervisor_from_guest_preirq()
enter_hypervisor_
Hi Jan,
On 05/07/2022 17:03, Jan Beulich wrote:
On 09.06.2022 17:52, Jan Beulich wrote:
With debug info retained, xen.efi can be quite large. Unlike for xen.gz
there's no intermediate step (mkelf32 there) involved which would strip
debug info kind of as a side effect. While the installing of xe
Hi Xenia,
On 05/07/2022 22:49, Xenia Ragiadakou wrote:
On 7/6/22 00:28, Julien Grall wrote:
Hi Xenia,
On 05/07/2022 22:02, Xenia Ragiadakou wrote:
Add the function prototypes of the functions below in
header
file so that they are visible before the function definitions in
traps.c.
enter_hy
Hi Xenia,
On 05/07/2022 13:21, Xenia Ragiadakou wrote:
Add the function prototype of show_stack() in header file
so that it is visible before its definition in traps.c.
Although show_stack() is referenced only in traps.c, it is declared with
external linkage because, during development, it is
Hi Julien,
On 7/6/22 00:38, Julien Grall wrote:
Hi Xenia,
On 05/07/2022 22:02, Xenia Ragiadakou wrote:
The function pv_console_evtchn() is defined in the header
.
If the header happens to be included by multiple files, this can
result in
linker errors due to multiple definitions,
So, it is m
On 30/06/2022 06:20, Jiamei Xie wrote:
Hi,
Hi Jiamei,
-Original Message-
From: Jiamei Xie
Sent: 2022年6月30日 9:54
To: xen-devel@lists.xenproject.org
Cc: Jiamei Xie ; Stefano Stabellini
; Julien Grall ; Bertrand Marquis
; Volodymyr Babchuk
; Wei Chen
Subject: [PATCH v3] xen/arm: avo
Hi Jiamei,
On 30/06/2022 02:53, Jiamei Xie wrote:
virt_vtimer_save is calculating the new time for the vtimer in:
"v->arch.virt_timer.cval + v->domain->arch.virt_timer_base.offset
- boot_count".
In this formula, "cval + offset" might cause uint64_t overflow.
Changing it to "ticks_to_ns(v->domain
On Tue, 5 Jul 2022, Julien Grall wrote:
> Hi Xenia,
>
> On 05/07/2022 22:49, Xenia Ragiadakou wrote:
> > On 7/6/22 00:28, Julien Grall wrote:
> > > Hi Xenia,
> > >
> > > On 05/07/2022 22:02, Xenia Ragiadakou wrote:
> > > > Add the function prototypes of the functions below in
> > > > header
> >
Hi Julien,
On 7/6/22 00:56, Julien Grall wrote:
On 05/07/2022 22:49, Xenia Ragiadakou wrote:
On 7/6/22 00:28, Julien Grall wrote:
Hi Xenia,
On 05/07/2022 22:02, Xenia Ragiadakou wrote:
Add the function prototypes of the functions below in
header
file so that they are visible before the func
flight 171503 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/171503/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277
test-amd64-amd64-li
1 - 100 of 112 matches
Mail list logo