Hi Xenia, On 05/07/2022 22:02, Xenia Ragiadakou wrote:
Add the function prototypes of the functions below in <asm/processor.h> header file so that they are visible before the function definitions in traps.c. enter_hypervisor_from_guest_preirq() enter_hypervisor_from_guest() do_trap_hyp_sync() do_trap_guest_sync() do_trap_irq() do_trap_fiq() leave_hypervisor_to_guest()
I have actually came across those missing prototypes in the past and I have refrained to add them because they are not meant to be called from C.
While I agree this is a violation of Misra C, I am still not convinced they should be added (there is no need to verify the prototype).
So IMHO, they should be marked as deviation. Cheers, -- Julien Grall
