Hi Xenia,
On 05/07/2022 13:21, Xenia Ragiadakou wrote:
Add the function prototype of show_stack() in <asm/processor.h> header file
so that it is visible before its definition in traps.c.
Although show_stack() is referenced only in traps.c, it is declared with
external linkage because, during development, it is often called also by
other files for debugging purposes. Declaring it static would increase
development effort. Add appropriate comment
Signed-off-by: Xenia Ragiadakou <burzalod...@gmail.com>
With one request below:
Acked-by: Julien Grall <jgr...@amazon.com>
---
xen/arch/arm/include/asm/processor.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/xen/arch/arm/include/asm/processor.h
b/xen/arch/arm/include/asm/processor.h
index 4188ec6bfb..c021160412 100644
--- a/xen/arch/arm/include/asm/processor.h
+++ b/xen/arch/arm/include/asm/processor.h
@@ -558,7 +558,9 @@ extern register_t __cpu_logical_map[];
void panic_PAR(uint64_t par);
void show_execution_state(const struct cpu_user_regs *regs);
+/* Debugging functions are declared with external linkage to aid development.
*/
I agree that those functions are only used for debugging today. But
there are no reason they can't be used in code in the future.
So I would like this comment to be dropped because it could easily
become stale.
If the others argue for keeping it, then I think...
void show_registers(const struct cpu_user_regs *regs);
+void show_stack(const struct cpu_user_regs *regs);
... we need a newline here so it is clearer which set of functions you
are referring to (at the moment one may think that
dump_execution_state()) is also included.
//#define dump_execution_state()
run_in_exception_handler(show_execution_state)
#define dump_execution_state() WARN()
Cheers,
--
Julien Grall
