Re: [PATCH] Fix spelling errors.

2020-12-01 Thread Jan Beulich
On 30.11.2020 18:39, Diederik de Haas wrote: > --- a/xen/arch/x86/cpu/vpmu.c > +++ b/xen/arch/x86/cpu/vpmu.c > @@ -680,7 +680,7 @@ static void pvpmu_finish(struct domain *d, > xen_pmu_params_t *params) > vcpu_unpause(v); > } > > -/* Dump some vpmu informations on console. Used in keyha

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-12-01 Thread Gustavo A. R. Silva
On Tue, Dec 01, 2020 at 12:52:27AM -0500, Martin K. Petersen wrote: > > Gustavo, > > > This series aims to fix almost all remaining fall-through warnings in > > order to enable -Wimplicit-fallthrough for Clang. > > Applied 20-22,54,120-124 to 5.11/scsi-staging, thanks. Awesome! :) Thanks, Mart

[PATCH v2 01/17] xen/cpupool: add cpu to sched_res_mask when removing it from cpupool

2020-12-01 Thread Juergen Gross
When a cpu is removed from a cpupool and added to the free cpus it should be added to sched_res_mask, too. The related removal from sched_res_mask in case of core scheduling is already done in schedule_cpu_add(). As long as all cpupools share the same scheduling granularity there is nothing going

[PATCH v2 03/17] xen/cpupool: sort included headers in cpupool.c

2020-12-01 Thread Juergen Gross
Common style is to include header files in alphabetical order. Sort the #include statements in cpupool.c accordingly. Signed-off-by: Juergen Gross Acked-by: Dario Faggioli --- xen/common/sched/cpupool.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/common/sched

[PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-01 Thread Juergen Gross
The cpupool id is an unsigned value in the public interface header, so there is no reason why it is a signed value in struct cpupool. Switch it to unsigned int. Signed-off-by: Juergen Gross --- V2: - new patch --- xen/common/sched/core.c| 2 +- xen/common/sched/cpupool.c | 48 +

[PATCH v2 00/17] xen: support per-cpupool scheduling granularity

2020-12-01 Thread Juergen Gross
Support scheduling granularity per cpupool. Setting the granularity is done via hypfs, which needed to gain dynamical entries for that purpose. Apart from the hypfs related additional functionality the main change for cpupools was the support for moving a domain to a new granularity, as this requi

[PATCH v2 08/17] docs: fix hypfs path documentation

2020-12-01 Thread Juergen Gross
The /params/* entry is missing a writable tag. Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- docs/misc/hypfs-paths.pandoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/misc/hypfs-paths.pandoc b/docs/misc/hypfs-paths.pandoc index dddb592bc5..6c7b2f7ee3 100644

[PATCH v2 02/17] xen/cpupool: add missing bits for per-cpupool scheduling granularity

2020-12-01 Thread Juergen Gross
Even with storing the scheduling granularity in struct cpupool there are still a few bits missing for being able to have cpupools with different granularity (apart from the missing interface for setting the individual granularities): the number of cpus in a scheduling unit is always taken from the

[PATCH v2 06/17] xen/cpupool: use ERR_PTR() for returning error cause from cpupool_create()

2020-12-01 Thread Juergen Gross
Instead of a pointer to an error variable as parameter just use ERR_PTR() to return the cause of an error in cpupool_create(). This propagates to scheduler_alloc(), too. Signed-off-by: Juergen Gross --- V2: - new patch --- xen/common/sched/core.c| 13 ++--- xen/common/sched/cpupool.

[PATCH v2 05/17] xen/cpupool: switch cpupool list to normal list interface

2020-12-01 Thread Juergen Gross
Instead of open coding something like a linked list just use the available functionality from list.h. The allocation of a new cpupool id is not aware of a possible wrap. Fix that. While adding the required new include to private.h sort the includes. Signed-off-by: From: Juergen Gross --- V2: -

[PATCH v2 09/17] xen/hypfs: move per-node function pointers into a dedicated struct

2020-12-01 Thread Juergen Gross
Move the function pointers currently stored in each hypfs node into a dedicated structure in order to save some space for each node. This will save even more space with additional callbacks added in future. Provide some standard function vectors. Instead of testing the write pointer to be not NUL

[PATCH v2 07/17] xen/cpupool: support moving domain between cpupools with different granularity

2020-12-01 Thread Juergen Gross
When moving a domain between cpupools with different scheduling granularity the sched_units of the domain need to be adjusted. Do that by allocating new sched_units and throwing away the old ones in sched_move_domain(). Signed-off-by: Juergen Gross --- xen/common/sched/core.c | 121

[PATCH v2 16/17] xen/cpupool: add scheduling granularity entry to cpupool entries

2020-12-01 Thread Juergen Gross
Add a "sched-gran" entry to the per-cpupool hypfs directories. For now make this entry read-only and let it contain one of the strings "cpu", "core" or "socket". Signed-off-by: Juergen Gross --- V2: - added const (Jan Beulich) - modify test in cpupool_gran_read() (Jan Beulich) --- docs/misc/hyp

[PATCH v2 10/17] xen/hypfs: pass real failure reason up from hypfs_get_entry()

2020-12-01 Thread Juergen Gross
Instead of handling all errors from hypfs_get_entry() as ENOENT pass up the real error value via ERR_PTR(). Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- xen/common/hypfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/common/hypfs.c b/xen/comm

[PATCH v2 11/17] xen/hypfs: add getsize() and findentry() callbacks to hypfs_funcs

2020-12-01 Thread Juergen Gross
Add a getsize() function pointer to struct hypfs_funcs for being able to have dynamically filled entries without the need to take the hypfs lock each time the contents are being generated. For directories add a findentry callback to the vector and modify hypfs_get_entry_rel() to use it. Signed-of

[PATCH v2 13/17] xen/hypfs: support dynamic hypfs nodes

2020-12-01 Thread Juergen Gross
Add a HYPFS_VARDIR_INIT() macro for initializing such a directory statically, taking a struct hypfs_funcs pointer as parameter additional to those of HYPFS_DIR_INIT(). Modify HYPFS_VARSIZE_INIT() to take the function vector pointer as an additional parameter as this will be needed for dynamical en

[PATCH v2 17/17] xen/cpupool: make per-cpupool sched-gran hypfs node writable

2020-12-01 Thread Juergen Gross
Make /cpupool//sched-gran in hypfs writable. This will enable per cpupool selectable scheduling granularity. Writing this node is allowed only with no cpu assigned to the cpupool. Allowed are values "cpu", "core" and "socket". Signed-off-by: Juergen Gross --- V2: - test user parameters earlier (

[PATCH v2 12/17] xen/hypfs: add new enter() and exit() per node callbacks

2020-12-01 Thread Juergen Gross
In order to better support resource allocation and locking for dynamic hypfs nodes add enter() and exit() callbacks to struct hypfs_funcs. The enter() callback is called when entering a node during hypfs user actions (traversing, reading or writing it), while the exit() callback is called when lea

[PATCH v2 14/17] xen/hypfs: add support for id-based dynamic directories

2020-12-01 Thread Juergen Gross
Add some helpers to hypfs.c to support dynamic directories with a numerical id as name. The dynamic directory is based on a template specified by the user allowing to use specific access functions and having a predefined set of entries in the directory. Signed-off-by: Juergen Gross --- V2: - use

[PATCH v2 15/17] xen/cpupool: add cpupool directories

2020-12-01 Thread Juergen Gross
Add /cpupool/ directories to hypfs. Those are completely dynamic, so the related hypfs access functions need to be implemented. Signed-off-by: Juergen Gross --- V2: - added const (Jan Beulich) - call hypfs_add_dir() in helper (Dario Faggioli) - switch locking to enter/exit callbacks --- docs/mis

[libvirt test] 157125: regressions - FAIL

2020-12-01 Thread osstest service owner
flight 157125 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/157125/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

[qemu-mainline test] 157116: regressions - FAIL

2020-12-01 Thread osstest service owner
flight 157116 qemu-mainline real [real] flight 157127 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157116/ http://logs.test-lab.xenproject.org/osstest/logs/157127/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-01 Thread Jan Beulich
On 01.12.2020 09:21, Juergen Gross wrote: > @@ -243,11 +243,11 @@ void cpupool_put(struct cpupool *pool) > * - unknown scheduler > */ > static struct cpupool *cpupool_create( > -int poolid, unsigned int sched_id, int *perr) > +unsigned int poolid, unsigned int sched_id, int *perr) > {

Re: [PATCH v2 15/17] xen/cpupool: add cpupool directories

2020-12-01 Thread Jan Beulich
On 01.12.2020 09:21, Juergen Gross wrote: > Add /cpupool/ directories to hypfs. Those are completely > dynamic, so the related hypfs access functions need to be implemented. > > Signed-off-by: Juergen Gross > --- > V2: > - added const (Jan Beulich) Any particular reason this doesn't extend to ..

Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-01 Thread Jürgen Groß
On 01.12.20 09:55, Jan Beulich wrote: On 01.12.2020 09:21, Juergen Gross wrote: @@ -243,11 +243,11 @@ void cpupool_put(struct cpupool *pool) * - unknown scheduler */ static struct cpupool *cpupool_create( -int poolid, unsigned int sched_id, int *perr) +unsigned int poolid, unsign

Re: [PATCH v2 15/17] xen/cpupool: add cpupool directories

2020-12-01 Thread Jürgen Groß
On 01.12.20 10:00, Jan Beulich wrote: On 01.12.2020 09:21, Juergen Gross wrote: Add /cpupool/ directories to hypfs. Those are completely dynamic, so the related hypfs access functions need to be implemented. Signed-off-by: Juergen Gross --- V2: - added const (Jan Beulich) Any particular reas

Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-01 Thread Jan Beulich
On 01.12.2020 10:01, Jürgen Groß wrote: > On 01.12.20 09:55, Jan Beulich wrote: >> On 01.12.2020 09:21, Juergen Gross wrote: >>> @@ -243,11 +243,11 @@ void cpupool_put(struct cpupool *pool) >>>* - unknown scheduler >>>*/ >>> static struct cpupool *cpupool_create( >>> -int poolid, unsi

Re: [PATCH v2 05/17] xen/cpupool: switch cpupool list to normal list interface

2020-12-01 Thread Jan Beulich
On 01.12.2020 09:21, Juergen Gross wrote: > @@ -260,23 +257,42 @@ static struct cpupool *cpupool_create( > > spin_lock(&cpupool_lock); > > -for_each_cpupool(q) > +if ( poolid != CPUPOOLID_NONE ) > { > -last = (*q)->cpupool_id; > -if ( (poolid != CPUPOOLID_NONE)

Re: [PATCH v2 05/17] xen/cpupool: switch cpupool list to normal list interface

2020-12-01 Thread Jürgen Groß
On 01.12.20 10:12, Jan Beulich wrote: On 01.12.2020 09:21, Juergen Gross wrote: @@ -260,23 +257,42 @@ static struct cpupool *cpupool_create( spin_lock(&cpupool_lock); -for_each_cpupool(q) +if ( poolid != CPUPOOLID_NONE ) { -last = (*q)->cpupool_id; -if

[linux-linus test] 157119: regressions - FAIL

2020-12-01 Thread osstest service owner
flight 157119 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/157119/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Julien Grall
On 30/11/2020 23:27, Oleksandr wrote: On 30.11.20 23:03, Volodymyr Babchuk wrote: Hi, Hi Volodymyr Oleksandr Tyshchenko writes: From: Oleksandr Tyshchenko In order to avoid code duplication (both handle_read() and handle_ioserv() contain the same code for the sign-extension) put th

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Julien Grall
Hi Jan, On 01/12/2020 07:55, Jan Beulich wrote: On 01.12.2020 00:27, Oleksandr wrote: On 30.11.20 23:03, Volodymyr Babchuk wrote: Oleksandr Tyshchenko writes: --- a/xen/include/asm-arm/traps.h +++ b/xen/include/asm-arm/traps.h @@ -83,6 +83,30 @@ static inline bool VABORT_GEN_BY_GUEST(const st

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Oleksandr
On 01.12.20 12:30, Julien Grall wrote: Hi Julien Hi Jan, On 01/12/2020 07:55, Jan Beulich wrote: On 01.12.2020 00:27, Oleksandr wrote: On 30.11.20 23:03, Volodymyr Babchuk wrote: Oleksandr Tyshchenko writes: --- a/xen/include/asm-arm/traps.h +++ b/xen/include/asm-arm/traps.h @@ -83,6 +83

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Jan Beulich
On 01.12.2020 11:30, Julien Grall wrote: > Hi Jan, > > On 01/12/2020 07:55, Jan Beulich wrote: >> On 01.12.2020 00:27, Oleksandr wrote: >>> On 30.11.20 23:03, Volodymyr Babchuk wrote: Oleksandr Tyshchenko writes: > --- a/xen/include/asm-arm/traps.h > +++ b/xen/include/asm-arm/traps.h

Re: [PATCH V3 01/23] x86/ioreq: Prepare IOREQ feature for making it common

2020-12-01 Thread Alex Bennée
Oleksandr Tyshchenko writes: > From: Oleksandr Tyshchenko > > As a lot of x86 code can be re-used on Arm later on, this > patch makes some preparation to x86/hvm/ioreq.c before moving > to the common code. This way we will get a verbatim copy > > It worth mentioning that a code which checks t

Re: [PATCH V3 02/23] x86/ioreq: Add IOREQ_STATUS_* #define-s and update code for moving

2020-12-01 Thread Alex Bennée
Oleksandr Tyshchenko writes: > From: Oleksandr Tyshchenko > > This patch continues to make some preparation to x86/hvm/ioreq.c > before moving to the common code. > > Add IOREQ_STATUS_* #define-s and update candidates for moving > since X86EMUL_* shouldn't be exposed to the common code in > th

Re: [PATCH v2 3/7] xen/arm: create a cpuinfo structure for guest

2020-12-01 Thread Bertrand Marquis
Hi Volodymyr, > On 30 Nov 2020, at 20:15, Volodymyr Babchuk > wrote: > > > Bertrand Marquis writes: > >> Create a cpuinfo structure for guest and mask into it the features that >> we do not support in Xen or that we do not want to publish to guests. >> >> Modify some values in the cpuinfo st

Re: [PATCH v2 4/7] xen/arm: Add handler for ID registers on arm64

2020-12-01 Thread Bertrand Marquis
Hi Volodymyr, > On 30 Nov 2020, at 20:22, Volodymyr Babchuk > wrote: > > > > Bertrand Marquis writes: > >> Add vsysreg emulation for registers trapped when TID3 bit is activated >> in HSR. >> The emulation is returning the value stored in cpuinfo_guest structure >> for most values and the ha

Re: [PATCH v2 5/7] xen/arm: Add handler for cp15 ID registers

2020-12-01 Thread Bertrand Marquis
Hi, > On 30 Nov 2020, at 20:31, Volodymyr Babchuk > wrote: > > > Bertrand Marquis writes: > >> Add support for emulation of cp15 based ID registers (on arm32 or when >> running a 32bit guest on arm64). >> The handlers are returning the values stored in the guest_cpuinfo >> structure. >> In th

Re: [PATCH v2 4/7] xen/arm: Add handler for ID registers on arm64

2020-12-01 Thread Volodymyr Babchuk
Hi Bertrand, Bertrand Marquis writes: > Hi Volodymyr, > >> On 30 Nov 2020, at 20:22, Volodymyr Babchuk >> wrote: >> >> >> >> Bertrand Marquis writes: >> >>> Add vsysreg emulation for registers trapped when TID3 bit is activated >>> in HSR. >>> The emulation is returning the value stored i

Re: [PATCH v2 5/7] xen/arm: Add handler for cp15 ID registers

2020-12-01 Thread Volodymyr Babchuk
Hi, Bertrand Marquis writes: > Hi, > >> On 30 Nov 2020, at 20:31, Volodymyr Babchuk >> wrote: >> >> >> Bertrand Marquis writes: >> >>> Add support for emulation of cp15 based ID registers (on arm32 or when >>> running a 32bit guest on arm64). >>> The handlers are returning the values stored

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Julien Grall
Hi Oleksandr, On 01/12/2020 10:42, Oleksandr wrote: On 01.12.20 12:30, Julien Grall wrote: Hi Julien Hi Jan, On 01/12/2020 07:55, Jan Beulich wrote: On 01.12.2020 00:27, Oleksandr wrote: On 30.11.20 23:03, Volodymyr Babchuk wrote: Oleksandr Tyshchenko writes: --- a/xen/include/asm-arm/t

Apple on Xen?

2020-12-01 Thread Jason Long
Hello, According to this news (https://aws.amazon.com/blogs/aws/new-use-mac-instances-to-build-test-macos-ios-ipados-tvos-and-watchos-apps/), Amazon EC2 can run macOS. Is it OK for Xen Project too? Thanks. 

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Oleksandr
On 01.12.20 14:13, Julien Grall wrote: Hi Oleksandr, Hi Julien. --- a/xen/include/asm-arm/traps.h +++ b/xen/include/asm-arm/traps.h @@ -83,6 +83,30 @@ static inline bool VABORT_GEN_BY_GUEST(const struct cpu_user_regs *regs)    (unsigned long)abort_guest_exit_end == regs->pc;   

Re: [PATCH V3 19/23] xen/arm: io: Abstract sign-extension

2020-12-01 Thread Julien Grall
On 01/12/2020 12:24, Oleksandr wrote: On 01.12.20 14:13, Julien Grall wrote: Hi Oleksandr, Hi Julien. --- a/xen/include/asm-arm/traps.h +++ b/xen/include/asm-arm/traps.h @@ -83,6 +83,30 @@ static inline bool VABORT_GEN_BY_GUEST(const struct cpu_user_regs *regs)    (unsigned

Re: [PATCH v4 01/23] xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > The seemingly arbitrary use of 'pci' and 'pcidev' in the code in libxl_pci.c > is confusing and also compromises use of some macros used for other device > types. Indeed it seems that DEFINE_DEVICE_TYPE_STRUCT_X exists s

Re: [PATCH V3 15/23] xen/arm: Stick around in leave_hypervisor_to_guest until I/O has completed

2020-12-01 Thread Julien Grall
Hi Volodymyr, On 30/11/2020 20:51, Volodymyr Babchuk wrote: Oleksandr Tyshchenko writes: From: Oleksandr Tyshchenko This patch adds proper handling of return value of vcpu_ioreq_handle_completion() which involves using a loop in leave_hypervisor_to_guest(). The reason to use an unbounded lo

Re: [PATCH v4 02/23] libxl: make libxl__device_list() work correctly for LIBXL__DEVICE_KIND_PCI...

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > ... devices. > > Currently there is an assumption built into libxl__device_list() that device > backends are fully enumarated under the '/libxl' path in xenstore. This is > not the case for PCI backend devices, which are

[xen-unstable test] 157123: tolerable FAIL

2020-12-01 Thread osstest service owner
flight 157123 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/157123/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 157115 pass in 157123 test-armhf-ar

Re: [PATCH v4 03/23] libxl: Make sure devices added by pci-attach are reflected in the config

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > Currently libxl__device_pci_add_xenstore() is broken in that does not > update the domain's configuration for the first device added (which causes > creation of the overall backend area in xenstore). This can be easily o

Re: [PATCH v4 04/23] libxl: add/recover 'rdm_policy' to/from PCI backend in xenstore

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > Other parameters, such as 'msitranslate' and 'permissive' are dealt with > but 'rdm_policy' appears to be have been completely missed. > > Signed-off-by: Paul Durrant Reviewed-by: Oleksandr Andrushchenko Thank you,

Re: [PATCH v4 05/23] libxl: s/detatched/detached in libxl_pci.c

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: From: Paul Durrant Simply spelling correction. Purely cosmetic fix. Signed-off-by: Paul Durrant Reviewed-by: Oleksandr Andrushchenko Thank you, Oleksandr --- Cc: Ian Jackson Cc: Wei Liu --- tools/libs/light/libxl_pci.c | 22 +

Re: [PATCH v4 06/23] libxl: remove extraneous arguments to do_pci_remove() in libxl_pci.c

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > Both 'domid' and 'pci' are available in 'pci_remove_state' so there is no > need to also pass them as separate arguments. > > Signed-off-by: Paul Durrant Reviewed-by: Oleksandr Andrushchenko Thank you, Oleksandr >

Re: [PATCH v4 07/23] libxl: stop using aodev->device_config in libxl__device_pci_add()...

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > ... to hold a pointer to the device. > > There is already a 'pci' field in 'pci_add_state' so simply use that from > the start. This also allows the 'pci' (#3) argument to be dropped from > do_pci_add(). > > NOTE: This p

Re: [PATCH v4 08/23] libxl: generalise 'driver_path' xenstore access functions in libxl_pci.c

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > For the purposes of re-binding a device to its previous driver > libxl__device_pci_assignable_add() writes the driver path into xenstore. > This path is then read back in libxl__device_pci_assignable_remove(). > > The fu

Re: [PATCH v4 09/23] libxl: remove unnecessary check from libxl__device_pci_add()

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > The code currently checks explicitly whether the device is already assigned, > but this is actually unnecessary as assigned devices do not form part of > the list returned by libxl_device_pci_assignable_list() and hence

Re: [PATCH v2 6/7] xen/arm: Add CP10 exception support to handle VMFR

2020-12-01 Thread Bertrand Marquis
Hi, > On 30 Nov 2020, at 20:39, Volodymyr Babchuk > wrote: > > > Bertrand Marquis writes: > >> Add support for cp10 exceptions decoding to be able to emulate the >> values for VMFR0 and VMFR1 when TID3 bit of HSR is activated. >> This is required for aarch32 guests accessing VMFR0 and VMFR1 u

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-12-01 Thread Dan Carpenter
On Sun, Nov 22, 2020 at 08:17:03AM -0800, Kees Cook wrote: > On Fri, Nov 20, 2020 at 11:51:42AM -0800, Jakub Kicinski wrote: > > On Fri, 20 Nov 2020 11:30:40 -0800 Kees Cook wrote: > > > On Fri, Nov 20, 2020 at 10:53:44AM -0800, Jakub Kicinski wrote: > > > > On Fri, 20 Nov 2020 12:21:39 -0600 Gusta

RE: [EXTERNAL] [PATCH v3 00/13] viridian: add support for ExProcessorMasks...

2020-12-01 Thread Paul Durrant
Wei, I'll likely send a v4 to address the style nit Jan picked up in patch #1 but the rest should be stable now. Could you have a look over it? Thanks, Paul > -Original Message- > From: Paul Durrant > Sent: 24 November 2020 19:08 > To: xen-devel@lists.xenproject.org > Cc: Durr

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-12-01 Thread Dan Carpenter
On Mon, Nov 23, 2020 at 05:32:51PM -0800, Nick Desaulniers wrote: > On Sun, Nov 22, 2020 at 8:17 AM Kees Cook wrote: > > > > On Fri, Nov 20, 2020 at 11:51:42AM -0800, Jakub Kicinski wrote: > > > If none of the 140 patches here fix a real bug, and there is no change > > > to machine code then it so

Re: [PATCH v4 10/23] libxl: remove get_all_assigned_devices() from libxl_pci.c

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > Use of this function is a very inefficient way to check whether a device > has already been assigned. > > This patch adds code that saves the domain id in xenstore at the point of > assignment, and removes it again when

Re: [PATCH v2 5/7] xen/arm: Add handler for cp15 ID registers

2020-12-01 Thread Bertrand Marquis
Hi Volodymyr, > On 1 Dec 2020, at 12:07, Volodymyr Babchuk wrote: > > > Hi, > > Bertrand Marquis writes: > >> Hi, >> >>> On 30 Nov 2020, at 20:31, Volodymyr Babchuk >>> wrote: >>> >>> >>> Bertrand Marquis writes: >>> Add support for emulation of cp15 based ID registers (on arm32 or

[PATCH for-4.14] Fix spelling errors.

2020-12-01 Thread Diederik de Haas
Only spelling errors; no functional changes. In docs/misc/dump-core-format.txt there are a few more instances of 'informations'. I'll leave that up to someone who can properly determine how those sentences should be constructed. Signed-off-by: Diederik de Haas --- I incorporated the remarks by

Re: [PATCH for-4.14] Fix spelling errors.

2020-12-01 Thread Jan Beulich
On 01.12.2020 15:42, Diederik de Haas wrote: > Only spelling errors; no functional changes. > > In docs/misc/dump-core-format.txt there are a few more instances of > 'informations'. I'll leave that up to someone who can properly determine > how those sentences should be constructed. > > Signed-of

Re: [PATCH v4 11/23] libxl: make sure callers of libxl_device_pci_list() free the list after use

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > A previous patch introduced libxl_device_pci_list_free() which should be used > by callers of libxl_device_pci_list() to properly dispose of the exported > 'libxl_device_pci' types and the free the memory holding them. W

Re: [PATCH v4 12/23] libxl: add libxl_device_pci_assignable_list_free()...

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > ... to be used by callers of libxl_device_pci_assignable_list(). > > Currently there is no API for callers of libxl_device_pci_assignable_list() > to free the list. The xl function pciassignable_list() calls > libxl_devi

Re: [PATCH v4 13/23] libxl: use COMPARE_PCI() macro is_pci_in_array()...

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > ... rather than an open-coded equivalent. > > This patch tidies up the is_pci_in_array() function, making it take a single > 'libxl_device_pci' argument rather than separate domain, bus, device and > function arguments.

Re: [PATCH for-4.14] Fix spelling errors.

2020-12-01 Thread Diederik de Haas
On dinsdag 1 december 2020 16:10:13 CET Jan Beulich wrote: > I'm afraid this isn't the kind of change we'd be backporting, Ok, I didn't know that. > unless you have a very good justification for a respective request. I was fixing issues found by Debian's lintian tool and 4.14 is currently in

Re: [PATCH v4 14/23] docs/man: extract documentation of PCI_SPEC_STRING from the xl.cfg manpage...

2020-12-01 Thread Oleksandr Andrushchenko
Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > ... and put it into a new xl-pci-configuration(5) manpage, akin to the > xl-network-configration(5) and xl-disk-configuration(5) manpages. > > This patch moves the content of the section verbatim. A subsequent patch > wi

Re: [PATCH v2 5/7] xen/arm: Add handler for cp15 ID registers

2020-12-01 Thread Volodymyr Babchuk
Hi, Bertrand Marquis writes: > Hi Volodymyr, > >> On 1 Dec 2020, at 12:07, Volodymyr Babchuk >> wrote: >> >> >> Hi, >> >> Bertrand Marquis writes: >> >>> Hi, >>> On 30 Nov 2020, at 20:31, Volodymyr Babchuk wrote: Bertrand Marquis writes: > Add suppor

[PATCH] vpci/msix: exit early if MSI-X is disabled

2020-12-01 Thread Roger Pau Monne
Do not attempt to mask an MSI-X entry if MSI-X is not enabled. Else it will lead to hitting the following assert on debug builds: (XEN) Panic on CPU 13: (XEN) Assertion 'entry->arch.pirq != INVALID_PIRQ' failed at vmsi.c:843 In order to fix it exit early from the switch in msix_write if MSI-X is

Re: [PATCH V3 01/23] x86/ioreq: Prepare IOREQ feature for making it common

2020-12-01 Thread Oleksandr
On 01.12.20 13:03, Alex Bennée wrote: Hi Alex Oleksandr Tyshchenko writes: From: Oleksandr Tyshchenko As a lot of x86 code can be re-used on Arm later on, this patch makes some preparation to x86/hvm/ioreq.c before moving to the common code. This way we will get a verbatim copy It wor

Re: [PATCH V3 01/23] x86/ioreq: Prepare IOREQ feature for making it common

2020-12-01 Thread Alex Bennée
Oleksandr writes: > On 01.12.20 13:03, Alex Bennée wrote: > > Hi Alex > >> Oleksandr Tyshchenko writes: >> >>> From: Oleksandr Tyshchenko >>> >>> As a lot of x86 code can be re-used on Arm later on, this >>> patch makes some preparation to x86/hvm/ioreq.c before moving >>> to the common code.

[qemu-mainline test] 157129: regressions - FAIL

2020-12-01 Thread osstest service owner
flight 157129 qemu-mainline real [real] flight 157140 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157129/ http://logs.test-lab.xenproject.org/osstest/logs/157140/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

[linux-linus test] 157131: regressions - trouble: broken/fail/pass

2020-12-01 Thread osstest service owner
flight 157131 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/157131/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl broken test-amd64-i386-qemut-rhel6hvm-intel 7 xe

Re: [PATCH v2 1/8] xen/arm: Import the SMMUv3 driver from Linux

2020-12-01 Thread Stefano Stabellini
On Thu, 26 Nov 2020, Rahul Singh wrote: > Based on tag Linux 5.9.8 commit 951cbbc386ff01b50da4f46387e994e81d9ab431 > > It's a copy of the Linux SMMUv3 driver. Xen specific code has not > been added yet and code has not been compiled. > > Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini

Re: [PATCH v2 2/8] xen/arm: revert atomic operation related command-queue insertion patch

2020-12-01 Thread Stefano Stabellini
On Thu, 26 Nov 2020, Rahul Singh wrote: > Linux SMMUv3 code implements the commands-queue insertion based on > atomic operations implemented in Linux. Atomic functions used by the > commands-queue insertion is not implemented in XEN therefore revert the > patch that implemented the commands-queue i

Re: [PATCH v2 3/8] xen/arm: revert patch related to XArray

2020-12-01 Thread Stefano Stabellini
On Thu, 26 Nov 2020, Rahul Singh wrote: > XArray is not implemented in XEN revert the patch that introduce the > XArray code in SMMUv3 driver. > > Once XArray is implemented in XEN this patch can be added in XEN. > > Reverted the commit 0299a1a81ca056e79c1a7fb751f936ec0d5c7afe > > Signed-off-by:

Re: [PATCH v2 4/8] xen/arm: Remove support for MSI on SMMUv3

2020-12-01 Thread Stefano Stabellini
On Thu, 26 Nov 2020, Rahul Singh wrote: > XEN does not support MSI on ARM platforms, therefore remove the MSI > support from SMMUv3 driver. > > Signed-off-by: Rahul Singh I wonder if it makes sense to #ifdef CONFIG_MSI this code instead of removing it completely. In the past, we tried to keep

Re: [PATCH v2 5/8] xen/arm: Remove support for PCI ATS on SMMUv3

2020-12-01 Thread Stefano Stabellini
On Thu, 26 Nov 2020, Rahul Singh wrote: > PCI ATS functionality is not implemented and tested on ARM. Remove the > PCI ATS support, once PCI ATS support is tested and available this > patch can be added. > > Signed-off-by: Rahul Singh This looks like a revert of 9ce27afc0830f. Can we add that as

Re: [PATCH v2 4/8] xen/arm: Remove support for MSI on SMMUv3

2020-12-01 Thread Stefano Stabellini
On Tue, 1 Dec 2020, Stefano Stabellini wrote: > On Thu, 26 Nov 2020, Rahul Singh wrote: > > XEN does not support MSI on ARM platforms, therefore remove the MSI > > support from SMMUv3 driver. > > > > Signed-off-by: Rahul Singh > > I wonder if it makes sense to #ifdef CONFIG_MSI this code instead

[xen-4.14-testing test] 157133: tolerable FAIL - PUSHED

2020-12-01 Thread osstest service owner
flight 157133 xen-4.14-testing real [real] flight 157144 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157133/ http://logs.test-lab.xenproject.org/osstest/logs/157144/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [PATCH v2 6/8] xen/arm: Remove support for Stage-1 translation on SMMUv3.

2020-12-01 Thread Stefano Stabellini
On Thu, 26 Nov 2020, Rahul Singh wrote: > Linux SMMUv3 driver supports both Stage-1 and Stage-2 translations. > As of now only Stage-2 translation support has been tested. > > Once Stage-1 translation support is tested this patch can be added. > > Signed-off-by: Rahul Singh [...] > @@ -1871,1

Re: [PATCH v2 7/8] xen/arm: Remove Linux specific code that is not usable in XEN

2020-12-01 Thread Stefano Stabellini
On Thu, 26 Nov 2020, Rahul Singh wrote: > struct io_pgtable_ops, struct io_pgtable_cfg, struct iommu_flush_ops, > and struct iommu_ops related code are linux specific. > > Remove code related to above struct as code is dead code in XEN. There are still instances of struct io_pgtable_cfg after app

Re: Apple on Xen?

2020-12-01 Thread Roman Shaposhnik
On Tue, Dec 1, 2020 at 4:22 AM Jason Long wrote: > > Hello, > According to this news > (https://aws.amazon.com/blogs/aws/new-use-mac-instances-to-build-test-macos-ios-ipados-tvos-and-watchos-apps/), > Amazon EC2 can run macOS. > Is it OK for Xen Project too? Amazon recently clarified that these

Re: [PATCH v2 8/8] xen/arm: Add support for SMMUv3 driver

2020-12-01 Thread Stefano Stabellini
On Thu, 26 Nov 2020, Rahul Singh wrote: > Add support for ARM architected SMMUv3 implementation. It is based on > the Linux SMMUv3 driver. > > Major differences with regard to Linux driver are as follows: > 1. Only Stage-2 translation is supported as compared to the Linux driver >that supports

[xen-4.12-testing test] 157134: tolerable FAIL - PUSHED

2020-12-01 Thread osstest service owner
flight 157134 xen-4.12-testing real [real] flight 157148 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157134/ http://logs.test-lab.xenproject.org/osstest/logs/157148/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [PATCH v2] tools/libs/ctrl: fix dumping of ballooned guest

2020-12-01 Thread Jürgen Groß
On 20.11.20 16:33, Jürgen Groß wrote: On 11.11.20 11:01, Juergen Gross wrote: A guest with memory < maxmem often can't be dumped via xl dump-core without an error message today: xc: info: exceeded nr_pages (262144) losing pages In case the last page of the guest isn't allocated the loop in xc_

[PATCH v9] xen/events: do some cleanups in evtchn_fifo_set_pending()

2020-12-01 Thread Juergen Gross
evtchn_fifo_set_pending() can be simplified a little bit. Especially testing for the fifo control block to exist can be moved out of the main if clause of the function enabling to avoid testing the LINKED bit twice. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross --- V8: - new patch V9:

[xen-4.13-testing test] 157135: tolerable FAIL - PUSHED

2020-12-01 Thread osstest service owner
flight 157135 xen-4.13-testing real [real] flight 157152 xen-4.13-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157135/ http://logs.test-lab.xenproject.org/osstest/logs/157152/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t