Re: [PATCH v2 01/11] swiotlb-xen: use vmalloc_to_page on vmalloc virt addresses

2020-06-08 Thread Christoph Hellwig
Well, this isn't just RPi4, but basically any ARM or ARM64 system with non-coherent DMA (which is most of them). > + struct page *pg; Please spell out page. > > if (hwdev && hwdev->coherent_dma_mask) > dma_mask = hwdev->coherent_dma_mask; > @@ -346,9 +347,11 @@ xen_swio

Re: [PATCH v2 04/11] swiotlb-xen: add struct device* parameter to xen_bus_to_phys

2020-06-08 Thread Christoph Hellwig
Same comment as for the last one. Also in the subject a whitespace is missing after "device" and before "*".

Re: [PATCH v2 03/11] swiotlb-xen: add struct device* parameter to xen_phys_to_bus

2020-06-08 Thread Christoph Hellwig
On Wed, Jun 03, 2020 at 03:22:39PM -0700, Stefano Stabellini wrote: > From: Stefano Stabellini > > The parameter is unused in this patch. > No functional changes. This looks weird. I'm pretty sure you are going to use it later, but why not just add the argument when it actually is used?

Re: [PATCH v2 08/11] swiotlb-xen: introduce phys_to_dma/dma_to_phys translations

2020-06-08 Thread Christoph Hellwig
On Wed, Jun 03, 2020 at 03:22:44PM -0700, Stefano Stabellini wrote: > From: Stefano Stabellini > > With some devices physical addresses are different than dma addresses. > To be able to deal with these cases, we need to call phys_to_dma on > physical addresses (including machine addresses in Xen

Re: [PATCH v2 09/11] swiotlb-xen: rename xen_phys_to_bus to xen_phys_to_dma and xen_bus_to_phys to xen_dma_to_phys

2020-06-08 Thread Christoph Hellwig
On Wed, Jun 03, 2020 at 03:22:45PM -0700, Stefano Stabellini wrote: > so that their names can better describe their behavior. > > No functional changes. I think this should go with the actual change, and adding the parameters. Touching this function piecemail in three patches for what really is

[ovmf test] 150917: all pass - PUSHED

2020-06-08 Thread osstest service owner
flight 150917 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/150917/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6ff7c838d09224dd4e4c9b5b93152d8db1b19740 baseline version: ovmf cfd73e0065f523e1d56bb

Re: [PATCH v2 10/11] xen/arm: introduce phys/dma translations in xen_dma_sync_for_*

2020-06-08 Thread Christoph Hellwig
On Wed, Jun 03, 2020 at 03:22:46PM -0700, Stefano Stabellini wrote: > From: Stefano Stabellini > > xen_dma_sync_for_cpu, xen_dma_sync_for_device, xen_arch_need_swiotlb are > getting called passing dma addresses. On some platforms dma addresses > could be different from physical addresses. Before

RE: [PATCH v2] build: fix dependency tracking for preprocessed files

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 05 June 2020 15:23 > To: xen-devel@lists.xenproject.org > Cc: Andrew Cooper ; George Dunlap > ; Ian Jackson > ; Julien Grall ; Stefano Stabellini > ; Wei Liu ; Paul Durrant > Subject: [PATCH v2] build: fix dependency tracking for preproces

[PATCH v1] tools: fix usage of strncpy

2020-06-08 Thread Olaf Hering
In case of truncation no trailing zero will be added to the target string. Reduce the amount of bytes to copy by one to make sure a trailing zero always exists. In file included from /usr/include/string.h:495, from libxl_internal.h:38, from libxl_utils.c:20: In fu

RE: xenforeignmemory fails to map PCI device memory with "Invalid Argument" error

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of ??? > Sent: 07 June 2020 23:19 > To: xen-devel@lists.xenproject.org > Subject: xenforeignmemory fails to map PCI device memory with "Invalid > Argument" error > > Hi xen-devel, > > I'm trying to read HVM guest PCI memory from Dom0 usin

Re: [PATCH v1] tools: fix usage of strncpy

2020-06-08 Thread Olaf Hering
Am Mon, 8 Jun 2020 09:28:54 +0200 schrieb Olaf Hering : > off-by-one error in libxl__prepare_sockaddr_un There is none, I had read the code backwards... Olaf pgpFP2LeUeAH4.pgp Description: Digitale Signatur von OpenPGP

Re: handle_pio looping during domain shutdown, with qemu 4.2.0 in stubdom

2020-06-08 Thread Jan Beulich
On 05.06.2020 18:18, 'Marek Marczykowski-Górecki' wrote: > On Fri, Jun 05, 2020 at 04:39:56PM +0100, Paul Durrant wrote: >>> From: Jan Beulich >>> Sent: 05 June 2020 14:57 >>> >>> On 05.06.2020 15:37, Paul Durrant wrote: > From: Jan Beulich > Sent: 05 June 2020 14:32 > > On 05.06.

Re: [PATCH for-4.14 v2] x86/rtc: provide mediated access to RTC for PVH dom0

2020-06-08 Thread Jan Beulich
On 06.06.2020 01:43, Roman Shaposhnik wrote: > On Fri, Jun 5, 2020 at 4:03 AM Roger Pau Monne wrote: >> >> Mediated access to the RTC was provided for PVHv1 dom0 using the PV >> code paths (guest_io_{write/read}), but those accesses where never >> implemented for PVHv2 dom0. This patch provides su

Re: Keystone Issue

2020-06-08 Thread Bertrand Marquis
> On 5 Jun 2020, at 20:12, CodeWiz2280 wrote: > > On Fri, Jun 5, 2020 at 11:05 AM CodeWiz2280 wrote: >> >> On Fri, Jun 5, 2020 at 8:47 AM Bertrand Marquis >> wrote: >>> >>> >>> On 5 Jun 2020, at 13:42, CodeWiz2280 wrote: On Fri, Jun 5, 2020 at 8:30 AM Julien Grall wrote

Re: [PATCH for-4.14 v2] x86/rtc: provide mediated access to RTC for PVH dom0

2020-06-08 Thread Roger Pau Monné
On Fri, Jun 05, 2020 at 04:43:12PM -0700, Roman Shaposhnik wrote: > On Fri, Jun 5, 2020 at 4:03 AM Roger Pau Monne wrote: > > > > Mediated access to the RTC was provided for PVHv1 dom0 using the PV > > code paths (guest_io_{write/read}), but those accesses where never > > implemented for PVHv2 dom

RE: handle_pio looping during domain shutdown, with qemu 4.2.0 in stubdom

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 08 June 2020 09:14 > To: 'Marek Marczykowski-Górecki' ; > p...@xen.org > Cc: 'Andrew Cooper' ; 'xen-devel' > > Subject: Re: handle_pio looping during domain shutdown, with qemu 4.2.0 in > stubdom > > On 05.06.2020 18:18, 'Marek Marczyko

Re: handle_pio looping during domain shutdown, with qemu 4.2.0 in stubdom

2020-06-08 Thread Jürgen Groß
On 08.06.20 11:15, Paul Durrant wrote: -Original Message- From: Jan Beulich Sent: 08 June 2020 09:14 To: 'Marek Marczykowski-Górecki' ; p...@xen.org Cc: 'Andrew Cooper' ; 'xen-devel' Subject: Re: handle_pio looping during domain shutdown, with qemu 4.2.0 in stubdom On 05.06.2020 18:1

[PATCH-for-4.14] ioreq: handle pending emulation racing with ioreq server destruction

2020-06-08 Thread Paul Durrant
From: Paul Durrant When an emulation request is initiated in hvm_send_ioreq() the guest vcpu is blocked on an event channel until that request is completed. If, however, the emulator is killed whilst that emulation is pending then the ioreq server may be destroyed. Thus when the vcpu is awoken th

Re: [PATCH v2 1/5] libxl: Generate golang bindings in libxl Makefile

2020-06-08 Thread George Dunlap
> On Jun 4, 2020, at 7:29 PM, Nick Rosbrook wrote: > >> The simplest short-term way to fix this would be to remove the `go fmt` call >> from `gengotypes.py`. It’s actually relatively unusual for generated code >> to look pretty (or even be looked at). We could also consider adding in >> so

[PATCH for-4.14 v3] x86/rtc: provide mediated access to RTC for PVH dom0

2020-06-08 Thread Roger Pau Monne
Mediated access to the RTC was provided for PVHv1 dom0 using the PV code paths (guest_io_{write/read}), but those accesses where never implemented for PVHv2 dom0. This patch provides such mediated accesses to the RTC for PVH dom0, just like it's provided for a classic PV dom0. Pull out some of the

Re: [PATCH-for-4.14] ioreq: handle pending emulation racing with ioreq server destruction

2020-06-08 Thread Jan Beulich
On 08.06.2020 11:46, Paul Durrant wrote: > From: Paul Durrant > > When an emulation request is initiated in hvm_send_ioreq() the guest vcpu is > blocked on an event channel until that request is completed. If, however, > the emulator is killed whilst that emulation is pending then the ioreq > ser

Re: [PATCH v1] tools: fix usage of strncpy

2020-06-08 Thread Ian Jackson
Olaf Hering writes ("Re: [PATCH v1] tools: fix usage of strncpy"): > Am Mon, 8 Jun 2020 09:28:54 +0200 > schrieb Olaf Hering : > > off-by-one error in libxl__prepare_sockaddr_un > > There is none, I had read the code backwards... I have just had the same thoughts but in the opposite order. That

RE: [PATCH-for-4.14] ioreq: handle pending emulation racing with ioreq server destruction

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 08 June 2020 11:58 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Paul Durrant ; Marek > Marczykowski-Górecki > > Subject: Re: [PATCH-for-4.14] ioreq: handle pending emulation racing with > ioreq server destruction > > On 08.0

Re: [PATCH-for-4.14] ioreq: handle pending emulation racing with ioreq server destruction

2020-06-08 Thread Jan Beulich
On 08.06.2020 13:04, Paul Durrant wrote: >> -Original Message- >> From: Jan Beulich >> Sent: 08 June 2020 11:58 >> To: Paul Durrant >> Cc: xen-devel@lists.xenproject.org; Paul Durrant ; >> Marek Marczykowski-Górecki >> >> Subject: Re: [PATCH-for-4.14] ioreq: handle pending emulation rac

RE: [PATCH for-4.14 v3] x86/rtc: provide mediated access to RTC for PVH dom0

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 08 June 2020 11:30 > To: xen-devel@lists.xenproject.org > Cc: p...@xen.org; Roger Pau Monne ; Jan Beulich > ; Andrew > Cooper ; Wei Liu > Subject: [PATCH for-4.14 v3] x86/rtc: provide mediated access to RTC for PVH > dom0 > > Mediate

Re: [PATCH v2 1/5] libxl: Generate golang bindings in libxl Makefile

2020-06-08 Thread Ian Jackson
George Dunlap writes ("Re: [PATCH v2 1/5] libxl: Generate golang bindings in libxl Makefile"): > So as written this turns out not to work correctly: `gengotypes.py` spits > out syntactically valid but unformatted Go code, and then runs `go fmt` on it > to get the right style (including tabs, &

RE: [PATCH-for-4.14] ioreq: handle pending emulation racing with ioreq server destruction

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 08 June 2020 12:10 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; 'Paul Durrant' ; > 'Marek Marczykowski-Górecki' > > Subject: Re: [PATCH-for-4.14] ioreq: handle pending emulation racing with > ioreq server destruction > > On 0

Re: [PATCH-for-4.14] ioreq: handle pending emulation racing with ioreq server destruction

2020-06-08 Thread Jan Beulich
On 08.06.2020 13:21, Paul Durrant wrote: >> From: Jan Beulich >> Sent: 08 June 2020 12:10 >> >> As said in the other thread, I think the change here will mask >> a problem elsewhere (presumably in qemu). I'm therefore unsure whether >> we want to apply it right away, rather than first understandin

Re: [PATCH for-4.14] golang/xenlight: remove call to go fmt in gengotypes.py

2020-06-08 Thread George Dunlap
> On Jun 6, 2020, at 5:10 PM, Nick Rosbrook wrote: > > Since the golang bindings are now set to be re-generated whenever a > change is made to tools/libxl/libxl_types.idl, the call to go fmt in > gengotypes.py results in a dirty git tree for users without go > installed. > > As an immediate fix

Re: [PATCH for-4.14 v3] x86/rtc: provide mediated access to RTC for PVH dom0

2020-06-08 Thread Roger Pau Monné
On Mon, Jun 08, 2020 at 12:12:40PM +0100, Paul Durrant wrote: > > -Original Message- > > From: Roger Pau Monne > > Sent: 08 June 2020 11:30 > > To: xen-devel@lists.xenproject.org > > Cc: p...@xen.org; Roger Pau Monne ; Jan Beulich > > ; Andrew > > Cooper ; Wei Liu > > Subject: [PATCH for

Re: [PATCH for-4.14 v3] x86/rtc: provide mediated access to RTC for PVH dom0

2020-06-08 Thread Jan Beulich
On 08.06.2020 12:29, Roger Pau Monne wrote: > Mediated access to the RTC was provided for PVHv1 dom0 using the PV > code paths (guest_io_{write/read}), but those accesses where never > implemented for PVHv2 dom0. This patch provides such mediated accesses > to the RTC for PVH dom0, just like it's p

[xen-unstable-smoke test] 150922: tolerable all pass - PUSHED

2020-06-08 Thread osstest service owner
flight 150922 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/150922/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v2 1/5] libxl: Generate golang bindings in libxl Makefile

2020-06-08 Thread George Dunlap
> On Jun 8, 2020, at 12:16 PM, Ian Jackson wrote: > > George Dunlap writes ("Re: [PATCH v2 1/5] libxl: Generate golang bindings in > libxl Makefile"): >> So as written this turns out not to work correctly: `gengotypes.py` spits >> out syntactically valid but unformatted Go code, and then ru

Re: [PATCH for-4.14 v3] x86/rtc: provide mediated access to RTC for PVH dom0

2020-06-08 Thread Jan Beulich
On 08.06.2020 13:45, Roger Pau Monné wrote: > On Mon, Jun 08, 2020 at 12:12:40PM +0100, Paul Durrant wrote: >>> From: Roger Pau Monne >>> Sent: 08 June 2020 11:30 >>> >>> @@ -1110,6 +,67 @@ static unsigned long get_cmos_time(void) >>> return mktime(rtc.year, rtc.mon, rtc.day, rtc.hour, rt

[qemu-mainline test] 150916: regressions - FAIL

2020-06-08 Thread osstest service owner
flight 150916 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/150916/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail in 150909 REGR. vs. 150694 Tests which are f

Re: Keystone Issue

2020-06-08 Thread CodeWiz2280
It actually shows only 1 interrupt for any of the devices in that list (e.g. spi, ttyS0, ethernet) so you're probably right on the money with it being an interrupt acknowledge issue. Any help you can provide is greatly appreciated. On Mon, Jun 8, 2020 at 4:40 AM Bertrand Marquis wrote: > > > > >

RE: handle_pio looping during domain shutdown, with qemu 4.2.0 in stubdom

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Jürgen Groß > Sent: 08 June 2020 10:25 > To: p...@xen.org; 'Jan Beulich' ; 'Marek > Marczykowski-Górecki' > ; 'Ian Jackson' > Cc: 'Andrew Cooper' ; 'xen-devel' > > Subject: Re: handle_pio looping during domain shutdown, with qemu 4.2.0 in > stubdom > > On

Re: [PATCH v1] tools: fix usage of strncpy

2020-06-08 Thread Jason Andryuk
On Mon, Jun 8, 2020 at 7:03 AM Ian Jackson wrote: > > Olaf Hering writes ("Re: [PATCH v1] tools: fix usage of strncpy"): > > Am Mon, 8 Jun 2020 09:28:54 +0200 > > schrieb Olaf Hering : > > > off-by-one error in libxl__prepare_sockaddr_un > > > > There is none, I had read the code backwards... > >

Re: handle_pio looping during domain shutdown, with qemu 4.2.0 in stubdom

2020-06-08 Thread Jan Beulich
On 08.06.2020 14:38, Paul Durrant wrote: >> From: Jürgen Groß >> Sent: 08 June 2020 10:25 >> >> On 08.06.20 11:15, Paul Durrant wrote: From: Jan Beulich Sent: 08 June 2020 09:14 On 05.06.2020 18:18, 'Marek Marczykowski-Górecki' wrote: > (XEN) d12v0 XEN_DMOP_remote_shutdown

RE: handle_pio looping during domain shutdown, with qemu 4.2.0 in stubdom

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich > Sent: 08 June 2020 13:47 > To: p...@xen.org > Cc: 'Jürgen Groß' ; 'Marek Marczykowski-Górecki' > ; > 'Ian Jackson' ; 'Andrew Cooper' > ; 'xen-devel' > > Subject: Re: handle_pio looping during domain shutdown, with qemu 4.2.0 in > stubdom > >

Re: [PATCH v3 0/4] microvm: memory config tweaks

2020-06-08 Thread Gerd Hoffmann
On Fri, May 29, 2020 at 09:39:53AM +0200, Gerd Hoffmann wrote: > With more microvm memory config tweaks split this into its owns series, > the microvm acpi patch series is already big enough ... > > v2: > - use 3G split. > - add patch to move virtio-mmio region. > - pick up acks & reviews. > v3

Re: [PATCH v3 0/4] microvm: memory config tweaks

2020-06-08 Thread Michael S. Tsirkin
On Fri, May 29, 2020 at 09:39:53AM +0200, Gerd Hoffmann wrote: > With more microvm memory config tweaks split this into its owns series, > the microvm acpi patch series is already big enough ... Looks sane: Acked-by: Michael S. Tsirkin microvm things so should use that tree ... > v2: > - use

Re: [PATCH v3 4/4] microvm: move virtio base to 0xfeb00000

2020-06-08 Thread Michael S. Tsirkin
On Fri, May 29, 2020 at 09:39:57AM +0200, Gerd Hoffmann wrote: > Place virtio-mmio devices near the other mmio regions, > next ioapic is at @ 0xfec0. > > Signed-off-by: Gerd Hoffmann > --- > include/hw/i386/microvm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/i

[PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering

2020-06-08 Thread Andrew Cooper
The cronjob which renders https://xenbits.xen.org/docs/ has been broken for a while. commitish_version() pulls an old version of xen/Makefile out of history, and uses the xenversion rule. Currently, this fails with: tmp.support-matrix.xen.make:130: scripts/Kbuild.include: No such file or dire

RE: [PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 08 June 2020 14:35 > To: Xen-devel > Cc: Andrew Cooper ; George Dunlap > ; Ian > Jackson ; Jan Beulich ; Konrad > Rzeszutek Wilk > ; Stefano Stabellini ; Wei > Liu ; Julien > Grall ; Anthony PERARD ; Paul > Durrant > Subject: [PATCH

Re: [PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering

2020-06-08 Thread Jan Beulich
On 08.06.2020 15:34, Andrew Cooper wrote: > The cronjob which renders https://xenbits.xen.org/docs/ has been broken for a > while. commitish_version() pulls an old version of xen/Makefile out of > history, and uses the xenversion rule. > > Currently, this fails with: > > tmp.support-matrix.xen

Re: [PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering

2020-06-08 Thread Ian Jackson
Andrew Cooper writes ("[PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering"): > The cronjob which renders https://xenbits.xen.org/docs/ has been broken for a > while. commitish_version() pulls an old version of xen/Makefile out of > history, and uses the xenversion rule. > > Currentl

Re: [PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering

2020-06-08 Thread Andrew Cooper
On 08/06/2020 14:41, Jan Beulich wrote: > On 08.06.2020 15:34, Andrew Cooper wrote: >> The cronjob which renders https://xenbits.xen.org/docs/ has been broken for a >> while. commitish_version() pulls an old version of xen/Makefile out of >> history, and uses the xenversion rule. >> >> Currently,

Re: [PATCH for-4.14] golang/xenlight: remove call to go fmt in gengotypes.py

2020-06-08 Thread Nick Rosbrook
On Mon, Jun 08, 2020 at 11:39:43AM +, George Dunlap wrote: > > > On Jun 6, 2020, at 5:10 PM, Nick Rosbrook wrote: > > > > Since the golang bindings are now set to be re-generated whenever a > > change is made to tools/libxl/libxl_types.idl, the call to go fmt in > > gengotypes.py results in

Re: [PATCH v2 1/5] libxl: Generate golang bindings in libxl Makefile

2020-06-08 Thread Nick Rosbrook
> > Out of curiosity, would it be totally out of the question to require > > having gofmt installed (not for 4.14, but in the future)? I ask because > > I haven't seen it discussed one way or the other. > > I think I’d like to try to avoid it, unless / until we have a “core > component” written i

Re: [PATCH v1] tools: fix usage of strncpy

2020-06-08 Thread Olaf Hering
Am Mon, 8 Jun 2020 08:43:50 -0400 schrieb Jason Andryuk : > I added a length check in this patch: gcc will not recognize such runtime checks and will (most likely) complain about the strncpy usage anyway, just as it does now in libxl__prepare_sockaddr_un. While the usage in libxl__prepare_socka

Re: [PATCH v2 for-4.14] docs/support-matrix: unbreak docs rendering

2020-06-08 Thread Andrew Cooper
On 08/06/2020 14:48, Ian Jackson wrote: > Andrew Cooper writes ("[PATCH v2 for-4.14] docs/support-matrix: unbreak docs > rendering"): >> The cronjob which renders https://xenbits.xen.org/docs/ has been broken for a >> while. commitish_version() pulls an old version of xen/Makefile out of >> histo

Re: [PATCH for-4.14] golang/xenlight: remove call to go fmt in gengotypes.py

2020-06-08 Thread George Dunlap
CC’ing release manager > On Jun 8, 2020, at 12:39 PM, George Dunlap wrote: > >> >> On Jun 6, 2020, at 5:10 PM, Nick Rosbrook wrote: >> >> Since the golang bindings are now set to be re-generated whenever a >> change is made to tools/libxl/libxl_types.idl, the call to go fmt in >> gengotypes.p

4.14.0-rc1 blocked on goland build failure - decision needed

2020-06-08 Thread Ian Jackson
Hi, Paul. For those on xen-devel: context is that Paul asked me to cut 4.14.0-rc1. The checklist asks me to perform a test build. My 32-bit tools test build failed. I think the problem is probably specific to 32-bit userland on 64-bit Linux kernel. I will send a second followup mail not CC Pau

Re: 4.14.0-rc1 blocked on goland build failure - decision needed

2020-06-08 Thread Ian Jackson
Ian Jackson writes ("4.14.0-rc1 blocked on goland build failure - decision needed"): > Hi, Paul. For those on xen-devel: context is that Paul asked me to > cut 4.14.0-rc1. The checklist asks me to perform a test build. > > My 32-bit tools test build failed. I think the problem is probably > sp

RE: [PATCH for-4.14] golang/xenlight: remove call to go fmt in gengotypes.py

2020-06-08 Thread Paul Durrant
> -Original Message- > From: George Dunlap > Sent: 08 June 2020 15:16 > To: Nick Rosbrook > Cc: Xen-devel ; Nick Rosbrook > ; Ian Jackson > ; Wei Liu ; Paul Durrant > Subject: Re: [PATCH for-4.14] golang/xenlight: remove call to go fmt in > gengotypes.py > > CC’ing release manager >

Re: 4.14.0-rc1 blocked on goland build failure - decision needed

2020-06-08 Thread George Dunlap
> On Jun 8, 2020, at 3:48 PM, Ian Jackson wrote: > > Ian Jackson writes ("4.14.0-rc1 blocked on goland build failure - decision > needed"): >> Hi, Paul. For those on xen-devel: context is that Paul asked me to >> cut 4.14.0-rc1. The checklist asks me to perform a test build. >> >> My 32-bit

Re: 4.14.0-rc1 blocked on goland build failure - decision needed [and 1 more messages]

2020-06-08 Thread Ian Jackson
Ian Jackson writes ("4.14.0-rc1 blocked on goland build failure - decision needed"): > Hi, Paul. For those on xen-devel: context is that Paul asked me to > cut 4.14.0-rc1. The checklist asks me to perform a test build. > > My 32-bit tools test build failed. I think the problem is probably > sp

RE: 4.14.0-rc1 blocked on goland build failure - decision needed

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Xen-devel On Behalf Of George > Dunlap > Sent: 08 June 2020 16:07 > To: Ian Jackson > Cc: Xen-devel ; Nick Rosbrook > ; Wei Liu > > Subject: Re: 4.14.0-rc1 blocked on goland build failure - decision needed > > > > > On Jun 8, 2020, at 3:48 PM, Ian Jackso

RE: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian stable)

2020-06-08 Thread Ian Jackson
Ian Jackson writes ("RE: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian stable)"): > Paul Durrant writes ("RE: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= > Debian stable)"): > > I assume we can revert if things go badly wrong and being able to > > commission more machines wo

RE: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian stable)

2020-06-08 Thread Paul Durrant
> -Original Message- > From: Ian Jackson > Sent: 08 June 2020 16:34 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; committ...@xenproject.org > Subject: RE: [OSSTEST PATCH v2 00/49] Switch to Debian buster (= Debian > stable) > > Ian Jackson writes ("RE: [OSSTEST PATCH v2 00/49]

Re: [PATCH v4 for-4.14] x86/monitor: revert default behavior when monitoring register write events

2020-06-08 Thread Jan Beulich
On 03.06.2020 17:07, Roger Pau Monné wrote: > On Wed, Jun 03, 2020 at 06:52:37AM -0600, Tamas K Lengyel wrote: >> For the last couple years we have received numerous reports from users of >> monitor vm_events of spurious guest crashes when using events. In particular, >> it has observed that the pr

Re: [PATCH for-4.14 v3] x86/rtc: provide mediated access to RTC for PVH dom0

2020-06-08 Thread Roger Pau Monné
On Mon, Jun 08, 2020 at 01:47:26PM +0200, Jan Beulich wrote: > On 08.06.2020 12:29, Roger Pau Monne wrote: > > Mediated access to the RTC was provided for PVHv1 dom0 using the PV > > code paths (guest_io_{write/read}), but those accesses where never > > implemented for PVHv2 dom0. This patch provid

[RFC PATCH 04/35] hw/arm/pxa2xx: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/pxa2xx.c | 3 +++ hw/display/pxa2xx_lcd.c | 3 +++ hw/input/pxa2xx_keypad.c | 3 +++ 3 files changed, 9 insertions(+) diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c index e649f8930c..4

[RFC PATCH 00/35] hw/qdev: Warn when using pre-qdev/QOM devices

2020-06-08 Thread Philippe Mathieu-Daudé
Based on today's IRC chat, this is a trivial RFC series to anotate pre-qdev/QOM devices so developers using them without knowing they are not QOM'ified yet can realize it and convert them if they have time. qdev/QOM devices are introspectable, so easier to test or even fuzz. Philippe Mathieu-Daud

[RFC PATCH 02/35] hw/core/qdev: Add qdev_warn_deprecated_function_used() helper

2020-06-08 Thread Philippe Mathieu-Daudé
When built with --enable-qdev-deprecation-warning, calling qdev_warn_deprecated_function_used() will emit a warning such: $ qemu-system-arm -M verdex ... qemu-system-arm: warning: use of deprecated non-qdev/non-qom code in pxa2xx_lcdc_init() qemu-system-arm: warning: use of deprecated non-q

[RFC PATCH 01/35] qom/object: Update documentation

2020-06-08 Thread Philippe Mathieu-Daudé
The documentation was introduced in 2f28d2ff9dc, then 0d09e41a51 and a27bd6c77 moved the headers around. Update the comment. Signed-off-by: Philippe Mathieu-Daudé --- include/qom/object.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qom/object.h b/include/qom

[RFC PATCH 03/35] hw/arm/omap: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/omap1.c| 6 ++ hw/char/omap_uart.c | 5 + hw/misc/omap_gpmc.c | 3 +++ hw/misc/omap_l4.c | 3 +++ hw/misc/omap_sdrc.c | 3 +++ hw/sd/omap_mmc.c

[RFC PATCH 07/35] hw/char/parallel: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/char/parallel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/char/parallel.c b/hw/char/parallel.c index 8dd67d1375..0ee577d420 100644 --- a/hw/char/parallel.c +++ b/hw/char/parallel.c @@

[RFC PATCH 06/35] hw/timer/arm_timer: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/arm_timer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/timer/arm_timer.c b/hw/timer/arm_timer.c index 9607366d78..e23e6b4b31 100644 --- a/hw/timer/arm_timer.c +++ b/hw/timer/arm_

[RFC PATCH 05/35] hw/arm/nseries: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/nseries.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c index eae800b5c1..bd0c3f39a9 100644 --- a/hw/arm/nseries.c +++ b/hw/arm/nseries.c @@ -44,6 +44,

[RFC PATCH 17/35] hw/input/pckbd: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/input/pckbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c index 60a4130320..c7f42be63b 100644 --- a/hw/input/pckbd.c +++ b/hw/input/pckb

[RFC PATCH 16/35] hw/input/lasips2: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/input/lasips2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/input/lasips2.c b/hw/input/lasips2.c index 0786e57338..452244f037 100644 --- a/hw/input/lasips2.c +++ b/hw/in

[RFC PATCH 14/35] hw/i386/pc: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2128f3d6fe..c71809fd28 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -94,6 +94,7 @@ #include "vmp

[RFC PATCH 10/35] hw/display/tc6393xb: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/tc6393xb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/tc6393xb.c b/hw/display/tc6393xb.c index 49a676d1b0..e4900e9502 100644 --- a/hw/display/tc6393xb.c +++ b/hw/displa

[RFC PATCH 11/35] hw/display/vga-isa-mm: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/vga-isa-mm.c | 5 + hw/display/vga.c| 3 +++ 2 files changed, 8 insertions(+) diff --git a/hw/display/vga-isa-mm.c b/hw/display/vga-isa-mm.c index 7321b7a06d..3e62389b63 100644 -

[RFC PATCH 12/35] hw/dma/etraxfs_dma: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/dma/etraxfs_dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/dma/etraxfs_dma.c b/hw/dma/etraxfs_dma.c index c4334e87bf..d2f7e7ca9d 100644 --- a/hw/dma/etraxfs_dma.c +++

[RFC PATCH 09/35] hw/display/ramfb: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/ramfb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c index 79b9754a58..a4a427e5c7 100644 --- a/hw/display/ramfb.c +++ b/hw/display/ramfb.c @@

[RFC PATCH 08/35] hw/display/blizzard: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/blizzard.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c index 105241577d..74557b152b 100644 --- a/hw/display/blizzard.c +++ b/hw/displa

[RFC PATCH 15/35] hw/i386/xen/xen-hvm: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/xen/xen-hvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 82ece6b9e7..a1163b1529 100644 --- a/hw/i386/xen/xen-hvm.c

[RFC PATCH 13/35] hw/dma/soc_dma: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/dma/soc_dma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/dma/soc_dma.c b/hw/dma/soc_dma.c index 3a430057f5..22fd8c38b0 100644 --- a/hw/dma/soc_dma.c +++ b/hw/dma/soc_dma.c @@ -21,6 +21

[RFC PATCH 19/35] hw/input/tsc2005: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/input/tsc2005.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/input/tsc2005.c b/hw/input/tsc2005.c index 55d61cc843..1f97b82379 100644 --- a/hw/input/tsc2005.c +++ b/hw/input/tsc2005.c @@

[RFC PATCH 18/35] hw/input/ps2: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/input/ps2.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index f8746d2f52..0d84061cae 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -

[RFC PATCH 21/35] hw/lm32/lm32_hwsetup: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/lm32/lm32_hwsetup.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/lm32/lm32_hwsetup.h b/hw/lm32/lm32_hwsetup.h index de94de177a..f4a4d8fe4b 100644 --- a/hw/lm32/lm32_hwsetup.h +++ b/hw/lm

[RFC PATCH 22/35] hw/m68k/mcf520x: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/m68k/mcf5206.c | 5 + hw/m68k/mcf5208.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/hw/m68k/mcf5206.c b/hw/m68k/mcf5206.c index a2fef04f8e..ec0d176674 100644 --- a/hw/m68k/mcf5206.c +

[RFC PATCH 25/35] hw/nvram/eeprom93xx: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/nvram/eeprom93xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/nvram/eeprom93xx.c b/hw/nvram/eeprom93xx.c index ca6f591c84..56603ea42b 100644 --- a/hw/nvram/eeprom93xx.c +++ b/hw/nvram/

[RFC PATCH 29/35] hw/ppc/ppc_booke: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/ppc_booke.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c index 652a21b806..a9e5e68578 100644 --- a/hw/ppc/ppc_booke.c +++ b/hw/pp

[RFC PATCH 27/35] hw/ppc/ppc: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/ppc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 4a11fb1640..39fcf746c5 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -37,6 +37,7 @@ #include "kvm

[RFC PATCH 28/35] hw/ppc/ppc4xx: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/ppc405_boards.c | 5 + hw/ppc/ppc405_uc.c | 21 + hw/ppc/ppc4xx_devs.c | 7 +++ 3 files changed, 33 insertions(+) diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc

[RFC PATCH 26/35] hw/openrisc/cputimer: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/openrisc/cputimer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c index 93268815d8..60f2c9667f 100644 --- a/hw/openrisc/cputimer.c +++ b/hw/op

[RFC PATCH 20/35] hw/intc/i8259: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/intc/i8259.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 51b27f6a34..9d9609cdab 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -30,6 +30,7 @@

Re: [PATCH for-4.14 v3] x86/rtc: provide mediated access to RTC for PVH dom0

2020-06-08 Thread Jan Beulich
On 08.06.2020 17:56, Roger Pau Monné wrote: > On Mon, Jun 08, 2020 at 01:47:26PM +0200, Jan Beulich wrote: >> On 08.06.2020 12:29, Roger Pau Monne wrote: >>> Mediated access to the RTC was provided for PVHv1 dom0 using the PV >>> code paths (guest_io_{write/read}), but those accesses where never >>

[RFC PATCH 24/35] hw/misc/cbus: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/cbus.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/cbus.c b/hw/misc/cbus.c index 3c3721ad2d..24e197684f 100644 --- a/hw/misc/cbus.c +++ b/hw/misc/cbus.c @@ -25,6 +25,7 @@ #in

[RFC PATCH 31/35] hw/sh4: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/char/sh_serial.c | 3 +++ hw/intc/sh_intc.c | 3 +++ hw/sh4/r2d.c| 3 +++ hw/sh4/sh7750.c | 4 hw/timer/sh_timer.c | 5 + 5 files changed, 18 insertions(+) diff --git a/hw/cha

[RFC PATCH 23/35] hw/misc/applesmc: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/applesmc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c index 1c4addb201..d63f19038d 100644 --- a/hw/misc/applesmc.c +++ b/hw/misc/applesmc.c @@

[RFC PATCH 30/35] hw/ppc/virtex_ml507: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/virtex_ml507.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c index 0dacfcd236..17b8036c38 100644 --- a/hw/ppc/virtex_ml507.c

[RFC PATCH 32/35] hw/riscv: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/riscv/riscv_htif.c | 4 hw/riscv/sifive_uart.c | 4 2 files changed, 8 insertions(+) diff --git a/hw/riscv/riscv_htif.c b/hw/riscv/riscv_htif.c index ca87a5cf9f..bd080dbefb 100644 --- a/h

[RFC PATCH 33/35] hw/timer/slavio_timer: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/slavio_timer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/timer/slavio_timer.c b/hw/timer/slavio_timer.c index 4c5d65e391..16f21669bf 100644 --- a/hw/timer/slavio_timer.c +++ b/h

[RFC PATCH 35/35] hw/xtensa/xtfpga: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/xtensa/xtfpga.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c index 60ccc74f5f..a3c82dc81a 100644 --- a/hw/xtensa/xtfpga.c +++ b/hw/xtensa/xtfpga.c @@

[RFC PATCH 34/35] hw/usb/hcd-musb: Emit warning when old code is used

2020-06-08 Thread Philippe Mathieu-Daudé
This code hasn't been QOM'ified yet. Warn the user. Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/hcd-musb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/usb/hcd-musb.c b/hw/usb/hcd-musb.c index c29fbef6fc..9b3cf1ca8f 100644 --- a/hw/usb/hcd-musb.c +++ b/hw/usb/hcd-musb.c @@ -25,

  1   2   >