> On Jun 6, 2020, at 5:10 PM, Nick Rosbrook <rosbro...@gmail.com> wrote: > > Since the golang bindings are now set to be re-generated whenever a > change is made to tools/libxl/libxl_types.idl, the call to go fmt in > gengotypes.py results in a dirty git tree for users without go > installed. > > As an immediate fix, just remove the call to go fmt from gengotypes.py. > While here, make sure the DO NOT EDIT comment and package declaration > remain formatted correctly. All other generated code is left > un-formatted for now. > > Signed-off-by: Nick Rosbrook <rosbro...@ainfosec.com>
Reviewed-by: George Dunlap <george.dun...@citrix.com> With one note: git complains that the resulting patch introduces loads of trailing whitespace. I went though gengotypes.py and essentially did `s/ \n/\n/g`. With your permission I’ll fold that (and the resulting patches) into this before checking it in. -George
