CC’ing release manager > On Jun 8, 2020, at 12:39 PM, George Dunlap <george.dun...@citrix.com> wrote: > >> >> On Jun 6, 2020, at 5:10 PM, Nick Rosbrook <rosbro...@gmail.com> wrote: >> >> Since the golang bindings are now set to be re-generated whenever a >> change is made to tools/libxl/libxl_types.idl, the call to go fmt in >> gengotypes.py results in a dirty git tree for users without go >> installed. >> >> As an immediate fix, just remove the call to go fmt from gengotypes.py. >> While here, make sure the DO NOT EDIT comment and package declaration >> remain formatted correctly. All other generated code is left >> un-formatted for now. >> >> Signed-off-by: Nick Rosbrook <rosbro...@ainfosec.com> > > Reviewed-by: George Dunlap <george.dun...@citrix.com>
Paul, this is a fix to the build system that only affects the formatting of some generated code. (At the moment, the generated code will look differently depending on whether you have golang installed or not.)
