[Xen-devel] [ovmf test] 144856: regressions - FAIL

2019-12-16 Thread osstest service owner
flight 144856 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144856/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

Re: [Xen-devel] [PATCH net-next] xen-netback: get rid of old udev related code

2019-12-16 Thread Jürgen Groß
On 13.12.19 11:12, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 13 December 2019 10:02 To: Durrant, Paul ; David Miller Cc: xen-devel@lists.xenproject.org; wei@kernel.org; linux- ker...@vger.kernel.org; net...@vger.kernel.org Subject: Re: [Xen-devel] [PATCH net-ne

Re: [Xen-devel] [PATCH net-next] xen-netback: get rid of old udev related code

2019-12-16 Thread Durrant, Paul
> -Original Message- > From: Jürgen Groß > Sent: 16 December 2019 08:10 > To: Durrant, Paul ; David Miller > > Cc: xen-devel@lists.xenproject.org; wei@kernel.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org > Subject: Re: [Xen-devel] [PATCH net-next] xen-netback: get rid o

Re: [Xen-devel] [PATCH net-next] xen-netback: get rid of old udev related code

2019-12-16 Thread Jürgen Groß
On 16.12.19 09:18, Durrant, Paul wrote: -Original Message- From: Jürgen Groß Sent: 16 December 2019 08:10 To: Durrant, Paul ; David Miller Cc: xen-devel@lists.xenproject.org; wei@kernel.org; linux- ker...@vger.kernel.org; net...@vger.kernel.org Subject: Re: [Xen-devel] [PATCH net-ne

[Xen-devel] [PATCH v2] Xen missing prompt log when exec-sp=off

2019-12-16 Thread Jin Nan Wang
Fix a issue when user disable ETP exec-sp, xen missed a prompt log in dmesg. Signed-off-by: James Wang --- xen/arch/x86/hvm/vmx/vmx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 7970ba93e1..5e86dd078

Re: [Xen-devel] [PATCH v2] IOMMU: make DMA containment of quarantined devices optional

2019-12-16 Thread Sander Eikelenboom
On 16/12/2019 08:24, Jürgen Groß wrote: > On 16.12.19 06:58, Tian, Kevin wrote: >>> From: Jürgen Groß >>> Sent: Friday, December 13, 2019 11:36 PM >>> >>> On 13.12.19 15:45, Jan Beulich wrote: On 13.12.2019 15:24, Jürgen Groß wrote: > On 13.12.19 15:11, Jan Beulich wrote: >> On 13.12.

[Xen-devel] [ovmf test] 144857: regressions - FAIL

2019-12-16 Thread osstest service owner
flight 144857 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144857/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

Re: [Xen-devel] xen-block: race condition when stopping the device (WAS: Re: [xen-4.13-testing test] 144736: regressions - FAIL)

2019-12-16 Thread Durrant, Paul
> -Original Message- [snip] > >> > >> This feels like a race condition between the init/free code with > >> handler. Anthony, does it ring any bell? > >> > > > > From that stack bt it looks like an iothread managed to run after the > sring was NULLed. This should not be able happen as the

Re: [Xen-devel] [PATCH v9 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-16 Thread Roger Pau Monné
On Fri, Dec 13, 2019 at 03:35:44PM +, SeongJae Park wrote: > Each `blkif` has a free pages pool for the grant mapping. The size of > the pool starts from zero and is increased on demand while processing > the I/O requests. If current I/O requests handling is finished or 100 > milliseconds has

Re: [Xen-devel] [PATCH v9 4/4] xen/blkback: Consistently insert one empty line between functions

2019-12-16 Thread Roger Pau Monné
On Fri, Dec 13, 2019 at 03:35:46PM +, SeongJae Park wrote: > The number of empty lines between functions in the xenbus.c is > inconsistent. This trivial style cleanup commit fixes the file to > consistently place only one empty line. > > Signed-off-by: SeongJae Park Thanks! Acked-by: Roger

Re: [Xen-devel] [PATCH 1/2] x86/time: drop vtsc_{kern, user}count debug counters

2019-12-16 Thread Roger Pau Monné
On Fri, Dec 13, 2019 at 10:48:01PM +, Igor Druzhinin wrote: > They either need to be transformed to atomics to work correctly > (currently they left unprotected for HVM domains) or dropped entirely ^ are used > as taking a per-domain spinlock is too expensive for high-vCPU cou

Re: [Xen-devel] xen-block: race condition when stopping the device (WAS: Re: [xen-4.13-testing test] 144736: regressions - FAIL)

2019-12-16 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of > Durrant, Paul > Sent: 16 December 2019 09:34 > To: Julien Grall ; Ian Jackson > Cc: Jürgen Groß ; Stefano Stabellini > ; qemu-de...@nongnu.org; osstest service owner > ; Anthony Perard > ; xen-devel@lists.xenproject.org > Subject: Re:

[Xen-devel] [xen-unstable test] 144850: tolerable FAIL

2019-12-16 Thread osstest service owner
flight 144850 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/144850/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-win7-amd64 7 xen-boot fail pass in 144827 test-armhf-armhf-xl-rtds 12

Re: [Xen-devel] [PATCH 2/2] x86/time: update vtsc_last with cmpxchg and drop vtsc_lock

2019-12-16 Thread Roger Pau Monné
On Fri, Dec 13, 2019 at 10:48:02PM +, Igor Druzhinin wrote: > Now that vtsc_last is the only entity protected by vtsc_lock we can > simply update it using a single atomic operation and drop the spinlock > entirely. This is extremely important for the case of running nested > (e.g. shim instance

Re: [Xen-devel] [PATCH v9 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-16 Thread SeongJae Park
On Mon, 16 Dec 2019 10:37:55 +0100 "Roger Pau Monné" wrote: > On Fri, Dec 13, 2019 at 03:35:44PM +, SeongJae Park wrote: > > Each `blkif` has a free pages pool for the grant mapping. The size of > > the pool starts from zero and is increased on demand while processing > > the I/O requests.

Re: [Xen-devel] [XEN PATCH 3/8] xen: Update Kconfig to Linux v5.4

2019-12-16 Thread Jan Beulich
On 13.12.2019 20:17, Andrew Cooper wrote: > On 13/12/2019 16:59, Jan Beulich wrote: >> On 13.12.2019 16:49, Anthony PERARD wrote: >>> On Fri, Dec 13, 2019 at 12:05:11PM +0100, Jan Beulich wrote: On 12.12.2019 19:27, Anthony PERARD wrote: > --- /dev/null > +++ b/xen/.gitignore > @@

Re: [Xen-devel] xen-block: race condition when stopping the device (WAS: Re: [xen-4.13-testing test] 144736: regressions - FAIL)

2019-12-16 Thread Durrant, Paul
> -Original Message- > From: Durrant, Paul > Sent: 16 December 2019 09:50 > To: Durrant, Paul ; Julien Grall ; > Ian Jackson > Cc: Jürgen Groß ; Stefano Stabellini > ; qemu-de...@nongnu.org; osstest service owner > ; Anthony Perard > ; xen-devel@lists.xenproject.org > Subject: RE: [Xen-de

[Xen-devel] [libvirt test] 144853: tolerable all pass - PUSHED

2019-12-16 Thread osstest service owner
flight 144853 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/144853/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 saverestore-support-checkfail like 144517 test-armhf-armhf-libvirt-raw 13 saveresto

[Xen-devel] [ovmf test] 144858: regressions - FAIL

2019-12-16 Thread osstest service owner
flight 144858 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144858/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

Re: [Xen-devel] [PATCH v2] Xen missing prompt log when exec-sp=off

2019-12-16 Thread Jan Beulich
On 16.12.2019 09:27, Jin Nan Wang wrote: > Fix a issue when user disable ETP exec-sp, xen missed a prompt > log in dmesg. Why "missed" (and why "prompt")? I think the original intention was to log a message only when no command line option was given and the system would be vulnerable without the d

Re: [Xen-devel] [PATCH 1/3] x86/mm: Use a more descriptive name for pagetable mfns

2019-12-16 Thread Jan Beulich
On 13.12.2019 18:37, George Dunlap wrote: > In many places, a PTE being modified is accompanied by the pagetable > mfn which contains the PTE (primarily in order to be able to maintain > linear mapping counts). In many cases, this mfn is stored in the > non-descript variable (or argement) "pfn". >

Re: [Xen-devel] [PATCH 2/3] x86/mm: Use mfn_t in type get / put call tree

2019-12-16 Thread Jan Beulich
On 13.12.2019 18:37, George Dunlap wrote: > Replace `unsigned long` with `mfn_t` as appropriate throughout > alloc/free_lN_table, get/put_page_from_lNe, and > get_lN_linear_pagetable. This obviates the need for a load of > `mfn_x()` and `_mfn()` casts. > > Signed-off-by: George Dunlap Ah, here

Re: [Xen-devel] [PATCH 1/3] x86/mm: Use a more descriptive name for pagetable mfns

2019-12-16 Thread George Dunlap
On 12/16/19 11:07 AM, Jan Beulich wrote: > On 13.12.2019 18:37, George Dunlap wrote: >> In many places, a PTE being modified is accompanied by the pagetable >> mfn which contains the PTE (primarily in order to be able to maintain >> linear mapping counts). In many cases, this mfn is stored in the

Re: [Xen-devel] [PATCH 2/3] x86/mm: Use mfn_t in type get / put call tree

2019-12-16 Thread George Dunlap
On 12/16/19 11:10 AM, Jan Beulich wrote: > On 13.12.2019 18:37, George Dunlap wrote: >> Replace `unsigned long` with `mfn_t` as appropriate throughout >> alloc/free_lN_table, get/put_page_from_lNe, and >> get_lN_linear_pagetable. This obviates the need for a load of >> `mfn_x()` and `_mfn()` casts

Re: [Xen-devel] [PATCH 3/3] x86/mm: More discriptive names for page de/validation functions

2019-12-16 Thread Jan Beulich
On 13.12.2019 18:37, George Dunlap wrote: > The functions alloc_page_type(), alloc_lN_table(), free_page_type() > and free_lN_table() are confusingly named: nothing is being allocated > or freed. Rather, the page being passed in is being either validated > or devalidated for use as the specific ty

Re: [Xen-devel] [PATCH 2/2] x86/time: update vtsc_last with cmpxchg and drop vtsc_lock

2019-12-16 Thread Jan Beulich
On 16.12.2019 11:00, Roger Pau Monné wrote: > On Fri, Dec 13, 2019 at 10:48:02PM +, Igor Druzhinin wrote: >> Now that vtsc_last is the only entity protected by vtsc_lock we can >> simply update it using a single atomic operation and drop the spinlock >> entirely. This is extremely important for

Re: [Xen-devel] [PATCH 2/3] x86/mm: Use mfn_t in type get / put call tree

2019-12-16 Thread Jan Beulich
On 16.12.2019 12:13, George Dunlap wrote: > On 12/16/19 11:10 AM, Jan Beulich wrote: >> On 13.12.2019 18:37, George Dunlap wrote: >>> Replace `unsigned long` with `mfn_t` as appropriate throughout >>> alloc/free_lN_table, get/put_page_from_lNe, and >>> get_lN_linear_pagetable. This obviates the ne

Re: [Xen-devel] [PATCH v2 0/3] x86: Protected Processor Inventory Number (PPIN) support

2019-12-16 Thread Jan Beulich
On 13.12.2019 20:50, Andrew Cooper wrote: > On 08/11/2019 15:22, Jan Beulich wrote: >> 1: include the PPIN in MCE records when available >> 2: explicitly disallow guest access to PPIN >> 3: provide Dom0 access to PPIN via XENPF_resource_op >> >> I have yet to get around to post the Linux side consu

[Xen-devel] Xen 4.13 RC5

2019-12-16 Thread Juergen Gross
Hi all, Xen 4.13 rc5 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.13.0-rc5 For your convenience there is also a tarball at: https://downloads.xenproject.org/release/xen/4.13.0-rc5/xen-4.13.0-rc5.tar.gz And the signature is at: https://downloads.xenproject.org

Re: [Xen-devel] [PATCH v2 2/3] x86: explicitly disallow guest access to PPIN

2019-12-16 Thread Jan Beulich
On 13.12.2019 20:47, Andrew Cooper wrote: > On 08/11/2019 15:24, Jan Beulich wrote: >> To fulfill the "protected" in its name, don't let the real hardware >> values "shine through". Report a control register value expressing this. > > Why not call it as it is?  They leak through due to bugs in MSR

[Xen-devel] [ovmf test] 144859: regressions - FAIL

2019-12-16 Thread osstest service owner
flight 144859 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144859/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

Re: [Xen-devel] [PATCH v3] Xen missing prompt log when exec-sp=off

2019-12-16 Thread Jan Beulich
On 16.12.2019 12:42, Jin Nan Wang wrote: > Fix a issue when user disable ETP exec-sp, xen missed a prompt > log in dmesg. Thanks for fixing the style issue, but submitting v3 without addressing the question on the "why" etc given on v2 isn't overly helpful. Jan __

[Xen-devel] [PATCH v3] Xen missing prompt log when exec-sp=off

2019-12-16 Thread Jin Nan Wang
Fix a issue when user disable ETP exec-sp, xen missed a prompt log in dmesg. Signed-off-by: James Wang --- xen/arch/x86/hvm/vmx/vmx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 7970ba93e1..9dcb10021

Re: [Xen-devel] [PATCH v2] Xen missing prompt log when exec-sp=off

2019-12-16 Thread Jin Nan Wang
On 16/12/2019 7:00 pm, Jan Beulich wrote: > On 16.12.2019 09:27, Jin Nan Wang wrote: >> Fix a issue when user disable ETP exec-sp, xen missed a prompt >> log in dmesg. > Why "missed" (and why "prompt")? I think the original intention > was to log a message only when no command line option was give

Re: [Xen-devel] [PATCH v3] Xen missing prompt log when exec-sp=off

2019-12-16 Thread Andrew Cooper
On 16/12/2019 11:49, Jan Beulich wrote: > On 16.12.2019 12:42, Jin Nan Wang wrote: >> Fix a issue when user disable ETP exec-sp, xen missed a prompt >> log in dmesg. > Thanks for fixing the style issue, but submitting v3 without > addressing the question on the "why" etc given on v2 isn't > overly

Re: [Xen-devel] [PATCH v2 0/3] x86: Protected Processor Inventory Number (PPIN) support

2019-12-16 Thread Andrew Cooper
On 16/12/2019 11:33, Jan Beulich wrote: > On 13.12.2019 20:50, Andrew Cooper wrote: >> On 08/11/2019 15:22, Jan Beulich wrote: >>> 1: include the PPIN in MCE records when available >>> 2: explicitly disallow guest access to PPIN >>> 3: provide Dom0 access to PPIN via XENPF_resource_op >>> >>> I hav

Re: [Xen-devel] [PATCH v2 2/3] x86: explicitly disallow guest access to PPIN

2019-12-16 Thread Andrew Cooper
On 16/12/2019 11:47, Jan Beulich wrote: >>   What >> you've done here is half-virtualise something we have no intention to >> ever virtualise for guests. >> >> Both of these should be blanket #GP faults.  AMD should never be in the >> position of seeing amd_ppin clear but PPIN_CTL returning LOCKOUT

[Xen-devel] [PATCH v4] Xen missing prompt log when exec-sp=off

2019-12-16 Thread Jin Nan Wang
Fix a issue when user disable ETP exec-sp, xen missed a prompt log in dmesg. At default, xen will tell "VMX: Disabling executable EPT suerpages due to CVE-2018-12207". When user add 'ept=exec-sp=off' on command-line. The prompt is disappeared. This can give users the illusion that the feature is t

Re: [Xen-devel] [PATCH 2/2] x86/time: update vtsc_last with cmpxchg and drop vtsc_lock

2019-12-16 Thread Roger Pau Monné
On Mon, Dec 16, 2019 at 12:21:09PM +0100, Jan Beulich wrote: > On 16.12.2019 11:00, Roger Pau Monné wrote: > > On Fri, Dec 13, 2019 at 10:48:02PM +, Igor Druzhinin wrote: > >> Now that vtsc_last is the only entity protected by vtsc_lock we can > >> simply update it using a single atomic operati

Re: [Xen-devel] [PATCH v2] Xen missing prompt log when exec-sp=off

2019-12-16 Thread Jan Beulich
On 16.12.2019 12:51, Jin Nan Wang wrote: > > On 16/12/2019 7:00 pm, Jan Beulich wrote: >> On 16.12.2019 09:27, Jin Nan Wang wrote: >>> Fix a issue when user disable ETP exec-sp, xen missed a prompt >>> log in dmesg. >> Why "missed" (and why "prompt")? I think the original intention >> was to log a

Re: [Xen-devel] [PATCH v2 2/3] x86: explicitly disallow guest access to PPIN

2019-12-16 Thread Jan Beulich
On 16.12.2019 13:26, Andrew Cooper wrote: > On 16/12/2019 11:47, Jan Beulich wrote: >>>   What >>> you've done here is half-virtualise something we have no intention to >>> ever virtualise for guests. >>> >>> Both of these should be blanket #GP faults.  AMD should never be in the >>> position of se

Re: [Xen-devel] [PATCH v4] Xen missing prompt log when exec-sp=off

2019-12-16 Thread Jan Beulich
On 16.12.2019 13:11, Jin Nan Wang wrote: > Fix a issue when user disable ETP exec-sp, xen missed a prompt > log in dmesg. > > At default, xen will tell "VMX: Disabling executable EPT suerpages > due to CVE-2018-12207". When user add 'ept=exec-sp=off' on command-line. > The prompt is disappeared. T

[Xen-devel] [ovmf test] 144860: regressions - FAIL

2019-12-16 Thread osstest service owner
flight 144860 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144860/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

Re: [Xen-devel] [PATCH 2/2] x86/time: update vtsc_last with cmpxchg and drop vtsc_lock

2019-12-16 Thread Jan Beulich
On 16.12.2019 13:30, Roger Pau Monné wrote: > On Mon, Dec 16, 2019 at 12:21:09PM +0100, Jan Beulich wrote: >> On 16.12.2019 11:00, Roger Pau Monné wrote: >>> On Fri, Dec 13, 2019 at 10:48:02PM +, Igor Druzhinin wrote: Now that vtsc_last is the only entity protected by vtsc_lock we can

[Xen-devel] [PATCH v10 1/4] xenbus/backend: Add memory pressure handler callback

2019-12-16 Thread SeongJae Park
From: SeongJae Park Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging for large systems having dynamic resource uti

[Xen-devel] [PATCH v10 0/4] xenbus/backend: Add a memory pressure handler callback

2019-12-16 Thread SeongJae Park
Granting pages consumes backend system memory. In systems configured with insufficient spare memory for those pages, it can cause a memory pressure situation. However, finding the optimal amount of the spare memory is challenging for large systems having dynamic resource utilization patterns. Al

[Xen-devel] [PATCH v10 3/4] xen/blkback: Remove unnecessary static variable name prefixes

2019-12-16 Thread SeongJae Park
From: SeongJae Park A few of static variables in blkback have 'xen_blkif_' prefix, though it is unnecessary for static variables. This commit removes such prefixes. Reviewed-by: Roger Pau Monné Signed-off-by: SeongJae Park --- drivers/block/xen-blkback/blkback.c | 37 +---

[Xen-devel] [PATCH v10 4/4] xen/blkback: Consistently insert one empty line between functions

2019-12-16 Thread SeongJae Park
From: SeongJae Park The number of empty lines between functions in the xenbus.c is inconsistent. This trivial style cleanup commit fixes the file to consistently place only one empty line. Acked-by: Roger Pau Monné Signed-off-by: SeongJae Park --- drivers/block/xen-blkback/xenbus.c | 7 ++---

[Xen-devel] [PATCH v10 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-16 Thread SeongJae Park
From: SeongJae Park Each `blkif` has a free pages pool for the grant mapping. The size of the pool starts from zero and is increased on demand while processing the I/O requests. If current I/O requests handling is finished or 100 milliseconds has passed since last I/O requests handling, it chec

Re: [Xen-devel] [PATCH 2/2] x86/time: update vtsc_last with cmpxchg and drop vtsc_lock

2019-12-16 Thread Igor Druzhinin
On 16/12/2019 10:00, Roger Pau Monné wrote: > On Fri, Dec 13, 2019 at 10:48:02PM +, Igor Druzhinin wrote: >> Now that vtsc_last is the only entity protected by vtsc_lock we can >> simply update it using a single atomic operation and drop the spinlock >> entirely. This is extremely important for

Re: [Xen-devel] [PATCH 2/2] x86/time: update vtsc_last with cmpxchg and drop vtsc_lock

2019-12-16 Thread Roger Pau Monné
On Mon, Dec 16, 2019 at 01:45:10PM +0100, Jan Beulich wrote: > On 16.12.2019 13:30, Roger Pau Monné wrote: > > On Mon, Dec 16, 2019 at 12:21:09PM +0100, Jan Beulich wrote: > >> On 16.12.2019 11:00, Roger Pau Monné wrote: > >>> On Fri, Dec 13, 2019 at 10:48:02PM +, Igor Druzhinin wrote: >

Re: [Xen-devel] [PATCH 2/2] x86/time: update vtsc_last with cmpxchg and drop vtsc_lock

2019-12-16 Thread Roger Pau Monné
On Mon, Dec 16, 2019 at 12:53:40PM +, Igor Druzhinin wrote: > On 16/12/2019 10:00, Roger Pau Monné wrote: > > On Fri, Dec 13, 2019 at 10:48:02PM +, Igor Druzhinin wrote: > > I'm not sure if the following would be slightly better performance > > wise: > > > > do { > > old = d->arch.vtsc

Re: [Xen-devel] [PATCH v2 2/3] x86: explicitly disallow guest access to PPIN

2019-12-16 Thread Andrew Cooper
On 16/12/2019 12:37, Jan Beulich wrote: > On 16.12.2019 13:26, Andrew Cooper wrote: >> On 16/12/2019 11:47, Jan Beulich wrote:   What you've done here is half-virtualise something we have no intention to ever virtualise for guests. Both of these should be blanket #GP faults

Re: [Xen-devel] [PATCH 03/12] hw/i386/pc: Remove obsolete pc_pci_device_init() declaration

2019-12-16 Thread Paolo Bonzini
On 13/12/19 17:17, Philippe Mathieu-Daudé wrote: > In commit 1454509726 we removed the pc_pci_device_init() > deprecated function and its calls, but we forgot to remove > its prototype. Do that now. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/i386/pc.h | 1 - > 1 file changed, 1

Re: [Xen-devel] [PATCH 04/12] hw/i386/pc: Remove obsolete cpu_set_smm_t typedef

2019-12-16 Thread Paolo Bonzini
On 13/12/19 17:17, Philippe Mathieu-Daudé wrote: > In commit f809c6051 we replaced the use of cpu_set_smm_t callbacks > by using a Notifier to modify the MemoryRegion. This prototype is > now not used anymore, we can safely remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/

Re: [Xen-devel] [PATCH 07/12] hw/ide/piix: Remove superfluous DEVICE() cast

2019-12-16 Thread Paolo Bonzini
On 13/12/19 17:17, Philippe Mathieu-Daudé wrote: > Commit 02a9594b4f0 already converted 'dev' to DeviceState. > Since the cast is superfluous, remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ide/piix.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw

Re: [Xen-devel] [PATCH 06/12] hw/i386/ich9: Move unnecessary "pci_bridge.h" include

2019-12-16 Thread Paolo Bonzini
On 13/12/19 17:17, Philippe Mathieu-Daudé wrote: > While the ICH9 chipset is a 'South Bridge', it is not a PCI bridge. > Nothing in "hw/i386/ich9.h" requires definitions from "pci_bridge.h" > so move its inclusion where it is required. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw

Re: [Xen-devel] [PATCH 09/12] hw/intc/ioapic: Make ioapic_print_redtbl() static

2019-12-16 Thread Paolo Bonzini
On 13/12/19 17:17, Philippe Mathieu-Daudé wrote: > Since commit 0c8465440 the ioapic_print_redtbl() function is not > used outside of ioapic_common.c, make it static, and remove its > prototype declaration in "ioapic_internal.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/i386/

Re: [Xen-devel] [PATCH 08/12] hw/ide/piix: Use ARRAY_SIZE() instead of magic numbers

2019-12-16 Thread Paolo Bonzini
On 13/12/19 17:17, Philippe Mathieu-Daudé wrote: > Using magic numbers is dangerous because the structures PCIIDEState > might be modified and this source file consuming the "ide/pci.h" > header would be out of sync, eventually accessing out of bound > array members. > Use the ARRAY_SIZE() to keep

Re: [Xen-devel] [PATCH 05/12] hw/i386/ich9: Remove unused include

2019-12-16 Thread Paolo Bonzini
On 13/12/19 17:17, Philippe Mathieu-Daudé wrote: > The "pcie_host.h" header is used by devices providing a PCI-e bus, > usually North Bridges. The ICH9 is a South Bridge. > Since we don't need this header, do not include it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/i386/ich9.

Re: [Xen-devel] [PATCH 0/3] Post-299 cleanups

2019-12-16 Thread Andrew Cooper
On 13/12/2019 17:37, George Dunlap wrote: > This series implements a number of cleanups to make the code simpler > and easier to follow. No functional changes intended. > > George Dunlap (3): > x86/mm: Use a more descriptive name for pagetable mfns > x86/mm: Use mfn_t in type get / put call tr

Re: [Xen-devel] [XEN PATCH 3/8] xen: Update Kconfig to Linux v5.4

2019-12-16 Thread Anthony PERARD
On Mon, Dec 16, 2019 at 11:16:52AM +0100, Jan Beulich wrote: > What headers are you taking about? My question was about the placement > of .gitignore entries only. I'm pretty sure I had previously expressed > that I'm not overly happy to see needless scattering around of them. > I'm merely trying t

[Xen-devel] [PATCH] x86/pv: Fix `global-pages` to match the documentation

2019-12-16 Thread Andrew Cooper
c/s 5de961d9c09 "x86: do not enable global pages when virtualized on AMD or Hygon hardware" in fact does. Fix the calculation in pge_init(). While fixing this, adjust the command line documenation, first to use the newer style, and to expand the description to discuss cases where the option might

[Xen-devel] [ovmf test] 144862: regressions - FAIL

2019-12-16 Thread osstest service owner
flight 144862 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144862/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

Re: [Xen-devel] [PATCH v4] gnttab: don't expose host physical address without need

2019-12-16 Thread Julien Grall
Hi, On 05/12/2019 15:34, Jan Beulich wrote: Translated domains shouldn't see host physical addresses. While the address is also not supposed to be handed back even to non-translated domains when GNTMAP_device_map is not set (as explicitly stated by a comment in the public header), PV kernels (Li

Re: [Xen-devel] [PATCH 1/2] x86/time: drop vtsc_{kern, user}count debug counters

2019-12-16 Thread Andrew Cooper
On 16/12/2019 09:47, Roger Pau Monné wrote: > On Fri, Dec 13, 2019 at 10:48:01PM +, Igor Druzhinin wrote: >> They either need to be transformed to atomics to work correctly >> (currently they left unprotected for HVM domains) or dropped entirely > ^ are used >> as taking a per

[Xen-devel] [PATCH] xen-bus/block: explicitly assign event channels to an AioContext

2019-12-16 Thread Paul Durrant
It is not safe to close an event channel from the QEMU main thread when that channel's poller is running in IOThread context. This patch adds a new xen_device_set_event_channel_context() function to explicitly assign the channel AioContext, and modifies xen_device_bind_event_channel() to initially

Re: [Xen-devel] [PATCH v10 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-16 Thread SeongJae Park
On Mon, 16 Dec 2019 13:45:25 +0100 SeongJae Park wrote: > From: SeongJae Park > > Each `blkif` has a free pages pool for the grant mapping. The size of > the pool starts from zero and is increased on demand while processing > the I/O requests. If current I/O requests handling is finished or 1

[Xen-devel] [ovmf test] 144863: regressions - FAIL

2019-12-16 Thread osstest service owner
flight 144863 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144863/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

Re: [Xen-devel] [PATCH] x86/pv: Fix `global-pages` to match the documentation

2019-12-16 Thread Roger Pau Monné
On Mon, Dec 16, 2019 at 02:02:27PM +, Andrew Cooper wrote: > c/s 5de961d9c09 "x86: do not enable global pages when virtualized on AMD or > Hygon hardware" in fact does. Fix the calculation in pge_init(). > > While fixing this, adjust the command line documenation, first to use the > newer sty

Re: [Xen-devel] [PATCH 12/12] hw/i386/pc: Move PC-machine specific declarations to 'pc_internal.h'

2019-12-16 Thread Philippe Mathieu-Daudé
On 12/15/19 10:58 AM, Michael S. Tsirkin wrote: On Fri, Dec 13, 2019 at 05:47:28PM +0100, Philippe Mathieu-Daudé wrote: On 12/13/19 5:17 PM, Philippe Mathieu-Daudé wrote: Historically, QEMU started with only one X86 machine: the PC. The 'hw/i386/pc.h' header was used to store all X86 and PC dec

Re: [Xen-devel] [PATCH 12/12] hw/i386/pc: Move PC-machine specific declarations to 'pc_internal.h'

2019-12-16 Thread Paolo Bonzini
On 16/12/19 16:37, Philippe Mathieu-Daudé wrote: > On 12/15/19 10:58 AM, Michael S. Tsirkin wrote: >> On Fri, Dec 13, 2019 at 05:47:28PM +0100, Philippe Mathieu-Daudé wrote: >>> On 12/13/19 5:17 PM, Philippe Mathieu-Daudé wrote: Historically, QEMU started with only one X86 machine: the PC. >>>

Re: [Xen-devel] [PATCH 12/12] hw/i386/pc: Move PC-machine specific declarations to 'pc_internal.h'

2019-12-16 Thread Philippe Mathieu-Daudé
On 12/16/19 4:41 PM, Paolo Bonzini wrote: On 16/12/19 16:37, Philippe Mathieu-Daudé wrote: On 12/15/19 10:58 AM, Michael S. Tsirkin wrote: On Fri, Dec 13, 2019 at 05:47:28PM +0100, Philippe Mathieu-Daudé wrote: On 12/13/19 5:17 PM, Philippe Mathieu-Daudé wrote: Historically, QEMU started wi

Re: [Xen-devel] [PATCH] x86/pv: Fix `global-pages` to match the documentation

2019-12-16 Thread Jan Beulich
On 16.12.2019 16:38, Roger Pau Monné wrote: > On Mon, Dec 16, 2019 at 02:02:27PM +, Andrew Cooper wrote: >> c/s 5de961d9c09 "x86: do not enable global pages when virtualized on AMD or >> Hygon hardware" in fact does. Fix the calculation in pge_init(). >> >> While fixing this, adjust the comman

Re: [Xen-devel] [XEN PATCH 3/8] xen: Update Kconfig to Linux v5.4

2019-12-16 Thread Jan Beulich
On 16.12.2019 15:01, Anthony PERARD wrote: > On Mon, Dec 16, 2019 at 11:16:52AM +0100, Jan Beulich wrote: >> What headers are you taking about? My question was about the placement >> of .gitignore entries only. I'm pretty sure I had previously expressed >> that I'm not overly happy to see needless

Re: [Xen-devel] [PATCH v4] gnttab: don't expose host physical address without need

2019-12-16 Thread Jan Beulich
On 16.12.2019 15:19, Julien Grall wrote: > On 05/12/2019 15:34, Jan Beulich wrote: >> Translated domains shouldn't see host physical addresses. While the >> address is also not supposed to be handed back even to non-translated >> domains when GNTMAP_device_map is not set (as explicitly stated by a

Re: [Xen-devel] [PATCH v10 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-16 Thread SeongJae Park
On Mon, 16 Dec 2019 15:37:20 +0100 SeongJae Park wrote: > On Mon, 16 Dec 2019 13:45:25 +0100 SeongJae Park wrote: > > > From: SeongJae Park > > [...] > > --- a/drivers/block/xen-blkback/xenbus.c > > +++ b/drivers/block/xen-blkback/xenbus.c > > @@ -824,6 +824,24 @@ static void frontend_changed

[Xen-devel] [PATCH] x86/mm: Simplify promote_l4_table()'s exit semantics

2019-12-16 Thread Andrew Cooper
promote_l4_table() is different from its lower level helpers, by having an extra return path out of the middle of the loop in the case of a failure. Break from the loop, which is consistent with the other helpers, and functionally equivalent. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC:

[Xen-devel] [ovmf test] 144867: regressions - FAIL

2019-12-16 Thread osstest service owner
flight 144867 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144867/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

Re: [Xen-devel] [PATCH v10 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-16 Thread Jürgen Groß
On 16.12.19 17:15, SeongJae Park wrote: On Mon, 16 Dec 2019 15:37:20 +0100 SeongJae Park wrote: On Mon, 16 Dec 2019 13:45:25 +0100 SeongJae Park wrote: From: SeongJae Park [...] --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -824,6 +824,24 @@ static

Re: [Xen-devel] [XEN PATCH 3/8] xen: Update Kconfig to Linux v5.4

2019-12-16 Thread Anthony PERARD
On Mon, Dec 16, 2019 at 04:55:52PM +0100, Jan Beulich wrote: > On 16.12.2019 15:01, Anthony PERARD wrote: > > On Mon, Dec 16, 2019 at 11:16:52AM +0100, Jan Beulich wrote: > >> What headers are you taking about? My question was about the placement > >> of .gitignore entries only. I'm pretty sure I h

Re: [Xen-devel] [PATCH] x86/mm: Simplify promote_l4_table()'s exit semantics

2019-12-16 Thread George Dunlap
On 12/16/19 4:20 PM, Andrew Cooper wrote: > promote_l4_table() is different from its lower level helpers, by having an > extra return path out of the middle of the loop in the case of a failure. > > Break from the loop, which is consistent with the other helpers, and > functionally equivalent. >

Re: [Xen-devel] [PATCH v3 01/22] golang/xenlight: generate enum types from IDL

2019-12-16 Thread George Dunlap
On 12/10/19 3:47 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > Introduce gengotypes.py to generate Go code the from IDL. As a first step, > implement 'enum' type generation. > > As a result of the newly-generated code, remove the existing, and now > conflicting definitions in xenlight.go. I

Re: [Xen-devel] [PATCH v3 07/22] golang/xenlight: define Mac builtin type

2019-12-16 Thread George Dunlap
On 12/10/19 3:47 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > Define Mac as [6]byte and implement fromC, toC, and String functions. > > Signed-off-by: Nick Rosbrook > Reviewed-by: George Dunlap > --- > Changes in v2: > - Fix the format string in String function to use %02x. > - Use a val

[Xen-devel] [ovmf test] 144874: regressions - FAIL

2019-12-16 Thread osstest service owner
flight 144874 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144874/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

Re: [Xen-devel] [PATCH 1/6] x86/suspend: Clarify and improve the behaviour of do_suspend_lowlevel()

2019-12-16 Thread Roger Pau Monné
On Fri, Dec 13, 2019 at 07:04:31PM +, Andrew Cooper wrote: > do_suspend_lowlevel() behaves as a function call, even when the trampoline > jumps back into the middle of it. Discuss this property, while renaming the > far-too-generic __ret_point to s3_resume. > > Optimise the calling logic for

[Xen-devel] [xtf test] 144868: all pass - PUSHED

2019-12-16 Thread osstest service owner
flight 144868 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144868/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf 8afcfc0c18de7a9a40aa0eb671772f9de577ccbf baseline version: xtf 27c415ad6e4a48eb3aac6e

Re: [Xen-devel] [PATCH v3 01/22] golang/xenlight: generate enum types from IDL

2019-12-16 Thread Nick Rosbrook
> I was expecting you to change this if you sent a v3. :-) > > I can still change it on check-in, but if for some reason there's a v4, > please make the change before resending. Thanks. :-) Sorry, my mistake. I will make the change if I send v4. Thanks, -NR _

Re: [Xen-devel] [PATCH v3 15/22] golang/xenlight: begin C to Go type marshaling

2019-12-16 Thread George Dunlap
On 12/10/19 3:47 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > Begin implementation of fromC marshaling functions for generated struct > types. This includes support for converting fields that are basic > primitive types such as string and integer types, nested anonymous > structs, nested li

Re: [Xen-devel] [PATCH v3 16/22] golang/xenlight: implement keyed union C to Go marshaling

2019-12-16 Thread George Dunlap
On 12/10/19 3:47 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > Switch over union key to determine how to populate 'union' in Go struct. > > Since the unions of C types cannot be directly accessed in cgo, use a > typeof trick to typedef a struct in the cgo preamble that is analagous > to eac

[Xen-devel] Xen ARM Dom0less passthrough without IOMMU

2019-12-16 Thread Andrei Cherechesu
Hello, My name is Andrei Cherechesu and I'm a Software Engineer at NXP Semiconductors in the Automotive department, Linux BSP Team. I would like to tell you have done a great job so far with Xen. Thus, we have ported and integrated Xen ARM in the Linux BSP for our boards. Currently, we are tryin

Re: [Xen-devel] [PATCH v3 11/22] golang/xenlight: re-factor Uuid type implementation

2019-12-16 Thread George Dunlap
On 12/10/19 3:47 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > Re-define Uuid as [16]byte and implement fromC, toC, and String functions. > > Signed-off-by: Nick Rosbrook Reviewed-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xe

[Xen-devel] [ovmf test] 144875: regressions - FAIL

2019-12-16 Thread osstest service owner
flight 144875 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144875/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

[Xen-devel] [xen-unstable-smoke test] 144871: tolerable all pass - PUSHED

2019-12-16 Thread osstest service owner
flight 144871 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/144871/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] [ovmf test] 144876: regressions - FAIL

2019-12-16 Thread osstest service owner
flight 144876 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/144876/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm6 xen-buildfail REGR. vs. 144637 build-amd64

[Xen-devel] [qemu-mainline test] 144861: tolerable FAIL - PUSHED

2019-12-16 Thread osstest service owner
flight 144861 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/144861/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 18 guest-localmigrate/x10 fail blocked in 144805 test-amd64-amd64-xl-qemuu-win7-amd6

Re: [Xen-devel] [PATCH v10 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected

2019-12-16 Thread SeongJae Park
On on, 16 Dec 2019 17:23:44 +0100, Jürgen Groß wrote: > On 16.12.19 17:15, SeongJae Park wrote: > > On Mon, 16 Dec 2019 15:37:20 +0100 SeongJae Park wrote: > > > >> On Mon, 16 Dec 2019 13:45:25 +0100 SeongJae Park wrote: > >> > >>> From: SeongJae Park > >>> > > [...] > >>> --- a/drivers/block/

[Xen-devel] REGRESSION: Xen 4.13 RC5 fails to bootstrap Dom0 on ARM

2019-12-16 Thread Roman Shaposhnik
Hi! it appears that something has broken in 4.13 RC5 so that I'm now getting the following on ARM (full logs are attached). (XEN) (XEN) Panic on CPU 0: (XEN) Failed to allocate requested dom0 memory. 672MB unallocated (XEN)

Re: [Xen-devel] [PATCH v4 1/6] arm/arm64/xen: hypercall.h add includes guards

2019-12-16 Thread Julien Grall
Hi, On 04/12/2019 23:20, Pavel Tatashin wrote: The arm and arm64 versions of hypercall.h are missing the include guards. This is needed because C inlines for privcmd_call are going to be added to the files. Also fix a comment. Signed-off-by: Pavel Tatashin --- arch/arm/include/asm/assembler

Re: [Xen-devel] [PATCH v4 2/6] arm/arm64/xen: use C inlines for privcmd_call

2019-12-16 Thread Julien Grall
Hello, On 04/12/2019 23:20, Pavel Tatashin wrote: privcmd_call requires to enable access to userspace for the duration of the hypercall. Currently, this is done via assembly macros. Change it to C inlines instead. Signed-off-by: Pavel Tatashin Acked-by: Stefano Stabellini Reviewed-by: Juli

  1   2   >