On 12/16/19 11:07 AM, Jan Beulich wrote: > On 13.12.2019 18:37, George Dunlap wrote: >> In many places, a PTE being modified is accompanied by the pagetable >> mfn which contains the PTE (primarily in order to be able to maintain >> linear mapping counts). In many cases, this mfn is stored in the >> non-descript variable (or argement) "pfn". >> >> Replace these names with lNmfn, to indicate that 1) this is a >> pagetable mfn, and 2) that it is the same level as the PTE in >> question. This should be enough to remind readers that it's the mfn >> containing the PTE. >> >> No functional change. >> >> Signed-off-by: George Dunlap <george.dun...@citrix.com> > > Acked-by: Jan Beulich <jbeul...@suse.com> > > I take it you considered by dropped the idea of switching to mfn_t > at the same time, as suggested by Andrew on v1?
Me: <waits for Jan to get to patch 2> :-) I thought it would be easier to review as two patches, each of which did exactly one thing. Since this patch was already complete, it was just as easy to make a second patch as to make one more-complicated-to-review patch. Thanks, -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
