Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Julien Grall
Hi Stefano, On 28/11/2019 01:12, Stefano Stabellini wrote: On Wed, 27 Nov 2019, Jürgen Groß wrote: On 27.11.19 10:31, Peng Fan wrote: Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range On 27.11.19 01:01, Julien Grall wrote: Hi, On 26/11/2019 23:17, Stefano Stab

Re: [Xen-devel] [PATCH v1] psr: fix bug which may cause crash

2019-11-28 Thread Yi Sun
On 19-11-27 11:06:49, Jan Beulich wrote: > On 27.11.2019 07:24, Yi Sun wrote: > > During test, we found a crash on Xen with below trace. > > (XEN) Xen call trace: > > (XEN)[] R psr.c#l3_cdp_write_msr+0x1e/0x22 > > (XEN)[] F psr.c#do_write_psr_msrs+0x6d/0x109 > > (XEN)[] F smp_call_funct

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Jürgen Groß
On 28.11.19 09:14, Julien Grall wrote: Hi Stefano, On 28/11/2019 01:12, Stefano Stabellini wrote: On Wed, 27 Nov 2019, Jürgen Groß wrote: On 27.11.19 10:31, Peng Fan wrote: Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range On 27.11.19 01:01, Julien Grall wrote

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Peng Fan
> Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER > range > > Hi Stefano, > > On 28/11/2019 01:12, Stefano Stabellini wrote: > > On Wed, 27 Nov 2019, Jürgen Groß wrote: > >> On 27.11.19 10:31, Peng Fan wrote: > Subject: Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3

[Xen-devel] [PATCH v2] xen/events: remove event handling recursion detection

2019-11-28 Thread Juergen Gross
__xen_evtchn_do_upcall() contains guards against being called recursively. This mechanism was introduced in the early pvops times (kernel 2.6.26) when there were all the Xen backend drivers missing from the upstream kernel, and some of those out-of-tree drivers were enabling interrupts in their eve

Re: [Xen-devel] [PATCH v2 0/2] xen/gntdev: sanitize user interface handling

2019-11-28 Thread Jürgen Groß
On 07.11.19 12:15, Juergen Gross wrote: The Xen gntdev driver's checking of the number of allowed mapped pages is in need of some sanitizing work. Changes in V2: - enhanced commit message of patch 1 (Andrew Cooper) Juergen Gross (2): xen/gntdev: replace global limit of mapped pages by limit

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Julien Grall
Hi, On 28/11/2019 08:32, Jürgen Groß wrote: On 28.11.19 09:14, Julien Grall wrote: In short, I think the patch should go in now and there are no downsides to it. That's it, I rest my case. Julien, I hope you'll reconsider. I don't really see the point to try to allow Linux 5.4 booting on Xen 4

Re: [Xen-devel] [RFC v5 000/126] error: auto propagated local_err

2019-11-28 Thread Markus Armbruster
Please accept my sincere apologies for taking so long to reply. A few thoughts before I dig deeper. Vladimir Sementsov-Ogievskiy writes: > Hi all! > > At the request of Markus: full version of errp propagation. Let's look > at it. Cover as much as possible, except inserting macro invocation > w

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Jürgen Groß
On 28.11.19 09:48, Julien Grall wrote: Hi, On 28/11/2019 08:32, Jürgen Groß wrote: On 28.11.19 09:14, Julien Grall wrote: In short, I think the patch should go in now and there are no downsides to it. That's it, I rest my case. Julien, I hope you'll reconsider. I don't really see the point to

Re: [Xen-devel] [PATCH v2] xen/x86: vpmu: Unmap per-vCPU PMU page when the domain is destroyed

2019-11-28 Thread Durrant, Paul
> -Original Message- > From: Julien Grall > Sent: 27 November 2019 19:42 > To: Durrant, Paul ; xen-devel@lists.xenproject.org > Cc: Jan Beulich ; Andrew Cooper > ; Wei Liu ; Roger Pau Monné > ; Jun Nakajima ; Kevin Tian > > Subject: Re: [PATCH v2] xen/x86: vpmu: Unmap per-vCPU PMU page wh

Re: [Xen-devel] [RFC v5 000/126] error: auto propagated local_err

2019-11-28 Thread Vladimir Sementsov-Ogievskiy
28.11.2019 11:54, Markus Armbruster wrote: > Please accept my sincere apologies for taking so long to reply. A few > thoughts before I dig deeper. > > Vladimir Sementsov-Ogievskiy writes: > >> Hi all! >> >> At the request of Markus: full version of errp propagation. Let's look >> at it. Cover a

[Xen-devel] [PATCH v3] xen/x86: vpmu: Unmap per-vCPU PMU page when the domain is destroyed

2019-11-28 Thread Paul Durrant
From: Julien Grall A guest will setup a shared page with the hypervisor for each vCPU via XENPMU_init. The page will then get mapped in the hypervisor and only released when XENPMU_finish is called. This means that if the guest fails to invoke XENPMU_finish, e.g if it is destroyed rather than cl

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Julien Grall
On 28/11/2019 09:00, Jürgen Groß wrote: On 28.11.19 09:48, Julien Grall wrote: Hi, On 28/11/2019 08:32, Jürgen Groß wrote: On 28.11.19 09:14, Julien Grall wrote: In short, I think the patch should go in now and there are no downsides to it. That's it, I rest my case. Julien, I hope you'll

Re: [Xen-devel] [XEN PATCH v3 07/11] xen: arm: vgic: allow delivery of PPIs to guests

2019-11-28 Thread Julien Grall
On 28/11/2019 01:07, Stefano Stabellini wrote: On Wed, 27 Nov 2019, Julien Grall wrote: On Tue, 26 Nov 2019, 23:18 Stefano Stabellini, wrote: On Fri, 15 Nov 2019, Stewart Hildebrand wrote: > Allow vgic_get_hw_irq_desc to be called with a vcpu argument. > > Use vcpu

Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

2019-11-28 Thread Jan Beulich
On 27.11.2019 19:17, Andrew Cooper wrote: > On 21/11/2019 08:34, Jan Beulich wrote: >> On 20.11.2019 18:13, Andrew Cooper wrote: >>> On 20/11/2019 16:40, Jürgen Groß wrote: On 20.11.19 17:30, Jan Beulich wrote: > On 08.11.2019 12:18, Jan Beulich wrote: >> The .file assembler directives

Re: [Xen-devel] [PATCH v1] psr: fix bug which may cause crash

2019-11-28 Thread Jan Beulich
On 28.11.2019 09:17, Yi Sun wrote: > On 19-11-27 11:06:49, Jan Beulich wrote: >> On 27.11.2019 07:24, Yi Sun wrote: >>> --- a/xen/arch/x86/psr.c >>> +++ b/xen/arch/x86/psr.c >>> @@ -316,6 +316,7 @@ static bool cat_init_feature(const struct cpuid_leaf >>> *regs, >>> [FEAT_TYPE_L3_CDP] = "L

Re: [Xen-devel] getting 4.11.3 ready

2019-11-28 Thread Jan Beulich
On 28.11.2019 00:51, Lars Kurth wrote: > On 29/10/2019, 12:41, "Stefano Stabellini" wrote: > On Tue, 29 Oct 2019, Julien Grall wrote: > > On 28/10/2019 21:43, Stefano Stabellini wrote: > > > On Mon, 28 Oct 2019, Julien Grall wrote: > > >> Hi, > > >> > > >> On 25/10/2019 11

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

2019-11-28 Thread Jan Beulich
On 28.11.2019 01:54, Stefano Stabellini wrote: > On Thu, 26 Sep 2019, Lars Kurth wrote: >> From: Lars Kurth >> >> This document highlights what reviewers such as maintainers and committers >> look >> for when reviewing code. It sets expectations for code authors and provides >> a framework for co

Re: [Xen-devel] [PATCH] tools/arm: include xen-tools/libs.h from libxl_arm_acpi.c

2019-11-28 Thread Wei Liu
On Wed, Nov 27, 2019 at 06:24:58PM -0800, Stefano Stabellini wrote: > libxl_arm_acpi.c is using BUILD_BUG_ON but it is not including > xen-tools/libs.h that defines it. > > Signed-off-by: Stefano Stabellini Acked-by: Wei Liu Juergen, this is a trivial patch. I think it can go in 4.13. Wei. >

Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

2019-11-28 Thread George Dunlap
> On Nov 28, 2019, at 9:55 AM, Jan Beulich wrote: Has anyone actually tried building a livepatch with this change in place? >>> Actually - what is your concern here? The exact spelling of symbols >>> names should be of no interest to the tool. After all the compiler is >>> free to invent all

[Xen-devel] [xen-4.12-testing test] 144339: tolerable FAIL - PUSHED

2019-11-28 Thread osstest service owner
flight 144339 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/144339/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qcow217 guest-localmigrate/x10 fail like 144319 test-amd64-i386-xl-pvshim12

Re: [Xen-devel] [PATCH v2 6/6] Added Resolving Disagreement

2019-11-28 Thread Jan Beulich
On 28.11.2019 01:56, Stefano Stabellini wrote: > On Thu, 26 Sep 2019, Lars Kurth wrote: >> +This could take for example the form of >> +> Do you think it would be useful for the code to do XXX? >> +> I can imagine a user wanting to do YYY (and XXX would enable this) >> + >> +That potentially adds

[Xen-devel] [PATCH v2] psr: fix bug which may cause crash

2019-11-28 Thread Yi Sun
During test, we found a crash on Xen with below trace. (XEN) Xen call trace: (XEN)[] R psr.c#l3_cdp_write_msr+0x1e/0x22 (XEN)[] F psr.c#do_write_psr_msrs+0x6d/0x109 (XEN)[] F smp_call_function_interrupt+0x5a/0xac (XEN)[] F call_function_interrupt+0x20/0x34 (XEN)[] F do_IRQ+0x175

Re: [Xen-devel] [PATCH v3] xen/x86: vpmu: Unmap per-vCPU PMU page when the domain is destroyed

2019-11-28 Thread Jan Beulich
On 28.11.2019 10:38, Paul Durrant wrote: > From: Julien Grall > > A guest will setup a shared page with the hypervisor for each vCPU via > XENPMU_init. The page will then get mapped in the hypervisor and only > released when XENPMU_finish is called. > > This means that if the guest fails to invo

Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

2019-11-28 Thread Jürgen Groß
On 28.11.19 11:17, George Dunlap wrote: On Nov 28, 2019, at 9:55 AM, Jan Beulich wrote: Has anyone actually tried building a livepatch with this change in place? Actually - what is your concern here? The exact spelling of symbols names should be of no interest to the tool. After all the comp

Re: [Xen-devel] [PATCH v2] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Durrant, Paul
> -Original Message- > From: George Dunlap > Sent: 27 November 2019 16:52 > To: Durrant, Paul ; Jan Beulich > Cc: AndrewCooper ; Anthony PERARD > ; Roger Pau Monné ; > Volodymyr Babchuk ; George Dunlap > ; Ian Jackson ; > Marek Marczykowski-Górecki ; Stefano > Stabellini ; xen-devel@lists

Re: [Xen-devel] [PATCH v3] xen/x86: vpmu: Unmap per-vCPU PMU page when the domain is destroyed

2019-11-28 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 28 November 2019 10:23 > To: Durrant, Paul ; Boris Ostrovsky > > Cc: xen-devel@lists.xenproject.org; Grall, Julien ; > Andrew Cooper ; Roger Pau Monné > ; Jun Nakajima ; Kevin Tian > ; Wei Liu > Subject: Re: [PATCH v3] xen/x86: vpmu: Unmap

Re: [Xen-devel] [PATCH] tools/arm: include xen-tools/libs.h from libxl_arm_acpi.c

2019-11-28 Thread Jürgen Groß
On 28.11.19 11:15, Wei Liu wrote: On Wed, Nov 27, 2019 at 06:24:58PM -0800, Stefano Stabellini wrote: libxl_arm_acpi.c is using BUILD_BUG_ON but it is not including xen-tools/libs.h that defines it. Signed-off-by: Stefano Stabellini Acked-by: Wei Liu Juergen, this is a trivial patch. I thi

Re: [Xen-devel] [PATCH v2] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Jan Beulich
On 28.11.2019 11:26, Durrant, Paul wrote: >> From: George Dunlap >> Sent: 27 November 2019 16:52 >> >> On 11/27/19 4:43 PM, Durrant, Paul wrote: From: George Dunlap Sent: 27 November 2019 16:34 TBH I'd be tempted to define XENSOMETHING_MAX_DEFAULT as (unsigned long)(-1)

Re: [Xen-devel] [PATCH] tools/arm: include xen-tools/libs.h from libxl_arm_acpi.c

2019-11-28 Thread Wei Liu
On Thu, Nov 28, 2019 at 11:30:34AM +0100, Jürgen Groß wrote: > On 28.11.19 11:15, Wei Liu wrote: > > On Wed, Nov 27, 2019 at 06:24:58PM -0800, Stefano Stabellini wrote: > > > libxl_arm_acpi.c is using BUILD_BUG_ON but it is not including > > > xen-tools/libs.h that defines it. > > > > > > Signed-o

Re: [Xen-devel] [Xen-users] 4.13RC3 and PVHVM makes drive drops just after boot

2019-11-28 Thread Anthony PERARD
On Wed, Nov 27, 2019 at 10:54:42PM +1000, Andrew wrote: > I have the system setup for testing, so happy to test any patches that may > come out. Thanks Andrew for the report, I think I understand the issue. I'll work on a fix. Cheers, -- Anthony PERARD _

[Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack

2019-11-28 Thread Jan Beulich
At the time the pending EOI stack was introduced there were no internally used IRQs which would have the LAPIC EOI issued from the ->end() hook. This had then changed with the introduction of IOMMUs, but the interaction issue was presumably masked by irq_guest_eoi_timer_fn() frequently EOI-ing inte

Re: [Xen-devel] [PATCH v2] x86 / iommu: set up a scratch page in the quarantine domain

2019-11-28 Thread Jan Beulich
On 27.11.2019 18:11, Paul Durrant wrote: > This patch introduces a new iommu_op to facilitate a per-implementation > quarantine set up, and then further code for x86 implementations > (amd and vtd) to set up a read-only scratch page to serve as the source > for DMA reads whilst a device is assigned

Re: [Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack

2019-11-28 Thread Jan Beulich
On 28.11.2019 12:03, Jan Beulich wrote: > At the time the pending EOI stack was introduced there were no > internally used IRQs which would have the LAPIC EOI issued from the > ->end() hook. This had then changed with the introduction of IOMMUs, > but the interaction issue was presumably masked by

Re: [Xen-devel] [PATCH v2] psr: fix bug which may cause crash

2019-11-28 Thread Jan Beulich
On 28.11.2019 11:18, Yi Sun wrote: > --- a/xen/arch/x86/psr.c > +++ b/xen/arch/x86/psr.c > @@ -1271,7 +1271,8 @@ static void do_write_psr_msrs(void *data) > > for ( j = 0; j < cos_num; j++, index++ ) > { > -if ( feat->cos_reg_val[cos * cos_num + j] != info->val[index

Re: [Xen-devel] [PATCH v2] x86 / iommu: set up a scratch page in the quarantine domain

2019-11-28 Thread Jürgen Groß
On 28.11.19 12:17, Jan Beulich wrote: On 27.11.2019 18:11, Paul Durrant wrote: This patch introduces a new iommu_op to facilitate a per-implementation quarantine set up, and then further code for x86 implementations (amd and vtd) to set up a read-only scratch page to serve as the source for DMA

Re: [Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack

2019-11-28 Thread Jürgen Groß
On 28.11.19 12:19, Jan Beulich wrote: On 28.11.2019 12:03, Jan Beulich wrote: At the time the pending EOI stack was introduced there were no internally used IRQs which would have the LAPIC EOI issued from the ->end() hook. This had then changed with the introduction of IOMMUs, but the interactio

[Xen-devel] [PATCH for-next] x86/svm: Correct vm_event API for descriptor accesses

2019-11-28 Thread Andrew Cooper
c/s d0a699a389f1 "x86/monitor: add support for descriptor access events" introduced logic looking for what appeared to be exitinfo (not that this exists in SVM - exitinfo1 or 2 do), but actually passed the exit IDT vectoring information. There is never any IDT vectoring involved in these intercept

Re: [Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack

2019-11-28 Thread Roger Pau Monné
On Thu, Nov 28, 2019 at 12:03:47PM +0100, Jan Beulich wrote: > At the time the pending EOI stack was introduced there were no > internally used IRQs which would have the LAPIC EOI issued from the > ->end() hook. This had then changed with the introduction of IOMMUs, > but the interaction issue was

Re: [Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack

2019-11-28 Thread Andrew Cooper
On 28/11/2019 11:03, Jan Beulich wrote: > Notes: > > - In principle we could get away without the check_eoi_deferral flag. > I've introduced it just to make sure there's as little change as > possible to unaffected paths. > - Similarly the cpu_has_pending_apic_eoi() check in do_IRQ() isn't >

Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

2019-11-28 Thread Sergey Dyasli
On 27/11/2019 18:17, Andrew Cooper wrote: > On 21/11/2019 08:34, Jan Beulich wrote: >> On 20.11.2019 18:13, Andrew Cooper wrote: >>> On 20/11/2019 16:40, Jürgen Groß wrote: On 20.11.19 17:30, Jan Beulich wrote: > On 08.11.2019 12:18, Jan Beulich wrote: >> The .file assembler directives

Re: [Xen-devel] [RFC v5 000/126] error: auto propagated local_err

2019-11-28 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 28.11.2019 11:54, Markus Armbruster wrote: >> Please accept my sincere apologies for taking so long to reply. A few >> thoughts before I dig deeper. >> >> Vladimir Sementsov-Ogievskiy writes: >> >>> Hi all! >>> >>> At the request of Markus: full version

[Xen-devel] [libvirt test] 144345: regressions - FAIL

2019-11-28 Thread osstest service owner
flight 144345 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/144345/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-qcow2 15 guest-start/debian.repeat fail REGR. vs. 144304 Tests which did not

[Xen-devel] [PATCH-for-4.13 v3] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Paul Durrant
From: George Dunlap Xen used to have single, system-wide limits for the number of grant frames and maptrack frames a guest was allowed to create. Increasing or decreasing this single limit on the Xen command-line would change the limit for all guests on the system. Later, per-domain limits for t

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

2019-11-28 Thread Lars Kurth
On 28/11/2019, 04:09, "Jan Beulich" wrote: On 28.11.2019 01:54, Stefano Stabellini wrote: > On Thu, 26 Sep 2019, Lars Kurth wrote: >> From: Lars Kurth >> >> This document highlights what reviewers such as maintainers and committers look >> for when reviewing code. It

Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

2019-11-28 Thread Andrew Cooper
On 28/11/2019 10:17, George Dunlap wrote: >> On Nov 28, 2019, at 9:55 AM, Jan Beulich wrote: > Has anyone actually tried building a livepatch with this change in place? Actually - what is your concern here? The exact spelling of symbols names should be of no interest to the tool. Aft

Re: [Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack

2019-11-28 Thread Jan Beulich
On 28.11.2019 12:39, Roger Pau Monné wrote: > On Thu, Nov 28, 2019 at 12:03:47PM +0100, Jan Beulich wrote: >> At the time the pending EOI stack was introduced there were no >> internally used IRQs which would have the LAPIC EOI issued from the >> ->end() hook. This had then changed with the introdu

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

2019-11-28 Thread Jan Beulich
On 28.11.2019 14:06, Lars Kurth wrote: > I can certainly add something on the timing , along the lines of > * For complex series, consider the time it takes to do reviews (maybe with a > guide of LOC per hour) and give reviewers enough time to > * For series with design issues or large questions,

Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

2019-11-28 Thread Jan Beulich
On 28.11.2019 14:10, Andrew Cooper wrote: > On 28/11/2019 10:17, George Dunlap wrote: >>> On Nov 28, 2019, at 9:55 AM, Jan Beulich wrote: >> Has anyone actually tried building a livepatch with this change in place? > Actually - what is your concern here? The exact spelling of symbols >

Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

2019-11-28 Thread Jan Beulich
On 28.11.2019 13:15, Sergey Dyasli wrote: > Applying the patch didn't end up well for my test LP (from another thread): > > Perform full initial build with 8 CPU(s)... > Reading special section data > Apply patch and build with 8 CPU(s)... > Unapply patch and build with 8 CPU(s)... > Extracting ne

Re: [Xen-devel] [PATCH for-next] x86/svm: Correct vm_event API for descriptor accesses

2019-11-28 Thread Tamas K Lengyel
On Thu, Nov 28, 2019 at 4:44 AM Andrew Cooper wrote: > > c/s d0a699a389f1 "x86/monitor: add support for descriptor access events" > introduced logic looking for what appeared to be exitinfo (not that this > exists in SVM - exitinfo1 or 2 do), but actually passed the exit IDT vectoring > informatio

Re: [Xen-devel] [PATCH-for-4.13 v3] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Durrant, Paul
> -Original Message- > From: Paul Durrant > Sent: 28 November 2019 12:51 > To: xen-devel@lists.xenproject.org > Cc: George Dunlap ; Durrant, Paul > ; Ian Jackson ; Wei Liu > ; Andrew Cooper ; George Dunlap > ; Jan Beulich ; Julien > Grall ; Konrad Rzeszutek Wilk ; > Stefano Stabellini ; An

Re: [Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack

2019-11-28 Thread Andrew Cooper
On 28/11/2019 12:10, Andrew Cooper wrote: > On 28/11/2019 11:03, Jan Beulich wrote: >> Notes: >> >> - In principle we could get away without the check_eoi_deferral flag. >> I've introduced it just to make sure there's as little change as >> possible to unaffected paths. >> - Similarly the cpu_h

Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

2019-11-28 Thread Ross Lagerwall
On 11/28/19 1:49 PM, Jan Beulich wrote: > On 28.11.2019 13:15, Sergey Dyasli wrote: >> Applying the patch didn't end up well for my test LP (from another thread): >> >> Perform full initial build with 8 CPU(s)... >> Reading special section data >> Apply patch and build with 8 CPU(s)... >> Unapply p

[Xen-devel] [xen-unstable-smoke test] 144346: tolerable all pass - PUSHED

2019-11-28 Thread osstest service owner
flight 144346 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/144346/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

2019-11-28 Thread Jan Beulich
On 28.11.2019 14:54, Ross Lagerwall wrote: > On 11/28/19 1:49 PM, Jan Beulich wrote: >> On 28.11.2019 13:15, Sergey Dyasli wrote: >>> Applying the patch didn't end up well for my test LP (from another thread): >>> >>> Perform full initial build with 8 CPU(s)... >>> Reading special section data >>>

[Xen-devel] [PATCH-for-4.13 v4] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Paul Durrant
From: George Dunlap Xen used to have single, system-wide limits for the number of grant frames and maptrack frames a guest was allowed to create. Increasing or decreasing this single limit on the Xen command-line would change the limit for all guests on the system. Later, per-domain limits for t

Re: [Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack

2019-11-28 Thread Jan Beulich
On 28.11.2019 14:53, Andrew Cooper wrote: > On 28/11/2019 12:10, Andrew Cooper wrote: >> On 28/11/2019 11:03, Jan Beulich wrote: >>> Notes: >>> >>> - In principle we could get away without the check_eoi_deferral flag. >>> I've introduced it just to make sure there's as little change as >>> poss

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

2019-11-28 Thread Lars Kurth
On 28/11/2019, 07:37, "Jan Beulich" wrote: On 28.11.2019 14:06, Lars Kurth wrote: > I can certainly add something on the timing , along the lines of > * For complex series, consider the time it takes to do reviews (maybe with a guide of LOC per hour) and give reviewers enough time

Re: [Xen-devel] [PATCH for-next] x86/svm: Correct vm_event API for descriptor accesses

2019-11-28 Thread Razvan COJOCARU
On 11/28/19 1:44 PM, Andrew Cooper wrote: > c/s d0a699a389f1 "x86/monitor: add support for descriptor access events" > introduced logic looking for what appeared to be exitinfo (not that this > exists in SVM - exitinfo1 or 2 do), but actually passed the exit IDT vectoring > information. There is n

Re: [Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack

2019-11-28 Thread Roger Pau Monné
On Thu, Nov 28, 2019 at 02:33:08PM +0100, Jan Beulich wrote: > On 28.11.2019 12:39, Roger Pau Monné wrote: > > On Thu, Nov 28, 2019 at 12:03:47PM +0100, Jan Beulich wrote: > >> At the time the pending EOI stack was introduced there were no > >> internally used IRQs which would have the LAPIC EOI is

Re: [Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack

2019-11-28 Thread Jan Beulich
On 28.11.2019 15:13, Roger Pau Monné wrote: > On Thu, Nov 28, 2019 at 02:33:08PM +0100, Jan Beulich wrote: >> On 28.11.2019 12:39, Roger Pau Monné wrote: >>> On Thu, Nov 28, 2019 at 12:03:47PM +0100, Jan Beulich wrote: At the time the pending EOI stack was introduced there were no intern

Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

2019-11-28 Thread Jan Beulich
On 28.11.2019 10:55, Jan Beulich wrote: > On 27.11.2019 19:17, Andrew Cooper wrote: >> On 21/11/2019 08:34, Jan Beulich wrote: >>> On 20.11.2019 18:13, Andrew Cooper wrote: On 20/11/2019 16:40, Jürgen Groß wrote: > On 20.11.19 17:30, Jan Beulich wrote: >> On 08.11.2019 12:18, Jan Beuli

Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

2019-11-28 Thread George Dunlap
On 11/28/19 1:10 PM, Andrew Cooper wrote: > On 28/11/2019 10:17, George Dunlap wrote: >>> On Nov 28, 2019, at 9:55 AM, Jan Beulich wrote: >> Has anyone actually tried building a livepatch with this change in place? > Actually - what is your concern here? The exact spelling of symbols >

[Xen-devel] [xen-unstable test] 144344: tolerable FAIL - PUSHED

2019-11-28 Thread osstest service owner
flight 144344 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/144344/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 16 guest-localmigrate fail REGR. vs. 144323 Tests which did not succeed

Re: [Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack

2019-11-28 Thread Roger Pau Monné
On Thu, Nov 28, 2019 at 03:19:50PM +0100, Jan Beulich wrote: > On 28.11.2019 15:13, Roger Pau Monné wrote: > > On Thu, Nov 28, 2019 at 02:33:08PM +0100, Jan Beulich wrote: > >> On 28.11.2019 12:39, Roger Pau Monné wrote: > >>> On Thu, Nov 28, 2019 at 12:03:47PM +0100, Jan Beulich wrote: > At

Re: [Xen-devel] [PATCH for-next] x86/svm: Correct vm_event API for descriptor accesses

2019-11-28 Thread Alexandru Stefan ISAILA
On 28.11.2019 13:44, Andrew Cooper wrote: > c/s d0a699a389f1 "x86/monitor: add support for descriptor access events" > introduced logic looking for what appeared to be exitinfo (not that this > exists in SVM - exitinfo1 or 2 do), but actually passed the exit IDT vectoring > information. There is

Re: [Xen-devel] [PATCH 2/3] arm64: remove uaccess_ttbr0 asm macros from cache functions

2019-11-28 Thread Mark Rutland
On Wed, Nov 27, 2019 at 01:44:52PM -0500, Pavel Tatashin wrote: > We currently duplicate the logic to enable/disable uaccess via TTBR0, > with C functions and assembly macros. This is a maintenenace burden > and is liable to lead to subtle bugs, so let's get rid of the assembly > macros, and always

[Xen-devel] [PATCH LP-BUILD_TOOLS] Fix building with updated ENFORCE_UNIQUE_SYMBOLS behaviour

2019-11-28 Thread Ross Lagerwall
The patch "build: provide option to disambiguate symbol names" changes ENFORCE_UNIQUE_SYMBOLS so that gcc generates output to a temporary file and then objcopy is used to create the final object file. This breaks livepatch-build's interposition of GCC to capture the changed object files so intercep

Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

2019-11-28 Thread Ross Lagerwall
On 11/28/19 1:57 PM, Jan Beulich wrote: > On 28.11.2019 14:54, Ross Lagerwall wrote: >> On 11/28/19 1:49 PM, Jan Beulich wrote: >>> On 28.11.2019 13:15, Sergey Dyasli wrote: Applying the patch didn't end up well for my test LP (from another thread): Perform full initial build with 8

Re: [Xen-devel] [PATCH for-4.13 2/2] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread George Dunlap
On 11/27/19 10:32 PM, Hans van Kranenburg wrote: > Hi all, > > On 11/27/19 12:13 PM, Durrant, Paul wrote: >>> -Original Message- >>> From: Ian Jackson >>> Sent: 27 November 2019 11:10 >>> [...] >>> Subject: RE: [Xen-devel] [PATCH for-4.13 2/2] Rationalize max_grant_frames >>> and max_mapt

Re: [Xen-devel] Ping: [PATCH v2] build: provide option to disambiguate symbol names

2019-11-28 Thread Wei Liu
On Thu, Nov 28, 2019 at 01:10:05PM +, Andrew Cooper wrote: > On 28/11/2019 10:17, George Dunlap wrote: > >> On Nov 28, 2019, at 9:55 AM, Jan Beulich wrote: > > Has anyone actually tried building a livepatch with this change in > > place? > Actually - what is your concern here? Th

Re: [Xen-devel] [PATCH for-next] x86/svm: Correct vm_event API for descriptor accesses

2019-11-28 Thread Adrian Pop
Hello, Andrew Cooper writes: > c/s d0a699a389f1 "x86/monitor: add support for descriptor access events" > introduced logic looking for what appeared to be exitinfo (not that this > exists in SVM - exitinfo1 or 2 do), but actually passed the exit IDT vectoring > information. There is never any

Re: [Xen-devel] [PATCH LP-BUILD_TOOLS] Fix building with updated ENFORCE_UNIQUE_SYMBOLS behaviour

2019-11-28 Thread Sergey Dyasli
On 28/11/2019 14:51, Ross Lagerwall wrote: > The patch "build: provide option to disambiguate symbol names" changes > ENFORCE_UNIQUE_SYMBOLS so that gcc generates output to a temporary file > and then objcopy is used to create the final object file. This breaks > livepatch-build's interposition of

Re: [Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack

2019-11-28 Thread Andrew Cooper
On 28/11/2019 14:00, Jan Beulich wrote: > On 28.11.2019 14:53, Andrew Cooper wrote: >> On 28/11/2019 12:10, Andrew Cooper wrote: >>> On 28/11/2019 11:03, Jan Beulich wrote: Notes: - In principle we could get away without the check_eoi_deferral flag. I've introduced it just to

Re: [Xen-devel] [PATCH for-4.13 2/2] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Hans van Kranenburg
On 11/28/19 3:54 PM, George Dunlap wrote: > On 11/27/19 10:32 PM, Hans van Kranenburg wrote: >> Hi all, >> >> On 11/27/19 12:13 PM, Durrant, Paul wrote: -Original Message- From: Ian Jackson Sent: 27 November 2019 11:10 [...] Subject: RE: [Xen-devel] [PATCH for-4.13

Re: [Xen-devel] [PATCH for-4.13 2/2] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Jürgen Groß
On 28.11.19 16:33, Hans van Kranenburg wrote: On 11/28/19 3:54 PM, George Dunlap wrote: On 11/27/19 10:32 PM, Hans van Kranenburg wrote: Hi all, On 11/27/19 12:13 PM, Durrant, Paul wrote: -Original Message- From: Ian Jackson Sent: 27 November 2019 11:10 [...] Subject: RE: [Xen-devel]

Re: [Xen-devel] [PATCH for-4.13 v2 0/3] x86/hvm: Multiple corrections to task switch handling

2019-11-28 Thread Jürgen Groß
On 26.11.19 13:03, Andrew Cooper wrote: These patches want backporting due to the severity of patch 2. They should therefore be considered for 4.13 at this point. Andrew Cooper (3): x86/vtx: Fix fault semantics for early task switch failures x86/svm: Always intercept ICEBP x86/svm: Wri

Re: [Xen-devel] [PATCH] x86/IRQ: make internally used IRQs also honor the pending EOI stack

2019-11-28 Thread Jan Beulich
On 28.11.2019 15:30, Roger Pau Monné wrote: > On Thu, Nov 28, 2019 at 03:19:50PM +0100, Jan Beulich wrote: >> On 28.11.2019 15:13, Roger Pau Monné wrote: >>> On Thu, Nov 28, 2019 at 02:33:08PM +0100, Jan Beulich wrote: On 28.11.2019 12:39, Roger Pau Monné wrote: > On Thu, Nov 28, 2019 at

Re: [Xen-devel] [PATCH-for-4.13 v4] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Jan Beulich
On 28.11.2019 14:58, Paul Durrant wrote: > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -84,11 +84,43 @@ struct grant_table { > struct grant_table_arch arch; > }; > > +static int __init parse_gnttab_limit(const char *param, const char *arg, No __init please here and

Re: [Xen-devel] [PATCH for-next] x86/svm: Correct vm_event API for descriptor accesses

2019-11-28 Thread Jan Beulich
On 28.11.2019 12:44, Andrew Cooper wrote: > c/s d0a699a389f1 "x86/monitor: add support for descriptor access events" > introduced logic looking for what appeared to be exitinfo (not that this > exists in SVM - exitinfo1 or 2 do), but actually passed the exit IDT vectoring > information. There is n

Re: [Xen-devel] [PATCH-for-4.13 v4] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH-for-4.13 v4] Rationalize max_grant_frames and max_maptrack_frames handling"): > On 28.11.2019 14:58, Paul Durrant wrote: > > uint32_t max_vcpus; > > uint32_t max_evtchn_port; > > -uint32_t max_grant_frames; > > -uint32_t max_maptrack_frames; > > +

Re: [Xen-devel] [PATCH-for-4.13 v4] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 28 November 2019 16:37 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; Andrew Cooper > ; Anthony PERARD ; > George Dunlap ; Roger Pau Monné > ; Volodymyr Babchuk ; > George Dunlap ; Ian Jackson > ; Marek Marczykowski-Górecki > ; S

Re: [Xen-devel] [PATCH-for-4.13 v4] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Jürgen Groß
On 28.11.19 17:36, Jan Beulich wrote: On 28.11.2019 14:58, Paul Durrant wrote: --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -84,11 +84,43 @@ struct grant_table { struct grant_table_arch arch; }; +static int __init parse_gnttab_limit(const char *param, const char *a

Re: [Xen-devel] [PATCH-for-4.13 v4] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Jan Beulich
On 28.11.2019 17:42, Durrant, Paul wrote: >> From: Jan Beulich >> Sent: 28 November 2019 16:37 >> >> On 28.11.2019 14:58, Paul Durrant wrote: >>> +val = simple_strtoul(arg, &e, 0); >>> +if ( *e ) >>> +return -EINVAL; >>> + >>> +if ( val <= INT_MAX ) >>> +*valp = val;

Re: [Xen-devel] [PATCH-for-4.13 v4] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Jan Beulich
On 28.11.2019 17:47, Jürgen Groß wrote: > On 28.11.19 17:36, Jan Beulich wrote: >> On 28.11.2019 14:58, Paul Durrant wrote: >>> --- a/xen/common/grant_table.c >>> +++ b/xen/common/grant_table.c >>> @@ -84,11 +84,43 @@ struct grant_table { >>> struct grant_table_arch arch; >>> }; >>> >>>

[Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Paul Durrant
From: George Dunlap Xen used to have single, system-wide limits for the number of grant frames and maptrack frames a guest was allowed to create. Increasing or decreasing this single limit on the Xen command-line would change the limit for all guests on the system. Later, per-domain limits for t

Re: [Xen-devel] [PATCH-for-4.13 v4] Rationalize max_grant_frames and max_maptrack_frames handling

2019-11-28 Thread Jan Beulich
On 28.11.2019 17:42, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH-for-4.13 v4] Rationalize max_grant_frames and > max_maptrack_frames handling"): >> On 28.11.2019 14:58, Paul Durrant wrote: >>> uint32_t max_vcpus; >>> uint32_t max_evtchn_port; >>> -uint32_t max_grant_frames;

[Xen-devel] [xen-unstable-smoke test] 144350: tolerable all pass - PUSHED

2019-11-28 Thread osstest service owner
flight 144350 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/144350/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Stefano Stabellini
On Thu, 28 Nov 2019, Julien Grall wrote: > > In both cases I see no reason to keep wrong code. > > > > Either the patch will let run Linux 5.4 fine - then the patch should > > definitely be taken. > That's up to Stefano and Peng to provide me information why this is fine. > FAOD, the current justi

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

2019-11-28 Thread Rich Persaud
On Nov 28, 2019, at 05:12, Jan Beulich wrote: > > On 28.11.2019 01:54, Stefano Stabellini wrote: >>> On Thu, 26 Sep 2019, Lars Kurth wrote: >>> From: Lars Kurth >>> >>> This document highlights what reviewers such as maintainers and committers >>> look >>> for when reviewing code. It sets exp

Re: [Xen-devel] [PATCH v2 4/6] Add Code Review Guide

2019-11-28 Thread Stefano Stabellini
On Thu, 28 Nov 2019, Jan Beulich wrote: > On 28.11.2019 01:54, Stefano Stabellini wrote: > > On Thu, 26 Sep 2019, Lars Kurth wrote: > >> From: Lars Kurth > >> > >> This document highlights what reviewers such as maintainers and committers > >> look > >> for when reviewing code. It sets expectatio

Re: [Xen-devel] [MirageOS-devel] [PATCH v2 4/6] Add Code Review Guide

2019-11-28 Thread Rich Persaud
On Nov 28, 2019, at 09:05, Lars Kurth wrote: > > On 28/11/2019, 07:37, "Jan Beulich" wrote: > >>On 28.11.2019 14:06, Lars Kurth wrote: >> I can certainly add something on the timing , along the lines of >> * For complex series, consider the time it takes to do reviews (maybe with a >> gui

Re: [Xen-devel] [PATCH v2 6/6] Added Resolving Disagreement

2019-11-28 Thread Stefano Stabellini
On Thu, 28 Nov 2019, Jan Beulich wrote: > On 28.11.2019 01:56, Stefano Stabellini wrote: > > On Thu, 26 Sep 2019, Lars Kurth wrote: > >> +This could take for example the form of > >> +> Do you think it would be useful for the code to do XXX? > >> +> I can imagine a user wanting to do YYY (and XXX

Re: [Xen-devel] [PATCH] tools/arm: include xen-tools/libs.h from libxl_arm_acpi.c

2019-11-28 Thread Stefano Stabellini
On Thu, 28 Nov 2019, Wei Liu wrote: > On Thu, Nov 28, 2019 at 11:30:34AM +0100, Jürgen Groß wrote: > > On 28.11.19 11:15, Wei Liu wrote: > > > On Wed, Nov 27, 2019 at 06:24:58PM -0800, Stefano Stabellini wrote: > > > > libxl_arm_acpi.c is using BUILD_BUG_ON but it is not including > > > > xen-tools

Re: [Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range

2019-11-28 Thread Julien Grall
On Thu, 28 Nov 2019, 18:09 Stefano Stabellini, wrote: > On Thu, 28 Nov 2019, Julien Grall wrote: > > > In both cases I see no reason to keep wrong code. > > > > > > Either the patch will let run Linux 5.4 fine - then the patch should > > > definitely be taken. > > That's up to Stefano and Peng to

[Xen-devel] [xen-unstable-smoke test] 144352: tolerable all pass - PUSHED

2019-11-28 Thread osstest service owner
flight 144352 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/144352/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH v2] xen/events: remove event handling recursion detection

2019-11-28 Thread Boris Ostrovsky
On 11/28/19 3:45 AM, Juergen Gross wrote: > - > static void __xen_evtchn_do_upcall(void) > { > struct vcpu_info *vcpu_info = __this_cpu_read(xen_vcpu); > - int cpu = get_cpu(); > - unsigned count; > + int cpu = smp_processor_id(); > > do { > vcpu_info->evtc

Re: [Xen-devel] [PATCH v2 0/2] xen/gntdev: sanitize user interface handling

2019-11-28 Thread Boris Ostrovsky
On 11/28/19 3:48 AM, Jürgen Groß wrote: > On 07.11.19 12:15, Juergen Gross wrote: >> The Xen gntdev driver's checking of the number of allowed mapped pages >> is in need of some sanitizing work. >> >> Changes in V2: >> - enhanced commit message of patch 1 (Andrew Cooper) >> >> Juergen Gross (2): >>

Re: [Xen-devel] [PATCH v3] xen/x86: vpmu: Unmap per-vCPU PMU page when the domain is destroyed

2019-11-28 Thread Boris Ostrovsky
On 11/28/19 5:23 AM, Jan Beulich wrote: > On 28.11.2019 10:38, Paul Durrant wrote: > >> --- a/xen/arch/x86/cpu/vpmu.c >> +++ b/xen/arch/x86/cpu/vpmu.c >> @@ -576,11 +576,36 @@ static void vpmu_arch_destroy(struct vcpu *v) >> >> vpmu->arch_vpmu_ops->arch_vpmu_destroy(v); >> } >> + >

  1   2   >