Re: [Xen-devel] [PATCH] MAINTAINERS: unify reference to xen-devel list

2019-01-14 Thread Juergen Gross
On 12/01/2019 10:07, Lukas Bulwahn wrote: > In the linux kernel MAINTAINERS file, largely > "xen-devel@lists.xenproject.org (moderated for non-subscribers)" > is used to refer to the xen-devel mailing list. > > The DRM DRIVERS FOR XEN section entry mentions > xen-de...@lists.xen.org instead, but

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Christopher Clark
On Fri, Jan 11, 2019 at 1:27 AM Roger Pau Monné wrote: > On Fri, Jan 11, 2019 at 7:04 AM Christopher Clark > wrote: > > > > On Thu, Jan 10, 2019 at 2:19 AM Roger Pau Monné wrote: > > > > > > On Mon, Jan 7, 2019 at 8:44 AM Christopher Clark > > > wrote: > > > > +/* > > > > + * Locking is organi

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Christopher Clark
On Fri, Jan 11, 2019 at 3:54 AM Jan Beulich wrote: > > >>> On 07.01.19 at 08:42, wrote: > > --- a/xen/common/argo.c > > +++ b/xen/common/argo.c > > @@ -17,7 +17,177 @@ > > */ > > > > #include > > +#include > > +#include > > +#include > > +#include > > +#include > > #include > > +#inclu

Re: [Xen-devel] RT Xen on ARM - R-Car series

2019-01-14 Thread Andrii Anisov
Hello Jairo, I was on vacations last week, and a regular CES rush the week before. Please give me some time to sort out what else has happened during that period, and I'll get back to you. -- Sincerely, Andrii Anisov. ___ Xen-devel mailing list Xen-d

Re: [Xen-devel] [PATCH v6 2/4] xen/arm: use SYMBOL when required

2019-01-14 Thread Jan Beulich
>>> On 11.01.19 at 17:58, wrote: > On Fri, 11 Jan 2019, Jan Beulich wrote: >> >> > --- a/xen/arch/arm/setup.c >> >> > +++ b/xen/arch/arm/setup.c >> >> > @@ -772,8 +772,10 @@ void __init start_xen(unsigned long >> >> > boot_phys_offset, >> >> > >> >> > /* Register Xen's load address as a bo

Re: [Xen-devel] [PATCH v3 1/1] cameraif: add ABI for para-virtual camera

2019-01-14 Thread Oleksandr Andrushchenko
Hello, Hans! Could you please take a look at my answers below and kindly let me know if we are ready for (final?) v4 from your point of view. Konrad, Xen-devel - do you have any objections/comments on this? Thank you, Oleksandr On 12/17/18 9:37 AM, Oleksandr Andrushchenko wrote: Hello, Hans!

Re: [Xen-devel] Command line options of dubious use

2019-01-14 Thread Andrii Anisov
On 02.01.19 19:15, Andrew Cooper wrote: On 02/01/2019 16:56, Olaf Hering wrote: On Mon, Dec 31, Andrew Cooper wrote: * tbuf_size and tevt_mask Given that xentrace can set them at runtime, and it is debugging functionality, I don't see a plausible use the command line options at all. 'tbuf_si

Re: [Xen-devel] [PATCH V3] x86/vm_event: block interrupt injection for sync vm_events

2019-01-14 Thread Razvan Cojocaru
On 1/12/19 12:04 AM, Boris Ostrovsky wrote: On 12/14/18 6:49 AM, Razvan Cojocaru wrote: Block interrupts (in vmx_intr_assist()) for the duration of processing a sync vm_event (similarly to the strategy currently used for single-stepping). Otherwise, attempting to emulate an instruction when requ

Re: [Xen-devel] [PATCH v3 1/1] cameraif: add ABI for para-virtual camera

2019-01-14 Thread Hans Verkuil
On 1/14/19 10:23 AM, Oleksandr Andrushchenko wrote: > Hello, Hans! > Could you please take a look at my answers below and kindly let me know > if we are ready for (final?) v4 from your point of view. Looks good, so I'm looking forward to a v4. Regards, Hans > > Konrad, Xen-devel - do y

Re: [Xen-devel] [PATCH v2 2/2] libxl: fix build (missing CLONE_NEWIPC) on astonishingly old systems

2019-01-14 Thread Jan Beulich
>>> On 11.01.19 at 20:23, wrote: > CLONE_NEWIPC was introduced in Linux 2.6.19, on the 29th of November > 2006, which was 12 years, 1 month, and 14 days ago. Thanks for the very precise counting, the latter part which will be wrong - even if just slightly - by the time you commit it ;-) > Nevert

Re: [Xen-devel] [PATCH V3] x86/vm_event: block interrupt injection for sync vm_events

2019-01-14 Thread Jan Beulich
>>> On 14.01.19 at 10:34, wrote: > On 1/12/19 12:04 AM, Boris Ostrovsky wrote: >> On 12/14/18 6:49 AM, Razvan Cojocaru wrote: >>> Block interrupts (in vmx_intr_assist()) for the duration of >>> processing a sync vm_event (similarly to the strategy >>> currently used for single-stepping). Otherwise

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-14 Thread Jan Beulich
>>> On 11.01.19 at 19:04, wrote: > On Fri, 11 Jan 2019, Jan Beulich wrote: >> >>> On 11.01.19 at 03:14, wrote: >> > Hi Juergen, Jan, >> > >> > I spoke with Julien: we are both convinced that the unsigned long >> > solution is best. But Julien also did some research and he thinks that >> > Jan's

[Xen-devel] Xen 4.12 Development Update

2019-01-14 Thread Juergen Gross
This email only tracks big items for xen.git tree. Please reply for items you would like to see in 4.12 so that people have an idea what is going on and prioritise accordingly. You're welcome to provide description and use cases of the feature you're working on. = Timeline = We now adopt a fixed

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-14 Thread Jan Beulich
>>> On 14.01.19 at 04:45, wrote: > So let's keep the linker-accessible variable as a type that works for the > linker (which really could be anything as long as you use the address, not > the value), but name it something else - a name that screams "DON'T USE ME > UNLESS YOU KNOW WHAT YOU'RE DOING

Re: [Xen-devel] [PATCH] arch/arm/xen: Remove duplicate header

2019-01-14 Thread Oleksandr Andrushchenko
On 1/7/19 7:37 PM, Souptick Joarder wrote: Remove duplicate header which is included twice. Signed-off-by: Souptick Joarder Reviewed-by: Oleksandr Andrushchenko --- arch/arm/xen/mm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c index cb44aa2..e1

[Xen-devel] getting started: Implementing a new TAP

2019-01-14 Thread Xen Mann
Hey there!   I'm going to extend openOCD. There is a new lightwight TAP AHB-Controller (AHBL) from Hilscher Companny. Depending on the chip thre is a ARM9 (netX50), a RISCV(netIOL), or … below it.   I'm going to add support to openOCD for this TAP-Device. I’m new to openOCD codebase. I was look

Re: [Xen-devel] [PATCH V3] x86/vm_event: block interrupt injection for sync vm_events

2019-01-14 Thread Julien Grall
Hi, On 14/01/2019 09:34, Razvan Cojocaru wrote: On 1/12/19 12:04 AM, Boris Ostrovsky wrote: On 12/14/18 6:49 AM, Razvan Cojocaru wrote: Block interrupts (in vmx_intr_assist()) for the duration of processing a sync vm_event (similarly to the strategy currently used for single-stepping). Otherwi

Re: [Xen-devel] Xen 4.12 Development Update

2019-01-14 Thread Andrew Cooper
On 14/01/2019 10:13, Juergen Gross wrote: > I have started to include the version number of series associated to each > feature. Can each owner send an update on the version number if the series > was posted upstream? > > = Projects = > > == Hypervisor == > > * Improvements to domain creation (v2

[Xen-devel] [linux-3.18 test] 131942: regressions - trouble: broken/fail/pass

2019-01-14 Thread osstest service owner
flight 131942 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/131942/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-win10-i386 broken test-amd64-amd64-xl-qcow2

Re: [Xen-devel] [PATCH V3] x86/vm_event: block interrupt injection for sync vm_events

2019-01-14 Thread Razvan Cojocaru
On 1/14/19 11:53 AM, Jan Beulich wrote: On 14.01.19 at 10:34, wrote: On 1/12/19 12:04 AM, Boris Ostrovsky wrote: On 12/14/18 6:49 AM, Razvan Cojocaru wrote: Block interrupts (in vmx_intr_assist()) for the duration of processing a sync vm_event (similarly to the strategy currently used for sin

Re: [Xen-devel] Command line options of dubious use

2019-01-14 Thread Andrew Cooper
On 04/01/2019 14:04, Jan Beulich wrote: >> dom0 (either PV, or PVH) cannot use the HPET >> safely, even if it is restricted to just read-only access. Dom0 must >> under no circumstance interact directly with the hardware HPET, as it is >> a direct interrupt source. > But reads don't cause interru

Re: [Xen-devel] [PATCH] tools/firmware: update OVMF Makefile

2019-01-14 Thread Wei Liu
On Sun, Jan 13, 2019 at 09:17:44PM +0100, Olaf Hering wrote: > On Wed, Nov 28, Wei Liu wrote: > > > OVMF has become dependent on OpenSSL, which it is included as a submodule. > > Initialise submodules before building. > > > +++ b/tools/firmware/ovmf-makefile > > build: > > + $(GIT) submodule u

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Roger Pau Monné
On Mon, Jan 14, 2019 at 9:32 AM Christopher Clark wrote: > > On Fri, Jan 11, 2019 at 1:27 AM Roger Pau Monné wrote: > > On Fri, Jan 11, 2019 at 7:04 AM Christopher Clark > > wrote: > > > > > > On Thu, Jan 10, 2019 at 2:19 AM Roger Pau Monné > > > wrote: > > > > > > > > On Mon, Jan 7, 2019 at

Re: [Xen-devel] Command line options of dubious use

2019-01-14 Thread Jan Beulich
>>> On 14.01.19 at 12:05, wrote: > On 04/01/2019 14:04, Jan Beulich wrote: >>> dom0 (either PV, or PVH) cannot use the HPET >>> safely, even if it is restricted to just read-only access. Dom0 must >>> under no circumstance interact directly with the hardware HPET, as it is >>> a direct interrupt

Re: [Xen-devel] [PATCH v2 2/2] libxl: fix build (missing CLONE_NEWIPC) on astonishingly old systems

2019-01-14 Thread Wei Liu
On Mon, Jan 14, 2019 at 02:47:58AM -0700, Jan Beulich wrote: > >>> On 11.01.19 at 20:23, wrote: > > CLONE_NEWIPC was introduced in Linux 2.6.19, on the 29th of November > > 2006, which was 12 years, 1 month, and 14 days ago. > > Thanks for the very precise counting, the latter part which will be

[Xen-devel] [PATCH] x86emul: correct AVX512BW write masking checks

2019-01-14 Thread Jan Beulich
For VPSADBW this likely was a result of bad copy-and-paste. For VPS{L,R}LDQ comment and code were not in line, but then again the comment also wasn't fully updated from the AVX2 original it got cloned from. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x

[Xen-devel] [PATCH] x86/cpuid: correct dependencies of post-SSE ISA extensions

2019-01-14 Thread Jan Beulich
First of all a PCLMULQDQ dependency was missing entirely. Add it as well as AESNI and SHA to SSE2, as all of them act on vectors of integers, whereas plain SSE supports vectors of single precision floats only. This is in line with how e.g. binutils and gcc treat them. Signed-off-by: Jan Beulich -

Re: [Xen-devel] [PATCH] tools/firmware: update OVMF Makefile

2019-01-14 Thread Olaf Hering
Am Mon, 14 Jan 2019 11:28:57 + schrieb Wei Liu : > Are you saying that the breakage is shown when you put a snapshot of > ovmf under xen.git? How does ovmf distribute their snapshot? How is that > generated? Does it contain snapshots of submodules it needs already? I export all required sourc

Re: [Xen-devel] [PATCH] x86/cpuid: correct dependencies of post-SSE ISA extensions

2019-01-14 Thread Andrew Cooper
On 14/01/2019 11:39, Jan Beulich wrote: > First of all a PCLMULQDQ dependency was missing entirely. Add it as well > as AESNI and SHA to SSE2, as all of them act on vectors of integers, > whereas plain SSE supports vectors of single precision floats only. This > is in line with how e.g. binutils an

Re: [Xen-devel] [Qemu-devel] [PATCH] xen: Fix event channel interface for XenDevice-s

2019-01-14 Thread Anthony PERARD
On Fri, Jan 11, 2019 at 06:16:45PM +, Peter Maydell wrote: > On Fri, 11 Jan 2019 at 18:13, Anthony PERARD > wrote: > > > > On Fri, Jan 11, 2019 at 06:09:41PM +, Anthony PERARD wrote: > > > Patch "xen: add event channel interface for XenDevice-s" makes use of > > > the type xenevtchn_port_

[Xen-devel] [linux-linus test] 131945: regressions - trouble: blocked/broken/fail/pass

2019-01-14 Thread osstest service owner
flight 131945 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/131945/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops broken build-i386

Re: [Xen-devel] [PATCH v2] xen: Fix x86 sched_clock() interface for xen

2019-01-14 Thread Juergen Gross
On 11/01/2019 21:35, Boris Ostrovsky wrote: > On 1/11/19 7:08 AM, Juergen Gross wrote: >> @@ -421,6 +424,11 @@ void xen_restore_time_memory_area(void) >> if (ret != 0) >> pr_notice("Cannot restore secondary vcpu_time_info (err %d)", >>ret); >> + >> +out: >>

Re: [Xen-devel] [PATCH v2 ] always clear the X2APIC_ENABLE bit for PV guest

2019-01-14 Thread Igor Druzhinin
ping? On 10/12/2018 10:03, Xin Li wrote: > From: Talons Lee > > Commit e657fcc clears cpu capability bit instead of using fake cpuid > value, the EXTD should always be off for PV guest without depending > on cpuid value. So remove the cpuid check in xen_read_msr_safe() to > always clear the X2AP

[Xen-devel] [PATCH v3] xen: Fix x86 sched_clock() interface for xen

2019-01-14 Thread Juergen Gross
Commit f94c8d11699759 ("sched/clock, x86/tsc: Rework the x86 'unstable' sched_clock() interface") broke Xen guest time handling across migration: [ 187.249951] Freezing user space processes ... (elapsed 0.001 seconds) done. [ 187.251137] OOM killer disabled. [ 187.251137] Freezing remaining fre

Re: [Xen-devel] [PATCH] x86/cpuid: correct dependencies of post-SSE ISA extensions

2019-01-14 Thread Jan Beulich
>>> On 14.01.19 at 13:00, wrote: > On 14/01/2019 11:39, Jan Beulich wrote: >> First of all a PCLMULQDQ dependency was missing entirely. Add it as well >> as AESNI and SHA to SSE2, as all of them act on vectors of integers, >> whereas plain SSE supports vectors of single precision floats only. This

Re: [Xen-devel] [PATCH v3 15/15] argo: validate hypercall arg structures via compat machinery

2019-01-14 Thread Jan Beulich
>>> On 07.01.19 at 08:42, wrote: > Argo doesn't use compat hypercall or argument translation but can use some > of the infrastructure for validating the hypercall argument structures to > ensure that the struct sizes, offsets and compositions don't vary between 32 > and 64bit, so add that here in

[Xen-devel] [PULL 00/25] Xen queue v2

2019-01-14 Thread Anthony PERARD
erard/qemu-dm.git tags/pull-xen-20190114 for you to fetch changes up to c6025bd197d0dbcc5067553fd12538d8b29383c2: xen-block: avoid repeated memory allocation (2019-01-14 13:45:40 +) Xen queue * Xen PV backend 'qdevificati

[Xen-devel] [PULL 07/25] xen: add xenstore watcher infrastructure

2019-01-14 Thread Anthony PERARD
From: Paul Durrant A Xen PV frontend communicates its state to the PV backend by writing to the 'state' key in the frontend area in xenstore. It is therefore necessary for a XenDevice implementation to be notified whenever the value of this key changes. This patch adds code to do this as follows

[Xen-devel] [PULL 04/25] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy

2019-01-14 Thread Anthony PERARD
From: Paul Durrant This patch adds the basic boilerplate for a 'XenBus' object that will act as a parent to 'XenDevice' PV backends. A new 'XenBridge' object is also added to connect XenBus to the system bus. The XenBus object is instantiated by a new xen_bus_init() function called from the same

[Xen-devel] [PULL 01/25] hw/xen/xen_pt_graphics: Don't trust the BIOS ROM contents so much

2019-01-14 Thread Anthony PERARD
From: Peter Maydell Coverity (CID 796599) points out that xen_pt_setup_vga() trusts the rom->size field in the BIOS ROM from a PCI passthrough VGA device, and uses it as an index into the memory which contains the BIOS image. A corrupt BIOS ROM could therefore cause us to index off the end of the

[Xen-devel] [PULL 02/25] xen/pt: allow passthrough of devices with bogus interrupt pin

2019-01-14 Thread Anthony PERARD
From: Zhao Yan For some pci device, even its PCI_INTERRUPT_PIN is not 0, it actually doesn't support INTx mode, so its machine irq read from host sysfs is 0. In that case, report PCI_INTERRUPT_PIN as 0 to guest and let passthrough continue. Reviewed-by: Roger Pau Monné Signed-off-by: Zhao Yan

[Xen-devel] [PULL 08/25] xen: add grant table interface for XenDevice-s

2019-01-14 Thread Anthony PERARD
From: Paul Durrant The legacy PV backend infrastructure provides functions to map, unmap and copy pages granted by frontends. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard Si

[Xen-devel] [PULL 03/25] xen: re-name XenDevice to XenLegacyDevice...

2019-01-14 Thread Anthony PERARD
From: Paul Durrant ...and xen_backend.h to xen-legacy-backend.h Rather than attempting to convert the existing backend infrastructure to be QOM compliant (which would be hard to do in an incremental fashion), subsequent patches will introduce a completely new framework for Xen PV backends. Hence

[Xen-devel] [PULL 09/25] xen: add event channel interface for XenDevice-s

2019-01-14 Thread Anthony PERARD
From: Paul Durrant The legacy PV backend infrastructure provides functions to bind, unbind and send notifications to event channnels. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant Reviewed-by: Anthony Pe

[Xen-devel] [PULL 06/25] xen: create xenstore areas for XenDevice-s

2019-01-14 Thread Anthony PERARD
From: Paul Durrant This patch adds a new source module, xen-bus-helper.c, which builds on basic libxenstore primitives to provide functions to create (setting permissions appropriately) and destroy xenstore areas, and functions to 'printf' and 'scanf' nodes therein. The main xen-bus code then use

[Xen-devel] [PULL 05/25] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom'

2019-01-14 Thread Anthony PERARD
From: Paul Durrant This patch adds new XenDevice-s: 'xen-disk' and 'xen-cdrom', both derived from a common 'xen-block' parent type. These will eventually replace the 'xen_disk' (note the underscore rather than hyphen) legacy PV backend but it is illustrative to build up the implementation increme

Re: [Xen-devel] [PATCH v3] xen: Fix x86 sched_clock() interface for xen

2019-01-14 Thread Boris Ostrovsky
On 1/14/19 7:44 AM, Juergen Gross wrote: > Commit f94c8d11699759 ("sched/clock, x86/tsc: Rework the x86 'unstable' > sched_clock() interface") broke Xen guest time handling across > migration: > > [ 187.249951] Freezing user space processes ... (elapsed 0.001 seconds) done. > [ 187.251137] OOM ki

[Xen-devel] [PULL 10/25] xen: duplicate xen_disk.c as basis of dataplane/xen-block.c

2019-01-14 Thread Anthony PERARD
From: Paul Durrant The new xen-block XenDevice implementation requires the same core dataplane as the legacy xen_disk implementation it will eventually replace. This patch therefore copies the legacy xen_disk.c source module into a new dataplane/xen-block.c source module as the basis for the new

[Xen-devel] [PULL 22/25] xen: Replace few mentions of xend by libxl

2019-01-14 Thread Anthony PERARD
xend have been replaced by libxenlight (libxl) for many Xen releases now. Signed-off-by: Anthony PERARD Acked-by: Stefano Stabellini --- hw/xenpv/xen_machine_pv.c | 2 +- include/hw/xen/xen.h | 2 +- qemu-options.hx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff

[Xen-devel] [PULL 19/25] MAINTAINERS: add myself as a Xen maintainer

2019-01-14 Thread Anthony PERARD
From: Paul Durrant I have made many significant contributions to the Xen code in QEMU, particularly the recent patches introducing a new PV device framework. I intend to make further significant contributions, porting other PV back- ends to the new framework with the intent of eventually removing

[Xen-devel] [PULL 16/25] xen: add implementations of xen-block connect and disconnect functions...

2019-01-14 Thread Anthony PERARD
From: Paul Durrant ...and wire in the dataplane. This patch adds the remaining code to make the xen-block XenDevice functional. The parameters that a block frontend expects to find are populated in the backend xenstore area, and the 'ring-ref' and 'event-channel' values specified in the frontend

[Xen-devel] [PULL 12/25] xen: add header and build dataplane/xen-block.c

2019-01-14 Thread Anthony PERARD
From: Paul Durrant This patch adds the transformations necessary to get dataplane/xen-block.c to build against the new XenBus/XenDevice framework. MAINTAINERS is also updated due to the introduction of dataplane/xen-block.h. NOTE: Existing data structure names are retained for the moment. These

[Xen-devel] [PULL 17/25] xen: add a mechanism to automatically create XenDevice-s...

2019-01-14 Thread Anthony PERARD
From: Paul Durrant ...that maintains compatibility with existing Xen toolstacks. Xen toolstacks instantiate PV backends by simply writing information into xenstore and expecting a backend implementation to be watching for this. This patch adds a new 'xen-backend' module to allow individual XenD

[Xen-devel] [PULL 13/25] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-block

2019-01-14 Thread Anthony PERARD
From: Paul Durrant This is a purely cosmetic patch that substitutes the old 'struct XenBlkDev' name with 'XenBlockDataPlane' and 'blkdev' field/variable names with 'dataplane', and then does necessary fix-up to adhere to coding style. No functional change. Signed-off-by: Paul Durrant Acked-by:

[Xen-devel] [PULL 11/25] xen: remove unnecessary code from dataplane/xen-block.c

2019-01-14 Thread Anthony PERARD
From: Paul Durrant Not all of the code duplicated from xen_disk.c is required as the basis for the new dataplane implementation so this patch removes extraneous code, along with the legacy #includes and calls to the legacy xen_pv_printf() function. Error messages are changed to be reported using

[Xen-devel] [PULL 18/25] xen: automatically create XenBlockDevice-s

2019-01-14 Thread Anthony PERARD
From: Paul Durrant This patch adds create and destroy function for XenBlockDevice-s so that they can be created automatically when the Xen toolstack instantiates a new PV backend via xenstore. When the XenBlockDevice is created this way it is also necessary to create a 'drive' which matches the c

[Xen-devel] [PULL 23/25] xen-block: improve batching behaviour

2019-01-14 Thread Anthony PERARD
From: Tim Smith When I/O consists of many small requests, performance is improved by batching them together in a single io_submit() call. When there are relatively few requests, the extra overhead is not worth it. This introduces a check to start batching I/O requests via blk_io_plug()/ blk_io_un

[Xen-devel] [PULL 24/25] xen-block: improve response latency

2019-01-14 Thread Anthony PERARD
From: Tim Smith If the I/O ring is full, the guest cannot send any more requests until some responses are sent. Only sending all available responses just before checking for new work does not leave much time for the guest to supply new work, so this will cause stalls if the ring gets full. Also,

[Xen-devel] [PULL 20/25] xen: remove the legacy 'xen_disk' backend

2019-01-14 Thread Anthony PERARD
From: Paul Durrant This backend has now been replaced by the 'xen-qdisk' XenDevice. Signed-off-by: Paul Durrant Acked-by: Anthony Perard Signed-off-by: Anthony PERARD --- hw/block/Makefile.objs |1 - hw/block/xen_disk.c| 1011 2 files changed,

[Xen-devel] [PULL 25/25] xen-block: avoid repeated memory allocation

2019-01-14 Thread Anthony PERARD
From: Tim Smith The xen-block dataplane currently allocates memory to hold the data for each request as that request is used, and frees it afterwards. Because it requires page-aligned blocks, this interacts poorly with non-page- aligned allocations and balloons the heap. Instead, allocate the ma

[Xen-devel] [PULL 15/25] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-block.c

2019-01-14 Thread Anthony PERARD
From: Paul Durrant This is a purely cosmetic patch that purges remaining use of 'blk' and 'ioreq' in local function names, and then makes sure all functions are prefixed with 'xen_block_'. No functional change. Signed-off-by: Paul Durrant Acked-by: Anthony Perard Signed-off-by: Anthony PERARD

[Xen-devel] [PULL 21/25] Remove broken Xen PV domain builder

2019-01-14 Thread Anthony PERARD
It is broken since Xen 4.9 [1] and it will not build in Xen 4.12. Also, it is not built by default since QEMU 2.6. [1] https://lists.xenproject.org/archives/html/xen-devel/2018-09/msg00313.html Signed-off-by: Anthony PERARD Acked-by: Stefano Stabellini --- configure | 17 --

[Xen-devel] [PULL 14/25] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-block.c

2019-01-14 Thread Anthony PERARD
From: Paul Durrant This is a purely cosmetic patch that purges the name 'ioreq' from struct, variable and field names. (This name has been problematic for a long time as 'ioreq' is the name used for generic I/O requests coming from Xen). The patch replaces 'struct ioreq' with a new 'XenBlockReque

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-14 Thread Jan Beulich
>>> On 07.01.19 at 08:42, wrote: > --- a/xen/common/argo.c > +++ b/xen/common/argo.c > @@ -23,16 +23,41 @@ > #include > #include > #include > +#include > +#include > #include > #include > > +#define MAX_RINGS_PER_DOMAIN128U > + > +/* All messages on the ring are padded to

Re: [Xen-devel] [PATCH v2 2/2] libxl: fix build (missing CLONE_NEWIPC) on astonishingly old systems

2019-01-14 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v2 2/2] libxl: fix build (missing CLONE_NEWIPC) on astonishingly old systems"): > On Mon, Jan 14, 2019 at 02:47:58AM -0700, Jan Beulich wrote: > > On 11.01.19 at 20:23, wrote: > > > CLONE_NEWIPC was introduced in Linux 2.6.19, on the 29th of November > > > 2006, which

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Rich Persaud
> On Jan 14, 2019, at 06:32, Roger Pau Monné wrote: > > On Mon, Jan 14, 2019 at 9:32 AM Christopher Clark > wrote: >> >> I've written a document about the locking to add to the tree with the >> series, and a copy is at github here: >> >> https://github.com/dozylynx/xen/blob/0cb95385eba696ecf4

Re: [Xen-devel] [PATCH v2 2/2] libxl: fix build (missing CLONE_NEWIPC) on astonishingly old systems

2019-01-14 Thread Jan Beulich
>>> On 14.01.19 at 15:22, wrote: > Wei Liu writes ("Re: [PATCH v2 2/2] libxl: fix build (missing CLONE_NEWIPC) > on astonishingly old systems"): >> On Mon, Jan 14, 2019 at 02:47:58AM -0700, Jan Beulich wrote: >> > On 11.01.19 at 20:23, wrote: >> > > CLONE_NEWIPC was introduced in Linux 2.6.19, o

Re: [Xen-devel] [PATCH V3] x86/vm_event: block interrupt injection for sync vm_events

2019-01-14 Thread Tamas K Lengyel
On Fri, Dec 14, 2018 at 4:50 AM Razvan Cojocaru wrote: > > Block interrupts (in vmx_intr_assist()) for the duration of > processing a sync vm_event (similarly to the strategy > currently used for single-stepping). Otherwise, attempting > to emulate an instruction when requested by a vm_event > rep

Re: [Xen-devel] [PATCH V3] x86/vm_event: block interrupt injection for sync vm_events

2019-01-14 Thread Juergen Gross
On 14/01/2019 11:56, Razvan Cojocaru wrote: > On 1/14/19 11:53 AM, Jan Beulich wrote: > On 14.01.19 at 10:34, wrote: >>> On 1/12/19 12:04 AM, Boris Ostrovsky wrote: On 12/14/18 6:49 AM, Razvan Cojocaru wrote: > Block interrupts (in vmx_intr_assist()) for the duration of > processi

Re: [Xen-devel] [PATCH V3] x86/vm_event: block interrupt injection for sync vm_events

2019-01-14 Thread Razvan Cojocaru
On 1/14/19 4:42 PM, Juergen Gross wrote: On 14/01/2019 11:56, Razvan Cojocaru wrote: On 1/14/19 11:53 AM, Jan Beulich wrote: On 14.01.19 at 10:34, wrote: On 1/12/19 12:04 AM, Boris Ostrovsky wrote: On 12/14/18 6:49 AM, Razvan Cojocaru wrote: Block interrupts (in vmx_intr_assist()) for the d

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Wei Liu
Hi all The locking scheme seems to be remaining sticking point. The rest are mostly cosmetic issues (FAOD, they still need to be addressed). Frankly I don't think there is enough time to address all the technical details, but let me sum up each side's position and see if we can reach an amicable

[Xen-devel] [linux-4.9 test] 131946: trouble: broken/fail/pass

2019-01-14 Thread osstest service owner
flight 131946 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/131946/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm broken test-amd64-amd64-xl-qem

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Andrew Cooper
On 07/01/2019 07:42, Christopher Clark wrote: > Initialises basic data structures and performs teardown of argo state > for domain shutdown. > > Inclusion of the Argo implementation is dependent on CONFIG_ARGO. > > Introduces a new Xen command line parameter 'argo': bool to enable/disable > the arg

[Xen-devel] [PATCH v3 3/3] libxl: fix build (missing CLONE_NEWIPC) on astonishingly old systems

2019-01-14 Thread Ian Jackson
CLONE_NEWIPC was introduced in Linux 2.6.19, on the 29th of November 2006, which was 12 years, 1 month, and 14 days ago. Nevertheless apparently some people are trying to build Xen on systems whose kernel headers are that old. Placate these people by providing a fallback #define for CLONE_NEWIPC.

[Xen-devel] [PATCH v3 2/3] Revert "libxl: fix build on rather old systems"

2019-01-14 Thread Ian Jackson
This reverts commit 1bce5f9baf0f4a4e50722f32b44afe4fdefc6b35. This situation should be handled by disabling the dm restrict feature, not silently falling back to lower protection. Also this #ifdeffery is bad style. Signed-off-by: Ian Jackson --- tools/libxl/libxl_linux.c | 16 ++--

[Xen-devel] [PATCH v3 1/3] docs/features/qemu-deprivilege.pandoc: No support with Linux <2.6.18

2019-01-14 Thread Ian Jackson
Some early kernesl are known not to reject unknown flags to unshare(). There may be other problems. CC: Jan Beulich Signed-off-by: Ian Jackson --- v3: New in this version of the series. --- docs/features/qemu-deprivilege.pandoc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/featur

Re: [Xen-devel] [PATCH v3 1/3] docs/features/qemu-deprivilege.pandoc: No support with Linux <2.6.18

2019-01-14 Thread Wei Liu
On Mon, Jan 14, 2019 at 02:59:35PM +, Ian Jackson wrote: > Some early kernesl are known not to reject unknown flags to > unshare(). There may be other problems. > > CC: Jan Beulich > Signed-off-by: Ian Jackson Acked-by: Wei Liu ___ Xen-devel ma

Re: [Xen-devel] [PATCH v3 2/3] Revert "libxl: fix build on rather old systems"

2019-01-14 Thread Wei Liu
On Mon, Jan 14, 2019 at 02:59:36PM +, Ian Jackson wrote: > This reverts commit 1bce5f9baf0f4a4e50722f32b44afe4fdefc6b35. > > This situation should be handled by disabling the dm restrict > feature, not silently falling back to lower protection. > > Also this #ifdeffery is bad style. > > Sign

Re: [Xen-devel] [PATCH v3 3/3] libxl: fix build (missing CLONE_NEWIPC) on astonishingly old systems

2019-01-14 Thread Wei Liu
On Mon, Jan 14, 2019 at 02:59:37PM +, Ian Jackson wrote: > CLONE_NEWIPC was introduced in Linux 2.6.19, on the 29th of November > 2006, which was 12 years, 1 month, and 14 days ago. > > Nevertheless apparently some people are trying to build Xen on systems > whose kernel headers are that old.

Re: [Xen-devel] [PATCH v3 08/15] argo: implement the unregister op

2019-01-14 Thread Jan Beulich
>>> On 07.01.19 at 08:42, wrote: > @@ -666,6 +667,105 @@ ring_find_info(const struct domain *d, const struct > argo_ring_id *id) > return NULL; > } > > +static struct argo_send_info * > +send_find_info(const struct domain *d, const struct argo_ring_id *id) As per the comment on patch 7,

Re: [Xen-devel] [PATCH] x86emul: fix test harness and fuzzer build dependencies

2019-01-14 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] [PATCH] x86emul: fix test harness and fuzzer build dependencies"): > On 21.12.18 at 15:16, wrote: > > Why is this particular inter-directory dependency unusual ? Do we > > plan to introduce similar MAKELEVEL-based invocation of dependency > > directory makefi

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Jan Beulich
>>> On 14.01.19 at 15:58, wrote: > On 07/01/2019 07:42, Christopher Clark wrote: >> --- a/xen/common/argo.c >> +++ b/xen/common/argo.c >> long >> do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, > > I know I'm commenting on the wrong patch, but please use unsigned long > cmd, so

[Xen-devel] PING ARM [PATCH v2] xen/cmdline: Fix buggy strncmp(s, LITERAL, ss - s) construct

2019-01-14 Thread Andrew Cooper
There are ARM changes in here, and this bugfix is needed for 4.12, and for backporting. The one change not represented here is switching strncmp() with memcmp() as recommended by Jan. ~Andrew On 04/01/2019 17:17, Andrew Cooper wrote: > When the command line parsing was updated to use const strin

Re: [Xen-devel] Xen 4.12 Development Update

2019-01-14 Thread Lars Kurth
Hi Juergen, > On 14 Jan 2019, at 10:13, Juergen Gross wrote: > > This email only tracks big items for xen.git tree. Please reply for items you > would like to see in 4.12 so that people have an idea what is going on and > prioritise accordingly. > > You're welcome to provide description and use

Re: [Xen-devel] [PATCH v3 04/15] argo: init, destroy and soft-reset, with enable command line opt

2019-01-14 Thread Lars Kurth
Adding Juergen, to make sure he is aware of the discussion, as this is an excellent summary of the status of this series. > On 14 Jan 2019, at 14:46, Wei Liu wrote: > > Hi all > > The locking scheme seems to be remaining sticking point. The rest are > mostly cosmetic issues (FAOD, they still

Re: [Xen-devel] [PATCH v3 07/15] argo: implement the register op

2019-01-14 Thread Andrew Cooper
On 07/01/2019 07:42, Christopher Clark wrote: > diff --git a/docs/misc/xen-command-line.pandoc > b/docs/misc/xen-command-line.pandoc > index aea13eb..68d4415 100644 > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -193,6 +193,21 @@ This allows domains access

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-14 Thread Julien Grall
Hi Jan, On 14/01/2019 10:11, Jan Beulich wrote: On 11.01.19 at 19:04, wrote: On Fri, 11 Jan 2019, Jan Beulich wrote: On 11.01.19 at 03:14, wrote: Hi Juergen, Jan, I spoke with Julien: we are both convinced that the unsigned long solution is best. But Julien also did some research and he th

Re: [Xen-devel] [PATCH] x86emul: fix test harness and fuzzer build dependencies

2019-01-14 Thread Jan Beulich
>>> On 14.01.19 at 16:09, wrote: > Jan Beulich writes ("Re: [Xen-devel] [PATCH] x86emul: fix test harness and > fuzzer build dependencies"): >> On 21.12.18 at 15:16, wrote: >> > Why is this particular inter-directory dependency unusual ? Do we >> > plan to introduce similar MAKELEVEL-based invo

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-14 Thread Jan Beulich
>>> On 14.01.19 at 16:41, wrote: > Hi Jan, > > On 14/01/2019 10:11, Jan Beulich wrote: > On 11.01.19 at 19:04, wrote: >>> On Fri, 11 Jan 2019, Jan Beulich wrote: >>> On 11.01.19 at 03:14, wrote: > Hi Juergen, Jan, > > I spoke with Julien: we are both convinced that the unsig

Re: [Xen-devel] [PATCH 03/15] x86/cpu/vpmu: Add Hygon Dhyana support for vPMU

2019-01-14 Thread Jan Beulich
>>> On 20.12.18 at 14:12, wrote: > --- a/xen/arch/x86/cpu/vpmu.c > +++ b/xen/arch/x86/cpu/vpmu.c > @@ -473,6 +473,7 @@ static int vpmu_arch_initialise(struct vcpu *v) > > switch ( vendor ) > { > +case X86_VENDOR_HYGON: > case X86_VENDOR_AMD: > ret = svm_vpmu_initialis

Re: [Xen-devel] PING ARM [PATCH v2] xen/cmdline: Fix buggy strncmp(s, LITERAL, ss - s) construct

2019-01-14 Thread Julien Grall
Hi Andrew, On 14/01/2019 15:17, Andrew Cooper wrote: diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index ca655ff..22a86ec 100644 --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -212,7 +212,7 @@ EFI_STATUS __init fdt_add_uefi_nodes(EFI_SYSTEM_TABLE

Re: [Xen-devel] [PATCH] pvcalls-front: fix potential null dereference

2019-01-14 Thread Boris Ostrovsky
On 1/13/19 10:20 PM, Wen Yang wrote: > static checker warning: > drivers/xen/pvcalls-front.c:373 alloc_active_ring() > error: we previously assumed 'map->active.ring' could be null >(see line 357) > > drivers/xen/pvcalls-front.c > 351 static int alloc_active_ring(struct soc

Re: [Xen-devel] [PATCH 04/15] x86/cpu/mce: Add Hygon Dhyana support to the MCA infrastructure

2019-01-14 Thread Jan Beulich
>>> On 20.12.18 at 14:12, wrote: > --- a/xen/arch/x86/cpu/mcheck/mce_amd.c > +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c > @@ -162,7 +162,8 @@ mcequirk_lookup_amd_quirkdata(struct cpuinfo_x86 *c) > { > int i; > > -BUG_ON(c->x86_vendor != X86_VENDOR_AMD); > +if (c->x86_vendor != X86_VEN

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-14 Thread Stewart Hildebrand
On Monday, January 14, 2019 10:53 AM, Jan Beulich wrote: > > Hi Jan, > > > > On 14/01/2019 10:11, Jan Beulich wrote: > > On 11.01.19 at 19:04, wrote: > >>> On Fri, 11 Jan 2019, Jan Beulich wrote: > >>> On 11.01.19 at 03:14, wrote: > > Hi Juergen, Jan, > > > > I spoke with Juli

Re: [Xen-devel] [PATCH 07/15] x86/acpi: Add Hygon Dhyana support

2019-01-14 Thread Jan Beulich
>>> On 20.12.18 at 14:14, wrote: > Add Hygon Dhyana support to the acpi cpufreq subsystem by using the code > path of AMD. ... cpufreq and cpuidle subsystems ... > @@ -660,8 +661,9 @@ int cpufreq_cpu_init(unsigned int cpuid) > { > int ret; > > -/* Currently we only handle Intel and A

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-14 Thread Julien Grall
Hi Jan, On 14/01/2019 15:52, Jan Beulich wrote: On 14.01.19 at 16:41, wrote: Hi Jan, On 14/01/2019 10:11, Jan Beulich wrote: On 11.01.19 at 19:04, wrote: On Fri, 11 Jan 2019, Jan Beulich wrote: On 11.01.19 at 03:14, wrote: Hi Juergen, Jan, I spoke with Julien: we are both convinced tha

[Xen-devel] [PATCH v6 2/2] xen/blkback: rework connect_ring() to avoid inconsistent xenstore 'ring-page-order' set by malicious blkfront

2019-01-14 Thread Dongli Zhang
The xenstore 'ring-page-order' is used globally for each blkback queue and therefore should be read from xenstore only once. However, it is obtained in read_per_ring_refs() which might be called multiple times during the initialization of each blkback queue. If the blkfront is malicious and the 'r

[Xen-devel] [PATCH v6 1/2] xen/blkback: add stack variable 'blkif' in connect_ring()

2019-01-14 Thread Dongli Zhang
As 'be->blkif' is used for many times in connect_ring(), the stack variable 'blkif' is added to substitute 'be-blkif'. Suggested-by: Paul Durrant Signed-off-by: Dongli Zhang Reviewed-by: Paul Durrant Reviewed-by: Roger Pau Monné --- drivers/block/xen-blkback/xenbus.c | 27 ++--

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-14 Thread Jan Beulich
>>> On 14.01.19 at 17:26, wrote: > On Monday, January 14, 2019 10:53 AM, Jan Beulich wrote: >> > Hi Jan, >> > >> > On 14/01/2019 10:11, Jan Beulich wrote: >> > On 11.01.19 at 19:04, wrote: >> >>> On Fri, 11 Jan 2019, Jan Beulich wrote: >> >>> On 11.01.19 at 03:14, wrote: >> > Hi Juer

Re: [Xen-devel] [PATCH v6 1/4] xen: introduce SYMBOL

2019-01-14 Thread Jan Beulich
>>> On 14.01.19 at 17:28, wrote: > Hi Jan, > > On 14/01/2019 15:52, Jan Beulich wrote: > On 14.01.19 at 16:41, wrote: >>> Hi Jan, >>> >>> On 14/01/2019 10:11, Jan Beulich wrote: >>> On 11.01.19 at 19:04, wrote: > On Fri, 11 Jan 2019, Jan Beulich wrote: > On 11.01.19 at 03:14

  1   2   >