Re: [Xen-devel] [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-08 Thread Oscar Salvador
On Fri, Oct 05, 2018 at 01:40:05PM +0530, Arun KS wrote: > When free pages are done with higher order, time spend on > coalescing pages by buddy allocator can be reduced. With > section size of 256MB, hot add latency of a single section > shows improvement from 50-60 ms to less than 1 ms, hence > i

Re: [Xen-devel] [PATCH 2/2] xen/xsm: Add new SILO mode for XSM

2018-10-08 Thread Xin Li (Talons)
Thanks Jan. > -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Tuesday, October 2, 2018 5:33 PM > To: Xin Li > Cc: Andrew Cooper ; Ming Lu > ; Sergey Dyasli ; Wei Liu > ; Xin Li (Talons) ; George Dunlap > ; Stefano Stabellini ; xen- > de...@lists.xen.org; Konrad R

Re: [Xen-devel] [PATCH] tools/ocaml: Release the global lock before invoking block syscalls

2018-10-08 Thread Christian Lindig
> On 8 Oct 2018, at 04:10, Yang Qian wrote: > > Functions related with event channel are parallelizable, so release global > lock before invoking C function which will finally call block syscalls. > > Signed-off-by: Yang Qian > --- > tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 30

Re: [Xen-devel] [PATCH V6] x86/altp2m: Add a subop for obtaining the mem access of a page

2018-10-08 Thread Razvan Cojocaru
On 10/4/18 7:56 PM, Tamas K Lengyel wrote: > On Thu, Sep 27, 2018 at 1:59 AM Razvan Cojocaru > wrote: >> >> Currently there is a subop for setting the memaccess of a page, but not >> for consulting it. The new HVMOP_altp2m_get_mem_access adds this >> functionality. >> >> Both altp2m get/set mem a

[Xen-devel] [linux-linus test] 128476: regressions - FAIL

2018-10-08 Thread osstest service owner
flight 128476 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/128476/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 125898 test-amd

Re: [Xen-devel] [PATCH 2/2] xen/xsm: Add new SILO mode for XSM

2018-10-08 Thread Jan Beulich
>>> On 08.10.18 at 09:49, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Tuesday, October 2, 2018 5:33 PM >> >> >>> On 29.09.18 at 11:22, wrote: >> > --- a/xen/xsm/dummy.c >> > +++ b/xen/xsm/dummy.c >> > @@ -11,7 +11,6 @@ >> > */ >> > >> > #define XSM_NO_WRAPPERS >> > -#defin

[Xen-devel] Xen 4.12 Development Update

2018-10-08 Thread Juergen Gross
This email only tracks big items for xen.git tree. Please reply for items you would like to see in 4.12 so that people have an idea what is going on and prioritise accordingly. You're welcome to provide description and use cases of the feature you're working on. = Timeline = We now adopt a fixed

Re: [Xen-devel] [PATCH 04/18] Various: Fix typo `occured'

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 19:29, wrote: > Signed-off-by: Ian Jackson Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 07/18] Various: Fix typo `infomation'

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 19:29, wrote: > Signed-off-by: Ian Jackson Acked-by: Jan Beulich Funny how often the same spelling mistakes repeat... Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/x

Re: [Xen-devel] Xen PV: Sample new PV driver for buffer sharing between domains

2018-10-08 Thread Omkar Bolla
Hi, Sorry for late response, On Wed, Oct 3, 2018 at 3:23 PM Julien Grall wrote: > > > On 10/02/2018 11:03 AM, Omkar Bolla wrote: > > Hi, > > > > Thanks, > > Basic state change is working now, after using above script. > > > > As I said, I want to share buffer between two domains. > > Could you

Re: [Xen-devel] [PATCH 10/18] INSTALL: Mention kconfig

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 19:29, wrote: > +Xen Hypervisor > +== > + > +Xen itself is configured via a `kconfig' system borrowed from Linux. > +See docs/misc/kconfig.txt. > + > +Note that unlike with Linux, and contrary to that document, you cannot > +look at Kconfig files, or the default or g

Re: [Xen-devel] Backports to stable

2018-10-08 Thread Jan Beulich
>>> On 07.10.18 at 03:04, wrote: > I'd like to propose backporting GCC7/8 fixes to all stable branches. Below > is a list up to stable-4.6, but some of the patches are already on > select branches (developed during that release cycle, or already > backported). I continue to be opposed to backport

Re: [Xen-devel] [PATCH 02/18] tools/xentrace/xenalyze: Fix typos detected by lintian

2018-10-08 Thread George Dunlap
On 10/05/2018 06:29 PM, Ian Jackson wrote: > Signed-off-by: Ian Jackson Reviewed-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 04/18] Various: Fix typo `occured'

2018-10-08 Thread George Dunlap
On 10/05/2018 06:29 PM, Ian Jackson wrote: > Signed-off-by: Ian Jackson Reviewed-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 07/18] Various: Fix typo `infomation'

2018-10-08 Thread George Dunlap
On 10/05/2018 06:29 PM, Ian Jackson wrote: > Signed-off-by: Ian Jackson Reviewed-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [xen-unstable test] 128478: tolerable FAIL

2018-10-08 Thread osstest service owner
flight 128478 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/128478/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-examine 4 memdisk-try-append fail pass in 128464 Tests which did not succeed, but

Re: [Xen-devel] [PATCH 01/18] docs/man: Fix two typos detected by the Debian lintian tool

2018-10-08 Thread Wei Liu
On Fri, Oct 05, 2018 at 06:29:00PM +0100, Ian Jackson wrote: > Signed-off-by: Ian Jackson > --- Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 21/23] xen/vpl011: buffer out chars when the backend is xen

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 20:47, wrote: > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -406,6 +406,13 @@ static void dump_console_ring_key(unsigned char key) > */ > static unsigned int __read_mostly console_rx = 0; > > +struct domain *console_input_domain(void) > +{ > +

Re: [Xen-devel] [PATCH 05/18] Various: Fix typo `reseting'

2018-10-08 Thread Wei Liu
On Fri, Oct 05, 2018 at 06:29:04PM +0100, Ian Jackson wrote: > Signed-off-by: Ian Jackson Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 08/18] Various: Fix typo `mappping'

2018-10-08 Thread Wei Liu
On Fri, Oct 05, 2018 at 06:29:07PM +0100, Ian Jackson wrote: > Signed-off-by: Ian Jackson Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 06/18] tools/python/xen/lowlevel: Fix typo `sucess'

2018-10-08 Thread Wei Liu
On Fri, Oct 05, 2018 at 06:29:05PM +0100, Ian Jackson wrote: > Signed-off-by: Ian Jackson Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 03/18] Various: Fix typos `unkown', `retreive' (detected by lintian)

2018-10-08 Thread Wei Liu
On Fri, Oct 05, 2018 at 06:29:02PM +0100, Ian Jackson wrote: > Signed-off-by: Ian Jackson Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 11/18] docs/man: Provide properly-formatted NAME sections

2018-10-08 Thread Wei Liu
On Fri, Oct 05, 2018 at 06:29:10PM +0100, Ian Jackson wrote: > A manpage `foo.7.pod' must start with > > =head NAME > > foo - some summary of what foo is or what this manpage is > > because otherwise manpage catalogue systems cannot generate a proper > `whatis' entry. > > Signed-off-by: Ian

Re: [Xen-devel] [PATCH 12/18] docs/man/xen-pv-channel.pod.7: Remove a spurious blank line

2018-10-08 Thread Wei Liu
On Fri, Oct 05, 2018 at 06:29:11PM +0100, Ian Jackson wrote: > No functional change. > > Signed-off-by: Ian Jackson Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 15/18] libfsimage: Honour general LDFLAGS

2018-10-08 Thread Wei Liu
On Fri, Oct 05, 2018 at 06:29:14PM +0100, Ian Jackson wrote: > Do not reset LDFLAGS to empty. Instead, append the fsimage-special > LDFLAGS. > > Signed-off-by: Ian Jackson Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org h

Re: [Xen-devel] [PATCH 13/18] tools/xenstat: Fix shared library version

2018-10-08 Thread Wei Liu
On Fri, Oct 05, 2018 at 06:29:12PM +0100, Ian Jackson wrote: > From: Bastian Blank > > libxenstat does not have a stable ABI. Set its version to the current > Xen release version. > > Signed-off-by: Ian Jackson Acked-by: Wei Liu ___ Xen-devel mail

Re: [Xen-devel] [PATCH v4 20/23] xen: support console_switching between Dom0 and DomUs on ARM

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 20:47, wrote: > @@ -391,31 +394,73 @@ static void dump_console_ring_key(unsigned char key) > free_xenheap_pages(buf, order); > } > > -/* CTRL- switches input direction between Xen and DOM0. */ > +/* > + * CTRL- switches input direction between Xen, Dom0 and > + * DomUs.

Re: [Xen-devel] [PATCH 17/18] xenmon: Install as xenmon, not xenmon.py

2018-10-08 Thread Wei Liu
On Fri, Oct 05, 2018 at 06:29:16PM +0100, Ian Jackson wrote: > Adding the implementation language as a suffix to a program name is > poor practice. > > Signed-off-by: Ian Jackson Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject

Re: [Xen-devel] [PATCH] tools/ocaml: Release the global lock before invoking block syscalls

2018-10-08 Thread Andrew Cooper
On 08/10/18 08:58, Christian Lindig wrote: > >> On 8 Oct 2018, at 04:10, Yang Qian wrote: >> >> Functions related with event channel are parallelizable, so release global >> lock before invoking C function which will finally call block syscalls. >> >> Signed-off-by: Yang Qian >> --- >> tools/ocam

[Xen-devel] [distros-debian-sid test] 75372: trouble: blocked/broken

2018-10-08 Thread Platform Team regression test user
flight 75372 distros-debian-sid real [real] http://osstest.xensource.com/osstest/logs/75372/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken build-i386

Re: [Xen-devel] [PATCH] x86/svm: Fix svm_update_guest_efer() for domains using shadow paging

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 19:02, wrote: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -649,13 +649,32 @@ void svm_update_guest_cr(struct vcpu *v, unsigned int > cr, unsigned int flags) > static void svm_update_guest_efer(struct vcpu *v) > { > struct vmcb_struct *vmcb

[Xen-devel] [PATCH] x86/vtd: fix iommu_share_p2m_table

2018-10-08 Thread Roger Pau Monne
Commit 2916951c1 changed the check in iommu_share_p2m_table to use need_iommu(d) instead of iommu_enabled, which broke the check because at the point in domain construction where iommu_share_p2m_table is called need_iommu(d) will always return false. Fix this by reverting to the previous logic. S

Re: [Xen-devel] [PATCH] x86/vtd: fix iommu_share_p2m_table

2018-10-08 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne [mailto:roger@citrix.com] > Sent: 08 October 2018 11:15 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Jan Beulich > ; Paul Durrant > Subject: [PATCH] x86/vtd: fix iommu_share_p2m_table > > Commit 2916951c1 changed the check i

Re: [Xen-devel] Xen PV: Sample new PV driver for buffer sharing between domains

2018-10-08 Thread Julien Grall
On 08/10/2018 10:12, Omkar Bolla wrote: Hi, Hi, This is also okay, but problem here is I am using 4.8 stable  xen because it  is working on Hkey960(ArmV8) This is because you can't bring up secondary CPUs on the Hikey with Xen 4.11 [1], right? It would be nice to find where the bug was i

Re: [Xen-devel] [PATCH] x86/vtd: fix iommu_share_p2m_table

2018-10-08 Thread Jan Beulich
>>> On 08.10.18 at 12:14, wrote: > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -505,7 +505,7 @@ int iommu_do_domctl( > > void iommu_share_p2m_table(struct domain* d) > { > -if ( iommu_use_hap_pt(d) ) > +if ( iommu_enabled && hap_enabled(d) && iomm

Re: [Xen-devel] [PATCH] x86/vtd: fix iommu_share_p2m_table

2018-10-08 Thread Jan Beulich
>>> On 08.10.18 at 12:27, wrote: >> -Original Message- >> From: Roger Pau Monne [mailto:roger@citrix.com] >> Sent: 08 October 2018 11:15 >> To: xen-devel@lists.xenproject.org >> Cc: Roger Pau Monne ; Jan Beulich >> ; Paul Durrant >> Subject: [PATCH] x86/vtd: fix iommu_share_p2m_tabl

Re: [Xen-devel] [PATCH] x86/vtd: fix iommu_share_p2m_table

2018-10-08 Thread Roger Pau Monné
On Mon, Oct 08, 2018 at 04:33:04AM -0600, Jan Beulich wrote: > >>> On 08.10.18 at 12:14, wrote: > > --- a/xen/drivers/passthrough/iommu.c > > +++ b/xen/drivers/passthrough/iommu.c > > @@ -505,7 +505,7 @@ int iommu_do_domctl( > > > > void iommu_share_p2m_tableiommu_share_p2m_table(struct domain*

Re: [Xen-devel] Backports to stable

2018-10-08 Thread Marek Marczykowski
On Mon, Oct 08, 2018 at 03:29:06AM -0600, Jan Beulich wrote: > >>> On 07.10.18 at 03:04, wrote: > > I'd like to propose backporting GCC7/8 fixes to all stable branches. Below > > is a list up to stable-4.6, but some of the patches are already on > > select branches (developed during that release c

Re: [Xen-devel] [PATCH] x86/vtd: fix iommu_share_p2m_table

2018-10-08 Thread Roger Pau Monné
On Mon, Oct 08, 2018 at 12:37:39PM +0200, Roger Pau Monné wrote: > On Mon, Oct 08, 2018 at 04:33:04AM -0600, Jan Beulich wrote: > > >>> On 08.10.18 at 12:14, wrote: > > > --- a/xen/drivers/passthrough/iommu.c > > > +++ b/xen/drivers/passthrough/iommu.c > > > @@ -505,7 +505,7 @@ int iommu_do_domctl

Re: [Xen-devel] Question, How to share interrupt between Doms

2018-10-08 Thread Julien Grall
On 08/10/2018 03:37, Peng Fan wrote: Hi Julien Hi Peng, -Original Message- From: Julien Grall [mailto:julien.gr...@arm.com] Sent: 2018年10月5日 1:27 To: Peng Fan ; Stefano Stabellini Cc: xen-devel@lists.xenproject.org; Andre Przywara Subject: Re: Question, How to share interrupt betwee

[Xen-devel] [PATCH 2/3] xen/xsm: Introduce new boot parameter xsm

2018-10-08 Thread Xin Li
Introduce new boot parameter xsm to choose which xsm module is enabled, and set default to dummy. And add new option in Kconfig to choose the default XSM implementation. Signed-off-by: Xin Li --- CC: Daniel De Graaf CC: George Dunlap CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stab

[Xen-devel] [PATCH 1/3] xen/xsm: remove unnecessary #define

2018-10-08 Thread Xin Li
From: root this #define is unnecessary since XSM_INLINE is redefined in xsm/dummy.h, so remove it. Signed-off-by: Xin Li --- CC: Daniel De Graaf CC: George Dunlap CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu CC: Sergey Dyasli CC: Andrew Co

[Xen-devel] [PATCH 3/3] xen/xsm: Add new SILO mode for XSM

2018-10-08 Thread Xin Li
When SILO is enabled, there would be no page-sharing or event notifications between unprivileged VMs (no grant tables or event channels). Signed-off-by: Xin Li --- CC: Daniel De Graaf CC: George Dunlap CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei

Re: [Xen-devel] [PATCH] x86/svm: Fix svm_update_guest_efer() for domains using shadow paging

2018-10-08 Thread Andrew Cooper
On 08/10/18 11:12, Jan Beulich wrote: On 05.10.18 at 19:02, wrote: >> --- a/xen/arch/x86/hvm/svm/svm.c >> +++ b/xen/arch/x86/hvm/svm/svm.c >> @@ -649,13 +649,32 @@ void svm_update_guest_cr(struct vcpu *v, unsigned int >> cr, unsigned int flags) >> static void svm_update_guest_efer(struct vc

Re: [Xen-devel] [PATCH v2] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

2018-10-08 Thread Jan Beulich
>>> On 25.09.18 at 17:30, wrote: > On 25/09/18 13:41, Jan Beulich wrote: > On 20.09.18 at 14:41, wrote: >>> On 13/09/18 11:12, Jan Beulich wrote: The function does two translations in one go for a single guest access. Any failure of the first translation step (guest linear -> guest

Re: [Xen-devel] [PATCH 1/3] xen/xsm: remove unnecessary #define

2018-10-08 Thread Jan Beulich
>>> On 08.10.18 at 12:59, wrote: > From: root > > this #define is unnecessary since XSM_INLINE is redefined in > xsm/dummy.h, so remove it. And it is actually a latent risk of build breakage, if the other one got updated without this one following suit. > Signed-off-by: Xin Li Reviewed-by: J

Re: [Xen-devel] Backports to stable

2018-10-08 Thread Jan Beulich
>>> On 08.10.18 at 12:40, wrote: > On Mon, Oct 08, 2018 at 03:29:06AM -0600, Jan Beulich wrote: >> >>> On 07.10.18 at 03:04, wrote: >> > I'd like to propose backporting GCC7/8 fixes to all stable branches. Below >> > is a list up to stable-4.6, but some of the patches are already on >> > select b

Re: [Xen-devel] [PATCH] x86/vtd: fix iommu_share_p2m_table

2018-10-08 Thread Jan Beulich
>>> On 08.10.18 at 12:50, wrote: > On Mon, Oct 08, 2018 at 12:37:39PM +0200, Roger Pau Monné wrote: >> On Mon, Oct 08, 2018 at 04:33:04AM -0600, Jan Beulich wrote: >> > >>> On 08.10.18 at 12:14, wrote: >> > > --- a/xen/drivers/passthrough/iommu.c >> > > +++ b/xen/drivers/passthrough/iommu.c >> >

Re: [Xen-devel] [PATCH] x86/svm: Fix svm_update_guest_efer() for domains using shadow paging

2018-10-08 Thread Jan Beulich
>>> On 08.10.18 at 13:03, wrote: > On 08/10/18 11:12, Jan Beulich wrote: > On 05.10.18 at 19:02, wrote: >>> --- a/xen/arch/x86/hvm/svm/svm.c >>> +++ b/xen/arch/x86/hvm/svm/svm.c >>> @@ -649,13 +649,32 @@ void svm_update_guest_cr(struct vcpu *v, unsigned int > cr, unsigned int flags) >>> sta

[Xen-devel] preparations for 4.11.1 and 4.8.5

2018-10-08 Thread Jan Beulich
All, both releases are due in about a month's time. Please point out backports you find missing from their respective staging branches, but which you consider relevant. On top of what I've just pushed there I have 2fb57e4bee x86: silence false log messages for plain "xpti" / "pv-l1tf" 51e0cb

[Xen-devel] [xen-unstable-smoke test] 128500: tolerable all pass - PUSHED

2018-10-08 Thread osstest service owner
flight 128500 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/128500/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH 1/2] x86/hvm: make sure HVM_PARAM_[BUF]IOREQ_PFN can only be set once

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 15:43, wrote: > These parameters should have always been in the 'set once' category > but this has, so far, not been enforced. But now that we're not even handling these anymore, why is there a need to start doing so? If anything wouldn't it be better to add them to the depreca

Re: [Xen-devel] [PATCH 1/3] xen/xsm: remove unnecessary #define

2018-10-08 Thread Wei Liu
On Mon, Oct 08, 2018 at 06:59:01PM +0800, Xin Li wrote: > From: root This needs to be deleted while committing. Wei. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 1/2] x86/hvm: make sure HVM_PARAM_[BUF]IOREQ_PFN can only be set once

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 15:43, wrote: > These parameters should have always been in the 'set once' category > but this has, so far, not been enforced. Hmm, now that I'm looking at patch 2 I see where this is coming from, but a hint towards this here would have helped, if this is to be a separate patch

Re: [Xen-devel] [PATCH 1/2] x86/hvm: make sure HVM_PARAM_[BUF]IOREQ_PFN can only be set once

2018-10-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 08 October 2018 14:20 > To: Paul Durrant > Cc: Andrew Cooper ; Wei Liu > ; xen-devel > Subject: Re: [PATCH 1/2] x86/hvm: make sure HVM_PARAM_[BUF]IOREQ_PFN can > only be set once > > >>> On 05.10.18 at 15:43, wr

Re: [Xen-devel] [PATCH 2/2] x86/hvm/ioreq: allow ioreq servers to use HVM_PARAM_[BUF]IOREQ_PFN

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 15:43, wrote: > Since commit 2c257bd6 "x86/hvm: remove default ioreq server (again)" the > GFNs allocated by the toolstack and set in HVM_PARAM_IOREQ_PFN and > HVM_PARAM_BUFIOREQ_PFN have been unused. This patch allows them to be used > by (non-default) ioreq servers. > > NOTE:

Re: [Xen-devel] [PATCH 2/5] xen/domain: Introduce a new arch_check_domain_config() helper

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 16:54, wrote: > On the ARM side, lift the code to select the appropriate GIC version when > NATIVE is requested. > > Signed-off-by: Andrew Cooper The minimal x86 pieces Acked-by: Jan Beulich (possibly subject to renaming as per patch 1's comment) Jan

Re: [Xen-devel] [PATCH 1/5] xen/domain: Introduce a new check_domain_config() helper

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 16:54, wrote: > Call it from the head of domain_create() (before doing any memory > allocations), which will apply the checks to dom0 as well as domU's. > > For now, just subsume the XEN_DOMCTL_CDF_* check from XEN_DOMCTL_createdomain. > This means that the corner case of the t

[Xen-devel] vtpmmgr compiled from from git strange output

2018-10-08 Thread Dag Nygren
Hi! Just cloned master from git and compiled stubdom/vtpmmgr and am getting weird output from it. Like this: INFO[TPM]: TPM2_PCR_Read TPM Manager - disk format 0 root seal: zu; sector of 84: zu root: zu v=zu itree: 36; sector of 112: zu group: zu v=zu id=zu md=zu group seal: zu; 72 in paren

Re: [Xen-devel] [PATCH 3/5] xen/domain: Audit config->max_vcpus during {, arch_}check_domain_config()

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 16:54, wrote: > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -601,6 +601,8 @@ void vcpu_switch_to_aarch64_mode(struct vcpu *v) > > int arch_check_domain_config(struct xen_domctl_createdomain *config) > { > +unsigned int max_vcpus = 0; Is the initialize

Re: [Xen-devel] [PATCH 4/5] xen/domain: Allocate d->vcpu[] earlier during domain_create()

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 16:54, wrote: > @@ -405,19 +419,6 @@ struct domain *domain_create(domid_t domid, > > if ( !is_idle_domain(d) ) > { > -/* Check d->max_vcpus and allocate d->vcpu[]. */ > -err = -EINVAL; > -if ( config->max_vcpus < 1 || > - config->m

[Xen-devel] [PATCH v2] x86/vtd: fix iommu_share_p2m_table

2018-10-08 Thread Roger Pau Monne
Commit 2916951c1 "mm / iommu: include need_iommu() test in iommu_use_hap_pt()" changed the check in iommu_share_p2m_table to use need_iommu(d) (as part of iommu_use_hap_pt) instead of iommu_enabled, which broke the check because at the point in domain construction where iommu_share_p2m_table is cal

Re: [Xen-devel] [PATCH v2] x86/vtd: fix iommu_share_p2m_table

2018-10-08 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne [mailto:roger@citrix.com] > Sent: 08 October 2018 14:53 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Jan Beulich > ; Paul Durrant > Subject: [PATCH v2] x86/vtd: fix iommu_share_p2m_table > > Commit 2916951c1 "mm / iommu: inc

Re: [Xen-devel] [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'

2018-10-08 Thread Ian Jackson
Tim Deegan writes ("Re: [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'"): > At 18:29 +0100 on 05 Oct (1538764157), Ian Jackson wrote: > > `kdd' is an unfortunate namespace landgrab. > > Bah, humbug, etc. :) Can we have a note in the changelog for the next > release to war

Re: [Xen-devel] [PATCH 10/18] INSTALL: Mention kconfig

2018-10-08 Thread Ian Jackson
Doug Goldstein writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"): > On Fri, Oct 05, 2018 at 06:29:09PM +0100, Ian Jackson wrote: > > Firstly, add a reference to the documentation for the kconfig system. > > > > Secondly, warn the user about the XEN_CONFIG_EXPERT problem. > > Reviewed-by: Doug

Re: [Xen-devel] [PATCH 10/18] INSTALL: Mention kconfig

2018-10-08 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"): > On 05.10.18 at 19:29, wrote: > > +silently overriden. The only way to find which configuration options > > Isn't it "overridden", or are both spellings okay? It is; I was wrong. > > +this varible there is nothing stopping you

Re: [Xen-devel] [PATCH 07/18] Various: Fix typo `infomation'

2018-10-08 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH 07/18] Various: Fix typo `infomation'"): > On 05.10.18 at 19:29, wrote: > > Signed-off-by: Ian Jackson > > Acked-by: Jan Beulich > > Funny how often the same spelling mistakes repeat... Mmm. In one of my own projects I had a persistent problem with `pseudo' (w

Re: [Xen-devel] [PATCH] mm/page_alloc: add bootscrub=idle cmdline option

2018-10-08 Thread Jan Beulich
>>> On 03.10.18 at 12:28, wrote: > Scrubbing RAM during boot may take a long time on machines with lots > of RAM. Add 'idle' option which marks all pages dirty initially so they > would eventually be scrubbed in idle-loop on every online CPU. > > Performance of idle-loop scrubbing is worse than b

Re: [Xen-devel] [PATCH 10/18] INSTALL: Mention kconfig

2018-10-08 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"): > On 08.10.18 at 16:08, wrote: > > Thanks, I'll take that as an ack. (Assuming you did indeed mean > > `accepting' rather than `excepting'.) > > Well, no, it was not meant as an ack, merely as the absence of further > objections.

Re: [Xen-devel] [PATCH v2] x86/vtd: fix iommu_share_p2m_table

2018-10-08 Thread Jan Beulich
>>> On 08.10.18 at 15:52, wrote: > Commit 2916951c1 "mm / iommu: include need_iommu() test in > iommu_use_hap_pt()" changed the check in iommu_share_p2m_table to use > need_iommu(d) (as part of iommu_use_hap_pt) instead of iommu_enabled, > which broke the check because at the point in domain const

Re: [Xen-devel] [PATCH 00/18] Miscellaneous build and docs, fixes from Debian

2018-10-08 Thread Ian Jackson
Ian Jackson writes ("[PATCH 00/18] Miscellaneous build and docs, fixes from Debian"): > Bastian Blank (1): > Ian Jackson (17): Thanks to the reviewers. I have pushed to staging these patches, which were acked/reviewed and seemed to me to be uncontroversial: > docs/man: Fix two typos detected

Re: [Xen-devel] [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'

2018-10-08 Thread Juergen Gross
On 08/10/2018 16:01, Ian Jackson wrote: > Tim Deegan writes ("Re: [PATCH 18/18] tools/debugger/kdd: Install as > `xen-kdd', not just `kdd'"): >> At 18:29 +0100 on 05 Oct (1538764157), Ian Jackson wrote: >>> `kdd' is an unfortunate namespace landgrab. >> >> Bah, humbug, etc. :) Can we have a note

Re: [Xen-devel] [PATCH] stubdom/grub.patches: Drop docs changes, for licensing reasons

2018-10-08 Thread Ian Jackson
Ian Jackson writes ("[PATCH] stubdom/grub.patches: Drop docs changes, for licensing reasons"): > The patch file 00cvs is an import of a new upstream version of > grub1 from upstream CVS. FTR, I intend to backport this change to the earliest (security-supported) tree that it cleanly applies to. I

Re: [Xen-devel] [PATCH 10/18] INSTALL: Mention kconfig

2018-10-08 Thread Jan Beulich
>>> On 08.10.18 at 16:08, wrote: > Jan Beulich writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"): >> On 05.10.18 at 19:29, wrote: >> > +silently overriden. The only way to find which configuration options >> >> Isn't it "overridden", or are both spellings okay? > > It is; I was wrong. > >

Re: [Xen-devel] [PATCH V3 2/2] Xen/PCIback: Implement PCI flr/slot/bus reset with 'reset' SysFS attribute

2018-10-08 Thread Boris Ostrovsky
On 10/3/18 11:51 AM, Pasi Kärkkäinen wrote: > On Wed, Sep 19, 2018 at 11:05:26AM +0200, Roger Pau Monné wrote: >> On Tue, Sep 18, 2018 at 02:09:53PM -0400, Boris Ostrovsky wrote: >>> On 9/18/18 5:32 AM, George Dunlap wrote: > On Sep 18, 2018, at 8:15 AM, Pasi Kärkkäinen wrote: > > Hi,

Re: [Xen-devel] [PATCH 2/2] x86/hvm/ioreq: allow ioreq servers to use HVM_PARAM_[BUF]IOREQ_PFN

2018-10-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 08 October 2018 14:29 > To: Paul Durrant > Cc: Andrew Cooper ; Wei Liu > ; xen-devel > Subject: Re: [PATCH 2/2] x86/hvm/ioreq: allow ioreq servers to use > HVM_PARAM_[BUF]IOREQ_PFN > > >>> On 05.10.18 at 15:43,

[Xen-devel] [PATCH] xen/sched: Drop set_current_state()

2018-10-08 Thread Andrew Cooper
This appears to have been a Linux-ism which found its way into the Xen codebase with the IA64 port, and remained after IA64 was removed. As far as I can tell from code archeology, none of the other architectures have ever had a current->state field. Signed-off-by: Andrew Cooper --- CC: George Du

[Xen-devel] [freebsd-master test] 128497: all pass - PUSHED

2018-10-08 Thread osstest service owner
flight 128497 freebsd-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/128497/ Perfect :-) All tests in this flight passed as required version targeted for testing: freebsd c0b412ce93b9d3ee750e5f262b50e64c52d300cc baseline version: freebsd 8f45b071b58

Re: [Xen-devel] [PATCH 2/2] x86/hvm/ioreq: allow ioreq servers to use HVM_PARAM_[BUF]IOREQ_PFN

2018-10-08 Thread Jan Beulich
>>> On 08.10.18 at 16:38, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 08 October 2018 14:29 >> To: Paul Durrant >> Cc: Andrew Cooper ; Wei Liu >> ; xen-devel >> Subject: Re: [PATCH 2/2] x86/hvm/ioreq: allow ioreq servers to use >> HVM_PARAM_[BUF

Re: [Xen-devel] [PATCH 2/2] x86/hvm/ioreq: allow ioreq servers to use HVM_PARAM_[BUF]IOREQ_PFN

2018-10-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 08 October 2018 15:59 > To: Paul Durrant > Cc: Andrew Cooper ; Wei Liu > ; xen-devel > Subject: RE: [PATCH 2/2] x86/hvm/ioreq: allow ioreq servers to use > HVM_PARAM_[BUF]IOREQ_PFN > > >>> On 08.10.18 at 16:38,

Re: [Xen-devel] [PATCH] xen/sched: Drop set_current_state()

2018-10-08 Thread Jan Beulich
>>> On 08.10.18 at 16:48, wrote: > This appears to have been a Linux-ism which found its way into the Xen > codebase with the IA64 port, and remained after IA64 was removed. > > As far as I can tell from code archeology, none of the other architectures > have ever had a current->state field. > >

Re: [Xen-devel] [PATCH 01/17] x86/shadow: put PV L1TF functions under CONFIG_PV

2018-10-08 Thread Jan Beulich
>>> On 04.10.18 at 17:43, wrote: > Signed-off-by: Wei Liu If applicable (not sure whether Tim would have to ack it instead): Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listin

Re: [Xen-devel] [PATCH] xen/sched: Drop set_current_state()

2018-10-08 Thread George Dunlap
On 10/08/2018 03:48 PM, Andrew Cooper wrote: > This appears to have been a Linux-ism which found its way into the Xen > codebase with the IA64 port, and remained after IA64 was removed. > > As far as I can tell from code archeology, none of the other architectures > have ever had a current->state

Re: [Xen-devel] [PATCH 02/17] x86/mm: make mm.c build with !CONFIG_PV

2018-10-08 Thread Jan Beulich
>>> On 04.10.18 at 17:43, wrote: > @@ -1277,6 +1274,8 @@ void put_page_from_l1e(l1_pgentry_t l1e, struct domain > *l1e_owner) > } > > > +#ifdef CONFIG_PV > + > /* Could you please avoid inserting yet another blank line here, and instead make use of the existing so far one too many? Jan

Re: [Xen-devel] [PATCH 5/5] RFC: test/depriv: Add a tool to check process-level depriv

2018-10-08 Thread Anthony PERARD
On Fri, Oct 05, 2018 at 05:57:01PM +0100, George Dunlap wrote: > +# TEST: Process / group id > +# > +# Read /proc//status, checking Uid and Gid lines > +# > +# Uid should be xen-qemuuser-range-base+$domid > +# Gid should be 65534 ("nobody") That is wrong. Gid doesn't have to be nobody. gid can be

Re: [Xen-devel] [PATCH 5/5] RFC: test/depriv: Add a tool to check process-level depriv

2018-10-08 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH 5/5] RFC: test/depriv: Add a tool to check process-level depriv"): > On Fri, Oct 05, 2018 at 05:57:01PM +0100, George Dunlap wrote: > > +# TEST: Process / group id > > +# > > +# Read /proc//status, checking Uid and Gid lines > > +# > > +# Uid should be xen-qemuus

Re: [Xen-devel] [PATCH 4/5] xen/domain: Allocate d->vcpu[] earlier during domain_create()

2018-10-08 Thread Andrew Cooper
On 08/10/18 14:51, Jan Beulich wrote: On 05.10.18 at 16:54, wrote: >> @@ -405,19 +419,6 @@ struct domain *domain_create(domid_t domid, >> >> if ( !is_idle_domain(d) ) >> { >> -/* Check d->max_vcpus and allocate d->vcpu[]. */ >> -err = -EINVAL; >> -if ( conf

[Xen-devel] [xen-unstable-smoke test] 128509: tolerable all pass - PUSHED

2018-10-08 Thread osstest service owner
flight 128509 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/128509/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[Xen-devel] Xen boot failure on QEMU (WAS: Re: [PATCH v3] xen:arm: Populate arm64 image header)

2018-10-08 Thread Julien Grall
(+ Peter Maydell and Stefano) Hi Steward, Thank you for the bug report. On 05/10/2018 23:17, Stewart Hildebrand wrote: On 11/09/2018 17:48, Amit Singh Tomar wrote: diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index d63734f..ef87b5c 100644 --- a/xen/arch/arm/arm64/head.S

[Xen-devel] [RFC 06/16] xen/arm: p2m: Introduce a helper to generate P2M table entry from a page

2018-10-08 Thread Julien Grall
Generate P2M table entry requires to set some default values which are worth to explain in a comment. At the moment, there are 2 places where such entry are created but only one as proper comment. Some move the code to generate P2M table entry in a separate helper. This will be helpful in a follow

[Xen-devel] [RFC 05/16] xen/arm: traps: Move the implementation of GUEST_BUG_ON in traps.h

2018-10-08 Thread Julien Grall
GUEST_BUG_ON may be used in other files doing guest emulation. Signed-off-by: Julien Grall --- The patch was previously sent separately. --- xen/arch/arm/traps.c| 24 xen/include/asm-arm/traps.h | 24 2 files changed, 24 insertions(

[Xen-devel] [RFC 12/16] xen/arm: Rework p2m_cache_flush to take a range [begin, end)

2018-10-08 Thread Julien Grall
The function will be easier to re-use in a follow-up patch if you have only the begin and end. At the same time, rename the function to reflect the change in the prototype. Signed-off-by: Julien Grall --- xen/arch/arm/domctl.c | 2 +- xen/arch/arm/p2m.c| 3 +-- xen/include/asm-arm/p

[Xen-devel] [RFC 13/16] xen/arm: p2m: Allow to flush cache on any RAM region

2018-10-08 Thread Julien Grall
Currently, we only allow to flush cache on region mapped as p2m_ram_{rw,ro}. There are no real problem to flush cache on any RAM region such as grants and foreign mapping. Therefore, relax the cache to allow flushing the cache on any RAM region. Signed-off-by: Julien Grall --- xen/arch/arm/p2m.

[Xen-devel] [RFC 10/16] xen/arm: vcpreg: Add wrappers to handle co-proc access trapped by HCR_EL2.TVM

2018-10-08 Thread Julien Grall
A follow-up patch will require to emulate some accesses to some co-processors registers trapped by HCR_EL2.TVM. When set, all NS EL1 writes to the virtual memory control registers will be trapped to the hypervisor. This patch adds the infrastructure to passthrough the access to host registers. For

[Xen-devel] [RFC 09/16] xen/arm: p2m: Introduce a function to resolve translation fault

2018-10-08 Thread Julien Grall
Currently a Stage-2 translation fault could happen: 1) MMIO emulation 2) When the page-tables is been updated using Break-Before-Make 3) Page not mapped A follow-up patch will re-purpose the valid bit in an entry to generate translation fault. This would be used to do an action on each

[Xen-devel] [RFC 02/16] xen/arm: Introduce helpers to get/set an MFN from/to an LPAE entry

2018-10-08 Thread Julien Grall
The new helpers make it easier to read the code by abstracting the way to set/get an MFN from/to an LPAE entry. The helpers are using "walk" as the bits are common across different LPAE stages. At the same time, use the new helpers to replace the various open-coding place. Signed-off-by: Julien G

[Xen-devel] [RFC 08/16] xen/arm: p2m: Handle translation fault in get_page_from_gva

2018-10-08 Thread Julien Grall
A follow-up patch will re-purpose the valid bit of LPAE entries to generate fault even on entry containing valid information. This means that when translation a guest VA to guest PA (e.g IPA) will fail if the Stage-2 entries used have the valid bit unset. Because of that, we need to fallback to wa

[Xen-devel] [RFC 15/16] xen/arm: Implement Set/Way operations

2018-10-08 Thread Julien Grall
Set/Way operations are used to perform maintenance on a given cache. At the moment, Set/Way operations are not trapped and therefore a guest OS will directly act on the local cache. However, a vCPU may migrate to another pCPU in the middle of the processor. This will result to have cache with stall

[Xen-devel] [RFC 11/16] xen/arm: vsysreg: Add wrapper to handle sysreg access trapped by HCR_EL2.TVM

2018-10-08 Thread Julien Grall
A follow-up patch will require to emulate some accesses to system registers trapped by HCR_EL2.TVM. When set, all NS EL1 writes to the virtual memory control registers will be trapped to the hypervisor. This patch adds the infrastructure to passthrough the access to the host registers. Note that

[Xen-devel] [RFC 04/16] xen/arm: guest_walk_tables: Switch the return to bool

2018-10-08 Thread Julien Grall
At the moment, guest_walk_tables can either return 0, -EFAULT, -EINVAL. The use of the last 2 are not clearly defined and used inconsistently in the code. The current only caller does not care about the return value and the value of it seems very limited (no way to differentiate between the 15ish e

  1   2   >