On 08/10/18 14:51, Jan Beulich wrote: >>>> On 05.10.18 at 16:54, <andrew.coop...@citrix.com> wrote: >> @@ -405,19 +419,6 @@ struct domain *domain_create(domid_t domid, >> >> if ( !is_idle_domain(d) ) >> { >> - /* Check d->max_vcpus and allocate d->vcpu[]. */ >> - err = -EINVAL; >> - if ( config->max_vcpus < 1 || >> - config->max_vcpus > domain_max_vcpus(d) ) >> - goto fail; > Ah, there it goes away. But I think it would be more logical for this to > happen in the previous patch. Anyway > Reviewed-by: Jan Beulich <jbeul...@suse.com> > for both, preferably (but not necessarily) with the removal moved > there.
The x86 side is trivial, but the ARM side is not. I don't think patches 3 and 4 should be merged, but I'll let Julien/Stefano have the final say. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel