Hi Jan,
Thank you for your review.
> On 08/07/ 2025 19:15, Jan Beulich wrote:
>> +pcpu.o: pcpu.c pcpu.h
>> +$(CC) $(CFLAGS) -c $< -o $@
>> +
>> +%.o: %.c
>> +$(CC) $(CFLAGS) -c $< -o $@
> As you mean to re-submit, you may also want to tidy (back) the above. You
> don't say why you need
On 08.07.2025 13:46, Jahan Murudi wrote:
> --- a/tools/xentop/Makefile
> +++ b/tools/xentop/Makefile
> @@ -15,6 +15,7 @@ include $(XEN_ROOT)/tools/Rules.mk
>
> CFLAGS += -DGCC_PRINTF $(CFLAGS_libxenstat)
> LDLIBS += $(LDLIBS_libxenstat) $(CURSES_LIBS) $(TINFO_LIBS) $(SOCKET_LIBS)
> -lm
> +LDLI
Hi Andriy,
Thank you for your review.
>On 08/07/ 2025 18:26, Andriy Sultanov wrote:
> > diff --git a/tools/xentop/xentop.c b/tools/xentop/xentop.c > index
> > f5d6c19cf9..477299c883 100644 > --- a/tools/xentop/xentop.c > +++
> > b/tools/xentop/xentop.c > @@ -69,6 +70,12 @@ > > #define
> diff --git a/tools/xentop/xentop.c b/tools/xentop/xentop.c
> index f5d6c19cf9..477299c883 100644
> --- a/tools/xentop/xentop.c
> +++ b/tools/xentop/xentop.c
> @@ -69,6 +70,12 @@
>
> #define INT_FIELD_WIDTH(n) ((unsigned int)(log10(n) + 1))
>
> +/* TEMPORARY: Forward declare the internal structu
