Hi Jan,

Thank you for your review.

> On 08/07/ 2025 19:15, Jan Beulich wrote:

>> +pcpu.o: pcpu.c pcpu.h
>> +    $(CC) $(CFLAGS) -c $< -o $@
>> +
>> +%.o: %.c
>> +    $(CC) $(CFLAGS) -c $< -o $@

> As you mean to re-submit, you may also want to tidy (back) the above. You 
> don't say why you need to spell out both the explicit and the pattern rule 
> here. And I don't think this is actually necessary. All you ought to need is 
> indeed the addition of the extra prereq object file.

You're right - these explicit rules are redundant. In v2 of the RFC patch, I've 
removed both the explicit pcpu.o rule and the pattern rule.
https://patchwork.kernel.org/project/xen-devel/patch/20250709082810.3052544-1-jahan.murudi...@renesas.com/

Regards,
Jahan Murudi

Reply via email to