> diff --git a/tools/xentop/xentop.c b/tools/xentop/xentop.c
> index f5d6c19cf9..477299c883 100644
> --- a/tools/xentop/xentop.c
> +++ b/tools/xentop/xentop.c
> @@ -69,6 +70,12 @@
>
> #define INT_FIELD_WIDTH(n) ((unsigned int)(log10(n) + 1))
>
> +/* TEMPORARY: Forward declare the internal structure */
> +struct xenstat_handle {
> + xc_interface *xc_handle;
> + /* Other members don't matter fo now */
> +};
> +
What makes this temporary? Is there a follow-up patch?
Or should this be an [RFC] instead of a [PATCH]?
> @@ -240,6 +248,7 @@ static void usage(const char *program)
> "-r, --repeat-header repeat table header before each
domain\n"
> "-v, --vcpus output vcpu data\n"
> "-b, --batch output in batch mode, no user input
accepted\n"
> + "-p, --pcpus show physical CPU stats\n"
> "-i, --iterations number of iterations before exiting\n"
> "-f, --full-name output the full domain name (not
truncated)\n"
> "-z, --dom0-first display dom0 first (ignore sorting)\n"
Incorrect indentation here
> @@ -1245,9 +1256,18 @@ static void top(void)
> do_vbd(domains[i]);
> }
>
> - if (!batch)
> + if (!batch && !show_pcpus )
> do_bottom_line();
>
> + if (show_pcpus && xhandle != NULL ) {
> + if (update_pcpu_stats(xhandle->xc_handle) == 0) {
> + print_pcpu_stats();
> + }
> + else {
> + print("Error getting PCPU stats\n");
> + }
> + }
> +
and here
