Re: Coding Style Review and Automation

2025-02-12 Thread Oleksandr Andrushchenko
Hi, Grygorii, On 12.02.25 13:14, Grygorii Strashko wrote: Hi On 12.02.25 11:14, Roger Pau Monné wrote: On Tue, Feb 11, 2025 at 02:33:08PM -0800, Stefano Stabellini wrote: Hi Oleksandr, This morning, we had a discussion among maintainers, and the suggested approach moving forward is as follow

Re: Coding Style Review and Automation

2025-02-12 Thread Oleksandr Andrushchenko
Hello, everybody! On 12.02.25 00:33, Stefano Stabellini wrote: Hi Oleksandr, This morning, we had a discussion among maintainers, and the suggested approach moving forward is as follows: Great news!! - First, it would be helpful to see a sample of the proposed changes applied to a single

Re: Coding Style Review and Automation

2025-02-12 Thread Edwin Torok
On 11 Feb 2025, at 18:54, Marek Marczykowski-Górecki wrote: > > On Tue, Feb 11, 2025 at 03:06:08PM +0100, Roger Pau Monné wrote: >> On Tue, Feb 11, 2025 at 11:19:23AM +0100, Jan Beulich wrote: >>> On 11.02.2025 10:10, Luca Fancellu wrote: >> 3) The size of the patch after applying clang-form

Re: Coding Style Review and Automation

2025-02-12 Thread Roger Pau Monné
On Wed, Feb 12, 2025 at 01:14:20PM +0200, Grygorii Strashko wrote: > Hi > > On 12.02.25 11:14, Roger Pau Monné wrote: > > On Tue, Feb 11, 2025 at 02:33:08PM -0800, Stefano Stabellini wrote: > > > Hi Oleksandr, > > > > > > This morning, we had a discussion among maintainers, and the suggested > >

Re: Coding Style Review and Automation

2025-02-12 Thread Grygorii Strashko
Hi On 12.02.25 11:14, Roger Pau Monné wrote: On Tue, Feb 11, 2025 at 02:33:08PM -0800, Stefano Stabellini wrote: Hi Oleksandr, This morning, we had a discussion among maintainers, and the suggested approach moving forward is as follows: - First, it would be helpful to see a sample of the prop

Re: Coding Style Review and Automation

2025-02-12 Thread Roger Pau Monné
On Tue, Feb 11, 2025 at 02:33:08PM -0800, Stefano Stabellini wrote: > Hi Oleksandr, > > This morning, we had a discussion among maintainers, and the suggested > approach moving forward is as follows: > > - First, it would be helpful to see a sample of the proposed changes > applied to a single

Re: Coding Style Review and Automation

2025-02-11 Thread Stefano Stabellini
Hi Oleksandr, This morning, we had a discussion among maintainers, and the suggested approach moving forward is as follows: - First, it would be helpful to see a sample of the proposed changes applied to a single source file as an example. If you could provide such a patch, it would help adva

Re: Coding Style Review and Automation

2025-02-11 Thread Marek Marczykowski-Górecki
On Tue, Feb 11, 2025 at 03:06:08PM +0100, Roger Pau Monné wrote: > On Tue, Feb 11, 2025 at 11:19:23AM +0100, Jan Beulich wrote: > > On 11.02.2025 10:10, Luca Fancellu wrote: > > >>> 3) The size of the patch after applying clang-format is huge. Really. > > >>> Something > > >>> like 9 MB. Even if e

Re: Coding Style Review and Automation

2025-02-11 Thread Roger Pau Monné
On Tue, Feb 11, 2025 at 11:19:23AM +0100, Jan Beulich wrote: > On 11.02.2025 10:10, Luca Fancellu wrote: > >>> 3) The size of the patch after applying clang-format is huge. Really. > >>> Something > >>> like 9 MB. Even if everyone agrees that the approach is good and we can > >>> proceed > >>> wi

Re: Coding Style Review and Automation

2025-02-11 Thread Anthony PERARD
On Tue, Feb 11, 2025 at 10:31:41AM +0100, Roger Pau Monné wrote: > One question that seems to have been dropped from my previous email: > would it be feasible to apply the updated style to newly added chunks > of code only, but not to the (unmodified) surrounding context? There's a tool that can f

Re: Coding Style Review and Automation

2025-02-11 Thread Roger Pau Monné
On Tue, Feb 11, 2025 at 11:14:55AM +0100, Jan Beulich wrote: > On 11.02.2025 10:01, Roger Pau Monné wrote: > > Is it possible for clang-format to be applied exclusively to newly > > added chunks of code, while keeping the surroundings untouched? > > I, too, was wondering about this, at least as a

Re: Coding Style Review and Automation

2025-02-11 Thread Jan Beulich
On 11.02.2025 11:26, Roger Pau Monné wrote: > On Tue, Feb 11, 2025 at 09:49:54AM +, Luca Fancellu wrote: >> Hi Roger, >> >> >> 5) You name it. I think many people in the community can name their >> points for >> and against clang-format. > > What are the parts of our co

Re: Coding Style Review and Automation

2025-02-11 Thread Jan Beulich
On 10.02.2025 22:16, Oleksandr Andrushchenko wrote: > So, in this attempt, I would suggest the following approach: > I think that I could start sending patches after the latest .clang-format 21 > for > some part of Xen, ARM code base for example, using work already done by Luca. Taking the sugges

Re: Coding Style Review and Automation

2025-02-11 Thread Roger Pau Monné
On Tue, Feb 11, 2025 at 09:49:54AM +, Luca Fancellu wrote: > Hi Roger, > > > 5) You name it. I think many people in the community can name their > points for > and against clang-format. > >>> > >>> What are the parts of our coding style that clang-format cannot > >>> cor

Re: Coding Style Review and Automation

2025-02-11 Thread Jan Beulich
On 11.02.2025 10:10, Luca Fancellu wrote: >>> 3) The size of the patch after applying clang-format is huge. Really. >>> Something >>> like 9 MB. Even if everyone agrees that the approach is good and we can >>> proceed >>> with it, it is highly unlikely anyone will be able to review it. Considerin

Re: Coding Style Review and Automation

2025-02-11 Thread Jan Beulich
On 11.02.2025 10:01, Roger Pau Monné wrote: > Is it possible for clang-format to be applied exclusively to newly > added chunks of code, while keeping the surroundings untouched? I, too, was wondering about this, at least as a data point. However, especially for files that aren't in a single style

Re: Coding Style Review and Automation

2025-02-11 Thread Luca Fancellu
Hi Roger, 5) You name it. I think many people in the community can name their points for and against clang-format. >>> >>> What are the parts of our coding style that clang-format cannot >>> correctly represent? Could you make a list of what would need to >>> change in Xen

Re: Coding Style Review and Automation

2025-02-11 Thread Roger Pau Monné
On Tue, Feb 11, 2025 at 09:10:38AM +, Luca Fancellu wrote: > Hi Roger, > > >> > >> 3) The size of the patch after applying clang-format is huge. Really. > >> Something > >> like 9 MB. Even if everyone agrees that the approach is good and we can > >> proceed > >> with it, it is highly unlike

Re: Coding Style Review and Automation

2025-02-11 Thread Luca Fancellu
Hi Roger, >> >> 3) The size of the patch after applying clang-format is huge. Really. >> Something >> like 9 MB. Even if everyone agrees that the approach is good and we can >> proceed >> with it, it is highly unlikely anyone will be able to review it. Considering >> that new patches are being

Re: Coding Style Review and Automation

2025-02-11 Thread Roger Pau Monné
On Mon, Feb 10, 2025 at 11:16:09PM +0200, Oleksandr Andrushchenko wrote: > Hello, everybody! > > What is the rationale behind introducing a tool to help with coding style > verification? I will partially quote Viktor Mitin here [2]: > > "The Xen Project has a coding standard in place, but like ma

Re: Coding Style Review and Automation

2025-02-10 Thread Stefano Stabellini
Thanks Oleksandr for the summary. Adding a few maintainers in CC On Mon, 10 Feb 2025, Oleksandr Andrushchenko wrote: > Hello, everybody! > > What is the rationale behind introducing a tool to help with coding style > verification? I will partially quote Viktor Mitin here [2]: > > "The Xen Projec

Coding Style Review and Automation

2025-02-10 Thread Oleksandr Andrushchenko
Hello, everybody! What is the rationale behind introducing a tool to help with coding style verification? I will partially quote Viktor Mitin here [2]: "The Xen Project has a coding standard in place, but like many projects, the standard is only enforced through peer review. Such mistakes slip t