On 11.02.2025 10:10, Luca Fancellu wrote: >>> 3) The size of the patch after applying clang-format is huge. Really. >>> Something >>> like 9 MB. Even if everyone agrees that the approach is good and we can >>> proceed >>> with it, it is highly unlikely anyone will be able to review it. Considering >>> that new patches are being added to the upstream during such a review, it >>> may >>> also lead to new code style violations or require a new review of that huge >>> patch. >> >> I think this approach is difficult. It would likely introduce a lot >> of noise when using `git blame` (I know, it's just one extra jump, >> but...), plus would likely break every patch that we currently have >> in-flight. > > I think we already discussed this in the past and having some churn was > accepted, > also about breaking existing patches, every change merged has the potential > to do > that, this one is more likely but it’s the game I guess?
That's easy to say if you have just a few patches in flight, yet I'm worried about this when considering the hundreds of mine that are awaiting review. Of course this would be of almost no concern (to me) if for the experimental phase it was only Arm code that was converted. Yet even then the plan is going to be to later do a full conversion (to whatever the worked out final style is), and I don't foresee the review situation to get any better. It'll be only yet more patches then that will need re-basing. Jan
