Re: Clang-format configuration discussion - pt 2

2024-01-08 Thread Luca Fancellu
> I found the way we dealt with MISRA rules quite helpful. We had a weekly meeting to discuss some of the rules and then the outcome was posted on the ML. Maybe we should do the same here? Any other suggestion how to move? >>> >>> I have mixed feelings with meetings like the M

Re: Clang-format configuration discussion - pt 2

2024-01-02 Thread Stefano Stabellini
On Thu, 7 Dec 2023, Julien Grall wrote: > > > > Most modern languages, including golang (and I think rust) have > > > > built-in style correctors (`go fmt` is go's official one). If you > > > > haven't worked with an automatic style checker / fixer, you don't know > > > > how much time, hassle, an

Re: Clang-format configuration discussion - pt 2

2023-12-07 Thread Jan Beulich
On 07.12.2023 09:43, Julien Grall wrote: > On 07/12/2023 07:28, Jan Beulich wrote: >> On 06.12.2023 18:55, Julien Grall wrote: >>> On 06/12/2023 02:32, George Dunlap wrote: On Tue, Dec 5, 2023 at 2:07 PM Jan Beulich wrote: > On 05.12.2023 14:46, Luca Fancellu wrote: >> In my opinion,

Re: Clang-format configuration discussion - pt 2

2023-12-07 Thread Julien Grall
Hi, On 07/12/2023 07:28, Jan Beulich wrote: On 06.12.2023 18:55, Julien Grall wrote: On 06/12/2023 02:32, George Dunlap wrote: On Tue, Dec 5, 2023 at 2:07 PM Jan Beulich wrote: On 05.12.2023 14:46, Luca Fancellu wrote: In my opinion, I don’t know of any tool that can address all the flexibi

Re: Clang-format configuration discussion - pt 2

2023-12-06 Thread Jan Beulich
On 06.12.2023 18:55, Julien Grall wrote: > On 06/12/2023 02:32, George Dunlap wrote: >> On Tue, Dec 5, 2023 at 2:07 PM Jan Beulich wrote: >>> On 05.12.2023 14:46, Luca Fancellu wrote: In my opinion, I don’t know of any tool that can address all the flexibility the Xen codestyle allows,

Re: Clang-format configuration discussion - pt 2

2023-12-06 Thread Julien Grall
On 06/12/2023 02:32, George Dunlap wrote: On Tue, Dec 5, 2023 at 2:07 PM Jan Beulich wrote: On 05.12.2023 14:46, Luca Fancellu wrote: In my opinion, I don’t know of any tool that can address all the flexibility the Xen codestyle allows, yet the use of automatic checkers would improve the

Re: Clang-format configuration discussion - pt 2

2023-12-05 Thread George Dunlap
On Tue, Dec 5, 2023 at 2:07 PM Jan Beulich wrote: > > On 05.12.2023 14:46, Luca Fancellu wrote: > > In my opinion, I don’t know of any tool that can address all the > > flexibility the Xen codestyle allows, yet the use of automatic > > checkers would improve the review time, allow more new contri

Re: Clang-format configuration discussion - pt 2

2023-12-05 Thread Jan Beulich
On 05.12.2023 14:46, Luca Fancellu wrote: > In my opinion, I don’t know of any tool that can address all the flexibility > the Xen codestyle allows, yet the use of automatic > checkers would improve the review time, allow more new contributors to > approach the community without being put down by

Re: Clang-format configuration discussion - pt 2

2023-12-05 Thread Luca Fancellu
> On 23 Nov 2023, at 14:47, Luca Fancellu wrote: > > Hi all, > > Let’s continue the discussion about clang-format configuration, this is part > 2, previous discussions are: > > - https://lists.xenproject.org/archives/html/xen-devel/2023-11/msg00498.html > > You can find the serie introducin

Re: Clang-format configuration discussion - pt 2

2023-11-28 Thread Luca Fancellu
> On 28 Nov 2023, at 11:27, Jan Beulich wrote: > > On 28.11.2023 11:55, Luca Fancellu wrote: >> >> >>> On 27 Nov 2023, at 15:37, Luca Fancellu wrote: >>> >>> >>> On 27 Nov 2023, at 15:13, Jan Beulich wrote: On 27.11.2023 15:58, Luca Fancellu wrote: >> On 27 Nov 2023,

Re: Clang-format configuration discussion - pt 2

2023-11-28 Thread Jan Beulich
On 28.11.2023 11:55, Luca Fancellu wrote: > > >> On 27 Nov 2023, at 15:37, Luca Fancellu wrote: >> >> >> >>> On 27 Nov 2023, at 15:13, Jan Beulich wrote: >>> >>> On 27.11.2023 15:58, Luca Fancellu wrote: > On 27 Nov 2023, at 12:20, Jan Beulich wrote: > On 24.11.2023 15:52, Luca Fancell

Re: Clang-format configuration discussion - pt 2

2023-11-28 Thread Luca Fancellu
> On 27 Nov 2023, at 15:37, Luca Fancellu wrote: > > > >> On 27 Nov 2023, at 15:13, Jan Beulich wrote: >> >> On 27.11.2023 15:58, Luca Fancellu wrote: On 27 Nov 2023, at 12:20, Jan Beulich wrote: On 24.11.2023 15:52, Luca Fancellu wrote: >> On 24 Nov 2023, at 12:47, Jan Beuli

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Luca Fancellu
> On 27 Nov 2023, at 15:55, Jan Beulich wrote: > > On 27.11.2023 16:37, Luca Fancellu wrote: >> >> >>> On 27 Nov 2023, at 15:13, Jan Beulich wrote: >>> >>> On 27.11.2023 15:58, Luca Fancellu wrote: > On 27 Nov 2023, at 12:20, Jan Beulich wrote: > On 24.11.2023 15:52, Luca Fancellu

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Jan Beulich
On 27.11.2023 16:37, Luca Fancellu wrote: > > >> On 27 Nov 2023, at 15:13, Jan Beulich wrote: >> >> On 27.11.2023 15:58, Luca Fancellu wrote: On 27 Nov 2023, at 12:20, Jan Beulich wrote: On 24.11.2023 15:52, Luca Fancellu wrote: >> On 24 Nov 2023, at 12:47, Jan Beulich wrote: >>>

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Luca Fancellu
> On 27 Nov 2023, at 15:13, Jan Beulich wrote: > > On 27.11.2023 15:58, Luca Fancellu wrote: >>> On 27 Nov 2023, at 12:20, Jan Beulich wrote: >>> On 24.11.2023 15:52, Luca Fancellu wrote: > On 24 Nov 2023, at 12:47, Jan Beulich wrote: > On 23.11.2023 15:47, Luca Fancellu wrote: >>

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Jan Beulich
On 27.11.2023 15:58, Luca Fancellu wrote: >> On 27 Nov 2023, at 12:20, Jan Beulich wrote: >> On 24.11.2023 15:52, Luca Fancellu wrote: On 24 Nov 2023, at 12:47, Jan Beulich wrote: On 23.11.2023 15:47, Luca Fancellu wrote: > Let’s continue the discussion about clang-format configurat

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Luca Fancellu
> On 27 Nov 2023, at 12:20, Jan Beulich wrote: > > On 24.11.2023 15:52, Luca Fancellu wrote: >>> On 24 Nov 2023, at 12:47, Jan Beulich wrote: >>> On 23.11.2023 15:47, Luca Fancellu wrote: Let’s continue the discussion about clang-format configuration, this is part 2, previous discus

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Jan Beulich
On 24.11.2023 15:52, Luca Fancellu wrote: >> On 24 Nov 2023, at 12:47, Jan Beulich wrote: >> On 23.11.2023 15:47, Luca Fancellu wrote: >>> Let’s continue the discussion about clang-format configuration, this is >>> part 2, previous discussions are: >>> >>> - https://lists.xenproject.org/archives/

Re: Clang-format configuration discussion - pt 2

2023-11-24 Thread Luca Fancellu
> On 24 Nov 2023, at 12:47, Jan Beulich wrote: > > On 23.11.2023 15:47, Luca Fancellu wrote: >> Hi all, >> >> Let’s continue the discussion about clang-format configuration, this is part >> 2, previous discussions are: >> >> - https://lists.xenproject.org/archives/html/xen-devel/2023-11/msg0

Re: Clang-format configuration discussion - pt 2

2023-11-24 Thread Jan Beulich
On 23.11.2023 15:47, Luca Fancellu wrote: > Hi all, > > Let’s continue the discussion about clang-format configuration, this is part > 2, previous discussions are: > > - https://lists.xenproject.org/archives/html/xen-devel/2023-11/msg00498.html > > You can find the serie introducing clang-form

Re: Clang-format configuration discussion - pt 2

2023-11-24 Thread Luca Fancellu
> On 24 Nov 2023, at 12:24, Jan Beulich wrote: > > On 24.11.2023 12:59, Luca Fancellu wrote: >> @@ -,19 +3318,18 @@ static int __init alloc_domain_evtchn(struct >> dt_device_node *node) >> rc = evtchn_alloc_unbound(&alloc_unbound, domU1_port); >> if ( rc < 0 ) >> { >> - printk(XENLOG_ERR >

Re: Clang-format configuration discussion - pt 2

2023-11-24 Thread Jan Beulich
On 24.11.2023 12:59, Luca Fancellu wrote: > @@ -,19 +3318,18 @@ static int __init alloc_domain_evtchn(struct > dt_device_node *node) > rc = evtchn_alloc_unbound(&alloc_unbound, domU1_port); > if ( rc < 0 ) > { > - printk(XENLOG_ERR > - "evtchn_alloc_unbound() failure (Error %d) \n", rc); > + p

Re: Clang-format configuration discussion - pt 2

2023-11-24 Thread Luca Fancellu
> On 24 Nov 2023, at 11:12, George Dunlap wrote: > > On Thu, Nov 23, 2023 at 2:48 PM Luca Fancellu wrote: >> AlignConsecutiveAssignments: None >> >> --- >> This one is disabled because of feedbacks from Stefano and Alejandro about >> some weird behaviour on our >> codebase. >> >> This one c

Re: Clang-format configuration discussion - pt 2

2023-11-24 Thread George Dunlap
On Thu, Nov 23, 2023 at 2:48 PM Luca Fancellu wrote: > AlignConsecutiveAssignments: None > > --- > This one is disabled because of feedbacks from Stefano and Alejandro about > some weird behaviour on our > codebase. > > This one could be phased along this line: “Consecutive assignments don't need

Clang-format configuration discussion - pt 2

2023-11-23 Thread Luca Fancellu
Hi all, Let’s continue the discussion about clang-format configuration, this is part 2, previous discussions are: - https://lists.xenproject.org/archives/html/xen-devel/2023-11/msg00498.html You can find the serie introducing clang-format here: https://patchwork.kernel.org/project/xen-devel/co