Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-29 Thread Federico Serafini
On 29/11/23 12:09, Jan Beulich wrote: On 29.11.2023 10:35, Federico Serafini wrote: I take this opportunity to inform that we are really close to the end with Rule 8.3 for x86, this is the situation: - do_multicall(), Stefano sent a patch; - guest_walk_tables(), Andrew will take care of it; - xe

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-29 Thread Jan Beulich
On 29.11.2023 10:35, Federico Serafini wrote: > I take this opportunity to inform that we are really close to the end > with Rule 8.3 for x86, this is the situation: > - do_multicall(), Stefano sent a patch; > - guest_walk_tables(), Andrew will take care of it; > - xenmem_add_to_physmap_one(), this

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-29 Thread Federico Serafini
On 28/11/23 14:43, Jan Beulich wrote: On 28.11.2023 14:17, Andrew Cooper wrote: On 28/11/2023 1:00 pm, Jan Beulich wrote: On 28.11.2023 10:46, Federico Serafini wrote: Uniform declaration and definition of guest_walk_tables() using parameter name "pfec_walk": this name highlights the connectio

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Jan Beulich
On 28.11.2023 14:11, Federico Serafini wrote: > On 28/11/23 14:00, Jan Beulich wrote: >> On 28.11.2023 10:46, Federico Serafini wrote: >>> Uniform declaration and definition of guest_walk_tables() using >>> parameter name "pfec_walk": >>> this name highlights the connection with PFEC_* constants an

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Jan Beulich
On 28.11.2023 14:17, Andrew Cooper wrote: > On 28/11/2023 1:00 pm, Jan Beulich wrote: >> On 28.11.2023 10:46, Federico Serafini wrote: >>> Uniform declaration and definition of guest_walk_tables() using >>> parameter name "pfec_walk": >>> this name highlights the connection with PFEC_* constants an

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Andrew Cooper
On 28/11/2023 1:00 pm, Jan Beulich wrote: > On 28.11.2023 10:46, Federico Serafini wrote: >> Uniform declaration and definition of guest_walk_tables() using >> parameter name "pfec_walk": >> this name highlights the connection with PFEC_* constants and it is >> consistent with the use of the parame

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Federico Serafini
On 28/11/23 14:00, Jan Beulich wrote: On 28.11.2023 10:46, Federico Serafini wrote: Uniform declaration and definition of guest_walk_tables() using parameter name "pfec_walk": this name highlights the connection with PFEC_* constants and it is consistent with the use of the parameter within func

Re: [XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Jan Beulich
On 28.11.2023 10:46, Federico Serafini wrote: > Uniform declaration and definition of guest_walk_tables() using > parameter name "pfec_walk": > this name highlights the connection with PFEC_* constants and it is > consistent with the use of the parameter within function body. > No functional change

[XEN PATCH] x86/guest_walk: address violations of MISRA C:2012 Rule 8.3

2023-11-28 Thread Federico Serafini
Uniform declaration and definition of guest_walk_tables() using parameter name "pfec_walk": this name highlights the connection with PFEC_* constants and it is consistent with the use of the parameter within function body. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/i