Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

2023-08-15 Thread Henry Wang
Hi Daniel, > On Aug 9, 2023, at 05:05, Daniel P. Smith > wrote: > > On 8/4/23 00:10, Henry Wang wrote: >> Hi Daniel, > > Hey Henry! > >>> -Original Message----- >>> Subject: [PATCH v2 2/2] fdt: make fdt handling reusable across arch >

Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

2023-08-08 Thread Daniel P. Smith
On 8/4/23 00:10, Henry Wang wrote: Hi Daniel, Hey Henry! -Original Message- Subject: [PATCH v2 2/2] fdt: make fdt handling reusable across arch This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig para

Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

2023-08-08 Thread Daniel P. Smith
On 8/3/23 16:37, Luca Fancellu wrote: Regarding the coding style, I think it’s better to keep the style you’ve found in the original file, and change only some bits when the code is not following it. I know there is nothing enforcing parameters on the same line of the function definition

RE: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

2023-08-03 Thread Henry Wang
Hi Daniel, > -Original Message- > Subject: [PATCH v2 2/2] fdt: make fdt handling reusable across arch > > This refactors reusable code from Arm's bootfdt.c and device-tree.h that is > general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is > introduc

Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

2023-08-03 Thread Luca Fancellu
> >> Regarding the coding style, I think it’s better to keep the style you’ve >> found in the original file, >> and change only some bits when the code is not following it. >> I know there is nothing enforcing parameters on the same line of the >> function definition at the >> moment, but it is

Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

2023-08-03 Thread Daniel P. Smith
On 8/3/23 14:05, Luca Fancellu wrote: Hi Daniel, [...] diff --git a/xen/common/fdt.c b/xen/common/fdt.c new file mode 100644 index 00..8d7acaaa43 --- /dev/null +++ b/xen/common/fdt.c @@ -0,0 +1,153 @@ +/* + * Flattened Device Tree + * + * Copyright (C) 2012-2014 Citrix Systems, Inc. + *

Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

2023-08-03 Thread Luca Fancellu
Hi Daniel, [...] > diff --git a/xen/common/fdt.c b/xen/common/fdt.c > new file mode 100644 > index 00..8d7acaaa43 > --- /dev/null > +++ b/xen/common/fdt.c > @@ -0,0 +1,153 @@ > +/* > + * Flattened Device Tree > + * > + * Copyright (C) 2012-2014 Citrix Systems, Inc. > + * > + * This program

Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

2023-08-03 Thread Daniel P. Smith
On 8/3/23 08:48, Michal Orzel wrote: Hi Daniel, On 03/08/2023 12:44, Daniel P. Smith wrote: This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is IIUC, you just try to untangle the code for fdt from d

Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

2023-08-03 Thread Michal Orzel
Hi Daniel, On 03/08/2023 12:44, Daniel P. Smith wrote: > > > This refactors reusable code from Arm's bootfdt.c and device-tree.h that is > general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is IIUC, you just try to untangle the code for fdt from dt (unflattened). CORE_DEVICE_TRE

[PATCH v2 2/2] fdt: make fdt handling reusable across arch

2023-08-03 Thread Daniel P. Smith
This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is introduced for when the ability of parsing DTB files is needed by a capability such as hyperlaunch. Signed-off-by: Daniel P. Smith --- MAINTAINERS