Hi Daniel, > On Aug 9, 2023, at 05:05, Daniel P. Smith <dpsm...@apertussolutions.com> > wrote: > > On 8/4/23 00:10, Henry Wang wrote: >> Hi Daniel, > > Hey Henry! > >>> -----Original Message----- >>> Subject: [PATCH v2 2/2] fdt: make fdt handling reusable across arch >>> >>> This refactors reusable code from Arm's bootfdt.c and device-tree.h that is >>> general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is >>> introduced for when the ability of parsing DTB files is needed by a >>> capability >>> such as hyperlaunch. >>> >>> Signed-off-by: Daniel P. Smith <dpsm...@apertussolutions.com> >> As said yesterday, I tested this patch and can confirm this patch will not >> break any of the boards we used for our testing. So >> Tested-by: Henry Wang <henry.w...@arm.com> > > Thank your for running it through your tests.
My pleasure. > >> (But I saw there are some comments from Michal and Luca about this >> patch so I think these comments need to be addressed) > > So far the changes are style and a few mechanical. While unlikely to cause a > functional change that could break, probably best to hold off adding your Tb > for now. Sorry for the late response, this email somehow fall through the cracks… I am ok to retain my T-by tag as the comments are only about styles and mechanical changes. Kind regards, Henry > > v/r > dps >