>
>> Regarding the coding style, I think it’s better to keep the style you’ve
>> found in the original file,
>> and change only some bits when the code is not following it.
>> I know there is nothing enforcing parameters on the same line of the
>> function definition at the
>> moment, but it is how it’s done from the original file so I would stick with
>> it.
>> Regarding the u32/u64 types, maybe since you are moving the code it can be
>> the occasion to
>> convert them, but check with the maintainer before.
>
> I can leave the main code as is, but I do think header decl's should be
> styled correctly as there is no need to have them churn in the future over
> purely style changes.
Uhm, when you say “styled correctly” do you mean as below?
>>> +bool __init device_tree_node_matches(
>>> + const void *fdt, int node, const char *match)
>>> +{
If that’s the case, it seems to me that there is nothing like that in the
codebase,
in my work with clang-format I’ve configured it to match as much as I can the
Xen style and this function would be formatted as the old style that it had.
Can I ask you where did you find instruction to style in that way?
