Re: [PATCH v1] xen/console: remove __printk_ratelimit()

2025-08-06 Thread Roger Pau Monné
On Fri, Jul 25, 2025 at 09:24:48PM +, dm...@proton.me wrote: > From: Denis Mukhin > > __printk_ratelimit() is never used outside of the console driver. > Remove it from the lib.h and merge with the public printk_ratelimit(). > > Not a functional change. > > Signed-off-by: Denis Mukhin > -

Re: [PATCH v1] xen/console: remove __printk_ratelimit()

2025-08-01 Thread Jan Beulich
On 31.07.2025 23:28, dm...@proton.me wrote: > On Thu, Jul 31, 2025 at 08:23:16AM +0200, Jan Beulich wrote: >> On 30.07.2025 20:06, dm...@proton.me wrote: >>> On Wed, Jul 30, 2025 at 07:35:04AM +0200, Jan Beulich wrote: On 30.07.2025 00:18, dm...@proton.me wrote: > On Mon, Jul 28, 2025 at 1

Re: [PATCH v1] xen/console: remove __printk_ratelimit()

2025-07-31 Thread dmkhn
Hi Jan, Thanks for the feedback. On Thu, Jul 31, 2025 at 08:23:16AM +0200, Jan Beulich wrote: > On 30.07.2025 20:06, dm...@proton.me wrote: > > On Wed, Jul 30, 2025 at 07:35:04AM +0200, Jan Beulich wrote: > >> On 30.07.2025 00:18, dm...@proton.me wrote: > >>> On Mon, Jul 28, 2025 at 11:32:43AM +0

Re: [PATCH v1] xen/console: remove __printk_ratelimit()

2025-07-30 Thread Jan Beulich
On 30.07.2025 20:06, dm...@proton.me wrote: > On Wed, Jul 30, 2025 at 07:35:04AM +0200, Jan Beulich wrote: >> On 30.07.2025 00:18, dm...@proton.me wrote: >>> On Mon, Jul 28, 2025 at 11:32:43AM +0200, Jan Beulich wrote: On 26.07.2025 11:20, Julien Grall wrote: > On 25/07/2025 22:24, dm...@p

Re: [PATCH v1] xen/console: remove __printk_ratelimit()

2025-07-30 Thread dmkhn
On Wed, Jul 30, 2025 at 07:35:04AM +0200, Jan Beulich wrote: > On 30.07.2025 00:18, dm...@proton.me wrote: > > On Mon, Jul 28, 2025 at 11:32:43AM +0200, Jan Beulich wrote: > >> On 26.07.2025 11:20, Julien Grall wrote: > >>> On 25/07/2025 22:24, dm...@proton.me wrote: > From: Denis Mukhin > >>

Re: [PATCH v1] xen/console: remove __printk_ratelimit()

2025-07-29 Thread Jan Beulich
On 30.07.2025 00:18, dm...@proton.me wrote: > On Mon, Jul 28, 2025 at 11:32:43AM +0200, Jan Beulich wrote: >> On 26.07.2025 11:20, Julien Grall wrote: >>> On 25/07/2025 22:24, dm...@proton.me wrote: From: Denis Mukhin __printk_ratelimit() is never used outside of the console driver.

Re: [PATCH v1] xen/console: remove __printk_ratelimit()

2025-07-29 Thread dmkhn
On Mon, Jul 28, 2025 at 11:32:43AM +0200, Jan Beulich wrote: > On 26.07.2025 11:20, Julien Grall wrote: > > On 25/07/2025 22:24, dm...@proton.me wrote: > >> From: Denis Mukhin > >> > >> __printk_ratelimit() is never used outside of the console driver. > >> Remove it from the lib.h and merge with t

Re: [PATCH v1] xen/console: remove __printk_ratelimit()

2025-07-28 Thread Jan Beulich
On 26.07.2025 11:20, Julien Grall wrote: > On 25/07/2025 22:24, dm...@proton.me wrote: >> From: Denis Mukhin >> >> __printk_ratelimit() is never used outside of the console driver. >> Remove it from the lib.h and merge with the public printk_ratelimit(). > > Is this solving any sort of violation?

Re: [PATCH v1] xen/console: remove __printk_ratelimit()

2025-07-26 Thread dmkhn
On Sat, Jul 26, 2025 at 10:20:58AM +0100, Julien Grall wrote: Hi Julien, Thanks for your feedback! I imagined that kind of a change may raise a question about importance of doing it. > Hi Denis, > > On 25/07/2025 22:24, dm...@proton.me wrote: > > From: Denis Mukhin > > > > __printk_ratelimit(

Re: [PATCH v1] xen/console: remove __printk_ratelimit()

2025-07-26 Thread Julien Grall
Hi Denis, On 25/07/2025 22:24, dm...@proton.me wrote: From: Denis Mukhin __printk_ratelimit() is never used outside of the console driver. Remove it from the lib.h and merge with the public printk_ratelimit(). Is this solving any sort of violation? Asking because even if the function is onl

[PATCH v1] xen/console: remove __printk_ratelimit()

2025-07-25 Thread dmkhn
From: Denis Mukhin __printk_ratelimit() is never used outside of the console driver. Remove it from the lib.h and merge with the public printk_ratelimit(). Not a functional change. Signed-off-by: Denis Mukhin --- xen/drivers/char/console.c | 29 - xen/include/xen/