Re: [PATCH v2 1/1] vpci: Add resizable bar support

2024-12-10 Thread Chen, Jiqian
On 2024/12/10 19:25, Roger Pau Monné wrote: > On Tue, Dec 10, 2024 at 10:54:43AM +0100, Jan Beulich wrote: >> On 10.12.2024 08:57, Chen, Jiqian wrote: >>> On 2024/12/10 15:17, Jan Beulich wrote: On 10.12.2024 08:07, Chen, Jiqian wrote: > On 2024/12/9 21:59, Jan Beulich wrote: >> On 02.

Re: [PATCH v3 1/3] common: remove -fno-stack-protector from EMBEDDED_EXTRA_CFLAGS

2024-12-10 Thread Jan Beulich
On 11.12.2024 03:04, Volodymyr Babchuk wrote: > This patch is preparation for making stack protector > configurable. First step is to remove -fno-stack-protector flag from > EMBEDDED_EXTRA_CFLAGS so separate components (Hypervisor in this case) > can enable/disable this feature by themselves. > >

Re: [PATCH v3 0/3] Add stack protector

2024-12-10 Thread Jan Beulich
On 11.12.2024 03:04, Volodymyr Babchuk wrote: > Both GCC and Clang support -fstack-protector feature, which add stack > canaries to functions where stack corruption is possible. This series > makes possible to use this feature in Xen. I tested this on ARM64 and > it is working as intended. Tested b

Re: [PATCH v3 14/19] wifi: ath11k: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Kalle Valo
Kalle Valo writes: > Easwar Hariharan writes: > >> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced >> secs_to_jiffies(). As the value here is a multiple of 1000, use >> secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. >> >> This is converted using s

Re: [PATCH v2 5/7] xen: add new domctl get_changed_domain

2024-12-10 Thread Jürgen Groß
On 10.12.24 17:29, Jan Beulich wrote: On 10.12.2024 16:52, Jürgen Groß wrote: On 09.12.24 18:04, Jan Beulich wrote: On 06.12.2024 14:02, Juergen Gross wrote: --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -192,6 +192,54 @@ static void domain_changed_state(const struct domain *d)

Re: [PATCH] MAINTAINERS: add Anthony, Michal, Roger to THE REST

2024-12-10 Thread Jan Beulich
On 11.12.2024 00:58, Stefano Stabellini wrote: > In recognition of their outstanding work and years of service to the Xen > Community, please join me in welcoming Anthony, Michal, and Roger as > Committers and REST Maintainers. > > Signed-off-by: Stefano Stabellini Acked-by: Jan Beulich albeit

Re: [PATCH v3 14/19] wifi: ath11k: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Kalle Valo
Easwar Hariharan writes: > Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced > secs_to_jiffies(). As the value here is a multiple of 1000, use > secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. > > This is converted using scripts/coccinelle/misc/secs_t

Re: [PATCH v2 34/35] xen/console: enable console owners w/ emulated NS8250

2024-12-10 Thread Jan Beulich
On 10.12.2024 23:46, Jason Andryuk wrote: > On 2024-12-05 23:42, Denis Mukhin via B4 Relay wrote: >> From: Denis Mukhin >> >> Enable console focus for domains w/ virtual NS8250. >> >> Code change allows to capture the output from the guest OS now and send it to >> the physical console device. >> >

Re: [PATCH v2 34/35] xen/console: enable console owners w/ emulated NS8250

2024-12-10 Thread Jan Beulich
On 10.12.2024 23:46, Jason Andryuk wrote: > On 2024-12-05 23:42, Denis Mukhin via B4 Relay wrote: >> From: Denis Mukhin >> >> Enable console focus for domains w/ virtual NS8250. >> >> Code change allows to capture the output from the guest OS now and send it to >> the physical console device. >> >

Re: [PATCH v2 20/35] xen/console: introduce console_owner_domid()

2024-12-10 Thread Jan Beulich
On 10.12.2024 23:11, Jason Andryuk wrote: > On 2024-12-05 23:41, Denis Mukhin via B4 Relay wrote: >> From: Denis Mukhin >> >> console_owner_domid() is introduced to obtain the "console owner" domain ID. >> >> The call is used in NS8250 emulator to identify the case when physical xen >> console foc

Re: [PATCH v2 21/35] xen/console: introduce console_init_owner()

2024-12-10 Thread Jan Beulich
On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -554,6 +554,22 @@ static void console_find_owner(void) > console_set_owner(DOMID_XEN); > } > > +static void console_init_owner(void) > +{ > +domid_t domid

Re: [PATCH v2 20/35] xen/console: introduce console_owner_domid()

2024-12-10 Thread Jan Beulich
On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: > From: Denis Mukhin > > console_owner_domid() is introduced to obtain the "console owner" domain ID. > > The call is used in NS8250 emulator to identify the case when physical xen > console focus is owned by the domain w/ NS8250 emulator, in

Re: [PATCH v3 18/19] livepatch: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Christophe Leroy
Le 10/12/2024 à 23:02, Easwar Hariharan a écrit : Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coc

Re: [PATCH v3 05/19] powerpc/papr_scm: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Christophe Leroy
Le 10/12/2024 à 23:02, Easwar Hariharan a écrit : Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coc

Re: [PATCH] MAINTAINERS: add Anthony, Michal, Roger to THE REST

2024-12-10 Thread Bertrand Marquis
> On 11 Dec 2024, at 00:58, Stefano Stabellini wrote: > > In recognition of their outstanding work and years of service to the Xen > Community, please join me in welcoming Anthony, Michal, and Roger as > Committers and REST Maintainers. > > Signed-off-by: Stefano Stabellini Acked-by: Bertra

Re: [PATCH v3 00/19] Converge on using secs_to_jiffies()

2024-12-10 Thread Jeff Johnson
On 12/10/2024 2:02 PM, Easwar Hariharan wrote: > This is a series that follows up on my previous series to introduce > secs_to_jiffies() and convert a few initial users.[1] In the review for > that series, Anna-Maria requested converting other users with > Coccinelle. [2] This is part 1 that conver

Re: [PATCH v2 1/1] vpci: Add resizable bar support

2024-12-10 Thread Chen, Jiqian
On 2024/12/10 19:30, Roger Pau Monné wrote: > On Mon, Dec 02, 2024 at 02:09:56PM +0800, Jiqian Chen wrote: >> Some devices, like discrete GPU of amd, support resizable bar >> capability, but vpci of Xen doesn't support this feature, so >> they fail to resize bars and then cause probing failure. >>

Re: [PATCH v2 1/1] vpci: Add resizable bar support

2024-12-10 Thread Chen, Jiqian
On 2024/12/10 19:25, Roger Pau Monné wrote: > On Tue, Dec 10, 2024 at 10:54:43AM +0100, Jan Beulich wrote: >> On 10.12.2024 08:57, Chen, Jiqian wrote: >>> On 2024/12/10 15:17, Jan Beulich wrote: On 10.12.2024 08:07, Chen, Jiqian wrote: > On 2024/12/9 21:59, Jan Beulich wrote: >> On 02.

Re: [PATCH v2 1/1] vpci: Add resizable bar support

2024-12-10 Thread Chen, Jiqian
On 2024/12/10 19:00, Roger Pau Monné wrote: > On Mon, Dec 09, 2024 at 02:59:31PM +0100, Jan Beulich wrote: >> On 02.12.2024 07:09, Jiqian Chen wrote: >>> +static int cf_check init_rebar(struct pci_dev *pdev) >>> +{ >>> +uint32_t ctrl; >>> +unsigned int rebar_offset, nbars; >>> + >>> +re

Re: [PATCH v2 1/1] vpci: Add resizable bar support

2024-12-10 Thread Chen, Jiqian
On 2024/12/10 17:54, Jan Beulich wrote: > On 10.12.2024 08:57, Chen, Jiqian wrote: >> On 2024/12/10 15:17, Jan Beulich wrote: >>> On 10.12.2024 08:07, Chen, Jiqian wrote: On 2024/12/9 21:59, Jan Beulich wrote: > On 02.12.2024 07:09, Jiqian Chen wrote: >> @@ -541,6 +542,16 @@ >> #

Re: [PATCH v3 00/19] Converge on using secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
> More confusingly still, they did send one standalone patch for > an Ethernet driver: > https://lore.kernel.org/all/20241210-converge-secs-to-jiffies-v3-20-59479891e...@linux.microsoft.com/ > And yet another Ethernet driver (drivers/net/ethernet/google/gve/) > is converted in this

Re: [PATCH 05/15] kconfig: introduce domain builder config option

2024-12-10 Thread Daniel P. Smith
On 11/26/24 05:09, Jan Beulich wrote: On 23.11.2024 19:20, Daniel P. Smith wrote: Hyperlaunch domain builder will be the consolidated boot time domain building logic framework. Introduces the config option to enable this domain builder to and turn on the ability to load the domain configuration

Re: [PATCH 05/15] kconfig: introduce domain builder config option

2024-12-10 Thread Daniel P. Smith
On 11/25/24 12:55, Jason Andryuk wrote: On 2024-11-23 13:20, Daniel P. Smith wrote: Hyperlaunch domain builder will be the consolidated boot time domain building logic framework. Introduces the config option to enable this domain builder to and turn on the ability to load the domain configurati

Re: [PATCH 04/15] kconfig: introduce option to independently enable libfdt

2024-12-10 Thread Daniel P. Smith
On 11/26/24 05:05, Jan Beulich wrote: On 26.11.2024 11:03, Jan Beulich wrote: On 23.11.2024 19:20, Daniel P. Smith wrote: --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -53,8 +53,12 @@ config HAS_ALTERNATIVE config HAS_COMPAT bool +config LIB_DEVICE_TREE +bool Nit: Ind

Re: [PATCH 04/15] kconfig: introduce option to independently enable libfdt

2024-12-10 Thread Daniel P. Smith
On 11/26/24 05:03, Jan Beulich wrote: On 23.11.2024 19:20, Daniel P. Smith wrote: --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -53,8 +53,12 @@ config HAS_ALTERNATIVE config HAS_COMPAT bool +config LIB_DEVICE_TREE +bool Nit: Indentation is wrong here and ... config

Re: [PATCH 04/15] kconfig: introduce option to independently enable libfdt

2024-12-10 Thread Daniel P. Smith
On 11/25/24 10:42, Jason Andryuk wrote: On 2024-11-23 13:20, Daniel P. Smith wrote: Currently the inclusion of libfdt is controlled by the CONFIG_HAS_DEVICE_TREE kconfig flag. This flag also changes behvaior in a few places, such as boot behavior ack. module processing for XSM. To support

Re: [PATCH 03/15] x86/boot: add cmdline to struct boot_domain

2024-12-10 Thread Daniel P. Smith
On 12/2/24 04:49, Jan Beulich wrote: On 23.11.2024 19:20, Daniel P. Smith wrote: --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -644,9 +644,11 @@ static bool __init check_and_adjust_load_address( } static int __init pvh_load_kernel( -struct domain *d, stru

Re: [PATCH v3 00/19] Converge on using secs_to_jiffies()

2024-12-10 Thread Jakub Kicinski
On Tue, 10 Dec 2024 18:50:40 -0800 Andrew Morton wrote: > > > Very unlikely, and any such conflict will be trivial. > > > > Agreed, mainly I don't understand why we'd make an exception > > and take the patchset via a special tree. > > It saves work for everyone? > > The patches are super-sim

Re: [PATCH 03/15] x86/boot: add cmdline to struct boot_domain

2024-12-10 Thread Daniel P. Smith
On 11/25/24 10:36, Jason Andryuk wrote: On 2024-11-23 13:20, Daniel P. Smith wrote: Add a container for the "cooked" command line for a domain. This provides for the backing memory to be directly associated with the domain being constructed. This is done in anticipation that the domain construc

Re: [PATCH v3 00/19] Converge on using secs_to_jiffies()

2024-12-10 Thread Andrew Morton
On Tue, 10 Dec 2024 18:41:29 -0800 Jakub Kicinski wrote: > On Tue, 10 Dec 2024 18:31:30 -0800 Andrew Morton wrote: > > > > I'll just grab everything and see if anyone complains ;) > > > > > > I may, if this leads to a conflict :( > > > > Very unlikely, and any such conflict will be trivial.

Re: [PATCH v3 00/19] Converge on using secs_to_jiffies()

2024-12-10 Thread Jakub Kicinski
rstand why we'd make an exception and take the patchset via a special tree. > > Easwar, please break this up per subsystem. > > The series is already one-patch-per-changed-file. More confusingly still, they did send one standalone patch for an Ethernet driver: https://lore.

Re: [PATCH v3 00/19] Converge on using secs_to_jiffies()

2024-12-10 Thread Andrew Morton
On Tue, 10 Dec 2024 17:35:48 -0800 Jakub Kicinski wrote: > On Tue, 10 Dec 2024 15:36:04 -0800 Andrew Morton wrote: > > > I have the same question as before: How do you expect these to land? > > > Do you now have a maintainer who will take all of them? > > > Or do you want individual maintainers t

[PATCH v3 2/3] xen: common: add ability to enable stack protector

2024-12-10 Thread Volodymyr Babchuk
Both GCC and Clang support -fstack-protector feature, which add stack canaries to functions where stack corruption is possible. This patch makes general preparations to enable this feature on different supported architectures: - Added CONFIG_HAS_STACK_PROTECTOR option so each architecture can

[PATCH v3 0/3] Add stack protector

2024-12-10 Thread Volodymyr Babchuk
Both GCC and Clang support -fstack-protector feature, which add stack canaries to functions where stack corruption is possible. This series makes possible to use this feature in Xen. I tested this on ARM64 and it is working as intended. Tested both with GCC and Clang. It is hard to enable this fea

[PATCH v3 3/3] xen: arm: enable stack protector feature

2024-12-10 Thread Volodymyr Babchuk
Enable previously added CONFIG_STACK_PROTECTOR feature for ARM platform. We initialize stack protector in two stages: from head.S using boot_stack_chk_guard_setup_early() function and from start_xen() using boot_stack_chk_guard_setup(). This ensures that all C code from the very beginning can use

[PATCH v3 1/3] common: remove -fno-stack-protector from EMBEDDED_EXTRA_CFLAGS

2024-12-10 Thread Volodymyr Babchuk
This patch is preparation for making stack protector configurable. First step is to remove -fno-stack-protector flag from EMBEDDED_EXTRA_CFLAGS so separate components (Hypervisor in this case) can enable/disable this feature by themselves. Signed-off-by: Volodymyr Babchuk --- Changes in v3: -

Re: [PATCH v3 00/19] Converge on using secs_to_jiffies()

2024-12-10 Thread Jakub Kicinski
On Tue, 10 Dec 2024 15:36:04 -0800 Andrew Morton wrote: > > I have the same question as before: How do you expect these to land? > > Do you now have a maintainer who will take all of them? > > Or do you want individual maintainers to take the ones applicable to them? > > I'll just grab everythin

Re: [PATCH v3 00/19] Converge on using secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
On 12/10/2024 4:35 PM, Andrew Morton wrote: > On Tue, 10 Dec 2024 22:02:31 + Easwar Hariharan > wrote: > >> This is a series that follows up on my previous series to introduce >> secs_to_jiffies() and convert a few initial users. > > Thanks, I added this to mm.git. I suppressed the usual a

RE: Welcome Honda to the Xen Project Board

2024-12-10 Thread Stefano Stabellini
Hi Yuichi, Welcome onboard! It is great to have you as part of our community, and we are looking forward to working together to enhance Xen in automotive. Cheers, Stefano On Tue, 10 Dec 2024, YUICHI KUSAKABE (日下部 雄一) wrote: > Hello All > >   > > We are happy to be able to join the member of

Re: [PATCH v9 5/6] x86/boot: introduce domid field to struct boot_domain

2024-12-10 Thread Daniel P. Smith
On 12/9/24 03:55, Jan Beulich wrote: On 04.12.2024 17:45, Daniel P. Smith wrote: On 11/27/24 05:32, Jan Beulich wrote: On 15.11.2024 14:12, Daniel P. Smith wrote: init_dom0_cpuid_policy(d); if ( alloc_dom0_vcpu0(d) == NULL ) -panic("Error creating d%uv0\n", domid); +

Re: [PATCH v3 00/19] Converge on using secs_to_jiffies()

2024-12-10 Thread Andrew Morton
On Tue, 10 Dec 2024 22:02:31 + Easwar Hariharan wrote: > This is a series that follows up on my previous series to introduce > secs_to_jiffies() and convert a few initial users. Thanks, I added this to mm.git. I suppressed the usual added-to-mm emails because s many cc's! I'd ask rele

Re: [PATCH] xen: update ECLAIR service identifiers from MC3R1 to MC3A2.

2024-12-10 Thread Stefano Stabellini
On Tue, 10 Dec 2024, Alessandro Zucchelli wrote: > Rename all instances of ECLAIR MISRA C:2012 service identifiers, > identified by the prefix MC3R1, to use the prefix MC3A2, which > refers to MISRA C:2012 Amendment 2 guidelines. > > This update is motivated by the need to upgrade ECLAIR GitLab ru

Re: [PATCH] MAINTAINERS: add Anthony, Michal, Roger to THE REST

2024-12-10 Thread Andrew Cooper
On 10/12/2024 11:58 pm, Stefano Stabellini wrote: > In recognition of their outstanding work and years of service to the Xen > Community, please join me in welcoming Anthony, Michal, and Roger as > Committers and REST Maintainers. > > Signed-off-by: Stefano Stabellini Acked-by: Andrew Cooper

[PATCH] MAINTAINERS: add Anthony, Michal, Roger to THE REST

2024-12-10 Thread Stefano Stabellini
In recognition of their outstanding work and years of service to the Xen Community, please join me in welcoming Anthony, Michal, and Roger as Committers and REST Maintainers. Signed-off-by: Stefano Stabellini diff --git a/MAINTAINERS b/MAINTAINERS index 026aa25a53..34ad49bc39 100644 --- a/MAINTA

Re: [PATCH v3 00/19] Converge on using secs_to_jiffies()

2024-12-10 Thread Andrew Morton
On Tue, 10 Dec 2024 15:14:22 -0800 Jeff Johnson wrote: > On 12/10/2024 2:02 PM, Easwar Hariharan wrote: > > This is a series that follows up on my previous series to introduce > > secs_to_jiffies() and convert a few initial users.[1] In the review for > > that series, Anna-Maria requested conver

Re: [PATCH v2 34/35] xen/console: enable console owners w/ emulated NS8250

2024-12-10 Thread Jason Andryuk
On 2024-12-05 23:42, Denis Mukhin via B4 Relay wrote: From: Denis Mukhin Enable console focus for domains w/ virtual NS8250. Code change allows to capture the output from the guest OS now and send it to the physical console device. Signed-off-by: Denis Mukhin --- xen/drivers/char/console.c

Re: [PATCH v2 21/35] xen/console: introduce console_init_owner()

2024-12-10 Thread Jason Andryuk
On 2024-12-05 23:41, Denis Mukhin via B4 Relay wrote: From: Denis Mukhin console_init_owner() is introduced for selecting the boot-time console owner. Signed-off-by: Denis Mukhin Reviewed-by: Jason Andryuk

Re: [PATCH v2 20/35] xen/console: introduce console_owner_domid()

2024-12-10 Thread Jason Andryuk
On 2024-12-05 23:41, Denis Mukhin via B4 Relay wrote: From: Denis Mukhin console_owner_domid() is introduced to obtain the "console owner" domain ID. The call is used in NS8250 emulator to identify the case when physical xen console focus is owned by the domain w/ NS8250 emulator, in which cas

[PATCH v3 01/19] netfilter: conntrack: Cleanup timeout definitions

2024-12-10 Thread Easwar Hariharan
None of the higher order definitions are used anymore, so remove definitions for minutes, hours, and days timeouts. Convert the seconds denominated timeouts to secs_to_jiffies() Signed-off-by: Easwar Hariharan --- net/netfilter/nf_conntrack_proto_sctp.c | 21 - 1 file changed

[PATCH v3 18/19] livepatch: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 17/19] ceph: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 14/19] wifi: ath11k: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 15/19] Bluetooth: MGMT: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 19/19] ALSA: line6: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 16/19] staging: vc04_services: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 02/19] coccinelle: misc: Add secs_to_jiffies script

2024-12-10 Thread Easwar Hariharan
This script finds and suggests conversions of timeout patterns that result in seconds-denominated timeouts to use the new secs_to_jiffies() API in include/linux/jiffies.h for better readability. Suggested-by: Anna-Maria Behnsen Signed-off-by: Easwar Hariharan --- scripts/coccinelle/misc/secs_to

[PATCH v3 12/19] xen/blkback: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 06/19] mm: kmemleak: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 10/19] scsi: arcmsr: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 13/19] gve: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 07/19] accel/habanalabs: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 11/19] scsi: pm8001: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 00/19] Converge on using secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
-20241210 - Fix typo'ed timeout in net/netfilter/nf_conntrack_proto_sctp.c (Stephen Rothwell) - Use Coccinelle operation modes for Coccinelle script (Markus Elfring) - Remove redundant comments in arch/arm/mach-pxa/sharpsl_pm.c (Christophe Leroy) - Remove excess line breaks (Heiko Carstens, Chris

[PATCH v3 09/19] scsi: lpfc: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 04/19] s390: kernel: Convert timeouts to use secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the values here are a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following

[PATCH v3 08/19] drm/xe: Convert timeout to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 05/19] powerpc/papr_scm: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

[PATCH v3 03/19] arm: pxa: Convert timeouts to use secs_to_jiffies()

2024-12-10 Thread Easwar Hariharan
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following C

Re: [PATCH] xen/vpci: fix memory type in guest_mem_bar_read()

2024-12-10 Thread Stewart Hildebrand
On 12/10/24 11:37, Roger Pau Monné wrote: > On Tue, Dec 10, 2024 at 11:25:44AM -0500, Stewart Hildebrand wrote: >> Currently, if bar->type is anything other than VPCI_BAR_MEM32, the >> memory type bits get set to PCI_BASE_ADDRESS_MEM_TYPE_64 in the returned >> value. This leads to the wrong memory

Re: [PATCH] x86/FPU: make vcpu_reset_fpu() build again with old gcc

2024-12-10 Thread Alejandro Vallejo
On Tue, Dec 10, 2024 at 4:14 PM Jan Beulich wrote: > > On 10.12.2024 16:12, Alejandro Vallejo wrote: > > On Tue Dec 10, 2024 at 2:34 PM GMT, Jan Beulich wrote: > >> On 10.12.2024 15:25, Alejandro Vallejo wrote: > >>> On Mon Dec 9, 2024 at 3:13 PM GMT, Jan Beulich wrote: > Fields of anonymous

[PATCH] xen/vpci: fix memory type in guest_mem_bar_read()

2024-12-10 Thread Stewart Hildebrand
Currently, if bar->type is anything other than VPCI_BAR_MEM32, the memory type bits get set to PCI_BASE_ADDRESS_MEM_TYPE_64 in the returned value. This leads to the wrong memory type for, e.g. VPCI_BAR_EMPTY. Only set PCI_BASE_ADDRESS_MEM_TYPE_64 when the bar type is VPCI_BAR_MEM64_LO. Fixes: 8c5b

Re: [PATCH] xen/vpci: fix memory type in guest_mem_bar_read()

2024-12-10 Thread Roger Pau Monné
On Tue, Dec 10, 2024 at 11:25:44AM -0500, Stewart Hildebrand wrote: > Currently, if bar->type is anything other than VPCI_BAR_MEM32, the > memory type bits get set to PCI_BASE_ADDRESS_MEM_TYPE_64 in the returned > value. This leads to the wrong memory type for, e.g. VPCI_BAR_EMPTY. > Only set PCI_B

Re: [PATCH] xen/vpci: fix memory type in guest_mem_bar_read()

2024-12-10 Thread Jan Beulich
On 10.12.2024 17:25, Stewart Hildebrand wrote: > Currently, if bar->type is anything other than VPCI_BAR_MEM32, the > memory type bits get set to PCI_BASE_ADDRESS_MEM_TYPE_64 in the returned > value. This leads to the wrong memory type for, e.g. VPCI_BAR_EMPTY. > Only set PCI_BASE_ADDRESS_MEM_TYPE_

Re: [PATCH v2 5/7] xen: add new domctl get_changed_domain

2024-12-10 Thread Jan Beulich
On 10.12.2024 16:52, Jürgen Groß wrote: > On 09.12.24 18:04, Jan Beulich wrote: >> On 06.12.2024 14:02, Juergen Gross wrote: >>> --- a/xen/common/domain.c >>> +++ b/xen/common/domain.c >>> @@ -192,6 +192,54 @@ static void domain_changed_state(const struct domain >>> *d) >>> spin_unlock(&dom_

Re: [PATCH] x86/FPU: make vcpu_reset_fpu() build again with old gcc

2024-12-10 Thread Jan Beulich
On 10.12.2024 16:12, Alejandro Vallejo wrote: > On Tue Dec 10, 2024 at 2:34 PM GMT, Jan Beulich wrote: >> On 10.12.2024 15:25, Alejandro Vallejo wrote: >>> On Mon Dec 9, 2024 at 3:13 PM GMT, Jan Beulich wrote: Fields of anonymous structs/unions may not be part of an initializer for rather

Re: [PATCH v1 5/6] xen/riscv: implement relocate_fdt()

2024-12-10 Thread Jan Beulich
On 10.12.2024 16:20, Oleksii Kurochko wrote: > On 12/9/24 4:00 PM, Jan Beulich wrote: >> On 27.11.2024 13:50, Oleksii Kurochko wrote: >>> relocate_fdt() relocates FDT to Xen heap instead of using early mapping >>> as it is expected that discard_initial_modules() ( is supposed to call >>> in the fut

Re: [PATCH v2 5/7] xen: add new domctl get_changed_domain

2024-12-10 Thread Jürgen Groß
On 09.12.24 18:04, Jan Beulich wrote: On 06.12.2024 14:02, Juergen Gross wrote: --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -192,6 +192,54 @@ static void domain_changed_state(const struct domain *d) spin_unlock(&dom_state_changed_lock); } +static void set_domain_state_info(

Re: [PATCH v2 4/7] xen: add bitmap to indicate per-domain state changes

2024-12-10 Thread Jürgen Groß
On 09.12.24 17:52, Jan Beulich wrote: On 06.12.2024 14:02, Juergen Gross wrote: Add a bitmap with one bit per possible domid indicating the respective domain has changed its state (created, deleted, dying, crashed, shutdown). Registering the VIRQ_DOM_EXC event will result in setting the bits fo

Re: [PATCH v2] CHANGELOG: Mention xl suspend/resume

2024-12-10 Thread Oleksii Kurochko
On 12/10/24 3:56 PM, Jason Andryuk wrote: The xl subcommands are generic, but only built when LIBXL_HAVE_NO_SUSPEND_RESUME is false. Currently that is only x86, so list them there. Signed-off-by: Jason Andryuk LGTM: Reviewed-by: Oleksii Kurochko Thanks. ~ Oleksii --- v2: Nest under "On

Re: [PATCH v1 4/6] xen/riscv: introduce cache management operations (CMO)

2024-12-10 Thread Oleksii Kurochko
On 12/10/24 1:39 PM, Jan Beulich wrote: On 10.12.2024 13:19, Oleksii Kurochko wrote: On 12/9/24 3:38 PM, Jan Beulich wrote: On 27.11.2024 13:50, Oleksii Kurochko wrote: --- a/xen/arch/riscv/Kconfig +++ b/xen/arch/riscv/Kconfig @@ -14,6 +14,9 @@ config ARCH_DEFCONFIG   string   defau

Re: [PATCH] arm/domain_build: Make find_unallocated_memory() more generic

2024-12-10 Thread Luca Fancellu
> On 10 Dec 2024, at 10:10, Michal Orzel wrote: > > At the moment, find_unallocated_memory() is only used to retrieve free > memory ranges for direct mapped domains in order to find extended > regions. It is not generic as it makes assumptions as for the place at > which it's being called (doma

Re: [PATCH v1 6/6] xen/riscv: relocating and unflattening host device tree

2024-12-10 Thread Oleksii Kurochko
On 12/9/24 4:57 PM, Jan Beulich wrote: On 09.12.2024 16:56, Jan Beulich wrote: On 27.11.2024 13:50, Oleksii Kurochko wrote: Relocate FDT to Xen heap instead of using early mapping as it is expected that discard_initial_modules() ( is supposed to call in the future ) discards the FDT boot modul

Re: [PATCH v1 5/6] xen/riscv: implement relocate_fdt()

2024-12-10 Thread Oleksii Kurochko
On 12/9/24 4:00 PM, Jan Beulich wrote: On 27.11.2024 13:50, Oleksii Kurochko wrote: relocate_fdt() relocates FDT to Xen heap instead of using early mapping as it is expected that discard_initial_modules() ( is supposed to call in the future ) discards the FDT boot module and remove_early_mappin

Re: [PATCH] x86/FPU: make vcpu_reset_fpu() build again with old gcc

2024-12-10 Thread Alejandro Vallejo
On Tue Dec 10, 2024 at 2:34 PM GMT, Jan Beulich wrote: > On 10.12.2024 15:25, Alejandro Vallejo wrote: > > On Mon Dec 9, 2024 at 3:13 PM GMT, Jan Beulich wrote: > >> Fields of anonymous structs/unions may not be part of an initializer for > >> rather old gcc. > > > > Can you add the specific versi

Re: [PATCH v2 3/4] x86/boot: Move some settings to C

2024-12-10 Thread Jan Beulich
On 10.12.2024 15:45, Frediano Ziglio wrote: > On Tue, Dec 10, 2024 at 10:38 AM Jan Beulich wrote: >> On 22.11.2024 10:33, Frediano Ziglio wrote: >>> switch ( magic ) >>> { >>> case MULTIBOOT_BOOTLOADER_MAGIC: >>> -return mbi_reloc(in, &ctx); >>> +res = mbi_reloc(in,

Re: [PATCH v2 19/35] xen/console: introduce console_set_owner()

2024-12-10 Thread Jan Beulich
On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -463,82 +463,100 @@ static void cf_check dump_console_ring_key(unsigned > char key) > > /* > * CTRL- changes input direction, rotating among Xen, Dom0, > - * and th

Re: [PATCH v2 2/4] x86/boot: Use header to allows inclusion of public xen.h header

2024-12-10 Thread Jan Beulich
On 10.12.2024 15:48, Frediano Ziglio wrote: > On Tue, Dec 10, 2024 at 2:44 PM Jan Beulich wrote: >> On 10.12.2024 15:35, Frediano Ziglio wrote: >>> On Tue, Dec 10, 2024 at 10:32 AM Jan Beulich wrote: On 22.11.2024 10:33, Frediano Ziglio wrote: > --- /dev/null > +++ b/xen/arch/x86/inc

Re: [PATCH v2 3/4] x86/boot: Move some settings to C

2024-12-10 Thread Frediano Ziglio
On Tue, Dec 10, 2024 at 10:38 AM Jan Beulich wrote: > > On 22.11.2024 10:33, Frediano Ziglio wrote: > > Initialise multiboot_ptr and pvh_start_info_pa from C code. > > > > Signed-off-by: Frediano Ziglio > > --- > > xen/arch/x86/boot/build32.lds.S | 3 +++ > > xen/arch/x86/boot/head.S

[PATCH v2] CHANGELOG: Mention xl suspend/resume

2024-12-10 Thread Jason Andryuk
The xl subcommands are generic, but only built when LIBXL_HAVE_NO_SUSPEND_RESUME is false. Currently that is only x86, so list them there. Signed-off-by: Jason Andryuk --- v2: Nest under "On X86" Expand commit message --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGE

Re: [PATCH v2 18/35] xen/console: introduce use of 'is_console' flag

2024-12-10 Thread Jan Beulich
On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: > From: Denis Mukhin > > The code now inspects d->is_console flag to decide whether the console focus > should move to the domain w/ console after administrator presses . > > Console owner domain switch logic updated accordingly. > > Signed-

Re: [PATCH v2 2/4] x86/boot: Use header to allows inclusion of public xen.h header

2024-12-10 Thread Frediano Ziglio
On Tue, Dec 10, 2024 at 2:44 PM Jan Beulich wrote: > > On 10.12.2024 15:35, Frediano Ziglio wrote: > > On Tue, Dec 10, 2024 at 10:32 AM Jan Beulich wrote: > >> > >> On 22.11.2024 10:33, Frediano Ziglio wrote: > >>> This allows to include other headers and avoid duplicated declarations. > >>> > >>

Re: [PATCH v2 2/4] x86/boot: Use header to allows inclusion of public xen.h header

2024-12-10 Thread Jan Beulich
On 10.12.2024 15:35, Frediano Ziglio wrote: > On Tue, Dec 10, 2024 at 10:32 AM Jan Beulich wrote: >> >> On 22.11.2024 10:33, Frediano Ziglio wrote: >>> This allows to include other headers and avoid duplicated declarations. >>> >>> Signed-off-by: Frediano Ziglio >> >> Again it's left unclear what

Re: [PATCH v2 1/4] Use an include/boot directory to override headers for boot code

2024-12-10 Thread Jan Beulich
On 10.12.2024 15:29, Frediano Ziglio wrote: > On Tue, Dec 10, 2024 at 10:14 AM Jan Beulich wrote: >> >> On 22.11.2024 10:33, Frediano Ziglio wrote: >>> Not all headers can be used by 32 bit boot code. >>> Allows to override some headers, we don't want to mess up with >>> main headers as most of th

Re: [PATCH v2 2/4] x86/boot: Use header to allows inclusion of public xen.h header

2024-12-10 Thread Frediano Ziglio
On Tue, Dec 10, 2024 at 10:32 AM Jan Beulich wrote: > > On 22.11.2024 10:33, Frediano Ziglio wrote: > > This allows to include other headers and avoid duplicated declarations. > > > > Signed-off-by: Frediano Ziglio > > Again it's left unclear what the purpose / goal is. > Reduce duplication avoi

Re: [PATCH] x86/FPU: make vcpu_reset_fpu() build again with old gcc

2024-12-10 Thread Jan Beulich
On 10.12.2024 15:25, Alejandro Vallejo wrote: > On Mon Dec 9, 2024 at 3:13 PM GMT, Jan Beulich wrote: >> Fields of anonymous structs/unions may not be part of an initializer for >> rather old gcc. > > Can you add the specific version for tracking purposes? It's all the same as before, and I reall

Re: [PATCH v2 17/35] xen/console: introduce consoled_is_enabled()

2024-12-10 Thread Jan Beulich
On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: > --- a/xen/drivers/char/consoled.c > +++ b/xen/drivers/char/consoled.c > @@ -43,13 +43,13 @@ struct xencons_interface *consoled_get_ring_addr(void) > static char buf[BUF_SZ + 1]; > > /* Receives characters from a domain's PV console */ > -v

Re: [PATCH v2 1/4] Use an include/boot directory to override headers for boot code

2024-12-10 Thread Frediano Ziglio
On Tue, Dec 10, 2024 at 10:14 AM Jan Beulich wrote: > > On 22.11.2024 10:33, Frediano Ziglio wrote: > > Not all headers can be used by 32 bit boot code. > > Allows to override some headers, we don't want to mess up with > > main headers as most of the code is only 64 bit so the easy stuff should >

Re: [PATCH v2 16/35] xen/console: introduce printk_common()

2024-12-10 Thread Jan Beulich
On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: > Introduce new printk() variant for convenient printouts which skip '(XEN)' > prefix on xen console. This is needed for the case when physical console is > owned by a domain w/ in-hypervisor UART emulation enabled. Imo it should still be guest

Re: [PATCH] x86/FPU: make vcpu_reset_fpu() build again with old gcc

2024-12-10 Thread Alejandro Vallejo
On Mon Dec 9, 2024 at 3:13 PM GMT, Jan Beulich wrote: > Fields of anonymous structs/unions may not be part of an initializer for > rather old gcc. Can you add the specific version for tracking purposes? > > Fixes: 49a068471d77 ("x86/fpu: Rework fpu_setup_fpu() uses to split it in > two") > Signe

Re: [PATCH v2 15/35] xen/console: rename console_rx to console_owner

2024-12-10 Thread Jan Beulich
On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote: > Preparation for the follow on change to switch console_owner to > domid_t address space. As with the earlier change - it's one thing to (plan to) change the number space, and another to go from input only to general console. Jan

  1   2   >