On 12/9/24 03:55, Jan Beulich wrote:
On 04.12.2024 17:45, Daniel P. Smith wrote:
On 11/27/24 05:32, Jan Beulich wrote:
On 15.11.2024 14:12, Daniel P. Smith wrote:
init_dom0_cpuid_policy(d);
if ( alloc_dom0_vcpu0(d) == NULL )
- panic("Error creating d%uv0\n", domid);
+ panic("Error creating d%uv0\n", bd->domid);
Imo this would better use d->domain_id. And while touching it, %u would also
want swapping for %d.
hmm, I was actually considering s/d%u/%pd/ and just pass in d, but was
certain if there was an explicit reason it wasn't used before. If I am
going to change it, would %pd not be more desired here?
When writing my original reply, I certainly considered this. The anomaly
here is that you really mean to log a vCPU ID, which would require a
struct vcpu * and use of %pv. Yet you don't have that here, precisely
because the creation of the vCPU failed. That said, since
vsprintf.c:print_vcpu() calls print_domain(), using %pd is certainly an
option here (inconsistencies would arise if %pv and %pd presented domain
IDs in [perhaps just slightly] different ways).
Will do, thanks!
v/r,
dps
