On 10.12.2024 23:11, Jason Andryuk wrote: > On 2024-12-05 23:41, Denis Mukhin via B4 Relay wrote: >> From: Denis Mukhin <dmuk...@ford.com> >> >> console_owner_domid() is introduced to obtain the "console owner" domain ID. >> >> The call is used in NS8250 emulator to identify the case when physical xen >> console focus is owned by the domain w/ NS8250 emulator, in which case, >> messages from guest OS are formatted w/o '(XEN)' prefix. >> >> Signed-off-by: Denis Mukhin <dmuk...@ford.com> > > Reviewed-by: Jason Andryuk <jason.andr...@amd.com> > > I expected this to be used immediately by patch 21, but it is not. You > might want to re-order it directly before its first use is introduced. > I haven't gotten far enough to know when that is.
Plus, no matter how far in the future it is, there'll be a window where the Misra rule of not having unreachable code in the project is violated. New functions now really need introducing when their first caller appears. Jan
