Re: [PATCH RFC for-4.19] docs/checklist: Start tagging new dev windows

2024-07-15 Thread Jan Beulich
On 15.07.2024 18:58, Julien Grall wrote: > On 15/07/2024 17:46, Andrew Cooper wrote: >> Signed-off-by: Andrew Cooper > > With one remark below: > > Reviewed-by: Julien Grall > >> --- >> CC: Jan Beulich >> CC: Stefano Stabellini >> CC: Julien Grall >> CC: Oleksii Kurochko >> >> This is abou

Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-15 Thread Jan Beulich
On 16.07.2024 01:46, Jason Andryuk wrote: > From: Jason Andryuk > > "$dev" needs to be set correctly for backendtype=phy as well as > backendtype=tap. Move the setting into the conditional, so it can be > handled properly for each. > > (dev could be captured during tap-ctl allocate for blktap m

Re: [PATCH for-4.19] docs/checklist: Fix XEN_EXTRAVERSION inconsistency for release candidates

2024-07-15 Thread Jan Beulich
On 15.07.2024 17:50, Andrew Cooper wrote: > An earlier part of the checklist states: > > * change xen-unstable README. The banner (generated using figlet) should > say: > - "Xen 4.5" in releases and on stable branches > - "Xen 4.5-unstable" on unstable > - "Xen 4.5-rc" for rel

Re: [PATCH for-4.19] docs/checklist: Fix XEN_EXTRAVERSION inconsistency for release candidates

2024-07-15 Thread Jan Beulich
On 15.07.2024 18:56, Julien Grall wrote: > On 15/07/2024 16:50, Andrew Cooper wrote: >> An earlier part of the checklist states: >> >>* change xen-unstable README. The banner (generated using figlet) should >> say: >>- "Xen 4.5" in releases and on stable branches >>- "Xen 4.5-u

[ovmf test] 186813: all pass - PUSHED

2024-07-15 Thread osstest service owner
flight 186813 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186813/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1bb9f47739ae7993191a36bea76c5a2157fdd10f baseline version: ovmf 8e6ba0dcae40bfd4c191b

Re: [RFC PATCH 17/17] CODING_STYLE: Add a section on header guards naming conventions

2024-07-15 Thread Stefano Stabellini
On Mon, 15 Jul 2024, Jan Beulich wrote: > On 13.07.2024 00:38, Stefano Stabellini wrote: > > On Wed, 3 Jul 2024, Jan Beulich wrote: > >> I further have to note that, as indicated during the earlier discussion, > >> I still cannot see how occasional ambiguity is going to be dealt with. > >> IOW from

[PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

2024-07-15 Thread Jason Andryuk
From: Jason Andryuk "$dev" needs to be set correctly for backendtype=phy as well as backendtype=tap. Move the setting into the conditional, so it can be handled properly for each. (dev could be captured during tap-ctl allocate for blktap module, but it would not be set properly for the find_dev

[linux-linus test] 186809: regressions - FAIL

2024-07-15 Thread osstest service owner
flight 186809 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/186809/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 186803 build-ar

Re: [PATCH] xen-netback: Use seq_putc() in xenvif_dump_hash_info()

2024-07-15 Thread Jakub Kicinski
On Mon, 15 Jul 2024 22:24:39 +0200 Christophe JAILLET wrote: > Most of the time, this kind of modification is useless because it is > already done by the compiler, see [1]. GTK, thanks!

Re: [PATCH] xen-netback: Use seq_putc() in xenvif_dump_hash_info()

2024-07-15 Thread Christophe JAILLET
Le 15/07/2024 à 18:01, Jakub Kicinski a écrit : On Sat, 13 Jul 2024 15:18:42 +0200 Markus Elfring wrote: Single characters (line breaks) should be put into a sequence. Thus use the corresponding function “seq_putc”. This issue was transformed by using the Coccinelle software. I prefer to only

[ovmf test] 186810: all pass - PUSHED

2024-07-15 Thread osstest service owner
flight 186810 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186810/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8e6ba0dcae40bfd4c191b2cd47e08f38186513d1 baseline version: ovmf 5366def8d01d141163a72

Re: [PATCH for-4.20] MAINTAINERS: Add me and Bertrand as device tree maintainers

2024-07-15 Thread Stefano Stabellini
On Mon, 15 Jul 2024, Michal Orzel wrote: > With Arm port being the major recipient of dt related patches and the > future need of incorporating dt support into other ports, we'd like to > keep an eye on these changes. > > Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini > --- > MAINT

Re: [XEN PATCH v3 2/2] x86/cpufreq: separate powernow/hwp/acpi cpufreq code

2024-07-15 Thread Jason Andryuk
On 2024-07-10 04:30, Sergiy Kibrik wrote: Build AMD Architectural P-state driver when CONFIG_AMD is on, and Intel Hardware P-States driver together with ACPI Processor P-States driver when CONFIG_INTEL is on respectively, allowing for a platform-specific build. Signed-off-by: Sergiy Kibrik CC:

[linux-6.1 test] 186804: tolerable FAIL - PUSHED

2024-07-15 Thread osstest service owner
flight 186804 linux-6.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/186804/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 186763 test-amd64-amd64-xl-qemuu-win7-amd64 19

Re: [XEN PATCH v3 07/12] x86/hvm: address violations of MISRA C Rule 16.3

2024-07-15 Thread Federico Serafini
On 13/07/24 01:25, Stefano Stabellini wrote: On Tue, 2 Jul 2024, Federico Serafini wrote: On 01/07/24 10:47, Jan Beulich wrote: On 26.06.2024 11:28, Federico Serafini wrote: @@ -2798,11 +2800,12 @@ void hvm_emulate_one_vm_event(enum emul_kind kind, unsigned int trapnr, hvio->mmio_in

Re: [PATCH 22/12] tools/examples: Remove more obsolete content

2024-07-15 Thread Andrew Cooper
On 15/07/2024 5:53 pm, Anthony PERARD wrote: > On Mon, Jul 15, 2024 at 04:16:40PM +0100, Andrew Cooper wrote: >> xeninfo.pl was introduced in commit 1b0a8bb57e3e ("Added xeninfo.pl, a script >> for collecting statistics from Xen hosts using the Xen-API") and has been >> touched exactly twice since

Re: [PATCH RFC for-4.19] docs/checklist: Start tagging new dev windows

2024-07-15 Thread Julien Grall
Hi Andrew, On 15/07/2024 17:46, Andrew Cooper wrote: Signed-off-by: Andrew Cooper With one remark below: Reviewed-by: Julien Grall --- CC: Jan Beulich CC: Stefano Stabellini CC: Julien Grall CC: Oleksii Kurochko This is about figuring out when a change was first introduced. Take 10b

Re: [PATCH for-4.19] docs/checklist: Fix XEN_EXTRAVERSION inconsistency for release candidates

2024-07-15 Thread Julien Grall
Hi, On 15/07/2024 16:50, Andrew Cooper wrote: An earlier part of the checklist states: * change xen-unstable README. The banner (generated using figlet) should say: - "Xen 4.5" in releases and on stable branches - "Xen 4.5-unstable" on unstable - "Xen 4.5-rc" for release

Re: [PATCH 22/12] tools/examples: Remove more obsolete content

2024-07-15 Thread Anthony PERARD
On Mon, Jul 15, 2024 at 04:16:40PM +0100, Andrew Cooper wrote: > xeninfo.pl was introduced in commit 1b0a8bb57e3e ("Added xeninfo.pl, a script > for collecting statistics from Xen hosts using the Xen-API") and has been > touched exactly twice since to remove hardcoded IP addresses and paths. Xen-A

[XEN PATCH v4 6/9] x86/mce: address violations of MISRA C Rule 16.3

2024-07-15 Thread Federico Serafini
Add missing break statements to address violations of MISRA C Rule 16.3: "An unconditional `break' statement shall terminate every switch-clause". No functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich --- xen/arch/x86/cpu/mcheck/mce_amd.c

[XEN PATCH v4 8/9] x86/mm: add defensive return

2024-07-15 Thread Federico Serafini
Add defensive return statement at the end of an unreachable default case. Other than improve safety, this meets the requirements to deviate a violation of MISRA C Rule 16.3: "An unconditional `break' statement shall terminate every switch-clause". Signed-off-by: Federico Serafini --- No changes f

[XEN PATCH v4 2/9] x86/cpuid: use fallthrough pseudo keyword

2024-07-15 Thread Federico Serafini
The current comment making explicit the fallthrough intention does not follow the agreed syntax: replace it with the pseduo keyword. No functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich --- xen/arch/x86/cpuid.c | 3 +-- 1 file changed, 1

[XEN PATCH v4 4/9] x86/vpmu: address violations of MISRA C Rule 16.3

2024-07-15 Thread Federico Serafini
Add missing break statements to address violations of MISRA C Rule 16.3: "An unconditional `break' statement shall terminate every switch-clause". No functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini --- xen/arch/x86/cpu/vpmu.c | 3 +++ xen/arch/x86/cpu/

[XEN PATCH v4 7/9] x86/hvm: address violations of MISRA C Rule 16.3

2024-07-15 Thread Federico Serafini
MISRA C Rule 16.3 states that "An unconditional `break' statement shall terminate every switch-clause". Add pseudo keyword fallthrough or missing break statement to address violations of the rule. As a defensive measure, return an error message or a null pointer in case an unreachable return stat

[XEN PATCH v4 0/9] x86: address some violations of MISRA C Rule 16.3

2024-07-15 Thread Federico Serafini
This patch series fixes a missing escape in a deviation and addresses some violations. Federico Serafini (9): automation/eclair: fix deviation of MISRA C Rule 16.3 x86/cpuid: use fallthrough pseudo keyword x86/domctl: address a violation of MISRA C Rule 16.3 x86/vpmu: address violations of

[XEN PATCH v4 5/9] x86/traps: address violations of MISRA C Rule 16.3

2024-07-15 Thread Federico Serafini
Add break or pseudo keyword fallthrough to address violations of MISRA C Rule 16.3: "An unconditional `break' statement shall terminate every switch-clause". No functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini --- xen/arch/x86/traps.c | 3 +++ 1 file changed,

[XEN PATCH v4 9/9] x86/mpparse: address a violation of MISRA C Rule 16.3

2024-07-15 Thread Federico Serafini
Add a missing break statement to address a violation of MISRA C Rule 16.3: "An unconditional `break' statement shall terminate every switch-clause". No functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich --- xen/arch/x86/mpparse.c | 1 + 1

[XEN PATCH v4 1/9] automation/eclair: fix deviation of MISRA C Rule 16.3

2024-07-15 Thread Federico Serafini
Escape the final dot of the comment and extend the search of a fallthrough comment up to 2 lines after the last statement. Fixes: Fixes: a128d8da91 ("automation/eclair: add deviations for MISRA C:2012 Rule 16.3") Reported-by: Jan Beulich Signed-off-by: Federico Serafini Acked-by: Stefano Stabel

[XEN PATCH v4 3/9] x86/domctl: address a violation of MISRA C Rule 16.3

2024-07-15 Thread Federico Serafini
Add missing break statement to address a violation of MISRA C Rule 16.3: "An unconditional `break' statement shall terminate every switch-clause". No functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich --- xen/arch/x86/domctl.c | 1 + 1 fi

[PATCH RFC for-4.19] docs/checklist: Start tagging new dev windows

2024-07-15 Thread Andrew Cooper
Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Stefano Stabellini CC: Julien Grall CC: Oleksii Kurochko This is about figuring out when a change was first introduced. Take 10b719dc88 for example (completely random pick). The right answer is `git tag --contains $sha` and look for the o

Re: [PATCH] xen-netback: Use seq_putc() in xenvif_dump_hash_info()

2024-07-15 Thread Jakub Kicinski
On Sat, 13 Jul 2024 15:18:42 +0200 Markus Elfring wrote: > Single characters (line breaks) should be put into a sequence. > Thus use the corresponding function “seq_putc”. > > This issue was transformed by using the Coccinelle software. I prefer to only merge trivial changes like this if maintain

[PATCH for-4.19] docs/checklist: Fix XEN_EXTRAVERSION inconsistency for release candidates

2024-07-15 Thread Andrew Cooper
An earlier part of the checklist states: * change xen-unstable README. The banner (generated using figlet) should say: - "Xen 4.5" in releases and on stable branches - "Xen 4.5-unstable" on unstable - "Xen 4.5-rc" for release candidate Update the notes about XEN_EXTRAVERSION t

[ovmf test] 186808: all pass - PUSHED

2024-07-15 Thread osstest service owner
flight 186808 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186808/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5366def8d01d141163a727aeaef61318180deb98 baseline version: ovmf 8bb9145ad1a5db068f63e

[XEN PATCH v3 RESEND] tools/lsevtchn: Use errno macro to handle hypercall error cases

2024-07-15 Thread Matthew Barnes
Currently, lsevtchn aborts its event channel enumeration when it hits its first hypercall error, namely: * When an event channel doesn't exist at the specified port * When the event channel is owned by Xen lsevtchn does not distinguish between different hypercall errors, which results in lsevtchn

[PATCH 22/12] tools/examples: Remove more obsolete content

2024-07-15 Thread Andrew Cooper
xeninfo.pl was introduced in commit 1b0a8bb57e3e ("Added xeninfo.pl, a script for collecting statistics from Xen hosts using the Xen-API") and has been touched exactly twice since to remove hardcoded IP addresses and paths. The configuration files in vnc/* date from when we had a vendered version

Re: [PATCH v2 8/8] xen/riscv: introduce early_fdt_map()

2024-07-15 Thread Jan Beulich
On 15.07.2024 16:58, Jan Beulich wrote: > On 15.07.2024 15:58, Oleksii wrote: >> On Mon, 2024-07-15 at 10:52 +0200, Jan Beulich wrote: >>> On 12.07.2024 18:22, Oleksii Kurochko wrote: +    rc = map_pages_to_xen(BOOT_FDT_VIRT_START, maddr_to_mfn(base_paddr), + 

Re: [PATCH v2 8/8] xen/riscv: introduce early_fdt_map()

2024-07-15 Thread Jan Beulich
On 15.07.2024 15:58, Oleksii wrote: > On Mon, 2024-07-15 at 10:52 +0200, Jan Beulich wrote: >> On 12.07.2024 18:22, Oleksii Kurochko wrote: >>> +    rc = map_pages_to_xen(BOOT_FDT_VIRT_START, >>> maddr_to_mfn(base_paddr), >>> +  SZ_2M >> PAGE_SHIFT, >>> +

Re: [PATCH 21/12] CI: Refresh and upgrade the Fedora container

2024-07-15 Thread Andrew Cooper
On 15/07/2024 2:39 pm, Anthony PERARD wrote: > On Sat, Jul 13, 2024 at 07:10:05PM +0100, Andrew Cooper wrote: >> Fedora 29 is long out of date. Move forward 5 years to Fedora 39. >> >> Inlcude all the usual improvements. Rework the container to be non-root, use >> heredocs for legibility, and swi

[linux-linus test] 186803: tolerable FAIL - PUSHED

2024-07-15 Thread osstest service owner
flight 186803 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/186803/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-raw 8 xen-boot fail in 186799 pass in 186803 test-armhf-armhf-xl-arndale 8 x

Re: [PATCH v2 8/8] xen/riscv: introduce early_fdt_map()

2024-07-15 Thread Oleksii
On Mon, 2024-07-15 at 10:52 +0200, Jan Beulich wrote: > On 12.07.2024 18:22, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/include/asm/mm.h > > +++ b/xen/arch/riscv/include/asm/mm.h > > @@ -266,4 +266,6 @@ static inline unsigned int > > arch_get_dma_bitsize(void) > >   > >  void setup_fixmap_map

Re: [PATCH v6 1/8] xen/device-tree: Move Arm's setup.c bootinfo functions to common

2024-07-15 Thread Oleksii
Hi Michal, On Mon, 2024-07-15 at 12:15 +0200, Michal Orzel wrote: > Hi Oleksii, > > In general, the patch looks ok (apart from Jan comments). Just a > couple of remarks. > > On 12/07/2024 18:22, Oleksii Kurochko wrote: > > > > > > From: Shawn Anastasio > > > > Arm's setup.c contains a collec

[seabios test] 186806: tolerable FAIL - PUSHED

2024-07-15 Thread osstest service owner
flight 186806 seabios real [real] flight 186807 seabios real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186806/ http://logs.test-lab.xenproject.org/osstest/logs/186807/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-qe

Re: [PATCH 21/12] CI: Refresh and upgrade the Fedora container

2024-07-15 Thread Anthony PERARD
On Sat, Jul 13, 2024 at 07:10:05PM +0100, Andrew Cooper wrote: > Fedora 29 is long out of date. Move forward 5 years to Fedora 39. > > Inlcude all the usual improvements. Rework the container to be non-root, use > heredocs for legibility, and switch to the new naming scheme. "clang" as been rem

Xen 4.19-rc3

2024-07-15 Thread Oleksii
Hi all, Xen 4.19-rc3 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.19.0-rc3 For your convenience there is also a tarball and the signature at: https://downloads.xenproject.org/release/xen/4.19.0-rc3/xen-4.19.0-rc3.tar.gz And the signature is at: https://downloa

Re: [PATCH 10/12] CI: Introduce debian:11/12-riscv64 containers

2024-07-15 Thread Oleksii
On Fri, 2024-07-12 at 13:30 +0100, Andrew Cooper wrote: > On 12/07/2024 12:39 pm, Oleksii wrote: > > On Thu, 2024-07-11 at 12:15 +0100, Andrew Cooper wrote: > > > For starters, they're slightly smaller: > > > > > >   $ docker image list > > >   registry.gitlab.com/xen-project/xen/debian  12-

[no subject]

2024-07-15 Thread Oleksii
Hi all, Xen 4.19-rc3 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.19.0-rc3 For your convenience there is also a tarball and the signature at: https://downloads.xenproject.org/release/xen/4.19.0-rc3/xen-4.19.0-rc3.tar.gz And the signature is at: https://downloa

Re: [PATCH 20/12] CI: Swap from perl to perl-base in build containers

2024-07-15 Thread Andrew Cooper
On 15/07/2024 1:46 pm, Anthony PERARD wrote: > On Sat, Jul 13, 2024 at 07:09:52PM +0100, Andrew Cooper wrote: >> We only need a basic perl environment, not the things that a primarily-perl >> project would want. >> >> Discovered during the Fedora refresh where the difference is ~40M, but it's >> mo

Re: [PATCH 20/12] CI: Swap from perl to perl-base in build containers

2024-07-15 Thread Anthony PERARD
On Sat, Jul 13, 2024 at 07:09:52PM +0100, Andrew Cooper wrote: > We only need a basic perl environment, not the things that a primarily-perl > project would want. > > Discovered during the Fedora refresh where the difference is ~40M, but it's > more modest for OpenSUSE and Ubuntu. "perl-base" on

[RFC XEN] xen/public: PV-IOMMU interface header proposal

2024-07-15 Thread Teddy Astie
Hello, After some discussions with Alejandro and Jan on the PV-IOMMU design patch [1], I've redesigned parts of the interface with some proposals and to be more similar to other hypercalls. In addition to that, I've took a step further and added tentative design for some new features (includin

Re: [PATCH 19/12] docs: Fix install-man$(1)-pages if no manpages are generated

2024-07-15 Thread Anthony PERARD
On Sat, Jul 13, 2024 at 07:09:39PM +0100, Andrew Cooper wrote: > All tools to build manpages are optional, and if none of them happen to be > present, the intermediate working directory may not even be created. > > Treat this as non-fatal, bringing the behaviour in line with install-html. > Like t

[ovmf test] 186805: all pass - PUSHED

2024-07-15 Thread osstest service owner
flight 186805 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186805/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8bb9145ad1a5db068f63e3e19b4a532226351b2b baseline version: ovmf 91226e1eecacac832e509

Re: systemd units are not installed in 4.19.0-rc2 anymore

2024-07-15 Thread Jan Beulich
On 15.07.2024 12:07, Andrew Cooper wrote: > On 15/07/2024 9:11 am, Jan Beulich wrote: >> On 13.07.2024 15:02, Andrew Cooper wrote: >>> On 13/07/2024 3:45 am, Marek Marczykowski-Górecki wrote: Hi, Something has changed between -rc1 and -rc2 that systemd units are not installed an

Re: systemd units are not installed in 4.19.0-rc2 anymore

2024-07-15 Thread Marek Marczykowski-Górecki
On Mon, Jul 15, 2024 at 11:07:42AM +0100, Andrew Cooper wrote: > On 15/07/2024 9:11 am, Jan Beulich wrote: > > On 13.07.2024 15:02, Andrew Cooper wrote: > >> On 13/07/2024 3:45 am, Marek Marczykowski-Górecki wrote: > >>> Hi, > >>> > >>> Something has changed between -rc1 and -rc2 that systemd units

Re: [PATCH v6 1/8] xen/device-tree: Move Arm's setup.c bootinfo functions to common

2024-07-15 Thread Michal Orzel
Hi Oleksii, In general, the patch looks ok (apart from Jan comments). Just a couple of remarks. On 12/07/2024 18:22, Oleksii Kurochko wrote: > > > From: Shawn Anastasio > > Arm's setup.c contains a collection of functions for parsing memory map > and other boot information from a device tree

Re: systemd units are not installed in 4.19.0-rc2 anymore

2024-07-15 Thread Andrew Cooper
On 15/07/2024 9:11 am, Jan Beulich wrote: > On 13.07.2024 15:02, Andrew Cooper wrote: >> On 13/07/2024 3:45 am, Marek Marczykowski-Górecki wrote: >>> Hi, >>> >>> Something has changed between -rc1 and -rc2 that systemd units are not >>> installed anymore by default. >>> >>> Reproducer: >>> >>>

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Andrew Cooper
On 15/07/2024 9:16 am, Jan Beulich wrote: > On 15.07.2024 09:38, Fonyuy-Asheri Caleb wrote: >>> Perhaps the more important question, are you booting the skylake with >>> cpuid=no-avx on the command line by any chance? >> No. I didn't boot any of the machines with any cpuid modification >> whatsoev

Re: [PATCH for-4.20] MAINTAINERS: Add me and Bertrand as device tree maintainers

2024-07-15 Thread Bertrand Marquis
Hi Michal, > On 15 Jul 2024, at 11:32, Michal Orzel wrote: > > With Arm port being the major recipient of dt related patches and the > future need of incorporating dt support into other ports, we'd like to > keep an eye on these changes. > > Signed-off-by: Michal Orzel Acked-by: Bertrand Marq

[PATCH for-4.20] MAINTAINERS: Add me and Bertrand as device tree maintainers

2024-07-15 Thread Michal Orzel
With Arm port being the major recipient of dt related patches and the future need of incorporating dt support into other ports, we'd like to keep an eye on these changes. Signed-off-by: Michal Orzel --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS i

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Fonyuy-Asheri Caleb
> On 15.07.2024 10:48, Fonyuy-Asheri Caleb wrote: > On 15.07.2024 09:38, Fonyuy-Asheri Caleb wrote: >>> Perhaps the more important question, are you booting the skylake with >>> cpuid=no-avx on the command line by any chance? >> >> No. I didn't boot any of the machines with an

[xen-unstable test] 186800: tolerable FAIL

2024-07-15 Thread osstest service owner
flight 186800 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/186800/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 186794 test-amd64-amd64-xl-qemuu-ws16-amd64

Re: [PATCH RFC] Arm64: amend "xen/arm64: head: Add missing code symbol annotations"

2024-07-15 Thread Jan Beulich
On 10.07.2024 23:29, Julien Grall wrote: > Hi Jan, > > On 10/06/2024 14:37, Jan Beulich wrote: >> While the change[1] didn't go in yet, there is the intention for the ELF >> metadata annotations from xen/linkage.h to also effect honoring of >> CONFIG_CC_SPLIT_SECTIONS. In code that's placement / o

Re: [RFC PATCH 17/17] CODING_STYLE: Add a section on header guards naming conventions

2024-07-15 Thread Alessandro Zucchelli
On 2024-07-15 09:23, Jan Beulich wrote: On 13.07.2024 00:38, Stefano Stabellini wrote: On Wed, 3 Jul 2024, Jan Beulich wrote: I further have to note that, as indicated during the earlier discussion, I still cannot see how occasional ambiguity is going to be dealt with. IOW from the rules above

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Jan Beulich
On 15.07.2024 10:48, Fonyuy-Asheri Caleb wrote: On 15.07.2024 09:38, Fonyuy-Asheri Caleb wrote: >> Perhaps the more important question, are you booting the skylake with >> cpuid=no-avx on the command line by any chance? > > No. I didn't boot any of the machines with any cpuid m

Re: [PATCH v2 8/8] xen/riscv: introduce early_fdt_map()

2024-07-15 Thread Jan Beulich
On 12.07.2024 18:22, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/include/asm/mm.h > +++ b/xen/arch/riscv/include/asm/mm.h > @@ -266,4 +266,6 @@ static inline unsigned int arch_get_dma_bitsize(void) > > void setup_fixmap_mappings(void); > > +void* early_fdt_map(paddr_t fdt_paddr); Please ca

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Fonyuy-Asheri Caleb
>>> On 15.07.2024 09:38, Fonyuy-Asheri Caleb wrote: > Perhaps the more important question, are you booting the skylake with > cpuid=no-avx on the command line by any chance? No. I didn't boot any of the machines with any cpuid modification whatsoever. >>> >>> Yet is there pe

Re: [PATCH v2 3/8] xen/riscv: enable CONFIG_HAS_DEVICE_TREE

2024-07-15 Thread Jan Beulich
On 12.07.2024 18:22, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich Albeit a little reluctantly, seeing the once again entirely missing description. Please can you get used to not leaving that out, unless the title really says _all_ that's wanted / needed? Jan

Re: [PATCH v6 1/8] xen/device-tree: Move Arm's setup.c bootinfo functions to common

2024-07-15 Thread Jan Beulich
On 12.07.2024 18:22, Oleksii Kurochko wrote:> --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -77,6 +77,7 @@ obj-$(CONFIG_UBSAN) += ubsan/ > > obj-$(CONFIG_NEEDS_LIBELF) += libelf/ > obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/ > +obj-$(CONFIG_HAS_DEVICE_TREE) += device-tree/ > > CONF

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Jan Beulich
On 15.07.2024 10:22, Fonyuy-Asheri Caleb wrote: > - Original Message - >> From: "Jan Beulich" >> To: "Fonyuy-Asheri Caleb" >> Cc: "xen-devel" , "Andrew Cooper" >> >> Sent: Monday, July 15, 2024 10:16:07 AM >> Subject: Re: Help with Understanding vcpu xstate restore error during vm >> m

Re: [PATCH] docs/misra: add rule 12.2

2024-07-15 Thread Jan Beulich
On 13.07.2024 00:45, Stefano Stabellini wrote: > As discussed during the last MISRA C meeting, add Rule 12.2 to the list > of MISRA C rules we accept, together with an explanation that we use gcc > -fsanitize=undefined alone to check for violations. Neither the "alone" here nor ... > --- a/docs/m

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Fonyuy-Asheri Caleb
- Original Message - > From: "Jan Beulich" > To: "Fonyuy-Asheri Caleb" > Cc: "xen-devel" , "Andrew Cooper" > > Sent: Monday, July 15, 2024 10:16:07 AM > Subject: Re: Help with Understanding vcpu xstate restore error during vm > migration > On 15.07.2024 09:38, Fonyuy-Asheri Caleb wrot

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Jan Beulich
On 15.07.2024 09:38, Fonyuy-Asheri Caleb wrote: >> Perhaps the more important question, are you booting the skylake with >> cpuid=no-avx on the command line by any chance? > > No. I didn't boot any of the machines with any cpuid modification whatsoever. Yet is there perhaps "Mitigating GDS by di

Re: systemd units are not installed in 4.19.0-rc2 anymore

2024-07-15 Thread Jan Beulich
On 13.07.2024 15:02, Andrew Cooper wrote: > On 13/07/2024 3:45 am, Marek Marczykowski-Górecki wrote: >> Hi, >> >> Something has changed between -rc1 and -rc2 that systemd units are not >> installed anymore by default. >> >> Reproducer: >> >> ./configure --prefix=/usr >> make dist-tools >>

Re: Help with Understanding vcpu xstate restore error during vm migration

2024-07-15 Thread Fonyuy-Asheri Caleb
>> PV Default policy: 30 leaves, 2 MSRs >> ... >> 000d: -> 0003::0240: >> 000d:0001 -> 0007::: > > ... PV guests get nothing, while you're trying to migrate in a guest > which... > >> =

Re: [PATCH 05/17] xen/x86: address violations of MISRA C:2012 Directive 4.10

2024-07-15 Thread Jan Beulich
On 13.07.2024 00:09, Stefano Stabellini wrote: > On Tue, 9 Jul 2024, Jan Beulich wrote: >> On 09.07.2024 09:38, Alessandro Zucchelli wrote: >>> On 2024-07-01 16:21, Jan Beulich wrote: On 01.07.2024 15:36, Alessandro Zucchelli wrote: > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Ma

Re: [RFC PATCH 17/17] CODING_STYLE: Add a section on header guards naming conventions

2024-07-15 Thread Jan Beulich
On 13.07.2024 00:38, Stefano Stabellini wrote: > On Wed, 3 Jul 2024, Jan Beulich wrote: >> I further have to note that, as indicated during the earlier discussion, >> I still cannot see how occasional ambiguity is going to be dealt with. >> IOW from the rules above two different headers could still

Re: [XEN PATCH for-4.19] xen/bitmap: amend MISRA C deviation for Rule 20.7

2024-07-15 Thread Jan Beulich
On 12.07.2024 23:26, Stefano Stabellini wrote: > On Tue, 9 Jul 2024, Jan Beulich wrote: >> On 09.07.2024 11:34, Nicola Vetrini wrote: >>> --- a/xen/include/xen/bitmap.h >>> +++ b/xen/include/xen/bitmap.h >>> @@ -103,18 +103,16 @@ extern int bitmap_allocate_region(unsigned long >>> *bitmap, int pos