On 13.07.2024 00:38, Stefano Stabellini wrote: > On Wed, 3 Jul 2024, Jan Beulich wrote: >> I further have to note that, as indicated during the earlier discussion, >> I still cannot see how occasional ambiguity is going to be dealt with. >> IOW from the rules above two different headers could still end up with >> the same guard identifier. > > Maybe something like this? > > "In the event of naming collisions, exceptions to the coding style may > be made at the discretion of the contributor and maintainers."
Hmm, maybe I wasn't clear enough then. My take is that the scheme should simply not allow for possible collisions. Neither the contributor nor the reviewer may spot such a collision, and it may therefore take until the first full scan that one is actually noticed. Which I consider too late in the process, even if we already were at the point where commits were checked pre-push. Jan
