On 12.07.2024 18:22, Oleksii Kurochko wrote:> --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -77,6 +77,7 @@ obj-$(CONFIG_UBSAN) += ubsan/ > > obj-$(CONFIG_NEEDS_LIBELF) += libelf/ > obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/ > +obj-$(CONFIG_HAS_DEVICE_TREE) += device-tree/ > > CONF_FILE := $(if $(patsubst > /%,,$(KCONFIG_CONFIG)),$(objtree)/)$(KCONFIG_CONFIG) > $(obj)/config.gz: $(CONF_FILE)
I think it would be nice for the bad placement of the two lib*/ entries to not lead to further bad placements. Imo your addition wants to go ahead of the obj-$(CONFIG_HAS_DEVICE_TREE) += device_tree.o line. (Eventually I expect common/device_tree.c would then also want to move there, probably at the same time renaming it.) Jan
