Re: [RFC XEN PATCH v3 3/3] libxl: Use gsi instead of irq for mapping pirq

On 2023/12/11 23:48, Roger Pau Monné wrote: > On Mon, Dec 11, 2023 at 12:40:09AM +0800, Jiqian Chen wrote: >> In PVH dom0, it uses the linux local interrupt mechanism, >> when it allocs irq for a gsi, it is dynamic, and follow >> the principle of applying first, distributing first. And >> the irq n

Re: [PATCH RFC v2 for-6.8/block 11/18] erofs: use bdev api

Hi, 在 2023/12/12 14:35, Gao Xiang 写道: On 2023/12/11 22:07, Yu Kuai wrote: From: Yu Kuai Avoid to access bd_inode directly, prepare to remove bd_inode from block_devcie. Signed-off-by: Yu Kuai ---   fs/erofs/data.c | 18 --   fs/erofs/internal.h |  2 ++   2 files changed

Re: [RFC XEN PATCH v3 2/3] x86/pvh: Add (un)map_pirq and setup_gsi for PVH dom0

On 2023/12/11 23:31, Roger Pau Monné wrote: > On Mon, Dec 11, 2023 at 12:40:08AM +0800, Jiqian Chen wrote: >> If run Xen with PVH dom0 and hvm domU, hvm will map a pirq for >> a passthrough device by using gsi, see >> xen_pt_realize->xc_physdev_map_pirq and >> pci_add_dm_done->xc_physdev_map_pirq.

Re: [PATCH RFC v2 for-6.8/block 11/18] erofs: use bdev api

On 2023/12/11 22:07, Yu Kuai wrote: From: Yu Kuai Avoid to access bd_inode directly, prepare to remove bd_inode from block_devcie. Signed-off-by: Yu Kuai --- fs/erofs/data.c | 18 -- fs/erofs/internal.h | 2 ++ 2 files changed, 14 insertions(+), 6 deletions(-) dif

Re: [RFC XEN PATCH v3 1/3] xen/vpci: Clear all vpci status of device

On 2023/12/11 23:22, Roger Pau Monné wrote: > On Mon, Dec 11, 2023 at 12:40:07AM +0800, Jiqian Chen wrote: >> When a device has been reset on dom0 side, the vpci on Xen >> side won't get notification, so the cached state in vpci is >> all out of date compare with the real device state. >> To solve

Re: [RFC QEMU PATCH v3 1/1] xen: Use gsi instead of irq for mapping pirq

On 2023/12/11 23:33, Roger Pau Monné wrote: > On Mon, Dec 11, 2023 at 12:52:40AM +0800, Jiqian Chen wrote: >> In PVH dom0, it uses the linux local interrupt mechanism, >> when it allocs irq for a gsi, it is dynamic, and follow >> the principle of applying first, distributing first. And >> the irq n

Re: [RFC KERNEL PATCH v3 3/3] PCI/sysfs: Add gsi sysfs for pci_dev

On 2023/12/12 01:57, Roger Pau Monné wrote: > On Mon, Dec 11, 2023 at 12:15:19AM +0800, Jiqian Chen wrote: >> There is a need for some scenarios to use gsi sysfs. >> For example, when xen passthrough a device to dumU, it will >> use gsi to map pirq, but currently userspace can't get gsi >> number.

Re: [PATCH] tools/xenstored: potentially split trace_io() out message

On 11.12.23 20:11, Julien Grall wrote: Hi Juergen, On 23/11/2023 16:08, Juergen Gross wrote: Today write_messages() will call trace_io() after having written the complete message to the ring buffer or socket. In case the message can't be written in one go, split it by writing one trace entry w

Re: [RFC KERNEL PATCH v2 2/3] xen/pvh: Unmask irq for passthrough device in PVH dom0

On 2023/12/11 23:45, Roger Pau Monné wrote: > On Wed, Dec 06, 2023 at 06:07:26AM +, Chen, Jiqian wrote: >> >> When PVH dom0 enable a device, it will get trigger and polarity from ACPI >> (see acpi_pci_irq_enable) >> I have a version of patch which tried that way, see below: >> >> diff --git a/

[xen-unstable test] 184094: regressions - FAIL

flight 184094 xen-unstable real [real] flight 184098 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/184094/ http://logs.test-lab.xenproject.org/osstest/logs/184098/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

[ovmf test] 184097: all pass - PUSHED

flight 184097 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184097/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 725acd0b9cc047b20a1b9379e46f05d3ebcf485e baseline version: ovmf 1d50544aa2321e4efcd9c

Re: [XEN PATCH v3 1/3] xen/x86: add missing instances of asmlinkage attributes

On Mon, 11 Dec 2023, Nicola Vetrini wrote: > No functional change. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH 7/7] x86/xstate: move BUILD_BUG_ON to address MISRA C:2012 Rule 2.1

On Mon, 11 Dec 2023, Nicola Vetrini wrote: > The string literal inside the expansion of BUILD_BUG_ON is considered > unreachable code; however, such statement can be moved earlier > with no functional change. > > Signed-off-by: Nicola Vetrini > --- > The motivation for this code movement is that

Re: [XEN PATCH 6/7] x86/platform: removed break to address MISRA C:2012 Rule 2.1

On Mon, 11 Dec 2023, Nicola Vetrini wrote: > The break statement is redundant, hence it can be removed. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH 4/7] xen/sched: address MISRA C:2012 Rule 2.1

On Mon, 11 Dec 2023, Nicola Vetrini wrote: > The break statement after the return statement is definitely unreachable > and can be removed with no functional change. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini

Re: [XEN PATCH 2/7] x86/mm: address MISRA C:2012 Rule 2.1

On Mon, 11 Dec 2023, Nicola Vetrini wrote: > The "return 0" after the swich statement in 'xen/arch/x86/mm.c' > is unreachable because all switch clauses end with returns. > However, some of them can be substituted with "break"s to allow > the "return 0" outside the switch to be reachable. > > No f

Re: [XEN PATCH 1/7] xen/shutdown: address MISRA C:2012 Rule 2.1

On Mon, 11 Dec 2023, Nicola Vetrini wrote: > Given that 'hwdom_shutdown' is a noreturn function, unreachable > breaks can be eliminated to resolve violations of Rule 2.1. > On the occasion, the type of its parameter is changed to uint8_t. > > No functional change. > > Signed-off-by: Nicola Vetrin

Re: [XEN PATCH 5/7] xen/arm: traps: add ASSERT_UNREACHABLE() where needed

On Mon, 11 Dec 2023, Nicola Vetrini wrote: > On 2023-12-11 17:05, Julien Grall wrote: > > On 11/12/2023 15:59, Julien Grall wrote: > > > Hi Nicola, > > > > > > On 11/12/2023 14:54, Nicola Vetrini wrote: > > > > On 2023-12-11 13:32, Julien Grall wrote: > > > > > Hi, > > > > > > > > > > On 11/12/20

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

On Mon, 11 Dec 2023, Roger Pau Monné wrote: > On Tue, Dec 05, 2023 at 06:34:35PM -0800, Stefano Stabellini wrote: > > On Tue, 5 Dec 2023, Roger Pau Monné wrote: > > > > > > I don't think we should enable IOREQ servers to handle PCI > > > > > > passthrough > > > > > > for PVH guests and/or guests w

Re: [PATCH RFC v2 for-6.8/block 15/18] buffer: add a new helper to read sb block

Hi, 在 2023/12/12 1:27, Jan Kara 写道: On Mon 11-12-23 22:07:53, Yu Kuai wrote: From: Yu Kuai Unlike __bread_gfp(), ext4 has special handing while reading sb block: 1) __GFP_NOFAIL is not set, and memory allocation can fail; 2) If buffer write failed before, set buffer uptodate and don't read

Re: [PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis

Hi, 在 2023/12/12 0:52, Jan Kara 写道: On Mon 11-12-23 22:05:35, Yu Kuai wrote: From: Yu Kuai Those apis will be used for other modules, so that bd_inode won't be accessed directly from other modules. Signed-off-by: Yu Kuai ... +void bdev_associated_mapping(struct block_device *bdev, +

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

On 11/27/2023 9:28 PM, Stefano Stabellini wrote: > On Mon, 27 Nov 2023, Chuck Zmudzinski wrote: >> On 11/27/2023 10:22 AM, Chuck Zmudzinski wrote: >> > On 11/27/2023 7:45 AM, Mario Marietto wrote: >> >> @Chuck Zmudzinski : Stay tuned. They want >> >> to help us. The

[ovmf test] 184095: all pass - PUSHED

flight 184095 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184095/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1d50544aa2321e4efcd9c193d534fb4096d64dbf baseline version: ovmf aa2f32cefa567133d94d5

Re: [RFC PATCH] xen/arm: Add emulation of Debug Data Transfer Registers

On Mon, 11 Dec 2023, Ayan Kumar Halder wrote: > On 11/12/2023 09:33, Julien Grall wrote: > > Hi, > > Hi Julien/Stefano/Bertrand/Michal, > > It is a great discussion, thanks for your suggestions. > > I think we have an agreement. :-) > > > > > On 07/12/2023 21:41, Stefano Stabellini wrote: > >

[linux-linus test] 184092: regressions - FAIL

flight 184092 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184092/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 6 kernel-build fail REGR. vs. 183973 Tests which are fai

Re: xc_dom_guest_type: image not capable of booting inside a HV M container: Invalid kernel

My apologies for the mistake I made on the experiment n. 2 ; I have used my X86 System,but I should have used the Arm chromebook :) Anyway : root@devuan-bunsen:/mnt/zroot2/zroot2/OS/Chromebook/domU/freebsd-xen# ./start-freebsd Parsing config from freebsd.cfg xc: error: panic: xg_dom_core.c:689:

Re: [PATCH] security-process.pandoc: Statement on issuing XSAs for older versions of Xen

On Fri, Oct 27, 2023 at 03:26:02PM +0100, George Dunlap wrote: > We recently had a situation where a security issue was discovered > which only affected versions of Xen out of security support from an > upstream perspective. However, many downstreams (including XenServer > and SUSE) still had supp

Re: xc_dom_guest_type: image not capable of booting inside a HV M container: Invalid kernel

Experiment n. 2 : Below I have applied the zImage patch of Julien to the Elliott Mitchell code : https://xenbits.xen.org/gitweb/?p=people/julieng/freebsd.git;a=commit;h=12a7cb346b88c6d3f52a20b98f361dc62797fbcd and I've used the kernel generated by the Elliott MItchell code : root@marietto:/mnt/z

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

On Mon, 2023-12-11 at 18:49 +0100, Jan Beulich wrote: > On 11.12.2023 18:37, Oleksii wrote: > > On Mon, 2023-12-11 at 17:02 +0100, Jan Beulich wrote: > > >  In which case the approach taken here may be fine, but > > > it still wouldn't be what I suggested. It may then be Stefano or > > > Andrew > >

Re: [PATCH] docs: Document a policy for when to deviate from specifications

Hi George, Sorry for the late reply. On 18/09/2023 13:28, George Dunlap wrote: There is an ongoing disagreement among maintainers for how Xen should handle deviations to specifications such as ACPI or EFI. Write up an explicit policy, and include two worked-out examples from recent discussions

Re: [PATCH] xen/pci: fix phantom error path in assign_device()

On 12/11/23 11:21, Jan Beulich wrote: > On 11.12.2023 16:05, Stewart Hildebrand wrote: >> Currently if an iommu_call() for a phantom function fails, there is no >> indication of the failure. Propagate (but don't return) the error code >> from the most recently failed iommu_call() and emit a warning

Re: [PATCH] tools/xenstored: potentially split trace_io() out message

Hi Juergen, On 23/11/2023 16:08, Juergen Gross wrote: Today write_messages() will call trace_io() after having written the complete message to the ring buffer or socket. In case the message can't be written in one go, split it by writing one trace entry when starting the write and one when fini

Re: [PATCH] tools/pygrub: Drop compatibility symlink

On 11/12/2023 5:07 pm, Anthony PERARD wrote: > On Thu, Nov 23, 2023 at 04:30:23PM +, Andrew Cooper wrote: >> This was declared deprecated in commit 10c88f1c18b7 ("tools: Install pv >> bootloaders in libexec rather than /usr/bin") in 2012 > This commit only speak about wanting to deprecate the f

[ovmf test] 184093: all pass - PUSHED

flight 184093 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184093/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf aa2f32cefa567133d94d574672a4479e004211ee baseline version: ovmf 5b5481526fc9b89e5f384

[xen-unstable test] 184089: regressions - FAIL

flight 184089 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184089/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 184031

Re: xc_dom_guest_type: image not capable of booting inside a HV M container: Invalid kernel

On 12/11/2023 12:59 PM, Mario Marietto wrote: > root@marietto:/mnt/zroot2/zroot2/OS/Chromebook/domU/freebsd-xen/boot-xen/kernel > # file > /mnt/zroot2/zroot2/OS/Chromebook/domU/freebsd-xen/boot-xen/kernel/kernel > > ELF 32-bit LSB executable,ARM, EABI5 version 1 (FreeBSD), dynamically linked, >

Re: xc_dom_guest_type: image not capable of booting inside a HV M container: Invalid kernel

root@marietto:/mnt/zroot2/zroot2/OS/Chromebook/domU/freebsd-xen/boot-xen/kernel # file /mnt/zroot2/zroot2/OS/Chromebook/domU/freebsd-xen/boot-xen/kernel/kernel ELF 32-bit LSB executable,ARM, EABI5 version 1 (FreeBSD), dynamically linked, interpreter /red/herring, BuildID[sha1]=5e6982c9cb67d9c9457

Re: [RFC KERNEL PATCH v3 3/3] PCI/sysfs: Add gsi sysfs for pci_dev

On Mon, Dec 11, 2023 at 12:15:19AM +0800, Jiqian Chen wrote: > There is a need for some scenarios to use gsi sysfs. > For example, when xen passthrough a device to dumU, it will > use gsi to map pirq, but currently userspace can't get gsi > number. > So, add gsi sysfs for that and for other potenti

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

On 11.12.2023 18:37, Oleksii wrote: > On Mon, 2023-12-11 at 17:02 +0100, Jan Beulich wrote: >>  In which case the approach taken here may be fine, but >> it still wouldn't be what I suggested. It may then be Stefano or >> Andrew >> who you could consider for such a tag. > I'm a bit confused again.

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

On Mon, 2023-12-11 at 17:02 +0100, Jan Beulich wrote: > On 11.12.2023 15:43, Oleksii wrote: > > On Mon, 2023-12-04 at 11:39 +0100, Jan Beulich wrote: > > > On 04.12.2023 11:34, Oleksii wrote: > > > > If you ( or anyone else ) don't mind, I'll update the patch > > > > with an > > > > introduction of

Re: [XEN PATCH 5/7] xen/arm: traps: add ASSERT_UNREACHABLE() where needed

On 2023-12-11 17:05, Julien Grall wrote: On 11/12/2023 15:59, Julien Grall wrote: Hi Nicola, On 11/12/2023 14:54, Nicola Vetrini wrote: On 2023-12-11 13:32, Julien Grall wrote: Hi, On 11/12/2023 10:30, Nicola Vetrini wrote: The branches of the switch after a call to 'do_unexpected_trap' can

Re: [PATCH RFC v2 for-6.8/block 15/18] buffer: add a new helper to read sb block

On Mon 11-12-23 22:07:53, Yu Kuai wrote: > From: Yu Kuai > > Unlike __bread_gfp(), ext4 has special handing while reading sb block: > > 1) __GFP_NOFAIL is not set, and memory allocation can fail; > 2) If buffer write failed before, set buffer uptodate and don't read >block from disk; > 3) RE

Re: xc_dom_guest_type: image not capable of booting inside a HV M container: Invalid kernel

On 12/11/2023 9:02 AM, Mario Marietto wrote: > Hello. > > Finally I tried to recompile the FreeBSD kernel using the @Elliott Mitchell > code because I want to boot FreeBSD as domU > with Xen installed on my Arm 32 bit Chromebook. Unfortunately it didn't work > at a

Re: [PATCH RFC v2 for-6.8/block 16/18] ext4: use new helper to read sb block

On Mon 11-12-23 22:08:08, Yu Kuai wrote: > From: Yu Kuai > > Remove __ext4_sb_bread_gfp() and ext4_buffer_uptodate() that is defined > by ext4, and convert to use common helper __bread_gfp2() and > buffer_uptodate_or_error(). > > Signed-off-by: Yu Kuai Looks good. Feel free to add: Reviewed-b

Re: INFORMAL VOTE REQUIRED - DOCUMENTATION WORDING

On Fri, 2023-12-01 at 10:27 +, George Dunlap wrote: > > FWIW I think a "five-point survey" would probably have been somewhat better: > > Regarding the review insisting that the word "broken" be removed from > the updated documentation to the old hypercall: (✔) I think this sort of enforcemen

Re: [PATCH] tools/pygrub: Drop compatibility symlink

On Fri, Dec 08, 2023 at 03:43:16PM +, George Dunlap wrote: > On Fri, Dec 8, 2023 at 3:36 PM Julien Grall wrote: > > > See above, I think this code is under the remit of Anthony. You haven't > > CCed him so no surprise no-one answered. > > Additionally, my old citrix address *was* cc'd, but I

Re: [PATCH] tools/pygrub: Drop compatibility symlink

On Thu, Nov 23, 2023 at 04:30:23PM +, Andrew Cooper wrote: > This was declared deprecated in commit 10c88f1c18b7 ("tools: Install pv > bootloaders in libexec rather than /usr/bin") in 2012 This commit only speak about wanting to deprecate the full path to `pygrub`, and calling something deprec

Re: [PATCH RFC v2 for-6.8/block 17/18] ext4: remove block_device_ejected()

On Mon 11-12-23 22:08:33, Yu Kuai wrote: > From: Yu Kuai > > block_device_ejected() is added by commit bdfe0cbd746a ("Revert > "ext4: remove block_device_ejected"") in 2015. At that time 'bdi->wb' > is destroyed synchronized from del_gendisk(), hence if ext4 is still > mounted, and then mark_buff

Re: [PATCH RFC v2 for-6.8/block 18/18] ext4: use bdev apis

On Mon 11-12-23 22:08:39, Yu Kuai wrote: > From: Yu Kuai > > Avoid to access bd_inode directly, prepare to remove bd_inode from > block_devcie. ^^^ device > Signed-off-by: Yu Kuai Looks good. Feel free to add: Reviewed-by: Jan Kara

Re: [PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis

On Mon 11-12-23 22:05:35, Yu Kuai wrote: > From: Yu Kuai > > Those apis will be used for other modules, so that bd_inode won't be > accessed directly from other modules. > > Signed-off-by: Yu Kuai ... > +void bdev_associated_mapping(struct block_device *bdev, > + stru

Re: [PATCH] xen/pci: fix phantom error path in assign_device()

On 11.12.2023 16:05, Stewart Hildebrand wrote: > Currently if an iommu_call() for a phantom function fails, there is no > indication of the failure. Propagate (but don't return) the error code > from the most recently failed iommu_call() and emit a warning. While > here, add a comment to clarify th

Re: [XEN PATCH] xen/arm: smmu: move phys_addr_t definition to linux-compat.h

On 11.12.2023 15:54, Federico Serafini wrote: > --- a/xen/include/xen/linux-compat.h > +++ b/xen/include/xen/linux-compat.h > @@ -16,5 +16,6 @@ typedef uint8_t __u8; > typedef int16_t __s16; > typedef int32_t __s32; > typedef int64_t __s64; > +typedef paddr_t phys_addr_t; Nit: Wants a blank lin

Re: [XEN PATCH 5/7] xen/arm: traps: add ASSERT_UNREACHABLE() where needed

On 11/12/2023 15:59, Julien Grall wrote: Hi Nicola, On 11/12/2023 14:54, Nicola Vetrini wrote: On 2023-12-11 13:32, Julien Grall wrote: Hi, On 11/12/2023 10:30, Nicola Vetrini wrote: The branches of the switch after a call to 'do_unexpected_trap' cannot return, but there is one path that

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

On 11.12.2023 15:43, Oleksii wrote: > On Mon, 2023-12-04 at 11:39 +0100, Jan Beulich wrote: >> On 04.12.2023 11:34, Oleksii wrote: >>> If you ( or anyone else ) don't mind, I'll update the patch with an >>> introduction of HAS_GRANT_TABLE. >> >> I won't NAK such a patch, but unless convincing argum

Re: [XEN PATCH 5/7] xen/arm: traps: add ASSERT_UNREACHABLE() where needed

Hi Nicola, On 11/12/2023 14:54, Nicola Vetrini wrote: On 2023-12-11 13:32, Julien Grall wrote: Hi, On 11/12/2023 10:30, Nicola Vetrini wrote: The branches of the switch after a call to 'do_unexpected_trap' cannot return, but there is one path that may return, hence only some clauses are marke

Re: [RFC PATCH v1 1/1] xen/Makefile: introduce ARCH_FIXED_CONFIG for randconfig

On 07.12.2023 21:17, Andrew Cooper wrote: > On 07/12/2023 5:03 pm, Oleksii Kurochko wrote: >> ARCH_FIXED_CONFIG is required in the case of randconfig >> and CI for configs that aren't ready or are not >> supposed to be implemented for specific architecture. >> These configs should always be disable

Re: [RFC XEN PATCH v3 3/3] libxl: Use gsi instead of irq for mapping pirq

On Mon, Dec 11, 2023 at 12:40:09AM +0800, Jiqian Chen wrote: > In PVH dom0, it uses the linux local interrupt mechanism, > when it allocs irq for a gsi, it is dynamic, and follow > the principle of applying first, distributing first. And > the irq number is alloced from small to large, but the > ap

Re: [RFC KERNEL PATCH v2 2/3] xen/pvh: Unmask irq for passthrough device in PVH dom0

On Wed, Dec 06, 2023 at 06:07:26AM +, Chen, Jiqian wrote: > On 2023/12/5 18:32, Jan Beulich wrote: > > On 05.12.2023 10:19, Roger Pau Monné wrote: > >> On Mon, Dec 04, 2023 at 02:19:33PM -0800, Stefano Stabellini wrote: > >>> On Mon, 4 Dec 2023, Roger Pau Monné wrote: > On Fri, Dec 01, 202

Re: [RFC QEMU PATCH v3 1/1] xen: Use gsi instead of irq for mapping pirq

On Mon, Dec 11, 2023 at 12:52:40AM +0800, Jiqian Chen wrote: > In PVH dom0, it uses the linux local interrupt mechanism, > when it allocs irq for a gsi, it is dynamic, and follow > the principle of applying first, distributing first. And > the irq number is alloced from small to large, but the > ap

Re: [RFC XEN PATCH v3 2/3] x86/pvh: Add (un)map_pirq and setup_gsi for PVH dom0

On Mon, Dec 11, 2023 at 12:40:08AM +0800, Jiqian Chen wrote: > If run Xen with PVH dom0 and hvm domU, hvm will map a pirq for > a passthrough device by using gsi, see > xen_pt_realize->xc_physdev_map_pirq and > pci_add_dm_done->xc_physdev_map_pirq. Then xc_physdev_map_pirq > will call into Xen, but

Re: [RFC XEN PATCH v3 1/3] xen/vpci: Clear all vpci status of device

On Mon, Dec 11, 2023 at 12:40:07AM +0800, Jiqian Chen wrote: > When a device has been reset on dom0 side, the vpci on Xen > side won't get notification, so the cached state in vpci is > all out of date compare with the real device state. > To solve that problem, add a new hypercall to clear all vpc

[xen-unstable-smoke test] 184091: tolerable all pass - PUSHED

flight 184091 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184091/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH] xen/pci: fix phantom error path in assign_device()

Currently if an iommu_call() for a phantom function fails, there is no indication of the failure. Propagate (but don't return) the error code from the most recently failed iommu_call() and emit a warning. While here, add a comment to clarify that the loop keeps iterating even when failure is encoun

[XEN PATCH] xen/arm: smmu: move phys_addr_t definition to linux-compat.h

Both smmu and smmu-v3 (ported from Linux) define the typedef name "phys_addr_t": move the type definition to the common header linux-compat.h to address violations of MISRA C:2012 Rule 5.6 ("A typedef name shall be a unique identifier"). No functional change. Suggested-by: Jan Beulich Suggested-b

Re: [XEN PATCH 5/7] xen/arm: traps: add ASSERT_UNREACHABLE() where needed

On 2023-12-11 13:32, Julien Grall wrote: Hi, On 11/12/2023 10:30, Nicola Vetrini wrote: The branches of the switch after a call to 'do_unexpected_trap' cannot return, but there is one path that may return, hence only some clauses are marked with ASSERT_UNREACHABLE(). I don't understand why this

Re: [XEN PATCH 3/7] xen/arm: address MISRA C:2012 Rule 2.1

On 2023-12-11 15:14, Julien Grall wrote: On 11/12/2023 13:06, Michal Orzel wrote: On 11/12/2023 13:29, Julien Grall wrote: Hi, On 11/12/2023 10:30, Nicola Vetrini wrote: The "return 1;" statements at the end of some cases in the switch of function 'vgic_v3_its_mmio_write' in 'vcig-v3-its.

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

On Mon, 2023-12-04 at 11:39 +0100, Jan Beulich wrote: > On 04.12.2023 11:34, Oleksii wrote: > > If you ( or anyone else ) don't mind, I'll update the patch with an > > introduction of HAS_GRANT_TABLE. > > I won't NAK such a patch, but unless convincing arguments appear I > also > won't ACK it. I a

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

> > Information coming from AML is required to be handed down by Dom0 to Xen. > > May want checking that (a) Dom0 properly does so and (b) Xen doesn't screw > > up in consuming that data. See PHYSDEVOP_setup_gsi. I wonder if this is > > specific to it being IRQ7 which GPIO uses, as at the (master)

[PATCH RFC v2 for-6.8/block 18/18] ext4: use bdev apis

From: Yu Kuai Avoid to access bd_inode directly, prepare to remove bd_inode from block_devcie. Signed-off-by: Yu Kuai --- fs/ext4/dir.c | 6 ++ fs/ext4/ext4_jbd2.c | 6 +++--- fs/ext4/super.c | 3 +-- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/fs/ext4/dir.c b/

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

Le lun. 11 déc. 2023 à 12:27, Jan Beulich a écrit : > > On 11.12.2023 12:09, Sébastien Chaumat wrote: > > Le lun. 11 déc. 2023 à 10:18, Sébastien Chaumat a > > écrit : > >> > >>> On 05.12.2023 21:31, Sébastien Chaumat wrote: > > [2.464598] amd_gpio AMDI0030:00: failed to enable wake-up i

Re: [XEN PATCH 3/7] xen/arm: address MISRA C:2012 Rule 2.1

On 11/12/2023 13:06, Michal Orzel wrote: On 11/12/2023 13:29, Julien Grall wrote: Hi, On 11/12/2023 10:30, Nicola Vetrini wrote: The "return 1;" statements at the end of some cases in the switch of function 'vgic_v3_its_mmio_write' in 'vcig-v3-its.c' cause the unreachability of the "ret

[PATCH RFC v2 for-6.8/block 17/18] ext4: remove block_device_ejected()

From: Yu Kuai block_device_ejected() is added by commit bdfe0cbd746a ("Revert "ext4: remove block_device_ejected"") in 2015. At that time 'bdi->wb' is destroyed synchronized from del_gendisk(), hence if ext4 is still mounted, and then mark_buffer_dirty() will reference destroyed 'wb'. However, su

[PATCH RFC v2 for-6.8/block 16/18] ext4: use new helper to read sb block

From: Yu Kuai Remove __ext4_sb_bread_gfp() and ext4_buffer_uptodate() that is defined by ext4, and convert to use common helper __bread_gfp2() and buffer_uptodate_or_error(). Signed-off-by: Yu Kuai --- fs/ext4/ext4.h| 13 - fs/ext4/inode.c | 8 fs/ext4/super.c | 4

[PATCH RFC v2 for-6.8/block 15/18] buffer: add a new helper to read sb block

From: Yu Kuai Unlike __bread_gfp(), ext4 has special handing while reading sb block: 1) __GFP_NOFAIL is not set, and memory allocation can fail; 2) If buffer write failed before, set buffer uptodate and don't read block from disk; 3) REQ_META is set for all IO, and REQ_PRIO is set for reading

[PATCH RFC v2 for-6.8/block 14/18] jbd2: use bdev apis

From: Yu Kuai Avoid to access bd_inode directly, prepare to remove bd_inode from block_devcie. Signed-off-by: Yu Kuai --- fs/jbd2/journal.c | 3 +-- fs/jbd2/recovery.c | 6 ++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index ed5318

[PATCH RFC v2 for-6.8/block 12/18] gfs2: use bdev api

From: Yu Kuai Avoid to access bd_inode directly, prepare to remove bd_inode from block_devcie. Signed-off-by: Yu Kuai --- fs/gfs2/glock.c | 2 +- fs/gfs2/ops_fstype.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index d6bf1f8c25d

[PATCH RFC v2 for-6.8/block 13/18] nilfs2: use bdev api in nilfs_attach_log_writer()

From: Yu Kuai Avoid to access bd_inode directly, prepare to remove bd_inode from block_devcie. Signed-off-by: Yu Kuai --- fs/nilfs2/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index 55e31cc903d1..a1130e384937 100644 --

Re: INFORMAL VOTE REQUIRED - DOCUMENTATION WORDING

Hi all, As we haven't yet reached a consensus, let's see what the informal vote looks like in the community by the end of the week. Since the scope and context have changed slightly, anonymous voting is permitted and I will be counting all votes made after Dec 4th. Please only vote once. Should y

[PATCH RFC v2 for-6.8/block 11/18] erofs: use bdev api

From: Yu Kuai Avoid to access bd_inode directly, prepare to remove bd_inode from block_devcie. Signed-off-by: Yu Kuai --- fs/erofs/data.c | 18 -- fs/erofs/internal.h | 2 ++ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/fs/erofs/data.c b/fs/erofs/data.c

[PATCH RFC v2 for-6.8/block 09/18] btrfs: use bdev apis

From: Yu Kuai On the one hand covert to use folio while reading bdev inode, on the other hand prevent to access bd_inode directly. Signed-off-by: Yu Kuai --- fs/btrfs/disk-io.c | 71 +- fs/btrfs/volumes.c | 17 ++- fs/btrfs/zoned.c | 15 +++

[PATCH RFC v2 for-6.8/block 03/18] bcache: use bdev api in read_super()

From: Yu Kuai On the one hand covert to use folio while reading bdev inode, on the other hand prevent to access bd_inode directly. Signed-off-by: Yu Kuai --- drivers/md/bcache/super.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/md/bcache/super.c b/dr

[PATCH RFC v2 for-6.8/block 05/18] s390/dasd: use bdev api in dasd_format()

From: Yu Kuai Avoid to access bd_inode directly, prepare to remove bd_inode from block_devcie. Signed-off-by: Yu Kuai --- drivers/s390/block/dasd_ioctl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/s390/block/dasd_ioctl.c b/drivers/s390/block/dasd_ioctl.c i

[PATCH RFC v2 for-6.8/block 10/18] cramfs: use bdev apis in cramfs_blkdev_read()

From: Yu Kuai On the one hand covert to use folio while reading bdev inode, on the other hand prevent to access bd_inode directly. Also do some cleanup that there is no need for two for loop, and remove local array pages. Signed-off-by: Yu Kuai --- fs/cramfs/inode.c | 36 +

[PATCH RFC v2 for-6.8/block 02/18] xen/blkback: use bdev api in xen_update_blkif_status()

From: Yu Kuai Avoid to access bd_inode directly, prepare to remove bd_inode from block_devcie. Signed-off-by: Yu Kuai --- drivers/block/xen-blkback/xenbus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xen

[PATCH RFC v2 for-6.8/block 06/18] scsicam: use bdev api in scsi_bios_ptable()

From: Yu Kuai Avoid to access bd_inode directly, prepare to remove bd_inode from block_devcie. Signed-off-by: Yu Kuai --- drivers/scsi/scsicam.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/scsicam.c b/drivers/scsi/scsicam.c index e2c7d8ef205f..9617d70c0e

[PATCH RFC v2 for-6.8/block 08/18] bio: export bio_add_folio_nofail()

From: Yu Kuai Currently btrfs is using __bio_add_page() in write_dev_supers(). In order to convert to use folio for bdev in btrfs, export bio_add_folio_nofail() so that it can replace __bio_add_page(). Signed-off-by: Yu Kuai --- block/bio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/b

[PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis

From: Yu Kuai Those apis will be used for other modules, so that bd_inode won't be accessed directly from other modules. Signed-off-by: Yu Kuai --- block/bdev.c | 70 ++ block/blk.h| 2 -- include/linux/blkdev.h | 17 ++ 3

[PATCH RFC v2 for-6.8/block 07/18] bcachefs: remove dead function bdev_sectors()

From: Yu Kuai bdev_sectors() is not used hence remove it. Signed-off-by: Yu Kuai --- fs/bcachefs/util.h | 5 - 1 file changed, 5 deletions(-) diff --git a/fs/bcachefs/util.h b/fs/bcachefs/util.h index 2984b57b2958..22a0acc1704f 100644 --- a/fs/bcachefs/util.h +++ b/fs/bcachefs/util.h @@ -

[PATCH RFC v2 for-6.8/block 00/18] block: don't access bd_inode directly from other modules

From: Yu Kuai Changes in v2: - remove some bdev apis that is not necessary; - pass in offset for bdev_read_folio() and __bdev_get_folio(); - remove bdev_gfp_constraint() and add a new helper in fs/buffer.c to prevent access bd_indoe() directly from mapping_gfp_constraint() in ext4.(patch 15,

[PATCH RFC v2 for-6.8/block 04/18] mtd: block2mtd: use bdev apis

From: Yu Kuai On the one hand covert to use folio while reading bdev inode, on the other hand prevent to access bd_inode directly. Signed-off-by: Yu Kuai --- drivers/mtd/devices/block2mtd.c | 81 +++-- 1 file changed, 36 insertions(+), 45 deletions(-) diff --git a/

xc_dom_guest_type: image not capable of booting inside a HV M container: Invalid kernel

Hello. Finally I tried to recompile the FreeBSD kernel using the @Elliott Mitchell code because I want to boot FreeBSD as domU with Xen installed on my Arm 32 bit Chromebook. Unfortunately it didn't work at all. Maybe I've missed something / I haven't understood well what to do. Please give me so

[PATCH 3/3] Mini-OS: cleanup hypervisor.c

Do the following cleanups in hypervisor.c: - Let hypervisor.c conform to the coding style. - Drop the bogus "inline" attributes of exported functions. - Replace a always zero cpu variable with smp_processor_id() as elsewhere in the code. - Replace "if () BUG()" with BUG_ON() in case the conditio

[PATCH 1/3] Mini-OS: call event handlers always with interrupts off

When unmasking an event channel the associated event handler can be called with interrupts enabled when not running as a PV guest. This can result in hard to debug races in case e.g. a handler is registered for multiple events or when the handler is not using a lock as it assumes to have interrupt

[PATCH 2/3] Mini-OS: drop in_callback variable

Now that do_hypervisor_callback() is always called with interrupts off the in_callback variable meant to handle recursive calls of do_hypervisor_callback() can be dropped. As a precaution add a test to do_hypervisor_callback() that interrupts are really disabled and crash in case this is not true.

[PATCH 0/3] Mini-OS: fix and cleanup of event handling

Patch 1 fixes an issue when running as PVH guest Patches 2 + 3 are cleanups Juergen Gross (3): Mini-OS: call event handlers always with interrupts off Mini-OS: drop in_callback variable Mini-OS: cleanup hypervisor.c hypervisor.c | 94 +++- in

Re: [XEN PATCH 4/7] xen/sched: address MISRA C:2012 Rule 2.1

On Mon, Dec 11, 2023 at 10:30 AM Nicola Vetrini wrote: > > The break statement after the return statement is definitely unreachable > and can be removed with no functional change. > > Signed-off-by: Nicola Vetrini Acked-by: George Dunlap

[ovmf test] 184090: all pass - PUSHED

flight 184090 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184090/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5b5481526fc9b89e5f3843d9bb3d6c4f5ce41060 baseline version: ovmf bb13a4adabcf0e5a16085

Re: [XEN PATCH v2 5/5] AMD/IOMMU: address violations of MISRA C:2012 Rule 8.2

On 08.12.2023 01:39, Stefano Stabellini wrote: > On Thu, 7 Dec 2023, Federico Serafini wrote: >> Add missing parameter names to address violations of MISRA C:2012 >> Rule 8.2. Remove trailing spaces and use C standard types to comply >> with XEN coding style. No functional change. >> >> Signed-off-

Re: [RFC 00/41] qom-topo: Abstract Everything about CPU Topology

Hi maintainers, Just a ping. Welcome your feedbacks! We wonder if the current RFC is an appropriate attempt towards the final hybrid topology. Thanks, Zhao On Thu, Nov 30, 2023 at 10:41:22PM +0800, Zhao Liu wrote: > Date: Thu, 30 Nov 2023 22:41:22 +0800 > From: Zhao Liu > Subject: [RFC 00/41]

Re: [XEN PATCH v2 4/5] x86/mm: address violations of MISRA C:2012 Rule 8.2

On 08.12.2023 01:40, Stefano Stabellini wrote: > On Thu, 7 Dec 2023, Federico Serafini wrote: >> Add missing parameter names. No functional change. >> >> Signed-off-by: Federico Serafini > > Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich

  1   2   >