Re: [PATCH v4 13/14] xen: ifdef inclusion of in

2023-11-27 Thread Jan Beulich
On 27.11.2023 20:38, Oleksii wrote: > On Mon, 2023-11-27 at 15:41 +0100, Jan Beulich wrote: >> On 27.11.2023 15:13, Oleksii Kurochko wrote: >>> --- a/xen/arch/ppc/include/asm/grant_table.h >>> +++ /dev/null >>> @@ -1,5 +0,0 @@ >>> -/* SPDX-License-Identifier: GPL-2.0-only */ >>> -#ifndef __ASM_PPC_

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-27 Thread Jan Beulich
On 27.11.2023 20:46, Oleksii wrote: > On Mon, 2023-11-27 at 15:31 +0100, Jan Beulich wrote: >> On 27.11.2023 15:13, Oleksii Kurochko wrote: >>> --- a/xen/arch/ppc/include/asm/irq.h >>> +++ b/xen/arch/ppc/include/asm/irq.h >>> @@ -3,7 +3,9 @@ >>>  #define __ASM_PPC_IRQ_H__ >>>   >>>  #include >>> +

[ovmf test] 183879: all pass - PUSHED

2023-11-27 Thread osstest service owner
flight 183879 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183879/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0e9ce9146a6dc50a35488e3a4a7a2a4bbaf1eb1c baseline version: ovmf 8736b8fdca85e02933cdb

Re: [PATCH v2] xen/events: fix error code in xen_bind_pirq_msi_to_irq()

2023-11-27 Thread Juergen Gross
On 28.11.23 07:52, Dan Carpenter wrote: Return -ENOMEM if xen_irq_init() fails. currently the code returns an uninitialized variable or zero. Fixes: 5dd9ad32d775 ("xen/events: drop xen_allocate_irqs_dynamic()") Signed-off-by: Dan Carpenter Reviewed-by: Juergen Gross Juergen OpenPGP_0xB

[xen-unstable-smoke test] 183878: regressions - all pass

2023-11-27 Thread osstest service owner
flight 183878 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183878/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 7 xen-build/dist-test fail REGR. vs. 183851 build-arm64-

[PATCH v2] xen/events: fix error code in xen_bind_pirq_msi_to_irq()

2023-11-27 Thread Dan Carpenter
Return -ENOMEM if xen_irq_init() fails. currently the code returns an uninitialized variable or zero. Fixes: 5dd9ad32d775 ("xen/events: drop xen_allocate_irqs_dynamic()") Signed-off-by: Dan Carpenter --- v2: Part of v1 was bogus. Delete that bit. drivers/xen/events/events_base.c | 4 +++- 1 f

Inquiry Regarding Usage of Xen Project Images for Private T-shirt Printing

2023-11-27 Thread Emely Vollmer
Dear Xen Project Team, I trust this message finds you well. My name is Emely. I am an avid supporter and admirer of the Xen Project, and I am writing to seek your guidance and permission regarding the use of your images for personal, non-commercial purposes. I have recently been exploring ways to

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-27 Thread Elliott Mitchell
On Mon, Nov 27, 2023 at 10:57:42AM -0500, Chuck Zmudzinski wrote: > On 11/27/2023 10:22 AM, Chuck Zmudzinski wrote: > > > > I have been collaborating with Mario, and I can explain what we have done > > so far : > > > > We are using Julien's patch set against an old development version of > > Fr

Re: [PATCH block/for-next v2 01/16] block: add a new helper to get inode from block_device

2023-11-27 Thread Christoph Hellwig
On Tue, Nov 28, 2023 at 09:35:56AM +0800, Yu Kuai wrote: > Thanks for the advice! In case I'm understanding correctly, do you mean > that all other fs/drivers that is using pages versions can safely switch > to folio versions now? If you never allocate a high-order folio pages are identical to fol

[ovmf test] 183875: trouble: blocked/broken

2023-11-27 Thread osstest service owner
flight 183875 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183875/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-27 Thread Stefano Stabellini
On Mon, 27 Nov 2023, Chuck Zmudzinski wrote: > On 11/27/2023 10:22 AM, Chuck Zmudzinski wrote: > > On 11/27/2023 7:45 AM, Mario Marietto wrote: > >> @Chuck Zmudzinski : Stay tuned. They want > >> to help us. The xen developers are great. Very good support for us. I'm

[xen-unstable-smoke test] 183874: trouble: blocked/broken

2023-11-27 Thread osstest service owner
flight 183874 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183874/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-arm64-xs

Re: [PATCH block/for-next v2 01/16] block: add a new helper to get inode from block_device

2023-11-27 Thread Yu Kuai
Hi, 在 2023/11/28 0:32, Christoph Hellwig 写道: On Mon, Nov 27, 2023 at 09:07:22PM +0800, Yu Kuai wrote: 1) Is't okay to add a new helper to pass in bdev for following apis? For some we already have them (e.g. bdev_nr_bytes to read the bdev) size, for some we need to add them. The big thing th

Re: [EXTERNAL] [PATCH v3 2/5] xen: backends: don't overwrite XenStore nodes created by toolstack

2023-11-27 Thread Volodymyr Babchuk
Hi David, Thank you for the review David Woodhouse writes: > [[S/MIME Signed Part:Undecided]] > On Fri, 2023-11-24 at 23:24 +, Volodymyr Babchuk wrote: >> Xen PV devices in QEMU can be created in two ways: either by QEMU >> itself, if they were passed via command line, or by Xen toolstack.

[linux-linus test] 183873: trouble: blocked/broken

2023-11-27 Thread osstest service owner
flight 183873 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183873/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-27 Thread Mario Marietto
Hello. I know two FreeBSD developers that can commit your patches,if they think that they are good. I could drop an email to them. I've hardly helped one of them with the testing when we have implemented the passthrough of a recent nvidia gpu on Linux. The second one is experienced with arm and vi

[ovmf test] 183870: trouble: blocked/broken

2023-11-27 Thread osstest service owner
flight 183870 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183870/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

Re: [PATCH v3 28/32] Mini-OS: add EXPORT_SYMBOL() instances to tpmback.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:19 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to tpmback.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > tpmback.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --g

Re: [PATCH v3 27/32] Mini-OS: add EXPORT_SYMBOL() instances to pcifront.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:18 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to pcifront.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > pcifront.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion

Re: [PATCH v3 24/32] Mini-OS: add EXPORT_SYMBOL() instances to blkfront.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:15 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to blkfront.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > blkfront.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletion

Re: [PATCH v3 31/32] Mini-OS: add EXPORT_SYMBOL() instances to xenbus.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:22 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to xenbus.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > xenbus.c | 23 +++ > 1 file changed, 23 insertions(+) >

Re: [PATCH v3 23/32] Mini-OS: add EXPORT_SYMBOL() instances to 9pfront.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:14 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to 9pfront.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > 9pfront.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/9pfron

Re: [PATCH v3 32/32] Mini-OS: hide all symbols not exported via EXPORT_SYMBOLS()

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:23 +0100, a ecrit: > When doing the final linking of the Mini-OS kernel only keep the > symbols visible which have been marked via EXPORT_SYMBOL(). > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > Makefil

Re: [PATCH v3 25/32] Mini-OS: add EXPORT_SYMBOL() instances to fbfront.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:16 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to fbfront.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > fbfront.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-

Re: [PATCH v3 29/32] Mini-OS: add EXPORT_SYMBOL() instances to tpmfront.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:20 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to tpmfront.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > tpmfront.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/

Re: [PATCH v3 00/32] Mini-OS: hide mini-os internal symbols

2023-11-27 Thread Samuel Thibault
Hello, Juergen Gross, le lun. 27 nov. 2023 11:24:51 +0100, a ecrit: > Mini-OS: add EXPORT_SYMBOL() instances to ioremap.c > Mini-OS: add EXPORT_SYMBOL() instances to lwip-*.c > Mini-OS: add EXPORT_SYMBOL() instances to netfront.c > Mini-OS: add EXPORT_SYMBOL() instances to tpm_tis.c I did

Re: [RFC PATCH v2 17/19] heki: x86: Update permissions counters during text patching

2023-11-27 Thread Peter Zijlstra
On Mon, Nov 27, 2023 at 10:48:29AM -0600, Madhavan T. Venkataraman wrote: > Apologies for the late reply. I was on vacation. Please see my response below: > > On 11/13/23 02:19, Peter Zijlstra wrote: > > On Sun, Nov 12, 2023 at 09:23:24PM -0500, Mickaël Salaün wrote: > >> From: Madhavan T. Venkata

Re: [PATCH v3 11/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/ctype.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:02 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/ctype.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/ctype.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/li

Re: [PATCH v3 20/32] Mini-OS: add EXPORT_SYMBOL() instances to lock.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:11 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lock.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lock.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > dif

Re: [PATCH v3 14/32] Mini-OS: add EXPORT_SYMBOL() instances to main.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:05 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to main.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/main.c b/ma

Re: [PATCH v3 13/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/xs.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:04 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/xs.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/xs.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [PATCH v3 21/32] Mini-OS: add EXPORT_SYMBOL() instances to time.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:12 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to time.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > arch/arm/time.c | 1 + > arch/x86/time.c | 2 +- > 2 files changed, 2 insertion

Re: [PATCH v3 16/32] Mini-OS: add EXPORT_SYMBOL() instances to events.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:07 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to events.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > events.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/eve

Re: [PATCH v3 15/32] Mini-OS: add EXPORT_SYMBOL() instances to console.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:06 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to console.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > console.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/con

Re: [PATCH v3 06/32] Mini-OS: add EXPORT_SYMBOL() instances to mm.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:24:57 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to mm.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > arch/arm/mm.c | 2 ++ > arch/x86/mm.c | 5 + > mm.c | 4 > 3 fi

Re: [RFC PATCH v2 18/19] heki: x86: Protect guest kernel memory using the KVM hypervisor

2023-11-27 Thread Peter Zijlstra
On Mon, Nov 27, 2023 at 11:05:23AM -0600, Madhavan T. Venkataraman wrote: > Apologies for the late reply. I was on vacation. Please see my response below: > > On 11/13/23 02:54, Peter Zijlstra wrote: > > On Sun, Nov 12, 2023 at 09:23:25PM -0500, Mickaël Salaün wrote: > >> From: Madhavan T. Venkata

Re: [PATCH v3 18/32] Mini-OS: add EXPORT_SYMBOL() instances to gnttab.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:09 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to gnttab.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > gnttab.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/gntt

Re: [PATCH v3 17/32] Mini-OS: add EXPORT_SYMBOL() instances to gntmap.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:08 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to gntmap.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > gntmap.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/gntma

Re: [PATCH v3 10/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/printf.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:01 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/printf.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/printf.c | 10 +- > 1 file changed, 9 insertions(+), 1 deleti

Re: [PATCH v3 12/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/xmalloc.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:03 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/xmalloc.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/xmalloc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCH v3 08/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/string.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:24:59 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/string.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/string.c | 18 ++ > 1 file changed, 18 insertions(+)

Re: [PATCH v3 09/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/math.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:00 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/math.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/math.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/

Re: [PATCH v3 07/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/sys.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:24:58 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/sys.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/sys.c | 92 --- > 1

Re: [PATCH v3 05/32] Mini-OS: add EXPORT_SYMBOL() instances to sched.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:24:56 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to sched.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > arch/x86/sched.c | 5 + > sched.c | 7 +++ > 2 files changed,

Re: [PATCH v3 04/32] Mini-OS: add EXPORT_SYMBOL() instances to hypervisor.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:24:55 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to hypervisor.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > hypervisor.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [PATCH v3 02/32] Mini-OS: explicitly mark symbols to be visible for apps

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:24:53 +0100, a ecrit: > Add an EXPORT_SYMBOL() macro to explicitly mark a symbol to be visible > for an app or library linked with Mini-OS. This prepares hiding all > other symbols from external components, avoiding any problems with > duplicate symbol names.

Re: [PATCH v3 03/32] Mini-OS: add EXPORT_SYMBOL() instances to kernel.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:24:54 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to kernel.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > kernel.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/kerne

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-27 Thread Oleksii
On Mon, 2023-11-27 at 15:31 +0100, Jan Beulich wrote: > On 27.11.2023 15:13, Oleksii Kurochko wrote: > > Arm, PPC and RISC-V use the same device.h thereby device.h > > was moved to asm-generic. Arm's device.h was taken as a base with > > the following changes: > >  - #ifdef PCI related things. > >

Re: [PATCH v4 12/14] xen/asm-generic: introduce stub header softirq.h

2023-11-27 Thread Oleksii
On Mon, 2023-11-27 at 15:36 +0100, Jan Beulich wrote: > On 27.11.2023 15:13, Oleksii Kurochko wrote: > > is common between Arm, PPC and RISC-V so it is > > moved to asm-generic. > > > > Drop Arm and PPC's softirq.h and use asm-generic version instead. > > > > Signed-off-by: Oleksii Kurochko > >

Re: [PATCH v4 13/14] xen: ifdef inclusion of in

2023-11-27 Thread Oleksii
On Mon, 2023-11-27 at 15:41 +0100, Jan Beulich wrote: > On 27.11.2023 15:13, Oleksii Kurochko wrote: > > --- a/xen/arch/ppc/include/asm/grant_table.h > > +++ /dev/null > > @@ -1,5 +0,0 @@ > > -/* SPDX-License-Identifier: GPL-2.0-only */ > > -#ifndef __ASM_PPC_GRANT_TABLE_H__ > > -#define __ASM_PPC_

xen | Successful pipeline for staging | 72d51813

2023-11-27 Thread GitLab
Pipeline #1086435762 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 72d51813 ( https://gitlab.com/xen-project/xen/-/commit/72d51813d631fe27d37736b7a55eeec08f246983 ) Commit Message: x86: amend cp

[xen-unstable-smoke test] 183871: trouble: blocked/broken

2023-11-27 Thread osstest service owner
flight 183871 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183871/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-arm64-xs

Re: MISRA: Compatible declarations for sort and bsearch

2023-11-27 Thread Nicola Vetrini
On 2023-11-27 15:59, Jan Beulich wrote: On 27.11.2023 15:32, Nicola Vetrini wrote: Still on the matter of Rule 8.4, though not related to bsearch or sort: - the definition of do_mca in x86/cpu/mcheck/mca.c has the following header: #include /* for do_mca */ which in turn leads to x86/in

[linux-linus test] 183868: trouble: blocked/broken

2023-11-27 Thread osstest service owner
flight 183868 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183868/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 broken build-amd64-pvops

Re: [XEN PATCH v2 2/3] xen/arm: add SAF deviation for debugging and logging effects

2023-11-27 Thread Simone Ballarin
On 27/11/23 16:09, Jan Beulich wrote: On 27.11.2023 15:35, Simone Ballarin wrote: On 27/11/23 11:46, Jan Beulich wrote: On 24.11.2023 18:29, Simone Ballarin wrote: --- a/docs/misra/safe.json +++ b/docs/misra/safe.json @@ -28,6 +28,22 @@ }, { "id": "SAF-3-sa

Re: [RFC PATCH v2 18/19] heki: x86: Protect guest kernel memory using the KVM hypervisor

2023-11-27 Thread Madhavan T. Venkataraman
Apologies for the late reply. I was on vacation. Please see my response below: On 11/13/23 02:54, Peter Zijlstra wrote: > On Sun, Nov 12, 2023 at 09:23:25PM -0500, Mickaël Salaün wrote: >> From: Madhavan T. Venkataraman >> >> Implement a hypervisor function, kvm_protect_memory() that calls the >>

Re: [PATCH v4 2/6] x86/hvm: Allow access to registers on the same page as MSI-X table

2023-11-27 Thread Jan Beulich
On 24.11.2023 02:47, Marek Marczykowski-Górecki wrote: > Some devices (notably Intel Wifi 6 AX210 card) keep auxiliary registers > on the same page as MSI-X table. Device model (especially one in > stubdomain) cannot really handle those, as direct writes to that page is > refused (page is on the mm

Re: [RFC PATCH v2 17/19] heki: x86: Update permissions counters during text patching

2023-11-27 Thread Madhavan T. Venkataraman
Apologies for the late reply. I was on vacation. Please see my response below: On 11/13/23 02:19, Peter Zijlstra wrote: > On Sun, Nov 12, 2023 at 09:23:24PM -0500, Mickaël Salaün wrote: >> From: Madhavan T. Venkataraman >> >> X86 uses a function called __text_poke() to modify executable code. Thi

Re: [PATCH block/for-next v2 01/16] block: add a new helper to get inode from block_device

2023-11-27 Thread Christoph Hellwig
On Mon, Nov 27, 2023 at 09:07:22PM +0800, Yu Kuai wrote: > 1) Is't okay to add a new helper to pass in bdev for following apis? For some we already have them (e.g. bdev_nr_bytes to read the bdev) size, for some we need to add them. The big thing that seems to stick out is page cache API, and I t

[OSSTEST PATCH] preseed_base: Remove reportbug-gtk if present

2023-11-27 Thread Anthony PERARD
The Debian installer have started to install "reportbug-gtk" which depends on "dconf-service" and "dbus-user-session" and "systemd". And when we try to install "sysvinit-core" we are met with the following error message: >The following packages have unmet dependencies: > dconf-service : De

Re: [PATCH v4 1/6] x86/msi: passthrough all MSI-X vector ctrl writes to device model

2023-11-27 Thread Jan Beulich
On 24.11.2023 02:47, Marek Marczykowski-Górecki wrote: > @@ -357,7 +356,17 @@ static int cf_check _msixtbl_write( > const struct hvm_io_handler *handler, uint64_t address, uint32_t len, > uint64_t val) > { > -return msixtbl_write(current, address, len, val); > +/* ignore invalid

Re: [PATCH] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-27 Thread Andrew Cooper
On 27/11/2023 3:18 pm, Neowutran wrote: >> Hello, >> >> Thankyou for the analysis. >> >> For your base version of QubeOS Xen, was that 4.13.2-5 ?   I can't see >> any APIC changes in the patchqueue, and I believe all relevant bugfixes >> are in 4.17.2, but I'd just like to confirm. > I was using th

Re: [Xen-devel] PV guest with PCI passthrough crash on Xen 4.8.3 inside KVM when booted through OVMF

2023-11-27 Thread Juergen Gross
On 27.11.23 16:56, Jason Andryuk wrote: On Mon, Nov 27, 2023 at 6:27 AM Marek Marczykowski-Górecki wrote: On Mon, Nov 27, 2023 at 11:20:36AM +, Frediano Ziglio wrote: On Sun, Nov 26, 2023 at 2:51 PM Marek Marczykowski-Górecki wrote: On Mon, Feb 19, 2018 at 06:30:14PM +0100, Juergen Gro

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Luca Fancellu
> On 27 Nov 2023, at 15:55, Jan Beulich wrote: > > On 27.11.2023 16:37, Luca Fancellu wrote: >> >> >>> On 27 Nov 2023, at 15:13, Jan Beulich wrote: >>> >>> On 27.11.2023 15:58, Luca Fancellu wrote: > On 27 Nov 2023, at 12:20, Jan Beulich wrote: > On 24.11.2023 15:52, Luca Fancellu

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-27 Thread Chuck Zmudzinski
On 11/27/2023 10:22 AM, Chuck Zmudzinski wrote: > On 11/27/2023 7:45 AM, Mario Marietto wrote: >> @Chuck Zmudzinski : Stay tuned. They want to >> help us. The xen developers are great. Very good support for us. I'm sure >> that you can give a good contribution to un

Re: [Xen-devel] PV guest with PCI passthrough crash on Xen 4.8.3 inside KVM when booted through OVMF

2023-11-27 Thread Jason Andryuk
On Mon, Nov 27, 2023 at 6:27 AM Marek Marczykowski-Górecki wrote: > > On Mon, Nov 27, 2023 at 11:20:36AM +, Frediano Ziglio wrote: > > On Sun, Nov 26, 2023 at 2:51 PM Marek Marczykowski-Górecki > > wrote: > > > > > > On Mon, Feb 19, 2018 at 06:30:14PM +0100, Juergen Gross wrote: > > > > On 16

Re: [PATCH] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-27 Thread Andrew Cooper
On 27/11/2023 2:53 pm, Roger Pau Monné wrote: > On Mon, Nov 27, 2023 at 11:49:03AM +, Andrew Cooper wrote: >> On 24/11/2023 7:54 pm, Neowutran wrote: >>> Hi, >>> I did some more tests and research, indeed this patch improved/solved my >>> specific case. >>> >>> Starting point: >>> >>> I am

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Jan Beulich
On 27.11.2023 16:37, Luca Fancellu wrote: > > >> On 27 Nov 2023, at 15:13, Jan Beulich wrote: >> >> On 27.11.2023 15:58, Luca Fancellu wrote: On 27 Nov 2023, at 12:20, Jan Beulich wrote: On 24.11.2023 15:52, Luca Fancellu wrote: >> On 24 Nov 2023, at 12:47, Jan Beulich wrote: >>>

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Luca Fancellu
> On 27 Nov 2023, at 15:13, Jan Beulich wrote: > > On 27.11.2023 15:58, Luca Fancellu wrote: >>> On 27 Nov 2023, at 12:20, Jan Beulich wrote: >>> On 24.11.2023 15:52, Luca Fancellu wrote: > On 24 Nov 2023, at 12:47, Jan Beulich wrote: > On 23.11.2023 15:47, Luca Fancellu wrote: >>

Re: [XEN PATCH v4] xen: replace some occurrences of SAF-1-safe with asmlinkage attribute

2023-11-27 Thread Jan Beulich
On 24.11.2023 09:11, Nicola Vetrini wrote: > The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced > by the asmlinkage pseudo-attribute, for the sake of uniformity. > > asmlinkage may in the future have the effect of altering the calling > convention, therefore three special wher

Re: We are not able to virtualize FreeBSD using xen 4.17 on Arm 32 bit

2023-11-27 Thread Chuck Zmudzinski
On 11/27/2023 7:45 AM, Mario Marietto wrote: > @Chuck Zmudzinski : Stay tuned. They want to > help us. The xen developers are great. Very good support for us. I'm sure > that you can give a good contribution to understand what's our problem and > how to implement a

Re: [PATCH] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-27 Thread Neowutran
c...@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hello, Thanks a lot for all the details and explainations ! :) On 2023-11-27 11:11, Andrew Cooper wrote: > On 24/11/2023 7:54 pm, Neowutran wr

xen | Successful pipeline for staging | fbcec32d

2023-11-27 Thread GitLab
Pipeline #1086376593 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: fbcec32d ( https://gitlab.com/xen-project/xen/-/commit/fbcec32d6d3ea0ac329301925b317478316209ed ) Commit Message: x86/mem_shari

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Jan Beulich
On 27.11.2023 15:58, Luca Fancellu wrote: >> On 27 Nov 2023, at 12:20, Jan Beulich wrote: >> On 24.11.2023 15:52, Luca Fancellu wrote: On 24 Nov 2023, at 12:47, Jan Beulich wrote: On 23.11.2023 15:47, Luca Fancellu wrote: > Let’s continue the discussion about clang-format configurat

Re: [XEN PATCH v2 2/3] xen/arm: add SAF deviation for debugging and logging effects

2023-11-27 Thread Jan Beulich
On 27.11.2023 15:35, Simone Ballarin wrote: > On 27/11/23 11:46, Jan Beulich wrote: >> On 24.11.2023 18:29, Simone Ballarin wrote: >>> --- a/docs/misra/safe.json >>> +++ b/docs/misra/safe.json >>> @@ -28,6 +28,22 @@ >>> }, >>> { >>> "id": "SAF-3-safe", >>> +

Re: [PATCH] x86/xen: fix percpu vcpu_info allocation

2023-11-27 Thread Juergen Gross
On 27.11.23 16:00, Jan Beulich wrote: On 27.11.2023 15:57, Boris Ostrovsky wrote: On 11/24/23 2:48 AM, Juergen Gross wrote: Today the percpu struct vcpu_info is allocated via DEFINE_PER_CPU(), meaning that it could cross a page boundary. In this case registering it with the hypervisor will fa

Re: [PATCH] x86/xen: fix percpu vcpu_info allocation

2023-11-27 Thread Jan Beulich
On 27.11.2023 15:57, Boris Ostrovsky wrote: > > > On 11/24/23 2:48 AM, Juergen Gross wrote: >> Today the percpu struct vcpu_info is allocated via DEFINE_PER_CPU(), >> meaning that it could cross a page boundary. In this case registering >> it with the hypervisor will fail, resulting in a panic().

Re: MISRA: Compatible declarations for sort and bsearch

2023-11-27 Thread Jan Beulich
On 27.11.2023 15:32, Nicola Vetrini wrote: > Still on the matter of Rule 8.4, though not related to bsearch or sort: > > - the definition of do_mca in x86/cpu/mcheck/mca.c has the following > header: >#include /* for do_mca */ >which in turn leads to x86/include/asm/hypercall.h, which in

Re: Clang-format configuration discussion - pt 2

2023-11-27 Thread Luca Fancellu
> On 27 Nov 2023, at 12:20, Jan Beulich wrote: > > On 24.11.2023 15:52, Luca Fancellu wrote: >>> On 24 Nov 2023, at 12:47, Jan Beulich wrote: >>> On 23.11.2023 15:47, Luca Fancellu wrote: Let’s continue the discussion about clang-format configuration, this is part 2, previous discus

Re: [PATCH] x86/xen: fix percpu vcpu_info allocation

2023-11-27 Thread Boris Ostrovsky
On 11/24/23 2:48 AM, Juergen Gross wrote: Today the percpu struct vcpu_info is allocated via DEFINE_PER_CPU(), meaning that it could cross a page boundary. In this case registering it with the hypervisor will fail, resulting in a panic(). This can easily be fixed by using DEFINE_PER_CPU_ALIGN

Re: [PATCH] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-27 Thread Roger Pau Monné
On Mon, Nov 27, 2023 at 11:49:03AM +, Andrew Cooper wrote: > On 24/11/2023 7:54 pm, Neowutran wrote: > > Hi, > > I did some more tests and research, indeed this patch improved/solved my > > specific case. > > > > Starting point: > > > > I am using Xen version 4.17.2 (exactly this source >

Re: [PATCH 1/2] livepatch-build-tools: remove usage of gawk

2023-11-27 Thread Roger Pau Monné
On Fri, Nov 24, 2023 at 12:10:57PM +, Alejandro Vallejo wrote: > On 24/11/2023 11:43, Ross Lagerwall wrote: > > On Thu, Nov 23, 2023 at 4:08 PM Roger Pau Monne > wrote: > >> > >> And instead use plain awk. > >> > >> There's no need to use the --non-decimal-data option for gawk, since the > >>

Re: [PATCH v4 14/14] xen/asm-generic: ifdef inclusion of

2023-11-27 Thread Jan Beulich
On 27.11.2023 15:13, Oleksii Kurochko wrote: > --- a/xen/arch/ppc/include/asm/mem_access.h > +++ /dev/null > @@ -1,5 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0-only */ > -#ifndef __ASM_PPC_MEM_ACCESS_H__ > -#define __ASM_PPC_MEM_ACCESS_H__ > - > -#endif /* __ASM_PPC_MEM_ACCESS_H__ */ Same as f

[PATCH] ubsan: Introduce CONFIG_UBSAN_FATAL to panic on UBSAN failure

2023-11-27 Thread Michal Orzel
Introduce the CONFIG_UBSAN_FATAL option to cater to scenarios where prompt attention to undefined behavior issues, notably during CI test runs, is essential. When enabled, this option causes Xen to panic upon detecting UBSAN failure (as the last step in ubsan_epilogue()). Signed-off-by: Michal Orz

Re: [PATCH v4 13/14] xen: ifdef inclusion of in

2023-11-27 Thread Jan Beulich
On 27.11.2023 15:13, Oleksii Kurochko wrote: > --- a/xen/arch/ppc/include/asm/grant_table.h > +++ /dev/null > @@ -1,5 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0-only */ > -#ifndef __ASM_PPC_GRANT_TABLE_H__ > -#define __ASM_PPC_GRANT_TABLE_H__ > - > -#endif /* __ASM_PPC_GRANT_TABLE_H__ */ Remov

Re: [PATCH v4 12/14] xen/asm-generic: introduce stub header softirq.h

2023-11-27 Thread Jan Beulich
On 27.11.2023 15:13, Oleksii Kurochko wrote: > is common between Arm, PPC and RISC-V so it is > moved to asm-generic. > > Drop Arm and PPC's softirq.h and use asm-generic version instead. > > Signed-off-by: Oleksii Kurochko > Reviewed-by: Michal Orzel > Added Acked-by: Jan Beulich In case a

Re: [PATCH v4 11/14] xen/asm-generic: introduce stub header numa.h

2023-11-27 Thread Jan Beulich
On 27.11.2023 15:13, Oleksii Kurochko wrote: > is common through some archs so it is moved > to asm-generic. > > Signed-off-by: Oleksii Kurochko > Reviewed-by: Michal Orzel Acked-by: Jan Beulich

Re: [XEN PATCH v2 2/3] xen/arm: add SAF deviation for debugging and logging effects

2023-11-27 Thread Simone Ballarin
On 27/11/23 11:46, Jan Beulich wrote: On 24.11.2023 18:29, Simone Ballarin wrote: Rule 13.1: Initializer lists shall not contain persistent side effects Effects caused by debug/logging macros and functions (like ASSERT, __bad_atomic_size, LOG, etc ...) that crash execution or produce logs are

Re: [PATCH v4 06/14] xen/asm-generic: introduce generic header percpu.h

2023-11-27 Thread Jan Beulich
On 27.11.2023 15:13, Oleksii Kurochko wrote: > The patch introduces generic percpu.h which was based on Arm's version > with the following changes: > * makes __per_cpu_data_end[] constant > * introduce get_per_cpu_offset() for macros this_cpu() and this_cpu_ptr() > * add inclustion of as get_pe

Re: MISRA: Compatible declarations for sort and bsearch

2023-11-27 Thread Nicola Vetrini
On 2023-11-24 10:40, Nicola Vetrini wrote: Hi all, in xen/lib.h and xen/sort.h there are definitions of the functions bsearch and sort that have no prior declarations, and therefore are subject to a violation of MISRA C Rule 8.4. I'm wondering whether it would be preferred 1. to put a decla

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-27 Thread Jan Beulich
On 27.11.2023 15:13, Oleksii Kurochko wrote: > Arm, PPC and RISC-V use the same device.h thereby device.h > was moved to asm-generic. Arm's device.h was taken as a base with > the following changes: > - #ifdef PCI related things. > - #ifdef ACPI related things. > - Rename #ifdef guards. > - Add

[PATCH v4 05/14] xen/asm-generic: introduce stub header

2023-11-27 Thread Oleksii Kurochko
is common for Arm, PPC and RISC-V thereby it is moved to asm-generic. Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich Acked-by: Julien Grall --- Changes in V4: - Added Reviewed-by: Jan Beulich - Added Acked-by: Julien Grall --- Changes in V3: - Drop Arm and PPC's random.h and swi

[PATCH v4 13/14] xen: ifdef inclusion of in

2023-11-27 Thread Oleksii Kurochko
Ifdef-ing inclusion of allows to avoid generation of empty for cases when CONFIG_GRANT_TABLE is not enabled. The following changes were done for Arm: should be included directly because it contains gnttab_dom0_frames() macros which is unique for Arm and is used in arch/arm/domain_build.c. is #

[PATCH v4 07/14] xen/asm-generic: introduce generalized hardirq.h

2023-11-27 Thread Oleksii Kurochko
is common through archs thereby it is moved to asm-generic. Arm and PPC were switched to asm generic verstion of hardirq.h. Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich Acked-by: Julien Grall --- Changes in V4: - Added Reviewed-by: Jan Beulich . - Added Acked-by: Julien Grall .

[PATCH v4 11/14] xen/asm-generic: introduce stub header numa.h

2023-11-27 Thread Oleksii Kurochko
is common through some archs so it is moved to asm-generic. Signed-off-by: Oleksii Kurochko Reviewed-by: Michal Orzel --- Changes in V4: - Updated guards name: *ARCH_GENERIC* -> *ASM_GENERIC*. - Moved inclusion of xen/mm-frame.h under "#ifndef CONFIG_NUMA". - Added Reviewed-by: Michal Orzel

[PATCH v4 09/14] xen/asm-generic: introduce generic header altp2m.h

2023-11-27 Thread Oleksii Kurochko
is common between several archs so it is moved to asm-generic. Arm and PPC were switched to asm-generic version of altp2m.h. Signed-off-by: Oleksii Kurochko Acked-by: Michal Orzel Acked-by: Jan Beulich --- Michal asked the following: Shouldn't this copyright be moved to generic header as

[PATCH v4 14/14] xen/asm-generic: ifdef inclusion of

2023-11-27 Thread Oleksii Kurochko
ifdefing inclusion of in allows to avoid generation of empty header for the case when !CONFIG_MEM_ACCESS. For Arm it was explicitly added inclusion of for p2m.c and traps.c because they require some functions from which aren't available in case of !CONFIG_MEM_ACCESS. Suggested-by: Jan Beulic

[PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-27 Thread Oleksii Kurochko
Arm, PPC and RISC-V use the same device.h thereby device.h was moved to asm-generic. Arm's device.h was taken as a base with the following changes: - #ifdef PCI related things. - #ifdef ACPI related things. - Rename #ifdef guards. - Add SPDX tag. - #ifdef CONFIG_HAS_DEVICE_TREE related things.

[PATCH v4 03/14] xen/asm-generic: introduce generic hypercall.h

2023-11-27 Thread Oleksii Kurochko
Introduce an empty generic hypercall.h for archs which don't implement it. Drop PPC's hypercall.h and switch to generic one instead. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V4: - Nothing changed. Only rebase. --- Changes in V3: - Drop PPC's hypercall.h and switch

[PATCH v4 10/14] xen/asm-generic: introduce stub header monitor.h

2023-11-27 Thread Oleksii Kurochko
The header is shared between several archs so it is moved to asm-generic. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich . --- Changes in V4: - Removed the double blank line. - Added Acked-by: Jan Beulich . - Update the commit message --- Changes in V3: - Use forward-declaration of str

  1   2   >