On 27.11.2023 20:46, Oleksii wrote: > On Mon, 2023-11-27 at 15:31 +0100, Jan Beulich wrote: >> On 27.11.2023 15:13, Oleksii Kurochko wrote: >>> --- a/xen/arch/ppc/include/asm/irq.h >>> +++ b/xen/arch/ppc/include/asm/irq.h >>> @@ -3,7 +3,9 @@ >>> #define __ASM_PPC_IRQ_H__ >>> >>> #include <xen/lib.h> >>> +#ifdef CONFIG_HAS_DEVICE_TREE >>> #include <xen/device_tree.h> >>> +#endif >>> #include <public/device_tree_defs.h> >> >> Why would this #ifdef not cover the public header as well? (Otherwise >> I'd >> be inclined to ask that the conditional be moved inside that header.) > In that header is defined only consts without additional header > inclusion. At that moment it looked to me pretty save to ifdef only > xen/device_tree.h but you are right we can move incluion of the public > header inside #ifdef OR just remove as xen/device_tree.h already > includes it.
Oh, yes, dropping the redundant #include would be even better then. Yet that furthers the desire to have the #ifdef inside that other header, to improve how things look as use sites like the one here. Jan
