Re: [PATCH] x86/x2apic: introduce a mixed physical/cluster mode

On Thu, Nov 23, 2023 at 10:39:37AM +0100, Roger Pau Monné wrote: > On Tue, Nov 21, 2023 at 04:56:47PM -0800, Elliott Mitchell wrote: > > It was insisted that full logs be sent to xen-devel. Perhaps I am > > paranoid, but I doubt I would have been successful at scrubbing all > > hardware serial num

[xen-unstable test] 183852: tolerable FAIL - PUSHED

flight 183852 xen-unstable real [real] flight 183854 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183852/ http://logs.test-lab.xenproject.org/osstest/logs/183854/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armh

[RFC PATCH v3 3/5] xen: add option to disable legacy backends

This patch makes legacy backends optional. As was discussed at [1] this is a solution to a problem when we can't run QEMU as a device model in a non-privileged domain. This is because legacy backends assume that they are always running in domain with ID = 0. Actually, this may prevent running QEMU

[PATCH v3 1/5] hw/xen: Set XenBackendInstance in the XenDevice before realizing it

From: David Woodhouse This allows a XenDevice implementation to know whether it was created by QEMU, or merely discovered in XenStore after the toolstack created it. This will allow us to create frontend/backend nodes only when we should, rather than unconditionally attempting to overwrite them f

[PATCH v3 2/5] xen: backends: don't overwrite XenStore nodes created by toolstack

Xen PV devices in QEMU can be created in two ways: either by QEMU itself, if they were passed via command line, or by Xen toolstack. In the latter case, QEMU scans XenStore entries and configures devices accordingly. In the second case we don't want QEMU to write/delete front-end entries for two r

[PATCH v3 5/5] xen_arm: Add virtual PCIe host bridge support

From: Oleksandr Tyshchenko The bridge is needed for virtio-pci support, as QEMU can emulate the whole bridge with any virtio-pci devices connected to it. This patch provides a flexible way to configure PCIe bridge resources using QEMU machine properties. We made this for several reasons: - We d

Re: [PATCH v2 08/15] VMX: convert vmx_basic_msr

On 24/11/2023 8:41 am, Jan Beulich wrote: > ... to a struct field, which is then going to be accompanied by other > capability/control data presently living in individual variables. As > this structure isn't supposed to be altered post-boot, put it in > .data.ro_after_init right away. > > Suggested

Re: [PATCH v2 06/15] x86/HVM: improve CET-IBT pruning of ENDBR

On 24/11/2023 8:39 am, Jan Beulich wrote: > __init{const,data}_cf_clobber can have an effect only for pointers > actually populated in the respective tables. While not the case for SVM > right now, VMX installs a number of pointers only under certain > conditions. Hence the respective functions wou

Re: [PATCH v4] xen/x86: On x2APIC mode, derive LDR from APIC ID

A few minor grammar notes. "x86/vlapic: In x2APIC ..." On 23/11/2023 5:30 pm, Alejandro Vallejo wrote: > Both Intel and AMD manuals agree that on x2APIC mode, the APIC LDR and ID > registers are derivable from each other through a fixed formula. > > Xen uses that formula, but applies it to vCPU

Re: [PATCH v3 07/13] xen/spinlock: make struct lock_profile rspinlock_t aware

On 20/11/2023 11:38, Juergen Gross wrote: Struct lock_profile contains a pointer to the spinlock it is associated with. Prepare support of differing spinlock_t and rspinlock_t types by adding a type indicator of the pointer. Use the highest bit of the block_cnt member for this indicator in order

Re: [PATCH] x86/x2apic: introduce a mixed physical/cluster mode

Content-D�� isposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <81f6bbd5-0487-461a-af1a-dbb6ead47...@citrix.com> On 2023-11-18 11:11, Andrew Cooper wrote: > On 18/11/2023 3:04 am, Elliott Mitchell wrote: > > On Fri, Nov 17, 2023 at 11:12:37AM +0100, Neowutran wrote: > >> On 2023-11-07

Re: [PATCH v3 06/13] xen/spinlock: add rspin_[un]lock_irq[save|restore]()

On 20/11/2023 11:38, Juergen Gross wrote: Instead of special casing rspin_lock_irqsave() and rspin_unlock_irqrestore() for the console lock, add those functions to spinlock handling and use them where needed. Signed-off-by: Juergen Gross --- V2: - new patch --- xen/arch/x86/traps.c | 14

Re: [PATCH 0/5] xen: address violations of MISRA C:2012 Rule 11.8

On 24/11/23 18:56, Andrew Cooper wrote: On 24/11/2023 4:29 pm, Simone Ballarin wrote: Maria Celeste Cesario (5): x86/platform_hypercall: address violations of MISRA C:2012 Rule 11.8 x86/boot/reloc: address violations of MISRA C:2012 Rule 11.8 AMD/IOMMU: address violations of MISRA C:201

Re: [PATCH v3 04/13] xen/spinlock: introduce new type for recursive spinlocks

On 20/11/2023 11:38, Juergen Gross wrote: Introduce a new type "rspinlock_t" to be used for recursive spinlocks. For now it is only an alias of spinlock_t, so both types can still be used for recursive spinlocks. This will be changed later, though. Switch all recursive spinlocks to the new type

Re: [PATCH v3 02/13] xen/spinlock: reduce lock profile ifdefs

On 24/11/2023 17:59, Alejandro Vallejo wrote: Hi, On 20/11/2023 11:38, Juergen Gross wrote:> With some small adjustments to the LOCK_PROFILE_* macros some #ifdefs can be dropped from spinlock.c. Signed-off-by: Juergen Gross --- V2: - new patch V3: - add variable name to macros parameter (Jan

[libvirt test] 183850: tolerable all pass - PUSHED

flight 183850 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/183850/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 183819 test-armhf-armhf-libvirt-raw 15 saveresto

Re: [PATCH v3 02/13] xen/spinlock: reduce lock profile ifdefs

Hi, On 20/11/2023 11:38, Juergen Gross wrote:> With some small adjustments to the LOCK_PROFILE_* macros some #ifdefs can be dropped from spinlock.c. Signed-off-by: Juergen Gross --- V2: - new patch V3: - add variable name to macros parameter (Jan Beulich) --- xen/common/spinlock.c | 49

Re: [PATCH 0/5] xen: address violations of MISRA C:2012 Rule 11.8

On 24/11/2023 4:29 pm, Simone Ballarin wrote: > Maria Celeste Cesario (5): > x86/platform_hypercall: address violations of MISRA C:2012 Rule 11.8 > x86/boot/reloc: address violations of MISRA C:2012 Rule 11.8 > AMD/IOMMU: address violations of MISRA C:2012 Rule 11.8 > x86/atomic: address vi

Re: [PATCH 3/5] AMD/IOMMU: address violations of MISRA C:2012 Rule 11.8

On 24/11/2023 4:29 pm, Simone Ballarin wrote: > From: Maria Celeste Cesario > > Add missing const qualifier in casting to comply with Rule 11.8. > The type of the formal parameter ivhd_block is const qualified. > No functional change. > > Signed-off-by: Maria Celeste Cesario > Signed-off-by: Sim

[XEN PATCH v2 2/3] xen/arm: add SAF deviation for debugging and logging effects

Rule 13.1: Initializer lists shall not contain persistent side effects Effects caused by debug/logging macros and functions (like ASSERT, __bad_atomic_size, LOG, etc ...) that crash execution or produce logs are not dangerous in initializer lists. The evaluation order in abnormal conditions is n

[XEN PATCH v2 1/3] automation/eclair: tag function calls to address violations of MISRA C:2012 Rule 13.1

Rule 13.1: Initializer lists shall not contain persistent side effects Invocations of functions in initializer lists cause violations of rule 13.1 if the called functions are not tagged with __attribute_pure__ or __attribute_const__ as they can produce persistent side effects. Handling these viol

[XEN PATCH v2 3/3] xen: address violations of MISRA C:2012 Rule 13.1

Rule 13.1: Initializer lists shall not contain persistent side effects The assignment operation in: .irq = rc = uart->irq, is a persistent side effect in a struct initializer list. This patch avoids rc assignment and directly uses uart->irq in the following if statement. No functional changes.

[XEN PATCH v2 0/3] xen: address violations of MISRA C:2012 Rule 13.1

This series contains some changes and deviation to address reports of MISRA C:2012 Rule 13.1: Initializer lists shall not contain persistent side effects An assignment has been moved outside the initializer lists, other violations have been deviated with SAF comments. Function calls do not necess

[PATCH 3/5] AMD/IOMMU: address violations of MISRA C:2012 Rule 11.8

From: Maria Celeste Cesario Add missing const qualifier in casting to comply with Rule 11.8. The type of the formal parameter ivhd_block is const qualified. No functional change. Signed-off-by: Maria Celeste Cesario Signed-off-by: Simone Ballarin --- xen/drivers/passthrough/amd/iommu_acpi.c

[PATCH 2/5] x86/boot/reloc: address violations of MISRA C:2012 Rule 11.8

From: Maria Celeste Cesario Add missing const qualifier in casting to comply with Rule 11.8. Argument tag is typically const qualified. No functional change. Signed-off-by: Maria Celeste Cesario Signed-off-by: Simone Ballarin --- xen/arch/x86/boot/reloc.c | 2 +- 1 file changed, 1 insertion

[PATCH 0/5] xen: address violations of MISRA C:2012 Rule 11.8

From: Maria Celeste Cesario The xen sources contains violations of MISRA C:2012 Rule 11.8 whose headline states: "A conversion shall not remove any const, volatile or Atomic qualification from the type pointed to by a pointer". This patch amends or removes casts that unnecessarily drop const qua

[PATCH 4/5] x86/atomic: address violations of MISRA C:2012 Rule 11.8

From: Maria Celeste Cesario Edit casts that unnecessarily remove const qualifiers to comply with Rule 11.8. The type of the provided pointer may be const qualified. No functional change. Signed-off-by: Maria Celeste Cesario Signed-off-by: Simone Ballarin --- xen/arch/x86/include/asm/atomic.

[PATCH 5/5] xen/arm: address violations of MISRA C:2012 Rule 11.8

From: Maria Celeste Cesario Add or amend casts to comply with Rule 11.8. The violations are resolved either: - by adding a missing const qualifier in the cast - by removing a cast to non-const on a const-qualified object No functional change. Signed-off-by: Maria Celeste Cesario Signed-off-b

[PATCH 1/5] x86/platform_hypercall: address violations of MISRA C:2012 Rule 11.8

From: Maria Celeste Cesario Add const qualifier in cast that unnecessarily removes it to comply with Rule 11.8. The variable info is declared with a const qualified type. No functional change. Signed-off-by: Maria Celeste Cesario Signed-off-by: Simone Ballarin --- xen/arch/x86/platform_hype

Re: [Discussion]: Making "LIBXL_HOTPLUG_TIMEOUT" configurable through 'xl.conf'

On 11/24/23 06:04, Olaf Hering wrote: Fri, 24 Nov 2023 13:47:53 +0100 Juergen Gross : As Olaf has said already: this wouldn't cover actions e.g. by libvirt. Jim pointed me to /etc/libvirt/libxl.conf. So from this perspective both xl and libvirt is covered. Now it just takes someone to impleme

Re: [PATCH v2 6/6] xen_arm: Add virtual PCIe host bridge support

Hi Igor, Thank you for the review, Igor Mammedov writes: > On Tue, 21 Nov 2023 22:10:28 + > Volodymyr Babchuk wrote: > >> From: Oleksandr Tyshchenko >> >> The bridge is needed for virtio-pci support, as QEMU can emulate the >> whole bridge with any virtio-pci devices connected to it. >

Re: Clang-format configuration discussion - pt 2

> On 24 Nov 2023, at 12:47, Jan Beulich wrote: > > On 23.11.2023 15:47, Luca Fancellu wrote: >> Hi all, >> >> Let’s continue the discussion about clang-format configuration, this is part >> 2, previous discussions are: >> >> - https://lists.xenproject.org/archives/html/xen-devel/2023-11/msg0

[XEN PATCH] automation/eclair: tag files as "adopted" and "out of scope"

Tag arm64/efibind.h as "adopted": it is used to build the efi stub, which is a separate entry point for Xen when booted from EFI firmware. Tag common/coverage/* as "out-of-scope": it is code to support gcov, hence it is part of the testing machinery. Signed-off-by: Federico Serafini --- automat

[XEN PATCH 03/11] xen/cpumask: address violations of MISRA C:2012 Rule 8.2

Add missing parameter names. No functional change. Signed-off-by: Federico Serafini --- xen/include/xen/cpumask.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/cpumask.h b/xen/include/xen/cpumask.h index 9826707909..145e140481 100644 --- a/xen/include/

[XEN PATCH 01/11] xen/console: address violations of MISRA C:2012 Rule 8.2

Add missing parameter names. No functional change. Signed-off-by: Federico Serafini --- xen/drivers/char/console.c | 4 ++-- xen/include/xen/console.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index 946af5e625.

[XEN PATCH 11/11] xen/serial: address a violation of MISRA C:2012 Rule 8.2

Add missing parameter name. No functional change. Signed-off-by: Federico Serafini --- In my previous patch for serial.h I missed one parameter: sorry for that. --- xen/include/xen/serial.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/serial.h b/xen/include

[XEN PATCH 07/11] xen/iommu: address violations of MISRA C:2012 Rule 8.2

Add missing parameter names to address violations of MISRA C:2012 Rule 8.2 and remove uses of u{8,16,32} in favor of C standard types. No functional change. Signed-off-by: Federico Serafini --- xen/include/xen/iommu.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --gi

[XEN PATCH 09/11] xen/param: address a violation of MISRA C:2012 Rule 8.2

Add missing parameter name. No functional change. Signed-off-by: Federico Serafini --- xen/include/xen/param.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/param.h b/xen/include/xen/param.h index 93c3fe7cb7..9170455cde 100644 --- a/xen/include/xen/param.h +

[XEN PATCH 08/11] xen/kernel: address a violation of MISRA C:2012 Rule 8.2

Add missing parameter name. No functional change. Signed-off-by: Federico Serafini --- xen/include/xen/kernel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/kernel.h b/xen/include/xen/kernel.h index 560b1c2832..6bbd4a2827 100644 --- a/xen/include/xen/kernel

[XEN PATCH 02/11] xen/aclinux: address violations of MISRA C:2012 Rule 8.2

Add missing parameter names. No functional change. Signed-off-by: Federico Serafini --- xen/include/acpi/platform/aclinux.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/include/acpi/platform/aclinux.h b/xen/include/acpi/platform/aclinux.h index 9e572460dc..f5e0a

[XEN PATCH 10/11] xen/perfc: address a violation of MISRA C:2012 Rule 8.2

Add missing parameter name. No functional change. Signed-off-by: Federico Serafini --- xen/include/xen/perfc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/perfc.h b/xen/include/xen/perfc.h index 96022c0748..f9009dc388 100644 --- a/xen/include/xen/perfc.h +

[XEN PATCH 06/11] xen/notifier: address violations of MISRA C:2012 Rule 8.2

Add missing parameter names. No functional change. Signed-off-by: Federico Serafini --- xen/include/xen/notifier.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/include/xen/notifier.h b/xen/include/xen/notifier.h index 51453c1552..2a952484df 100644 --- a/xen/include/x

[XEN PATCH 00/11] xen: address violations of MISRA C:2012 Rule 8.2

This patch series adds some of the missing parameter names. No functional changes are introduced. Federico Serafini (11): xen/console: address violations of MISRA C:2012 Rule 8.2 xen/aclinux: address violations of MISRA C:2012 Rule 8.2 xen/cpumask: address violations of MISRA C:2012 Rule 8.2

[XEN PATCH 04/11] xen/dmi: address a violation of MISRA C:2012 Rule 8.2

Add missing parameter name. No functional change. Signed-off-by: Federico Serafini --- xen/include/xen/dmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/dmi.h b/xen/include/xen/dmi.h index 71a5c46dc6..0fef41842e 100644 --- a/xen/include/xen/dmi.h +++ b/xen

[XEN PATCH 05/11] xen/domain: address violations of MISRA C:2012 Rule 8.2

Add missing parameter names. No functional change. Signed-off-by: Federico Serafini --- xen/include/xen/domain.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 460c8c3d27..d345278b71 100644 --- a/xen/in

[RFC PATCH] Mini-OS: explicitly mark symbols to be visible for apps

Add an EXPORT_SYMBOL() macro to explicitly mark a symbol to be visible for an app or library linked with Mini-OS. This enables to hide all other symbols from external components, avoiding any problems with duplicate symbol names. Signed-off-by: Juergen Gross --- Based on top of my previous series

Re: [PATCH v2 05/15] x86: amend cpu_has_xen_[ibt,shstk}

In the subject, [ -> { ? On 24/11/2023 8:38 am, Jan Beulich wrote: > ... to evaluate to false at compile-time when the respective Kconfig > control is off, thus allowing the compiler to eliminate then-dead code. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper I've got part of a series

Re: [XEN PATCH v2] domain: add ASSERT to help static analysis tools

On 2023-11-17 10:21, Nicola Vetrini wrote: Static analysis tools may detect a possible null pointer dereference of 'config'. This ASSERT helps them in detecting that such a condition is not possible given that only real domains can enter this branch, which are guaranteeed to have a non-NULL confi

Re: [XEN PATCH v5 0/2] use the documentation for MISRA C:2012 Dir 4.1

On 2023-11-17 09:53, Nicola Vetrini wrote: This series addresses some concerns raised on patches 2 and 3 from [1]. Note that patch 1 from that series has already been applied. Patch 1 comprises a modified version of patches 2 and 3 of the previous series. Patch 2 is brand new, as it merely clar

Re: [PATCH v3 09/14] xen/asm-generic: introduce generic header altp2m.h

On 17.11.2023 13:24, Oleksii Kurochko wrote: > is common between archs so it is moved to > asm-generic. Here and elsewhere: The statement above can be read that the same applies to all arch-s (in which case the header would better move to include/xen/). Since this isn't true for x86, may I sugges

Re: [PATCH v3 10/14] xen/asm-generic: introduce stub header monitor.h

On 17.11.2023 13:24, Oleksii Kurochko wrote: > --- a/xen/arch/ppc/include/asm/monitor.h > +++ /dev/null > @@ -1,43 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0-only */ > -/* Derived from xen/arch/arm/include/asm/monitor.h */ > -#ifndef __ASM_PPC_MONITOR_H__ > -#define __ASM_PPC_MONITOR_H__ > - >

Re: [PATCH v3 12/14] xen/asm-generic: introduce stub header softirq.h

On 24.11.2023 14:04, Michal Orzel wrote: > On 17/11/2023 13:24, Oleksii Kurochko wrote: >> >> >> is common between Arm, PPC and RISC-V so it is >> moved to asm-generic. >> >> Signed-off-by: Oleksii Kurochko > Reviewed-by: Michal Orzel Acked-by: Jan Beulich

Re: [PATCH v3 11/14] xen/asm-generic: introduce stub header numa.h

On 24.11.2023 14:03, Michal Orzel wrote: > On 17/11/2023 13:24, Oleksii Kurochko wrote: >> --- a/xen/arch/arm/include/asm/numa.h >> +++ b/xen/include/asm-generic/numa.h >> @@ -1,9 +1,11 @@ >> -#ifndef __ARCH_ARM_NUMA_H >> -#define __ARCH_ARM_NUMA_H >> +/* SPDX-License-Identifier: GPL-2.0-only */ >>

Re: [PATCH v3 09/14] xen/asm-generic: introduce generic header altp2m.h

On 24.11.2023 14:00, Michal Orzel wrote: > On 17/11/2023 13:24, Oleksii Kurochko wrote: >> --- a/xen/arch/arm/include/asm/altp2m.h >> +++ /dev/null >> @@ -1,39 +0,0 @@ >> -/* >> - * Alternate p2m >> - * >> - * Copyright (c) 2014, Intel Corporation. > Shouldn't this copyright be moved to generic hea

Re: [PATCH v3 12/14] xen/asm-generic: introduce stub header softirq.h

Hi, On 17/11/2023 13:24, Oleksii Kurochko wrote: > > > is common between Arm, PPC and RISC-V so it is > moved to asm-generic. > > Signed-off-by: Oleksii Kurochko Reviewed-by: Michal Orzel ~Michal

Re: [Discussion]: Making "LIBXL_HOTPLUG_TIMEOUT" configurable through 'xl.conf'

Fri, 24 Nov 2023 13:47:53 +0100 Juergen Gross : > As Olaf has said already: this wouldn't cover actions e.g. by libvirt. Jim pointed me to /etc/libvirt/libxl.conf. So from this perspective both xl and libvirt is covered. Now it just takes someone to implement it. Olaf pgpHB9JoF7AJr.pgp Descri

Re: [PATCH v3 11/14] xen/asm-generic: introduce stub header numa.h

Hi, On 17/11/2023 13:24, Oleksii Kurochko wrote: > > > is common through some archs so it is moved > to asm-generic. > > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > - Remove old header inclusion in asm-generic numa.h and include > and > - Drop Arm and PPC's numa.h and use

Re: [PATCH v3 09/14] xen/asm-generic: introduce generic header altp2m.h

Hi, On 17/11/2023 13:24, Oleksii Kurochko wrote: > > > is common between archs so it is moved to > asm-generic. > > Arm and PPC were switched to asm-generic version of altp2m.h. > > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > - Drop Arm and PPC's altp2m.h > - Update the commit

Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory

Volodymyr Babchuk writes: > Hi, > > Volodymyr Babchuk writes: > >> Hi Stefano, >> >> Stefano Stabellini writes: >> >>> On Wed, 22 Nov 2023, David Woodhouse wrote: On Wed, 2023-11-22 at 15:09 -0800, Stefano Stabellini wrote: > On Wed, 22 Nov 2023, David Woodhouse wrote: > > On Wed

Re: [Discussion]: Making "LIBXL_HOTPLUG_TIMEOUT" configurable through 'xl.conf'

On 23.11.23 16:18, Divin Raj wrote: On 11/16/23 9:53 AM, Olaf Hering wrote: Thu, 16 Nov 2023 09:21:06 + Luca Fancellu : I see your patch is handling this issue but maybe was not meant to be upstreamed, so I would like to ask if you are willing to make it upstream-able or if it’s not plann

Re: Clang-format configuration discussion - pt 2

On 23.11.2023 15:47, Luca Fancellu wrote: > Hi all, > > Let’s continue the discussion about clang-format configuration, this is part > 2, previous discussions are: > > - https://lists.xenproject.org/archives/html/xen-devel/2023-11/msg00498.html > > You can find the serie introducing clang-form

[xen-unstable test] 183847: tolerable FAIL - PUSHED

flight 183847 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183847/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 183839 test-amd64-i386-xl-qemuu-win7-amd64

Re: [PATCH v2 6/6] xen_arm: Add virtual PCIe host bridge support

On Tue, 21 Nov 2023 22:10:28 + Volodymyr Babchuk wrote: > From: Oleksandr Tyshchenko > > The bridge is needed for virtio-pci support, as QEMU can emulate the > whole bridge with any virtio-pci devices connected to it. > > This patch provides a flexible way to configure PCIe brige resources

Re: Clang-format configuration discussion - pt 2

> On 24 Nov 2023, at 12:24, Jan Beulich wrote: > > On 24.11.2023 12:59, Luca Fancellu wrote: >> @@ -,19 +3318,18 @@ static int __init alloc_domain_evtchn(struct >> dt_device_node *node) >> rc = evtchn_alloc_unbound(&alloc_unbound, domU1_port); >> if ( rc < 0 ) >> { >> - printk(XENLOG_ERR >

Re: Clang-format configuration discussion - pt 2

On 24.11.2023 12:59, Luca Fancellu wrote: > @@ -,19 +3318,18 @@ static int __init alloc_domain_evtchn(struct > dt_device_node *node) > rc = evtchn_alloc_unbound(&alloc_unbound, domU1_port); > if ( rc < 0 ) > { > - printk(XENLOG_ERR > - "evtchn_alloc_unbound() failure (Error %d) \n", rc); > + p

Re: [PATCH] automation: Switch u-boot boot command to bootz for arm32 tests

On 24/11/2023 12:09 pm, Michal Orzel wrote: > Thanks to recent changes added to ImageBuilder to support the bootz > command, which allows obtaining the effective image size (including NOLOAD > sections) from the zImage header, switch the BOOT_CMD for arm32 tests to > bootz. Among other scenarios, t

Re: [PATCH v3 02/14] xen/asm-generic: introduce generic device.h

On Fri, 2023-11-24 at 11:01 +, Julien Grall wrote: > Hi Oleksii, > > On 17/11/2023 12:24, Oleksii Kurochko wrote: > > Arm, PPC and RISC-V use the same device.h thereby device.h > > was moved to asm-generic. > > I read "was moved" as the patch should also contain some deleted > lines. > But

Re: [PATCH 1/2] livepatch-build-tools: remove usage of gawk

On 24/11/2023 11:43, Ross Lagerwall wrote: > On Thu, Nov 23, 2023 at 4:08 PM Roger Pau Monne wrote: >> >> And instead use plain awk. >> >> There's no need to use the --non-decimal-data option for gawk, since the >> numbers that we want to print are already prefixed with '0x', and so plain awk

[PATCH] automation: Switch u-boot boot command to bootz for arm32 tests

Thanks to recent changes added to ImageBuilder to support the bootz command, which allows obtaining the effective image size (including NOLOAD sections) from the zImage header, switch the BOOT_CMD for arm32 tests to bootz. Among other scenarios, this change will enable us, in the future, to add tes

Re: [PATCH v3 08/14] xen/asm-generic: introduce generic div64.h header

Hi Julien, On Fri, 2023-11-24 at 11:29 +, Julien Grall wrote: > Hi, > > On 17/11/2023 12:24, Oleksii Kurochko wrote: > > All archs have the do_div implementation for BITS_PER_LONG == 64 > > so do_div64.h is moved to asm-generic. > > You are saying "all archs" but ... > > > > > x86 and PPC

Re: [PATCH 2/2] livepatch-build-tools: do not use readlink -m option

On Thu, Nov 23, 2023 at 4:08 PM Roger Pau Monne wrote: > > Busybox readlink implementation only supports the -f option to follow > symlinks, > so adjust the logic in order to keep the same behaviour without using the -m > option. > > Singed-off-by: Roger Pau Monné Reviewed-by: Ross Lagerwall

Re: Clang-format configuration discussion - pt 2

> On 24 Nov 2023, at 11:12, George Dunlap wrote: > > On Thu, Nov 23, 2023 at 2:48 PM Luca Fancellu wrote: >> AlignConsecutiveAssignments: None >> >> --- >> This one is disabled because of feedbacks from Stefano and Alejandro about >> some weird behaviour on our >> codebase. >> >> This one c

Re: [PATCH 1/2] livepatch-build-tools: remove usage of gawk

On Thu, Nov 23, 2023 at 4:08 PM Roger Pau Monne wrote: > > And instead use plain awk. > > There's no need to use the --non-decimal-data option for gawk, since the > numbers that we want to print are already prefixed with '0x', and so plain awk > will do the conversion from hexadecimal to decimal j

[xen-unstable-smoke test] 183851: tolerable all pass - PUSHED

flight 183851 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183851/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v3 08/14] xen/asm-generic: introduce generic div64.h header

Hi, On 17/11/2023 12:24, Oleksii Kurochko wrote: All archs have the do_div implementation for BITS_PER_LONG == 64 so do_div64.h is moved to asm-generic. You are saying "all archs" but ... x86 and PPC were switched to asm-generic version of div64.h. ... you only switch x86/PPC to div64.h.

Re: [PATCH v3 07/14] xen/asm-generic: introduce generalized hardirq.h

Hi Oleksii, On 17/11/2023 12:24, Oleksii Kurochko wrote: is common through archs thereby it is moved to asm-generic. Arm and PPC were switched to asm generic verstion of hardirq.h. Signed-off-by: Oleksii Kurochko Acked-by: Julien Grall Cheers, -- Julien Grall

Re: [PATCH v3 06/14] xen/asm-generic: introduce generic header percpu.h

Hi Oleksii, On 17/11/2023 12:24, Oleksii Kurochko wrote: The patch introduces generic percpu.h which was based on Arm's version with the following changes: * makes __per_cpu_data_end[] constant * introduce get_per_cpu_offset() for macros this_cpu() and this_cpu_ptr() * add inclustion of a

Re: Clang-format configuration discussion - pt 2

On Thu, Nov 23, 2023 at 2:48 PM Luca Fancellu wrote: > AlignConsecutiveAssignments: None > > --- > This one is disabled because of feedbacks from Stefano and Alejandro about > some weird behaviour on our > codebase. > > This one could be phased along this line: “Consecutive assignments don't need

Re: [PATCH v3 05/14] xen/asm-generic: introduce stub header

Hi Oleksii, On 17/11/2023 12:24, Oleksii Kurochko wrote: is common for Arm, PPC and RISC-V thereby it is moved to asm-generic. Signed-off-by: Oleksii Kurochko Acked-by: Julien Grall Cheers, -- Julien Grall

Re: [PATCH v3 04/14] xen/asm-generic: introduce generic header iocap.h

Hi Oleksii, On 17/11/2023 12:24, Oleksii Kurochko wrote: iocap.h is common for Arm, PPC and RISC-V architectures thereby it was moved to asm-generic. Also Arm and PPC were switched to asm-generic version of iocap.h. Signed-off-by: Oleksii Kurochko Acked-by: Julien Grall Cheers, -- Julien

Re: [PATCH v3 02/14] xen/asm-generic: introduce generic device.h

Hi Oleksii, On 17/11/2023 12:24, Oleksii Kurochko wrote: Arm, PPC and RISC-V use the same device.h thereby device.h was moved to asm-generic. I read "was moved" as the patch should also contain some deleted lines. But below, I only see the file introduced. Did you intend to also remove the

Re: [PATCH v6 3/5] arm/dom0less: put dom0less feature code in a separate module

Hi Luca, + CC others On 24/11/2023 10:48, Luca Fancellu wrote: > > > Currently the dom0less feature code is mostly inside domain_build.c > and setup.c, it is a feature that may not be useful to everyone so > put the code in a different compilation module in order to make it > easier to disable

Governance PR

Hi all, Please see an updated Governance PR on GitLab here: https://gitlab.com/xen-project/governance/governance/-/merge_requests/1 Comments: Revise code of conduct for enhanced clarity, inclusivity, and accountability In response to valuable feedback from community members and in alignment wit

Re: [PATCH v3 01/14] xen/asm-generic: introduce stub header paging.h

Hi Oleksii, On 17/11/2023 12:24, Oleksii Kurochko wrote: The patch introduces generic paging.h header for Arm, PPC and RISC-V. All mentioned above architectures use hardware virt extensions and hardware pagetable extensions thereby it makes sense to set paging_mode_translate and paging_mode_ext

[PATCH v2 30/39] xen/riscv: define an address of frame table

Also the patchs adds some helpful macros. Signed-off-by: Oleksii Kurochko --- Changes in V2: - Nothing changed. Only rebase. --- xen/arch/riscv/include/asm/config.h | 21 + 1 file changed, 21 insertions(+) diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/i

[RFC QEMU PATCH v2 1/1] xen/pci: get gsi from irq for passthrough devices

In PVH dom0, it uses the linux local interrupt mechanism, when it allocs irq for a gsi, it is dynamic, and follow the principle of applying first, distributing first. And if you debug the kernel codes, you will find the irq number is alloced from small to large, but the applying gsi number is not,

[RFC QEMU PATCH v2 0/1] Support device passthrough when dom0 is PVH on Xen

Hi All, This patch is the v2 of the implementation of passthrough when dom0 is PVH on Xen. Issues we encountered: 1. failed to map pirq for gsi Problem: qemu will call xc_physdev_map_pirq() to map a passthrough device’s gsi to pirq in function xen_pt_realize(). But failed. Reason: According to

[PATCH v2 39/39] xen: fix compilation issue of serial.c

The following issue occurs on RISC-V platforms: drivers/char/serial.c: In function 'serial_tx_interrupt': drivers/char/serial.c:88:9: error: implicit declaration of function 'cpu_relax' [-Werror=implicit-function-declaration] 88 | cpu_relax(); cpu_relax() is defined in so it was added

[PATCH v2 35/39] xen: add necessary headers to common to build full Xen for RISC-V

Signed-off-by: Oleksii Kurochko --- Changes in V2: - Nothing changed. Only rebase. --- xen/include/xen/domain.h | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 54d88bf5e3..a4e11342e3 100644 --- a/xen/include/xen/domain.h +++ b/xen/inc

[PATCH v2 25/39] xen/riscv: introduce asm/p2m.h

Signed-off-by: Oleksii Kurochko --- Changes in V2: - Nothing changed. Only rebase. --- xen/arch/riscv/include/asm/p2m.h | 105 +++ 1 file changed, 105 insertions(+) create mode 100644 xen/arch/riscv/include/asm/p2m.h diff --git a/xen/arch/riscv/include/asm/p2m.h b/x

Re: [PATCH v6 4/5] xen/arm: Move static memory build code in separate modules

Hi Luca, + CC others On 24/11/2023 10:48, Luca Fancellu wrote: > > > Move static memory and static shared memory code in separate modules > so that they are included only when the corresponding feature is > enabled, doing that we modularise the features and we remove some > ifdefs from the code

[PATCH v2 32/39] xen/riscv: add minimal stuff to asm/page.h to build full Xen

Signed-off-by: Oleksii Kurochko --- Changes in V2: - Nothing changed. Only rebase. --- xen/arch/riscv/include/asm/page.h | 21 + 1 file changed, 21 insertions(+) diff --git a/xen/arch/riscv/include/asm/page.h b/xen/arch/riscv/include/asm/page.h index 95074e29b3..abbae75aaf

[PATCH v2 29/39] xen/riscv: add definition of __read_mostly

The definition of __read_mostly should be removed in: https://lore.kernel.org/xen-devel/f25eb5c9-7c14-6e23-8535-2c66772b3...@suse.com/ The patch introduces it in arch-specific header to not block enabling of full Xen build for RISC-V. Signed-off-by: Oleksii Kurochko --- - update the commit mess

[PATCH v2 33/39] xen/riscv: add minimal stuff to asm/processor.h to build full Xen

Signed-off-by: Oleksii Kurochko --- Changes in V2: - Nothing changed. Only rebase. --- xen/arch/riscv/include/asm/processor.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/xen/arch/riscv/include/asm/processor.h b/xen/arch/riscv/include/asm/processor.h index 6db681d805..b6

[PATCH v2 26/39] xen/riscv: introduce asm/regs.h

Signed-off-by: Oleksii Kurochko --- Changes in V2: - change xen/lib.h to xen/bug.h - remove unnecessary empty line --- xen/arch/riscv/include/asm/regs.h | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 xen/arch/riscv/include/asm/regs.h diff --git a/xen/arch

[PATCH v2 20/39] xen/riscv: define bug frame tables in xen.lds.S

Signed-off-by: Oleksii Kurochko --- Changes in V2: - Nothing changed. Only rebase. --- xen/arch/riscv/xen.lds.S | 10 ++ 1 file changed, 10 insertions(+) diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S index 3fa7db3bf9..a10e0ad87c 100644 --- a/xen/arch/riscv/xen.lds.S +

[RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

In PVH dom0, it uses the linux local interrupt mechanism, when it allocs irq for a gsi, it is dynamic, and follow the principle of applying first, distributing first. And if you debug the kernel codes, you will find the irq number is alloced from small to large, but the applying gsi number is not,

[RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

If we run Xen with PVH dom0 and hvm domU, hvm will map a pirq for a passthrough device by using gsi, see xen_pt_realize->xc_physdev_map_pirq and pci_add_dm_done->xc_physdev_map_pirq. Then xc_physdev_map_pirq will call into Xen, but in hvm_physdev_op, PHYSDEVOP_map_pirq is not allowed because currd

[RFC XEN PATCH v2 1/3] xen/vpci: Clear all vpci status of device

When a device has been reset on dom0 side, the vpci on Xen side won't get notification, so the cached state in vpci is all out of date compare with the real device state. To solve that problem, this patch add new hypercall to clear all vpci device state. And when reset device happens on dom0 side,

[PATCH v2 37/39] xen/rirscv: add minimal amount of stubs to build full Xen

Signed-off-by: Oleksii Kurochko --- Changes in V2: - define udelay stub - remove 'select HAS_PDX' from RISC-V Kconfig because of https://lore.kernel.org/xen-devel/20231006144405.1078260-1-andrew.coop...@citrix.com/ --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/early_printk.c | 1

  1   2   >