On 23.11.23 16:18, Divin Raj wrote:
On 11/16/23 9:53 AM, Olaf Hering wrote:Thu, 16 Nov 2023 09:21:06 +0000 Luca Fancellu <luca.fance...@arm.com>:I see your patch is handling this issue but maybe was not meant to be upstreamed, so I would like to ask if you are willing to make it upstream-able or if it’s not plannedto do so.Right now I do not have the time to work on this. First there need to be an agreement about how the timeout needs to be configured. OlafHello everyone,Following our earlier discussion, we learned that there is already a solution to fix the LIBXL hotplug timeout issue. Currently, we have two options:1. Xenstore Key/Value Approach: This is implemented in the patch "libxl.LIBXL_HOTPLUG_TIMEOUT.patch". This method does not require recompiling libxl. It involves setting up a key/value in Xenstore before domain creation. The patch can be viewed here: [https://build.opensuse.org/package/view_file/openSUSE:Factory/xen/libxl.LIBXL_HOTPLUG_TIMEOUT.patch?expand=1].
I don't like this approach. It was used to solve the problem without affecting the ABI, but it is basically a hack.
2. Configuration via 'xl.conf': We can make "LIBXL_HOTPLUG_TIMEOUT" configurable through the 'xl.conf' file.
As Olaf has said already: this wouldn't cover actions e.g. by libvirt. I think we might want something like libxl.conf (or xen.conf?) setting defaults for ALL tool stacks. I think we should even move some of the settings from xl.conf into the new file (like autoballoon, max_grant_frames, etc.). Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
