Re: Xen reliance on non-standard GCC features

On 05.06.2023 23:39, Stefano Stabellini wrote: > On Mon, 5 Jun 2023, Roberto Bagnara wrote: Here is a list of extensions that are documented in the GCC manual: >>> >>> I suppose that this list wasn't meant to be complete? The most >>> prominent example is probably asm(). >> >> As far as I can

RE: [XEN][PATCH v7 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree

Hi Vikram, > -Original Message- > >> is starting from a given node. So how about > >> "dt_find_node_by_path_from()"? > > Thank you for the suggestion. This name was added in v3 as Luca Fancellu > > suggested to rename this function to "device_tree_find_node_by_path". I > > am okay with ren

Re: [PATCH] amd: disable C6 after 1000 days on Fam17h models 30-3fh

On 06.06.2023 14:47, Roger Pau Monné wrote: > On Mon, Jun 05, 2023 at 05:54:50PM +0200, Jan Beulich wrote: >> On 05.06.2023 17:10, Roger Pau Monne wrote: >>> As specified on Errata 1474: >>> >>> "A core will fail to exit CC6 after about 1044 days after the last >>> system reset. The time of failure

Re: [XEN][PATCH v7 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree

On 06/06/2023 22:29, Vikram Garhwal wrote: > Hi, > > On 6/5/23 12:12 PM, Julien Grall wrote: >> Hi, >> >> On 02/06/2023 01:48, Vikram Garhwal wrote: >>> Add device_tree_find_node_by_path() to find a matching node with path >>> for a >> >> AFAICT, the only difference in name between the new func

[PATCH] x86: allow non-BIGMEM configs to boot on >= 16Tb systems

While frame table setup, directmap init, and boot allocator population respect all intended bounds, the logic passing memory to the heap allocator which wasn't passed to the boot allocator fails to respect max_{pdx,pfn}. This then typically triggers the BUG() in free_heap_pages() after checking pag

[linux-linus test] 181217: regressions - FAIL

flight 181217 linux-linus real [real] flight 181238 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181217/ http://logs.test-lab.xenproject.org/osstest/logs/181238/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

[ovmf test] 181234: all pass - PUSHED

flight 181234 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181234/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 67fc78d026490ea4c375eeb19724abb40e7be8f2 baseline version: ovmf ded0b489af09cde5afa05

[xen-unstable-smoke test] 181233: tolerable all pass - PUSHED

flight 181233 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181233/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[qemu-mainline test] 181231: regressions - FAIL

flight 181231 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181231/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-buildfail REGR. vs. 180691 build-arm64

[PATCH v4 7/7] xen/arm: smmuv3: Add PCI devices support for SMMUv3

From: Rahul Singh Signed-off-by: Rahul Singh Signed-off-by: Stewart Hildebrand --- v3->v4: * no change v2->v3: * rebase * invoke iommu_add_pci_sideband_ids() from add_device hook v1->v2: * ignore add_device/assign_device/reassign_device calls for phantom functions (i.e. devfn != pdev->devfn

[PATCH v4 6/7] xen/arm: smmuv2: Add PCI devices support for SMMUv2

From: Oleksandr Andrushchenko Signed-off-by: Oleksandr Tyshchenko Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Stewart Hildebrand --- v3->v4: * add new device_is_protected check in add_device hook to match SMMUv3 and IPMMU-VMSA drivers v2->v3: * invoke iommu_add_pci_sideband_ids()

[PATCH v4 5/7] iommu/arm: iommu_add_dt_pci_sideband_ids phantom handling

Handle phantom functions in iommu_add_dt_pci_sideband_ids(). Each phantom function will have a unique requestor ID (RID)/BDF. On ARM, we need to map/translate the RID/BDF to an AXI stream ID for each phantom function according to the pci-iommu device tree mapping [1]. The RID/BDF -> AXI stream ID m

[PATCH v4 4/7] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API

From: Oleksandr Tyshchenko The main purpose of this patch is to add a way to register PCI device (which is behind the IOMMU) using the generic PCI-IOMMU DT bindings [1] before assigning that device to a domain. This behaves similarly to the existing iommu_add_dt_device API, except it handles PCI

[PATCH v4 3/7] iommu/arm: Add iommu_dt_xlate()

From: Oleksandr Tyshchenko Move code for processing DT IOMMU specifier to a separate helper. This helper will be re-used for adding PCI devices by the subsequent patches as we will need exact the same actions for processing DT PCI-IOMMU specifier. While at it introduce NO_IOMMU to avoid magic "1

[PATCH v4 2/7] xen/arm: Move is_protected flag to struct device

From: Oleksandr Tyshchenko This flag will be re-used for PCI devices by the subsequent patches. Signed-off-by: Oleksandr Tyshchenko Signed-off-by: Stewart Hildebrand --- v3->v4: * move is_protected flag within struct device to reduce padding * re-add device_is_protected checks in add_device ho

[PATCH v4 1/7] xen/arm: Improve readability of check for registered devices

From: Oleksandr Tyshchenko Improve readability of check for devices already registered with the SMMU with legacy mmu-masters DT bindings by using is_protected. There are 2 device tree bindings for registering a device with the SMMU: * mmu-masters (legacy, SMMUv1/2 only) * iommus A device tree m

[PATCH v4 0/7] SMMU handling for PCIe Passthrough on ARM

This series introduces SMMU handling for PCIe passthrough on ARM. These patches are independent from (and don't depend on) the vPCI reference counting/locking work in progress, and should be able to be upstreamed independently. v3->v4: * split a change from ("xen/arm: Move is_protected flag to str

[PATCH] docs/misra: new rules addition

From: Stefano Stabellini For Dir 1.1, a document describing all implementation-defined behaviour (i.e. gcc-specific behavior) will be added to docs/misra, also including implementation-specific (gcc-specific) appropriate types for bit-field relevant to Rule 6.1. Rule 21.21 is lacking an example

[qemu-mainline test] 181212: regressions - FAIL

flight 181212 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181212/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 180691 test-amd64-amd64-

[ovmf test] 181225: all pass - PUSHED

flight 181225 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181225/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ded0b489af09cde5afa05d74acdb12cd4b4f8394 baseline version: ovmf cdd20638bc97cef1356a5

[xen-unstable test] 181210: regressions - FAIL

flight 181210 xen-unstable real [real] flight 181222 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181210/ http://logs.test-lab.xenproject.org/osstest/logs/181222/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

[ovmf test] 181221: all pass - PUSHED

flight 181221 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181221/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf cdd20638bc97cef1356a5c687a412f869c637245 baseline version: ovmf 4bd0849d81b4823319609

Re: [XEN][PATCH v7 09/19] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller

Hi, On 6/5/23 12:22 PM, Julien Grall wrote: Hi, On 02/06/2023 08:45, Michal Orzel wrote: On 02/06/2023 02:48, Vikram Garhwal wrote: diff --git a/xen/include/xen/iommu-private.h b/xen/include/xen/iommu-private.h new file mode 100644 index 00..5615decaff --- /dev/null +++ b/xen/includ

Re: [XEN][PATCH v7 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree

Hi, On 6/5/23 12:12 PM, Julien Grall wrote: Hi, On 02/06/2023 01:48, Vikram Garhwal wrote: Add device_tree_find_node_by_path() to find a matching node with path for a AFAICT, the only difference in name between the new function and the existing one is "device_tree" vs "dt". The latter is ju

[PATCH v1 6/8] xen/riscv: add SPDX tags

Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/include/asm/config.h | 2 ++ xen/arch/riscv/include/asm/current.h | 2 ++ xen/arch/riscv/include/asm/early_printk.h | 2 ++ xen/arch/riscv/include/asm/mm.h | 2 ++ xen/arch/riscv/include/asm/page-bits.h| 2 ++ xen/arch/ri

[PATCH v1 8/8] xen/riscv: move extern of cpu0_boot_stack to header

Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/include/asm/mm.h | 2 ++ xen/arch/riscv/mm.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/riscv/include/asm/mm.h b/xen/arch/riscv/include/asm/mm.h index 3b04131628..fc3afa5521 100644 --- a/xen/arch/r

[PATCH v1 7/8] xen/riscv: add __ASSEMBLY__ guards

Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/include/asm/page.h | 4 1 file changed, 4 insertions(+) diff --git a/xen/arch/riscv/include/asm/page.h b/xen/arch/riscv/include/asm/page.h index 8e8ec9ee36..1c6add70a5 100644 --- a/xen/arch/riscv/include/asm/page.h +++ b/xen/arch/riscv/inc

[PATCH v1 4/8] xen/riscv: introduce function for physical offset calculation

The function was introduced to not calculate and save physical offset before MMU is enabled because access to start() is PC-relative and in case of linker_addr != load_addr it will result in incorrect value in phys_offset. Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/include/asm/mm.h | 2

[PATCH v1 1/8] xen/riscv: make sure that identity mapping isn't bigger then page size

Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/xen.lds.S | 9 + 1 file changed, 9 insertions(+) diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S index 878130f313..74afbaab9b 100644 --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -20,6 +20,7 @@ SECTION

[PATCH v1 3/8] xen/riscv: introduce reset_stack() function

Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/riscv64/head.S | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index 8887f0cbd4..6fb7dd80fd 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/r

[PATCH v1 2/8] xen/riscv: add .sbss section to .bss

Sometimes variables are located in .sbss section but it won't be mapped after MMU will be enabled. To avoid MMU failures .sbss should be mapped Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/xen.lds.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/riscv/xen.lds.

[PATCH v1 0/8] xen/riscv: introduce identity mapping

The patch series introduces things necessary to implement identity mapping: 1. Make identity mapping for _start and stack. 2. Enable MMU. 3. Jump to the virtual address world 4. Remove identity mapping for _start and stack. Also current patch series introduces the calculation of physical o

[PATCH v1 5/8] xen/riscv: introduce identity mapping

The way how switch to virtual address was implemented in the commit e66003e7be ("xen/riscv: introduce setup_initial_pages") wasn't safe enough so identity mapping was introduced and used. Fixes: e66003e7be ("xen/riscv: introduce setup_initial_pages") Signed-off-by: Oleksii Kurochko --- xen/arch/

Re: [XEN][PATCH v7 05/19] xen/arm: Add CONFIG_OVERLAY_DTB

Thanks, will update the Changelog.md with Jan's suggestions. On 6/2/23 2:22 AM, Henry Wang wrote: Hi Jan and Vikram, -Original Message- Subject: Re: [XEN][PATCH v7 05/19] xen/arm: Add CONFIG_OVERLAY_DTB diff --git a/CHANGELOG.md b/CHANGELOG.md index 5bfd3aa5c0..a137fce576 100644 ---

Re: [XEN][PATCH v7 04/19] common/device_tree: change __unflatten_device_tree() type

Hi Julien, Will update the commit message regarding why we need to export this for dtbo programming. On 6/5/23 12:04 PM, Julien Grall wrote: Hi, Title: 'type' is a bit confusing here. How about "Export __unflatten_device_tre()"? On 02/06/2023 01:48, Vikram Garhwal wrote: Following change

Re: [XEN][PATCH v7 02/19] common/device_tree.c: unflatten_device_tree() propagate errors

Hi Michal, On 6/2/23 12:14 AM, Michal Orzel wrote: Title: s/unflatten_device_tree/__unflatten_device_tree/ or you mean to propagate errors from unflatten_dt_node? On 02/06/2023 02:48, Vikram Garhwal wrote: This will be useful in dynamic node programming when new dt nodes are unflattend during

Re: [PATCH v8 05/12] arm/sve: save/restore SVE context switch

Hi Luca, On 06/06/2023 14:22, Luca Fancellu wrote: On 1 Jun 2023, at 11:17, Bertrand Marquis wrote: Hi Luca, On 31 May 2023, at 09:24, Luca Fancellu wrote: Save/restore context switch for SVE, allocate memory to contain the Z0-31 registers whose length is maximum 2048 bits each and FFR

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

On 06/06/2023 08:04, Michal Orzel wrote: Hi Julien, Hi Michal, On 05/06/2023 20:34, Julien Grall wrote: I can think of the following patches: 1) Use correct accessors for early pl011 on arm32 and arm64 - this would use the accessors depending on the given register size (ldrh, strh, strb)

Re: [PATCH] livepatch: apply_alternatives() is only used for livepatch

On 06/06/2023 6:23 pm, Roger Pau Monne wrote: > diff --git a/xen/arch/x86/include/asm/alternative.h > b/xen/arch/x86/include/asm/alternative.h > index a1cd6a9fe5b8..688b554099b3 100644 > --- a/xen/arch/x86/include/asm/alternative.h > +++ b/xen/arch/x86/include/asm/alternative.h > @@ -24,7 +24,9 @@

Re: [PATCH] livepatch: apply_alternatives() is only used for livepatch

Hi Roger, On 06/06/2023 18:23, Roger Pau Monne wrote: Guard it with CONFIG_LIVEPATCH. Note alternatives are applied at boot using _apply_alternatives(). Signed-off-by: Roger Pau Monné Reviewed-by: Julien Grall --- xen/arch/arm/alternative.c | 2 ++ xen/arch/arm/include/asm

Re: [PATCH v2 16/16] xen-blkback: Inform userspace that device has been opened

On Tue, Jun 06, 2023 at 11:15:37AM +0200, Roger Pau Monné wrote: > On Tue, May 30, 2023 at 04:31:16PM -0400, Demi Marie Obenour wrote: > > Set "opened" to "0" before the hotplug script is called. Once the > > device node has been opened, set "opened" to "1". > > > > "opened" is used exclusively b

[PATCH] livepatch: apply_alternatives() is only used for livepatch

Guard it with CONFIG_LIVEPATCH. Note alternatives are applied at boot using _apply_alternatives(). Signed-off-by: Roger Pau Monné --- xen/arch/arm/alternative.c | 2 ++ xen/arch/arm/include/asm/alternative.h | 2 ++ xen/arch/x86/alternative.c | 5 +++-- xen/arch/x86/incl

Re: [PATCH v2 13/16] xen-blkback: Implement diskseq checks

On Tue, Jun 06, 2023 at 10:25:47AM +0200, Roger Pau Monné wrote: > On Tue, May 30, 2023 at 04:31:13PM -0400, Demi Marie Obenour wrote: > > This allows specifying a disk sequence number in XenStore. If it does > > not match the disk sequence number of the underlying device, the device > > will not

[ovmf test] 181213: all pass - PUSHED

flight 181213 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181213/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4bd0849d81b48233196092868081315ec4d9233d baseline version: ovmf c1dd400a13d1a5e862809

[linux-linus test] 181204: regressions - FAIL

flight 181204 linux-linus real [real] flight 181216 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181204/ http://logs.test-lab.xenproject.org/osstest/logs/181216/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

[libvirt test] 181205: tolerable all pass - PUSHED

flight 181205 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/181205/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 181133 test-armhf-armhf-libvirt 16 saveresto

Re: [PATCH v3 3/6] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API

On 5/24/23 03:49, Michal Orzel wrote: > Hi Stewart, > > On 18/05/2023 23:06, Stewart Hildebrand wrote: >> >> >> From: Oleksandr Tyshchenko >> >> The main purpose of this patch is to add a way to register PCI device >> (which is behind the IOMMU) using the generic PCI-IOMMU DT bindings [1] >> befo

Re: [PATCH] xen-block: fix segv on unrealize

Sorry! Reviewed-by: Stefan Hajnoczi

Re: [PATCH] xen-block: fix segv on unrealize

On 6/6/23 15:16, Anthony PERARD via wrote: From: Anthony PERARD Backtrace: qemu_lockcnt_lock (lockcnt=0xb4) at ../util/lockcnt.c:238 aio_set_fd_handler (ctx=0x0, fd=51, is_external=true, io_read=0x0, io_write=0x0, io_poll=0x0, io_poll_ready=0x0, opaque=0x0) at ../util/aio-posix.c:119

Re: [PATCH v8 09/12] tools: add physinfo arch_capabilities handling for Arm

> On 31 May 2023, at 08:24, Luca Fancellu wrote: > > On Arm, the SVE vector length is encoded in arch_capabilities field > of struct xen_sysctl_physinfo, make use of this field in the tools > when building for arm. > > Create header arm-arch-capabilities.h to handle the arch_capabilities > fie

Re: [PATCH v8 05/12] arm/sve: save/restore SVE context switch

> On 1 Jun 2023, at 11:17, Bertrand Marquis wrote: > > Hi Luca, > >> On 31 May 2023, at 09:24, Luca Fancellu wrote: >> >> Save/restore context switch for SVE, allocate memory to contain >> the Z0-31 registers whose length is maximum 2048 bits each and >> FFR who can be maximum 256 bits, the

[PATCH] xen-block: fix segv on unrealize

From: Anthony PERARD Backtrace: qemu_lockcnt_lock (lockcnt=0xb4) at ../util/lockcnt.c:238 aio_set_fd_handler (ctx=0x0, fd=51, is_external=true, io_read=0x0, io_write=0x0, io_poll=0x0, io_poll_ready=0x0, opaque=0x0) at ../util/aio-posix.c:119 xen_device_unbind_event_channel (xendev=0x55c6d

Re: [PATCH] amd: disable C6 after 1000 days on Fam17h models 30-3fh

On Mon, Jun 05, 2023 at 05:54:50PM +0200, Jan Beulich wrote: > On 05.06.2023 17:10, Roger Pau Monne wrote: > > As specified on Errata 1474: > > > > "A core will fail to exit CC6 after about 1044 days after the last > > system reset. The time of failure may vary depending on the spread > > spectrum

[qemu-mainline test] 181201: regressions - FAIL

flight 181201 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/181201/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 180691 test-amd64-amd64-

Re: [PATCH 2/2] x86/vPIT: account for "counter stopped" time

On Thu, Jun 01, 2023 at 04:20:13PM +0200, Jan Beulich wrote: > On 01.06.2023 13:48, Roger Pau Monné wrote: > > On Tue, May 30, 2023 at 05:30:40PM +0200, Jan Beulich wrote: > >> TBD: "gate" can only ever be low for chan2 (with "x86/vPIT: check/bound > >> values loaded from state save record" [2

Re: [PATCH 1/2] x86/vPIT: re-order functions

On Thu, Jun 01, 2023 at 04:06:53PM +0200, Jan Beulich wrote: > On 01.06.2023 13:50, Roger Pau Monné wrote: > > On Thu, Jun 01, 2023 at 11:56:12AM +0200, Jan Beulich wrote: > >> On 01.06.2023 11:17, Roger Pau Monné wrote: > >>> On Tue, May 30, 2023 at 05:30:02PM +0200, Jan Beulich wrote: > To a

Re: [PATCH 0/2] xen/blkback: support delete-on-close block devices

On Thu, Jun 01, 2023 at 05:48:21PM -0400, Demi Marie Obenour wrote: > These two patches allow userspace to provide an expected diskseq of a > block device and discover when blkback has opened the device. Together, > these features allow using blkback with delete-on-close block devices, > such as l

Re: [PATCH v2 16/16] xen-blkback: Inform userspace that device has been opened

On Tue, May 30, 2023 at 04:31:16PM -0400, Demi Marie Obenour wrote: > Set "opened" to "0" before the hotplug script is called. Once the > device node has been opened, set "opened" to "1". > > "opened" is used exclusively by userspace. It serves two purposes: > > 1. It tells userspace that the d

[xen-unstable test] 181194: tolerable FAIL - PUSHED

flight 181194 xen-unstable real [real] flight 181208 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181194/ http://logs.test-lab.xenproject.org/osstest/logs/181208/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: [PATCH v2 15/16] xen-blkback: Minor cleanups

On Tue, May 30, 2023 at 04:31:15PM -0400, Demi Marie Obenour wrote: > This adds a couple of BUILD_BUG_ON()s and moves some arithmetic after > the validation code that checks the arithmetic’s preconditions. The > previous code was correct but could potentially trip sanitizers that > check for unsig

Re: [PATCH v2 13/16] xen-blkback: Implement diskseq checks

On Tue, May 30, 2023 at 04:31:13PM -0400, Demi Marie Obenour wrote: > This allows specifying a disk sequence number in XenStore. If it does > not match the disk sequence number of the underlying device, the device > will not be exported and a warning will be logged. Userspace can use > this to el

Re: [PATCH] xen/arm: debug-pl011: Use 32-bit accessors for broader compatibility

Hi Julien, On 05/06/2023 20:34, Julien Grall wrote: > > > Hi, > > On 01/06/2023 13:38, Michal Orzel wrote: >> >> On 01/06/2023 14:17, Julien Grall wrote: >>> >>> >>> >>> >>> >>> On Thu, 1 Jun 2023 at 13:48, Michal Orzel >> > wrote: >>> >>> Hi Julien, >>> >>>